X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;f=server%2Fcontrollers%2Fapi%2Fusers.ts;h=3106df9b9279105175eb63785d39757c75c8fd36;hb=d3ea89759104e6c14b00443526f2c2a0a13aeb97;hp=ffe5881e5594040e6a5cb9f99fcaf84cee6e59bd;hpb=69818c9394366b954b6ba3bd697bd9d2b09f2a16;p=github%2FChocobozzz%2FPeerTube.git

diff --git a/server/controllers/api/users.ts b/server/controllers/api/users.ts
index ffe5881e5..3106df9b9 100644
--- a/server/controllers/api/users.ts
+++ b/server/controllers/api/users.ts
@@ -1,68 +1,100 @@
 import * as express from 'express'
-import { waterfall } from 'async'
-
-import { database as db } from '../../initializers/database'
-import { CONFIG, USER_ROLES } from '../../initializers'
-import { logger, getFormatedObjects } from '../../helpers'
+import { UserCreate, UserRight, UserRole, UserUpdate, UserUpdateMe, UserVideoRate as FormattedUserVideoRate } from '../../../shared'
+import { getFormattedObjects, logger, retryTransactionWrapper } from '../../helpers'
+import { CONFIG } from '../../initializers'
+import { createUserAccountAndChannel } from '../../lib/user'
 import {
+  asyncMiddleware,
   authenticate,
-  ensureIsAdmin,
-  usersAddValidator,
-  usersUpdateValidator,
-  usersRemoveValidator,
-  usersVideoRatingValidator,
+  ensureUserHasRight,
+  ensureUserRegistrationAllowed,
   paginationValidator,
   setPagination,
-  usersSortValidator,
   setUsersSort,
-  token
+  setVideosSort,
+  token,
+  usersAddValidator,
+  usersGetValidator,
+  usersRegisterValidator,
+  usersRemoveValidator,
+  usersSortValidator,
+  usersUpdateMeValidator,
+  usersUpdateValidator,
+  usersVideoRatingValidator
 } from '../../middlewares'
+import { videosSortValidator } from '../../middlewares/validators'
+import { AccountVideoRateModel } from '../../models/account/account-video-rate'
+import { UserModel } from '../../models/account/user'
+import { VideoModel } from '../../models/video/video'
 
 const usersRouter = express.Router()
 
 usersRouter.get('/me',
   authenticate,
-  getUserInformation
+  asyncMiddleware(getUserInformation)
+)
+
+usersRouter.get('/me/videos',
+  authenticate,
+  paginationValidator,
+  videosSortValidator,
+  setVideosSort,
+  setPagination,
+  asyncMiddleware(getUserVideos)
 )
 
 usersRouter.get('/me/videos/:videoId/rating',
   authenticate,
-  usersVideoRatingValidator,
-  getUserVideoRating
+  asyncMiddleware(usersVideoRatingValidator),
+  asyncMiddleware(getUserVideoRating)
 )
 
 usersRouter.get('/',
+  authenticate,
+  ensureUserHasRight(UserRight.MANAGE_USERS),
   paginationValidator,
   usersSortValidator,
   setUsersSort,
   setPagination,
-  listUsers
+  asyncMiddleware(listUsers)
+)
+
+usersRouter.get('/:id',
+  asyncMiddleware(usersGetValidator),
+  getUser
 )
 
 usersRouter.post('/',
   authenticate,
-  ensureIsAdmin,
-  usersAddValidator,
-  createUser
+  ensureUserHasRight(UserRight.MANAGE_USERS),
+  asyncMiddleware(usersAddValidator),
+  asyncMiddleware(createUserRetryWrapper)
 )
 
 usersRouter.post('/register',
-  ensureRegistrationEnabled,
-  usersAddValidator,
-  createUser
+  asyncMiddleware(ensureUserRegistrationAllowed),
+  asyncMiddleware(usersRegisterValidator),
+  asyncMiddleware(registerUserRetryWrapper)
+)
+
+usersRouter.put('/me',
+  authenticate,
+  usersUpdateMeValidator,
+  asyncMiddleware(updateMe)
 )
 
 usersRouter.put('/:id',
   authenticate,
-  usersUpdateValidator,
-  updateUser
+  ensureUserHasRight(UserRight.MANAGE_USERS),
+  asyncMiddleware(usersUpdateValidator),
+  asyncMiddleware(updateUser)
 )
 
 usersRouter.delete('/:id',
   authenticate,
-  ensureIsAdmin,
-  usersRemoveValidator,
-  removeUser
+  ensureUserHasRight(UserRight.MANAGE_USERS),
+  asyncMiddleware(usersRemoveValidator),
+  asyncMiddleware(removeUser)
 )
 
 usersRouter.post('/token', token, success)
@@ -76,96 +108,137 @@ export {
 
 // ---------------------------------------------------------------------------
 
-function ensureRegistrationEnabled (req: express.Request, res: express.Response, next: express.NextFunction) {
-  const registrationEnabled = CONFIG.SIGNUP.ENABLED
+async function getUserVideos (req: express.Request, res: express.Response, next: express.NextFunction) {
+  const user = res.locals.oauth.token.User as UserModel
+  const resultList = await VideoModel.listUserVideosForApi(user.id ,req.query.start, req.query.count, req.query.sort)
 
-  if (registrationEnabled === true) {
-    return next()
+  return res.json(getFormattedObjects(resultList.data, resultList.total))
+}
+
+async function createUserRetryWrapper (req: express.Request, res: express.Response, next: express.NextFunction) {
+  const options = {
+    arguments: [ req ],
+    errorMessage: 'Cannot insert the user with many retries.'
   }
 
-  return res.status(400).send('User registration is not enabled.')
+  await retryTransactionWrapper(createUser, options)
+
+  // TODO : include Location of the new user -> 201
+  return res.type('json').status(204).end()
 }
 
-function createUser (req: express.Request, res: express.Response, next: express.NextFunction) {
-  const user = db.User.build({
-    username: req.body.username,
-    password: req.body.password,
-    email: req.body.email,
+async function createUser (req: express.Request) {
+  const body: UserCreate = req.body
+  const user = new UserModel({
+    username: body.username,
+    password: body.password,
+    email: body.email,
     displayNSFW: false,
-    role: USER_ROLES.USER
+    autoPlayVideo: true,
+    role: body.role,
+    videoQuota: body.videoQuota
   })
 
-  user.save().asCallback(function (err) {
-    if (err) return next(err)
+  await createUserAccountAndChannel(user)
 
-    return res.type('json').status(204).end()
-  })
+  logger.info('User %s with its channel and account created.', body.username)
 }
 
-function getUserInformation (req: express.Request, res: express.Response, next: express.NextFunction) {
-  db.User.loadByUsername(res.locals.oauth.token.user.username, function (err, user) {
-    if (err) return next(err)
+async function registerUserRetryWrapper (req: express.Request, res: express.Response, next: express.NextFunction) {
+  const options = {
+    arguments: [ req ],
+    errorMessage: 'Cannot insert the user with many retries.'
+  }
+
+  await retryTransactionWrapper(registerUser, options)
 
-    return res.json(user.toFormatedJSON())
+  return res.type('json').status(204).end()
+}
+
+async function registerUser (req: express.Request) {
+  const body: UserCreate = req.body
+
+  const user = new UserModel({
+    username: body.username,
+    password: body.password,
+    email: body.email,
+    displayNSFW: false,
+    autoPlayVideo: true,
+    role: UserRole.USER,
+    videoQuota: CONFIG.USER.VIDEO_QUOTA
   })
+
+  await createUserAccountAndChannel(user)
+
+  logger.info('User %s with its channel and account registered.', body.username)
 }
 
-function getUserVideoRating (req: express.Request, res: express.Response, next: express.NextFunction) {
-  const videoId = '' + req.params.videoId
-  const userId = +res.locals.oauth.token.User.id
+async function getUserInformation (req: express.Request, res: express.Response, next: express.NextFunction) {
+  // We did not load channels in res.locals.user
+  const user = await UserModel.loadByUsernameAndPopulateChannels(res.locals.oauth.token.user.username)
+
+  return res.json(user.toFormattedJSON())
+}
 
-  db.UserVideoRate.load(userId, videoId, null, function (err, ratingObj) {
-    if (err) return next(err)
+function getUser (req: express.Request, res: express.Response, next: express.NextFunction) {
+  return res.json(res.locals.user.toFormattedJSON())
+}
 
-    const rating = ratingObj ? ratingObj.type : 'none'
+async function getUserVideoRating (req: express.Request, res: express.Response, next: express.NextFunction) {
+  const videoId = +req.params.videoId
+  const accountId = +res.locals.oauth.token.User.Account.id
 
-    res.json({
-      videoId,
-      rating
-    })
-  })
+  const ratingObj = await AccountVideoRateModel.load(accountId, videoId, null)
+  const rating = ratingObj ? ratingObj.type : 'none'
+
+  const json: FormattedUserVideoRate = {
+    videoId,
+    rating
+  }
+  res.json(json)
 }
 
-function listUsers (req: express.Request, res: express.Response, next: express.NextFunction) {
-  db.User.listForApi(req.query.start, req.query.count, req.query.sort, function (err, usersList, usersTotal) {
-    if (err) return next(err)
+async function listUsers (req: express.Request, res: express.Response, next: express.NextFunction) {
+  const resultList = await UserModel.listForApi(req.query.start, req.query.count, req.query.sort)
 
-    res.json(getFormatedObjects(usersList, usersTotal))
-  })
+  return res.json(getFormattedObjects(resultList.data, resultList.total))
 }
 
-function removeUser (req: express.Request, res: express.Response, next: express.NextFunction) {
-  waterfall([
-    function loadUser (callback) {
-      db.User.loadById(req.params.id, callback)
-    },
-
-    function deleteUser (user, callback) {
-      user.destroy().asCallback(callback)
-    }
-  ], function andFinally (err) {
-    if (err) {
-      logger.error('Errors when removed the user.', { error: err })
-      return next(err)
-    }
-
-    return res.sendStatus(204)
-  })
+async function removeUser (req: express.Request, res: express.Response, next: express.NextFunction) {
+  const user = await UserModel.loadById(req.params.id)
+
+  await user.destroy()
+
+  return res.sendStatus(204)
 }
 
-function updateUser (req: express.Request, res: express.Response, next: express.NextFunction) {
-  db.User.loadByUsername(res.locals.oauth.token.user.username, function (err, user) {
-    if (err) return next(err)
+async function updateMe (req: express.Request, res: express.Response, next: express.NextFunction) {
+  const body: UserUpdateMe = req.body
 
-    if (req.body.password) user.password = req.body.password
-    if (req.body.displayNSFW !== undefined) user.displayNSFW = req.body.displayNSFW
+  // FIXME: user is not already a Sequelize instance?
+  const user = res.locals.oauth.token.user
 
-    user.save().asCallback(function (err) {
-      if (err) return next(err)
+  if (body.password !== undefined) user.password = body.password
+  if (body.email !== undefined) user.email = body.email
+  if (body.displayNSFW !== undefined) user.displayNSFW = body.displayNSFW
+  if (body.autoPlayVideo !== undefined) user.autoPlayVideo = body.autoPlayVideo
 
-      return res.sendStatus(204)
-    })
-  })
+  await user.save()
+
+  return res.sendStatus(204)
+}
+
+async function updateUser (req: express.Request, res: express.Response, next: express.NextFunction) {
+  const body: UserUpdate = req.body
+  const user = res.locals.user as UserModel
+
+  if (body.email !== undefined) user.email = body.email
+  if (body.videoQuota !== undefined) user.videoQuota = body.videoQuota
+  if (body.role !== undefined) user.role = body.role
+
+  await user.save()
+
+  return res.sendStatus(204)
 }
 
 function success (req: express.Request, res: express.Response, next: express.NextFunction) {