X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;f=server%2Fcontrollers%2Factivitypub%2Finbox.ts;h=807d0bdf4e53b378ed932f7c371f75adbef01aa1;hb=e71bcc0f4b31ecfd84a786411febfc6d18a85258;hp=79d989c2c26d6d0bb1e55477f2947fb151c23843;hpb=e4f97babf701481b55cc10fb3448feab5f97c867;p=github%2FChocobozzz%2FPeerTube.git diff --git a/server/controllers/activitypub/inbox.ts b/server/controllers/activitypub/inbox.ts index 79d989c2c..807d0bdf4 100644 --- a/server/controllers/activitypub/inbox.ts +++ b/server/controllers/activitypub/inbox.ts @@ -1,36 +1,42 @@ import * as express from 'express' - -import { - processCreateActivity, - processUpdateActivity, - processFlagActivity -} from '../../lib' -import { - Activity, - ActivityType, - RootActivity, - ActivityPubCollection, - ActivityPubOrderedCollection -} from '../../../shared' -import { - signatureValidator, - checkSignature, - asyncMiddleware -} from '../../middlewares' +import { Activity, ActivityPubCollection, ActivityPubOrderedCollection, ActivityType, RootActivity } from '../../../shared' import { logger } from '../../helpers' +import { isActivityValid } from '../../helpers/custom-validators/activitypub/activity' +import { processCreateActivity, processUpdateActivity, processUndoActivity } from '../../lib' +import { processAcceptActivity } from '../../lib/activitypub/process/process-accept' +import { processAddActivity } from '../../lib/activitypub/process/process-add' +import { processAnnounceActivity } from '../../lib/activitypub/process/process-announce' +import { processDeleteActivity } from '../../lib/activitypub/process/process-delete' +import { processFollowActivity } from '../../lib/activitypub/process/process-follow' +import { asyncMiddleware, checkSignature, localAccountValidator, signatureValidator } from '../../middlewares' +import { activityPubValidator } from '../../middlewares/validators/activitypub/activity' +import { AccountInstance } from '../../models/account/account-interface' -const processActivity: { [ P in ActivityType ]: (activity: Activity) => Promise } = { +const processActivity: { [ P in ActivityType ]: (activity: Activity, inboxAccount?: AccountInstance) => Promise } = { Create: processCreateActivity, + Add: processAddActivity, Update: processUpdateActivity, - Flag: processFlagActivity + Delete: processDeleteActivity, + Follow: processFollowActivity, + Accept: processAcceptActivity, + Announce: processAnnounceActivity, + Undo: processUndoActivity } const inboxRouter = express.Router() -inboxRouter.post('/', +inboxRouter.post('/inbox', + signatureValidator, + asyncMiddleware(checkSignature), + activityPubValidator, + asyncMiddleware(inboxController) +) + +inboxRouter.post('/account/:name/inbox', signatureValidator, asyncMiddleware(checkSignature), - // inboxValidator, + localAccountValidator, + activityPubValidator, asyncMiddleware(inboxController) ) @@ -54,12 +60,17 @@ async function inboxController (req: express.Request, res: express.Response, nex activities = [ rootActivity as Activity ] } - await processActivities(activities) + // Only keep activities we are able to process + logger.debug('Filtering activities...', { activities }) + activities = activities.filter(a => isActivityValid(a)) + logger.debug('We keep %d activities.', activities.length, { activities }) + + await processActivities(activities, res.locals.account) res.status(204).end() } -async function processActivities (activities: Activity[]) { +async function processActivities (activities: Activity[], inboxAccount?: AccountInstance) { for (const activity of activities) { const activityProcessor = processActivity[activity.type] if (activityProcessor === undefined) { @@ -67,6 +78,6 @@ async function processActivities (activities: Activity[]) { continue } - await activityProcessor(activity) + await activityProcessor(activity, inboxAccount) } }