X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;f=server%2Fcontrollers%2Factivitypub%2Finbox.ts;h=30662990a0e628e9025de95ff4e59eb95fffd374;hb=20bafcb61bee2a9a10a500908850c9a7d5e3c8c5;hp=38d5c51dfbf91386fb418695ac8eb7d05c838183;hpb=97567dd81f508dd6295ac4d73d849aa2ce0a6549;p=github%2FChocobozzz%2FPeerTube.git diff --git a/server/controllers/activitypub/inbox.ts b/server/controllers/activitypub/inbox.ts index 38d5c51df..30662990a 100644 --- a/server/controllers/activitypub/inbox.ts +++ b/server/controllers/activitypub/inbox.ts @@ -1,12 +1,11 @@ import * as express from 'express' +import { InboxManager } from '@server/lib/activitypub/inbox-manager' import { Activity, ActivityPubCollection, ActivityPubOrderedCollection, RootActivity } from '../../../shared' +import { HttpStatusCode } from '../../../shared/models/http/http-error-codes' import { isActivityValid } from '../../helpers/custom-validators/activitypub/activity' import { logger } from '../../helpers/logger' -import { processActivities } from '../../lib/activitypub/process/process' import { asyncMiddleware, checkSignature, localAccountValidator, localVideoChannelValidator, signatureValidator } from '../../middlewares' import { activityPubValidator } from '../../middlewares/validators/activitypub/activity' -import { queue } from 'async' -import { ActorModel } from '../../models/activitypub/actor' const inboxRouter = express.Router() @@ -40,20 +39,13 @@ export { // --------------------------------------------------------------------------- -const inboxQueue = queue<{ activities: Activity[], signatureActor?: ActorModel, inboxActor?: ActorModel }, Error>((task, cb) => { - const options = { signatureActor: task.signatureActor, inboxActor: task.inboxActor } - - processActivities(task.activities, options) - .then(() => cb()) -}) - function inboxController (req: express.Request, res: express.Response) { const rootActivity: RootActivity = req.body - let activities: Activity[] = [] + let activities: Activity[] - if ([ 'Collection', 'CollectionPage' ].indexOf(rootActivity.type) !== -1) { + if ([ 'Collection', 'CollectionPage' ].includes(rootActivity.type)) { activities = (rootActivity as ActivityPubCollection).items - } else if ([ 'OrderedCollection', 'OrderedCollectionPage' ].indexOf(rootActivity.type) !== -1) { + } else if ([ 'OrderedCollection', 'OrderedCollectionPage' ].includes(rootActivity.type)) { activities = (rootActivity as ActivityPubOrderedCollection).orderedItems } else { activities = [ rootActivity as Activity ] @@ -68,11 +60,13 @@ function inboxController (req: express.Request, res: express.Response) { logger.info('Receiving inbox requests for %d activities by %s.', activities.length, res.locals.signature.actor.url) - inboxQueue.push({ + InboxManager.Instance.addInboxMessage({ activities, signatureActor: res.locals.signature.actor, - inboxActor: accountOrChannel ? accountOrChannel.Actor : undefined + inboxActor: accountOrChannel + ? accountOrChannel.Actor + : undefined }) - return res.status(204).end() + return res.status(HttpStatusCode.NO_CONTENT_204).end() }