X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;f=server%2Fcontrollers%2Factivitypub%2Fclient.ts;h=71a5b623256dcb1c2c190a2163ade4bfe4396369;hb=de94ac86a211dec657332d964693857ec235ce40;hp=1a4e28dc8856e26a3b0e5bf24fe74775ced4a402;hpb=1a8dd4da77468068d1ff7f7bd67f76399ae04e04;p=github%2FChocobozzz%2FPeerTube.git diff --git a/server/controllers/activitypub/client.ts b/server/controllers/activitypub/client.ts index 1a4e28dc8..71a5b6232 100644 --- a/server/controllers/activitypub/client.ts +++ b/server/controllers/activitypub/client.ts @@ -1,123 +1,167 @@ -// Intercept ActivityPub client requests +import * as cors from 'cors' import * as express from 'express' +import { getServerActor } from '@server/models/application/application' +import { MAccountId, MActorId, MChannelId, MVideoId, MVideoUrl } from '@server/types/models' import { VideoPrivacy, VideoRateType } from '../../../shared/models/videos' +import { VideoPlaylistPrivacy } from '../../../shared/models/videos/playlist/video-playlist-privacy.model' import { activityPubCollectionPagination, activityPubContextify } from '../../helpers/activitypub' -import { CONFIG, ROUTE_CACHE_LIFETIME } from '../../initializers' -import { buildAnnounceWithVideoAudience, buildDislikeActivity, buildLikeActivity } from '../../lib/activitypub/send' +import { ROUTE_CACHE_LIFETIME, WEBSERVER } from '../../initializers/constants' import { audiencify, getAudience } from '../../lib/activitypub/audience' +import { buildAnnounceWithVideoAudience, buildLikeActivity } from '../../lib/activitypub/send' import { buildCreateActivity } from '../../lib/activitypub/send/send-create' +import { buildDislikeActivity } from '../../lib/activitypub/send/send-dislike' +import { + getLocalVideoCommentsActivityPubUrl, + getLocalVideoDislikesActivityPubUrl, + getLocalVideoLikesActivityPubUrl, + getLocalVideoSharesActivityPubUrl +} from '../../lib/activitypub/url' import { asyncMiddleware, - videosShareValidator, executeIfActivityPub, localAccountValidator, localVideoChannelValidator, - videosCustomGetValidator + videosCustomGetValidator, + videosShareValidator } from '../../middlewares' -import { - getAccountVideoRateValidator, - videoCommentGetValidator, - videosGetValidator -} from '../../middlewares/validators' +import { cacheRoute } from '../../middlewares/cache' +import { getAccountVideoRateValidatorFactory, videoCommentGetValidator } from '../../middlewares/validators' +import { videoFileRedundancyGetValidator, videoPlaylistRedundancyGetValidator } from '../../middlewares/validators/redundancy' +import { videoPlaylistElementAPGetValidator, videoPlaylistsGetValidator } from '../../middlewares/validators/videos/video-playlists' import { AccountModel } from '../../models/account/account' -import { ActorModel } from '../../models/activitypub/actor' +import { AccountVideoRateModel } from '../../models/account/account-video-rate' import { ActorFollowModel } from '../../models/activitypub/actor-follow' import { VideoModel } from '../../models/video/video' -import { VideoChannelModel } from '../../models/video/video-channel' +import { VideoCaptionModel } from '../../models/video/video-caption' import { VideoCommentModel } from '../../models/video/video-comment' +import { VideoPlaylistModel } from '../../models/video/video-playlist' import { VideoShareModel } from '../../models/video/video-share' -import { cacheRoute } from '../../middlewares/cache' import { activityPubResponse } from './utils' -import { AccountVideoRateModel } from '../../models/account/account-video-rate' -import { - getRateUrl, - getVideoCommentsActivityPubUrl, - getVideoDislikesActivityPubUrl, - getVideoLikesActivityPubUrl, - getVideoSharesActivityPubUrl -} from '../../lib/activitypub' -import { VideoCaptionModel } from '../../models/video/video-caption' -import { videoRedundancyGetValidator } from '../../middlewares/validators/redundancy' -import { getServerActor } from '../../helpers/utils' -import { VideoRedundancyModel } from '../../models/redundancy/video-redundancy' const activityPubClientRouter = express.Router() +activityPubClientRouter.use(cors()) + +// Intercept ActivityPub client requests activityPubClientRouter.get('/accounts?/:name', - executeIfActivityPub(asyncMiddleware(localAccountValidator)), - executeIfActivityPub(accountController) + executeIfActivityPub, + asyncMiddleware(localAccountValidator), + accountController ) activityPubClientRouter.get('/accounts?/:name/followers', - executeIfActivityPub(asyncMiddleware(localAccountValidator)), - executeIfActivityPub(asyncMiddleware(accountFollowersController)) + executeIfActivityPub, + asyncMiddleware(localAccountValidator), + asyncMiddleware(accountFollowersController) ) activityPubClientRouter.get('/accounts?/:name/following', - executeIfActivityPub(asyncMiddleware(localAccountValidator)), - executeIfActivityPub(asyncMiddleware(accountFollowingController)) + executeIfActivityPub, + asyncMiddleware(localAccountValidator), + asyncMiddleware(accountFollowingController) +) +activityPubClientRouter.get('/accounts?/:name/playlists', + executeIfActivityPub, + asyncMiddleware(localAccountValidator), + asyncMiddleware(accountPlaylistsController) ) activityPubClientRouter.get('/accounts?/:name/likes/:videoId', - executeIfActivityPub(asyncMiddleware(getAccountVideoRateValidator('like'))), - executeIfActivityPub(getAccountVideoRate('like')) + executeIfActivityPub, + asyncMiddleware(getAccountVideoRateValidatorFactory('like')), + getAccountVideoRateFactory('like') ) activityPubClientRouter.get('/accounts?/:name/dislikes/:videoId', - executeIfActivityPub(asyncMiddleware(getAccountVideoRateValidator('dislike'))), - executeIfActivityPub(getAccountVideoRate('dislike')) + executeIfActivityPub, + asyncMiddleware(getAccountVideoRateValidatorFactory('dislike')), + getAccountVideoRateFactory('dislike') ) activityPubClientRouter.get('/videos/watch/:id', - executeIfActivityPub(asyncMiddleware(cacheRoute(ROUTE_CACHE_LIFETIME.ACTIVITY_PUB.VIDEOS))), - executeIfActivityPub(asyncMiddleware(videosGetValidator)), - executeIfActivityPub(asyncMiddleware(videoController)) + executeIfActivityPub, + asyncMiddleware(cacheRoute()(ROUTE_CACHE_LIFETIME.ACTIVITY_PUB.VIDEOS)), + asyncMiddleware(videosCustomGetValidator('only-video-with-rights')), + asyncMiddleware(videoController) ) activityPubClientRouter.get('/videos/watch/:id/activity', - executeIfActivityPub(asyncMiddleware(videosGetValidator)), - executeIfActivityPub(asyncMiddleware(videoController)) + executeIfActivityPub, + asyncMiddleware(videosCustomGetValidator('only-video-with-rights')), + asyncMiddleware(videoController) ) activityPubClientRouter.get('/videos/watch/:id/announces', - executeIfActivityPub(asyncMiddleware(videosCustomGetValidator('only-video'))), - executeIfActivityPub(asyncMiddleware(videoAnnouncesController)) + executeIfActivityPub, + asyncMiddleware(videosCustomGetValidator('only-immutable-attributes')), + asyncMiddleware(videoAnnouncesController) ) activityPubClientRouter.get('/videos/watch/:id/announces/:actorId', - executeIfActivityPub(asyncMiddleware(videosShareValidator)), - executeIfActivityPub(asyncMiddleware(videoAnnounceController)) + executeIfActivityPub, + asyncMiddleware(videosShareValidator), + asyncMiddleware(videoAnnounceController) ) activityPubClientRouter.get('/videos/watch/:id/likes', - executeIfActivityPub(asyncMiddleware(videosCustomGetValidator('only-video'))), - executeIfActivityPub(asyncMiddleware(videoLikesController)) + executeIfActivityPub, + asyncMiddleware(videosCustomGetValidator('only-immutable-attributes')), + asyncMiddleware(videoLikesController) ) activityPubClientRouter.get('/videos/watch/:id/dislikes', - executeIfActivityPub(asyncMiddleware(videosCustomGetValidator('only-video'))), - executeIfActivityPub(asyncMiddleware(videoDislikesController)) + executeIfActivityPub, + asyncMiddleware(videosCustomGetValidator('only-immutable-attributes')), + asyncMiddleware(videoDislikesController) ) activityPubClientRouter.get('/videos/watch/:id/comments', - executeIfActivityPub(asyncMiddleware(videosCustomGetValidator('only-video'))), - executeIfActivityPub(asyncMiddleware(videoCommentsController)) + executeIfActivityPub, + asyncMiddleware(videosCustomGetValidator('only-immutable-attributes')), + asyncMiddleware(videoCommentsController) ) activityPubClientRouter.get('/videos/watch/:videoId/comments/:commentId', - executeIfActivityPub(asyncMiddleware(videoCommentGetValidator)), - executeIfActivityPub(asyncMiddleware(videoCommentController)) + executeIfActivityPub, + asyncMiddleware(videoCommentGetValidator), + asyncMiddleware(videoCommentController) ) activityPubClientRouter.get('/videos/watch/:videoId/comments/:commentId/activity', - executeIfActivityPub(asyncMiddleware(videoCommentGetValidator)), - executeIfActivityPub(asyncMiddleware(videoCommentController)) + executeIfActivityPub, + asyncMiddleware(videoCommentGetValidator), + asyncMiddleware(videoCommentController) ) activityPubClientRouter.get('/video-channels/:name', - executeIfActivityPub(asyncMiddleware(localVideoChannelValidator)), - executeIfActivityPub(asyncMiddleware(videoChannelController)) + executeIfActivityPub, + asyncMiddleware(localVideoChannelValidator), + videoChannelController ) activityPubClientRouter.get('/video-channels/:name/followers', - executeIfActivityPub(asyncMiddleware(localVideoChannelValidator)), - executeIfActivityPub(asyncMiddleware(videoChannelFollowersController)) + executeIfActivityPub, + asyncMiddleware(localVideoChannelValidator), + asyncMiddleware(videoChannelFollowersController) ) activityPubClientRouter.get('/video-channels/:name/following', - executeIfActivityPub(asyncMiddleware(localVideoChannelValidator)), - executeIfActivityPub(asyncMiddleware(videoChannelFollowingController)) + executeIfActivityPub, + asyncMiddleware(localVideoChannelValidator), + asyncMiddleware(videoChannelFollowingController) +) +activityPubClientRouter.get('/video-channels/:name/playlists', + executeIfActivityPub, + asyncMiddleware(localVideoChannelValidator), + asyncMiddleware(videoChannelPlaylistsController) ) activityPubClientRouter.get('/redundancy/videos/:videoId/:resolution([0-9]+)(-:fps([0-9]+))?', - executeIfActivityPub(asyncMiddleware(videoRedundancyGetValidator)), - executeIfActivityPub(asyncMiddleware(videoRedundancyController)) + executeIfActivityPub, + asyncMiddleware(videoFileRedundancyGetValidator), + asyncMiddleware(videoRedundancyController) +) +activityPubClientRouter.get('/redundancy/streaming-playlists/:streamingPlaylistType/:videoId', + executeIfActivityPub, + asyncMiddleware(videoPlaylistRedundancyGetValidator), + asyncMiddleware(videoRedundancyController) +) + +activityPubClientRouter.get('/video-playlists/:playlistId', + executeIfActivityPub, + asyncMiddleware(videoPlaylistsGetValidator('all')), + asyncMiddleware(videoPlaylistController) +) +activityPubClientRouter.get('/video-playlists/:playlistId/videos/:playlistElementId', + executeIfActivityPub, + asyncMiddleware(videoPlaylistElementAPGetValidator), + videoPlaylistElementController ) // --------------------------------------------------------------------------- @@ -128,53 +172,68 @@ export { // --------------------------------------------------------------------------- -function accountController (req: express.Request, res: express.Response, next: express.NextFunction) { - const account: AccountModel = res.locals.account +function accountController (req: express.Request, res: express.Response) { + const account = res.locals.account return activityPubResponse(activityPubContextify(account.toActivityPubObject()), res) } -async function accountFollowersController (req: express.Request, res: express.Response, next: express.NextFunction) { - const account: AccountModel = res.locals.account +async function accountFollowersController (req: express.Request, res: express.Response) { + const account = res.locals.account const activityPubResult = await actorFollowers(req, account.Actor) return activityPubResponse(activityPubContextify(activityPubResult), res) } -async function accountFollowingController (req: express.Request, res: express.Response, next: express.NextFunction) { - const account: AccountModel = res.locals.account +async function accountFollowingController (req: express.Request, res: express.Response) { + const account = res.locals.account const activityPubResult = await actorFollowing(req, account.Actor) return activityPubResponse(activityPubContextify(activityPubResult), res) } -function getAccountVideoRate (rateType: VideoRateType) { +async function accountPlaylistsController (req: express.Request, res: express.Response) { + const account = res.locals.account + const activityPubResult = await actorPlaylists(req, { account }) + + return activityPubResponse(activityPubContextify(activityPubResult), res) +} + +async function videoChannelPlaylistsController (req: express.Request, res: express.Response) { + const channel = res.locals.videoChannel + const activityPubResult = await actorPlaylists(req, { channel }) + + return activityPubResponse(activityPubContextify(activityPubResult), res) +} + +function getAccountVideoRateFactory (rateType: VideoRateType) { return (req: express.Request, res: express.Response) => { - const accountVideoRate: AccountVideoRateModel = res.locals.accountVideoRate + const accountVideoRate = res.locals.accountVideoRate const byActor = accountVideoRate.Account.Actor - const url = getRateUrl(rateType, byActor, accountVideoRate.Video) const APObject = rateType === 'like' - ? buildLikeActivity(url, byActor, accountVideoRate.Video) - : buildCreateActivity(url, byActor, buildDislikeActivity(url, byActor, accountVideoRate.Video)) + ? buildLikeActivity(accountVideoRate.url, byActor, accountVideoRate.Video) + : buildDislikeActivity(accountVideoRate.url, byActor, accountVideoRate.Video) return activityPubResponse(activityPubContextify(APObject), res) } } async function videoController (req: express.Request, res: express.Response) { - const video: VideoModel = res.locals.video + // We need more attributes + const video = await VideoModel.loadAndPopulateAccountAndServerAndTags(res.locals.onlyVideoWithRights.id) - if (video.url.startsWith(CONFIG.WEBSERVER.URL) === false) return res.redirect(video.url) + if (redirectIfNotOwned(video.url, res)) return // We need captions to render AP object - video.VideoCaptions = await VideoCaptionModel.listVideoCaptions(video.id) + const captions = await VideoCaptionModel.listVideoCaptions(video.id) + const videoWithCaptions = Object.assign(video, { VideoCaptions: captions }) - const audience = getAudience(video.VideoChannel.Account.Actor, video.privacy === VideoPrivacy.PUBLIC) - const videoObject = audiencify(video.toActivityPubObject(), audience) + const audience = getAudience(videoWithCaptions.VideoChannel.Account.Actor, videoWithCaptions.privacy === VideoPrivacy.PUBLIC) + const videoObject = audiencify(videoWithCaptions.toActivityPubObject(), audience) if (req.path.endsWith('/activity')) { - const data = buildCreateActivity(video.url, video.VideoChannel.Account.Actor, videoObject, audience) + const data = buildCreateActivity(videoWithCaptions.url, video.VideoChannel.Account.Actor, videoObject, audience) return activityPubResponse(activityPubContextify(data), res) } @@ -182,17 +241,19 @@ async function videoController (req: express.Request, res: express.Response) { } async function videoAnnounceController (req: express.Request, res: express.Response) { - const share = res.locals.videoShare as VideoShareModel + const share = res.locals.videoShare - if (share.url.startsWith(CONFIG.WEBSERVER.URL) === false) return res.redirect(share.url) + if (redirectIfNotOwned(share.url, res)) return - const { activity } = await buildAnnounceWithVideoAudience(share.Actor, share, res.locals.video, undefined) + const { activity } = await buildAnnounceWithVideoAudience(share.Actor, share, res.locals.videoAll, undefined) - return activityPubResponse(activityPubContextify(activity), res) + return activityPubResponse(activityPubContextify(activity, 'Announce'), res) } async function videoAnnouncesController (req: express.Request, res: express.Response) { - const video: VideoModel = res.locals.video + const video = res.locals.onlyImmutableVideo + + if (redirectIfNotOwned(video.url, res)) return const handler = async (start: number, count: number) => { const result = await VideoShareModel.listAndCountByVideoId(video.id, start, count) @@ -201,82 +262,94 @@ async function videoAnnouncesController (req: express.Request, res: express.Resp data: result.rows.map(r => r.url) } } - const json = await activityPubCollectionPagination(getVideoSharesActivityPubUrl(video), handler, req.query.page) + const json = await activityPubCollectionPagination(getLocalVideoSharesActivityPubUrl(video), handler, req.query.page) return activityPubResponse(activityPubContextify(json), res) } async function videoLikesController (req: express.Request, res: express.Response) { - const video: VideoModel = res.locals.video - const json = await videoRates(req, 'like', video, getVideoLikesActivityPubUrl(video)) + const video = res.locals.onlyImmutableVideo + + if (redirectIfNotOwned(video.url, res)) return + + const json = await videoRates(req, 'like', video, getLocalVideoLikesActivityPubUrl(video)) return activityPubResponse(activityPubContextify(json), res) } async function videoDislikesController (req: express.Request, res: express.Response) { - const video: VideoModel = res.locals.video - const json = await videoRates(req, 'dislike', video, getVideoDislikesActivityPubUrl(video)) + const video = res.locals.onlyImmutableVideo + + if (redirectIfNotOwned(video.url, res)) return + + const json = await videoRates(req, 'dislike', video, getLocalVideoDislikesActivityPubUrl(video)) return activityPubResponse(activityPubContextify(json), res) } async function videoCommentsController (req: express.Request, res: express.Response) { - const video: VideoModel = res.locals.video + const video = res.locals.onlyImmutableVideo + + if (redirectIfNotOwned(video.url, res)) return const handler = async (start: number, count: number) => { - const result = await VideoCommentModel.listAndCountByVideoId(video.id, start, count) + const result = await VideoCommentModel.listAndCountByVideoForAP(video, start, count) return { total: result.count, data: result.rows.map(r => r.url) } } - const json = await activityPubCollectionPagination(getVideoCommentsActivityPubUrl(video), handler, req.query.page) + const json = await activityPubCollectionPagination(getLocalVideoCommentsActivityPubUrl(video), handler, req.query.page) return activityPubResponse(activityPubContextify(json), res) } -async function videoChannelController (req: express.Request, res: express.Response) { - const videoChannel: VideoChannelModel = res.locals.videoChannel +function videoChannelController (req: express.Request, res: express.Response) { + const videoChannel = res.locals.videoChannel return activityPubResponse(activityPubContextify(videoChannel.toActivityPubObject()), res) } async function videoChannelFollowersController (req: express.Request, res: express.Response) { - const videoChannel: VideoChannelModel = res.locals.videoChannel + const videoChannel = res.locals.videoChannel const activityPubResult = await actorFollowers(req, videoChannel.Actor) return activityPubResponse(activityPubContextify(activityPubResult), res) } async function videoChannelFollowingController (req: express.Request, res: express.Response) { - const videoChannel: VideoChannelModel = res.locals.videoChannel + const videoChannel = res.locals.videoChannel const activityPubResult = await actorFollowing(req, videoChannel.Actor) return activityPubResponse(activityPubContextify(activityPubResult), res) } async function videoCommentController (req: express.Request, res: express.Response) { - const videoComment: VideoCommentModel = res.locals.videoComment + const videoComment = res.locals.videoCommentFull - if (videoComment.url.startsWith(CONFIG.WEBSERVER.URL) === false) return res.redirect(videoComment.url) + if (redirectIfNotOwned(videoComment.url, res)) return const threadParentComments = await VideoCommentModel.listThreadParentComments(videoComment, undefined) const isPublic = true // Comments are always public - const audience = getAudience(videoComment.Account.Actor, isPublic) + let videoCommentObject = videoComment.toActivityPubObject(threadParentComments) - const videoCommentObject = audiencify(videoComment.toActivityPubObject(threadParentComments), audience) + if (videoComment.Account) { + const audience = getAudience(videoComment.Account.Actor, isPublic) + videoCommentObject = audiencify(videoCommentObject, audience) - if (req.path.endsWith('/activity')) { - const data = buildCreateActivity(videoComment.url, videoComment.Account.Actor, videoCommentObject, audience) - return activityPubResponse(activityPubContextify(data), res) + if (req.path.endsWith('/activity')) { + const data = buildCreateActivity(videoComment.url, videoComment.Account.Actor, videoCommentObject, audience) + return activityPubResponse(activityPubContextify(data), res) + } } return activityPubResponse(activityPubContextify(videoCommentObject), res) } async function videoRedundancyController (req: express.Request, res: express.Response) { - const videoRedundancy: VideoRedundancyModel = res.locals.videoRedundancy - if (videoRedundancy.url.startsWith(CONFIG.WEBSERVER.URL) === false) return res.redirect(videoRedundancy.url) + const videoRedundancy = res.locals.videoRedundancy + + if (redirectIfNotOwned(videoRedundancy.url, res)) return const serverActor = await getServerActor() @@ -285,31 +358,63 @@ async function videoRedundancyController (req: express.Request, res: express.Res if (req.path.endsWith('/activity')) { const data = buildCreateActivity(videoRedundancy.url, serverActor, object, audience) - return activityPubResponse(activityPubContextify(data), res) + return activityPubResponse(activityPubContextify(data, 'CacheFile'), res) } + return activityPubResponse(activityPubContextify(object, 'CacheFile'), res) +} + +async function videoPlaylistController (req: express.Request, res: express.Response) { + const playlist = res.locals.videoPlaylistFull + + if (redirectIfNotOwned(playlist.url, res)) return + + // We need more attributes + playlist.OwnerAccount = await AccountModel.load(playlist.ownerAccountId) + + const json = await playlist.toActivityPubObject(req.query.page, null) + const audience = getAudience(playlist.OwnerAccount.Actor, playlist.privacy === VideoPlaylistPrivacy.PUBLIC) + const object = audiencify(json, audience) + return activityPubResponse(activityPubContextify(object), res) } +function videoPlaylistElementController (req: express.Request, res: express.Response) { + const videoPlaylistElement = res.locals.videoPlaylistElementAP + + if (redirectIfNotOwned(videoPlaylistElement.url, res)) return + + const json = videoPlaylistElement.toActivityPubObject() + return activityPubResponse(activityPubContextify(json), res) +} + // --------------------------------------------------------------------------- -async function actorFollowing (req: express.Request, actor: ActorModel) { +async function actorFollowing (req: express.Request, actor: MActorId) { const handler = (start: number, count: number) => { return ActorFollowModel.listAcceptedFollowingUrlsForApi([ actor.id ], undefined, start, count) } - return activityPubCollectionPagination(CONFIG.WEBSERVER.URL + req.path, handler, req.query.page) + return activityPubCollectionPagination(WEBSERVER.URL + req.path, handler, req.query.page) +} + +async function actorFollowers (req: express.Request, actor: MActorId) { + const handler = (start: number, count: number) => { + return ActorFollowModel.listAcceptedFollowerUrlsForAP([ actor.id ], undefined, start, count) + } + + return activityPubCollectionPagination(WEBSERVER.URL + req.path, handler, req.query.page) } -async function actorFollowers (req: express.Request, actor: ActorModel) { +async function actorPlaylists (req: express.Request, options: { account: MAccountId } | { channel: MChannelId }) { const handler = (start: number, count: number) => { - return ActorFollowModel.listAcceptedFollowerUrlsForApi([ actor.id ], undefined, start, count) + return VideoPlaylistModel.listPublicUrlsOfForAP(options, start, count) } - return activityPubCollectionPagination(CONFIG.WEBSERVER.URL + req.path, handler, req.query.page) + return activityPubCollectionPagination(WEBSERVER.URL + req.path, handler, req.query.page) } -function videoRates (req: express.Request, rateType: VideoRateType, video: VideoModel, url: string) { +function videoRates (req: express.Request, rateType: VideoRateType, video: MVideoId, url: string) { const handler = async (start: number, count: number) => { const result = await AccountVideoRateModel.listAndCountAccountUrlsByVideoId(rateType, video.id, start, count) return { @@ -319,3 +424,12 @@ function videoRates (req: express.Request, rateType: VideoRateType, video: Video } return activityPubCollectionPagination(url, handler, req.query.page) } + +function redirectIfNotOwned (url: string, res: express.Response) { + if (url.startsWith(WEBSERVER.URL) === false) { + res.redirect(url) + return true + } + + return false +}