X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;f=client%2Fsrc%2Froot-helpers%2Fplugins-manager.ts;h=f3416e44a09c5c2cac1d5ee7185eb15c4206e7fb;hb=178af31cb8624567a26a1ca06cba9f3a475be330;hp=61731032ad7f8cbed25bddd558370b246fdc01f2;hpb=fb3c9e2bf5b45d6d283cea4d55cc0d49eb58e3cb;p=github%2FChocobozzz%2FPeerTube.git diff --git a/client/src/root-helpers/plugins-manager.ts b/client/src/root-helpers/plugins-manager.ts index 61731032a..f3416e44a 100644 --- a/client/src/root-helpers/plugins-manager.ts +++ b/client/src/root-helpers/plugins-manager.ts @@ -3,7 +3,7 @@ import * as debug from 'debug' import { firstValueFrom, ReplaySubject } from 'rxjs' import { first, shareReplay } from 'rxjs/operators' import { RegisterClientHelpers } from 'src/types/register-client-option.model' -import { getHookType, internalRunHook } from '@shared/core-utils/plugins/hooks' +import { getExternalAuthHref, getHookType, internalRunHook } from '@shared/core-utils/plugins/hooks' import { ClientHookName, clientHookObject, @@ -16,11 +16,11 @@ import { RegisterClientRouteOptions, RegisterClientSettingsScriptOptions, RegisterClientVideoFieldOptions, - RegisteredExternalAuthConfig, ServerConfigPlugin } from '@shared/models' import { environment } from '../environments/environment' import { ClientScript } from '../types' +import { logger } from './logger' interface HookStructValue extends RegisterClientHookOptions { plugin: ServerConfigPlugin @@ -48,7 +48,7 @@ type OnSettingsScripts = (pluginInfo: PluginInfo, options: RegisterClientSetting type OnClientRoute = (options: RegisterClientRouteOptions) => void -const logger = debug('peertube:plugins') +const debugLogger = debug('peertube:plugins') class PluginsManager { private hooks: Hooks = {} @@ -67,7 +67,9 @@ class PluginsManager { signup: new ReplaySubject(1), login: new ReplaySubject(1), 'video-edit': new ReplaySubject(1), - embed: new ReplaySubject(1) + embed: new ReplaySubject(1), + 'my-library': new ReplaySubject(1), + 'video-channel': new ReplaySubject(1) } private readonly peertubeHelpersFactory: PeertubeHelpersFactory @@ -91,9 +93,13 @@ class PluginsManager { return isTheme ? '/themes' : '/plugins' } - static getExternalAuthHref (auth: RegisteredExternalAuthConfig) { - return environment.apiUrl + `/plugins/${auth.name}/${auth.version}/auth/${auth.authName}` + static getDefaultLoginHref (apiUrl: string, serverConfig: HTMLServerConfig) { + if (!serverConfig || serverConfig.client.menu.login.redirectOnSingleExternalAuth !== true) return undefined + const externalAuths = serverConfig.plugin.registeredExternalAuths + if (externalAuths.length !== 1) return undefined + + return getExternalAuthHref(apiUrl, externalAuths[0]) } loadPluginsList (config: HTMLServerConfig) { @@ -102,16 +108,27 @@ class PluginsManager { } } - async runHook (hookName: ClientHookName, result?: T, params?: any) { - if (!this.hooks[hookName]) return result + async runHook (hookName: ClientHookName, resultArg?: T | Promise, params?: any) { + if (!this.hooks[hookName]) { + // eslint-disable-next-line no-return-await + return await resultArg + } const hookType = getHookType(hookName) - for (const hook of this.hooks[hookName]) { - console.log('Running hook %s of plugin %s.', hookName, hook.plugin.name) + let result = await resultArg - result = await internalRunHook(hook.handler, hookType, result, params, err => { - console.error('Cannot run hook %s of script %s of plugin %s.', hookName, hook.clientScript.script, hook.plugin.name, err) + for (const hook of this.hooks[hookName]) { + logger.info(`Running hook ${hookName} of plugin ${hook.plugin.name}`) + + result = await internalRunHook({ + handler: hook.handler, + hookType, + result, + params, + onError: err => { + logger.error(`Cannot run hook ${hookName} of script ${hook.clientScript.script} of plugin ${hook.plugin.name}`, err) + } }) } @@ -169,7 +186,7 @@ class PluginsManager { this.loadingScopes[scope] = true - logger('Loading scope %s', scope) + debugLogger('Loading scope %s', scope) try { if (!isReload) this.loadedScopes.push(scope) @@ -179,7 +196,7 @@ class PluginsManager { this.loadingScopes[scope] = false this.pluginsLoaded[scope].next(true) - logger('Nothing to load for scope %s', scope) + debugLogger('Nothing to load for scope %s', scope) return } @@ -199,9 +216,9 @@ class PluginsManager { this.pluginsLoaded[scope].next(true) this.loadingScopes[scope] = false - logger('Scope %s loaded', scope) + debugLogger('Scope %s loaded', scope) } catch (err) { - console.error('Cannot load plugins by scope %s.', scope, err) + logger.error(`Cannot load plugins by scope ${scope}`, err) } } @@ -210,7 +227,7 @@ class PluginsManager { const registerHook = (options: RegisterClientHookOptions) => { if (clientHookObject[options.target] !== true) { - console.error('Unknown hook %s of plugin %s. Skipping.', options.target, plugin.name) + logger.error(`Unknown hook ${options.target} of plugin ${plugin.name}. Skipping.`) return } @@ -251,7 +268,7 @@ class PluginsManager { const peertubeHelpers = this.peertubeHelpersFactory(pluginInfo) - console.log('Loading script %s of plugin %s.', clientScript.script, plugin.name) + logger.info(`Loading script ${clientScript.script} of plugin ${plugin.name}`) const absURL = (environment.apiUrl || window.location.origin) + clientScript.script return dynamicImport(absURL) @@ -265,7 +282,7 @@ class PluginsManager { }) }) .then(() => this.sortHooksByPriority()) - .catch(err => console.error('Cannot import or register plugin %s.', pluginInfo.plugin.name, err)) + .catch(err => logger.error(`Cannot import or register plugin ${pluginInfo.plugin.name}`, err)) } private sortHooksByPriority () { @@ -293,7 +310,7 @@ async function dynamicImport (url: string) { // eslint-disable-next-line no-new-func return new Function(`return import('${url}')`)() } catch { - console.log('Fallback to import polyfill') + logger.info('Fallback to import polyfill') return new Promise((resolve, reject) => { const vector = '$importModule$' + Math.random().toString(32).slice(2)