X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;f=client%2Fsrc%2Fapp%2F%2Bvideos%2F%2Bvideo-edit%2Fvideo-update.component.ts;h=b70270261dbc2e1053729fae51ec251d59eceaff;hb=e7c89cc3f3e69776c6ad62e62a52f8d2f12a81c1;hp=9c4998f2e75b3eafcc54b8f528a23b22b827c4db;hpb=4495806f2f5045a0626ab64f43b5fc4deefe2ac0;p=github%2FChocobozzz%2FPeerTube.git diff --git a/client/src/app/+videos/+video-edit/video-update.component.ts b/client/src/app/+videos/+video-edit/video-update.component.ts index 9c4998f2e..b70270261 100644 --- a/client/src/app/+videos/+video-edit/video-update.component.ts +++ b/client/src/app/+videos/+video-edit/video-update.component.ts @@ -4,11 +4,14 @@ import { SelectChannelItem } from 'src/types/select-options-item.model' import { Component, HostListener, OnInit } from '@angular/core' import { ActivatedRoute, Router } from '@angular/router' import { Notifier } from '@app/core' -import { FormReactive, FormValidatorService } from '@app/shared/shared-forms' +import { FormReactive, FormReactiveService } from '@app/shared/shared-forms' import { Video, VideoCaptionEdit, VideoCaptionService, VideoDetails, VideoEdit, VideoService } from '@app/shared/shared-main' import { LiveVideoService } from '@app/shared/shared-video-live' import { LoadingBarService } from '@ngx-loading-bar/core' +import { logger } from '@root-helpers/logger' +import { pick, simpleObjectsDeepEqual } from '@shared/core-utils' import { LiveVideo, LiveVideoUpdate, VideoPrivacy } from '@shared/models' +import { VideoSource } from '@shared/models/videos/video-source' import { hydrateFormFromVideo } from './shared/video-edit-utils' @Component({ @@ -17,20 +20,20 @@ import { hydrateFormFromVideo } from './shared/video-edit-utils' templateUrl: './video-update.component.html' }) export class VideoUpdateComponent extends FormReactive implements OnInit { - video: VideoEdit + videoEdit: VideoEdit videoDetails: VideoDetails + videoSource: VideoSource userVideoChannels: SelectChannelItem[] = [] videoCaptions: VideoCaptionEdit[] = [] liveVideo: LiveVideo isUpdatingVideo = false forbidScheduledPublication = false - waitTranscodingEnabled = true private updateDone = false constructor ( - protected formValidatorService: FormValidatorService, + protected formReactiveService: FormReactiveService, private route: ActivatedRoute, private router: Router, private notifier: Notifier, @@ -46,24 +49,26 @@ export class VideoUpdateComponent extends FormReactive implements OnInit { this.buildForm({}) const { videoData } = this.route.snapshot.data - const { video, videoChannels, videoCaptions, liveVideo } = videoData + const { video, videoChannels, videoCaptions, videoSource, liveVideo } = videoData - this.video = new VideoEdit(video) this.videoDetails = video + this.videoEdit = new VideoEdit(this.videoDetails) this.userVideoChannels = videoChannels this.videoCaptions = videoCaptions + this.videoSource = videoSource this.liveVideo = liveVideo - this.forbidScheduledPublication = this.video.privacy !== VideoPrivacy.PRIVATE + this.forbidScheduledPublication = this.videoEdit.privacy !== VideoPrivacy.PRIVATE } onFormBuilt () { - hydrateFormFromVideo(this.form, this.video, true) + hydrateFormFromVideo(this.form, this.videoEdit, true) if (this.liveVideo) { this.form.patchValue({ saveReplay: this.liveVideo.saveReplay, + replayPrivacy: this.liveVideo.replaySettings ? this.liveVideo.replaySettings.privacy : VideoPrivacy.PRIVATE, latencyMode: this.liveVideo.latencyMode, permanentLive: this.liveVideo.permanentLive }) @@ -92,16 +97,12 @@ export class VideoUpdateComponent extends FormReactive implements OnInit { return { canDeactivate: this.formChanged === false, text } } - isWaitTranscodingEnabled () { + isWaitTranscodingHidden () { if (this.videoDetails.getFiles().length > 1) { // Already transcoded - return false + return true } - if (this.liveVideo && this.form.value['saveReplay'] !== true) { - return false - } - - return true + return false } async update () { @@ -112,32 +113,33 @@ export class VideoUpdateComponent extends FormReactive implements OnInit { return } - this.video.patch(this.form.value) + this.videoEdit.patch(this.form.value) this.loadingBar.useRef().start() this.isUpdatingVideo = true // Update the video - this.videoService.updateVideo(this.video) + this.videoService.updateVideo(this.videoEdit) .pipe( // Then update captions - switchMap(() => this.videoCaptionService.updateCaptions(this.video.id, this.videoCaptions)), + switchMap(() => this.videoCaptionService.updateCaptions(this.videoEdit.id, this.videoCaptions)), switchMap(() => { if (!this.liveVideo) return of(undefined) const liveVideoUpdate: LiveVideoUpdate = { saveReplay: !!this.form.value.saveReplay, + replaySettings: { privacy: this.form.value.replayPrivacy }, permanentLive: !!this.form.value.permanentLive, latencyMode: this.form.value.latencyMode } // Don't update live attributes if they did not change - const liveChanged = Object.keys(liveVideoUpdate) - .some(key => this.liveVideo[key] !== liveVideoUpdate[key]) + const baseVideo = pick(this.liveVideo, Object.keys(liveVideoUpdate) as (keyof LiveVideoUpdate)[]) + const liveChanged = !simpleObjectsDeepEqual(baseVideo, liveVideoUpdate) if (!liveChanged) return of(undefined) - return this.liveVideoService.updateLive(this.video.id, liveVideoUpdate) + return this.liveVideoService.updateLive(this.videoEdit.id, liveVideoUpdate) }) ) .subscribe({ @@ -146,23 +148,23 @@ export class VideoUpdateComponent extends FormReactive implements OnInit { this.isUpdatingVideo = false this.loadingBar.useRef().complete() this.notifier.success($localize`Video updated.`) - this.router.navigateByUrl(Video.buildWatchUrl(this.video)) + this.router.navigateByUrl(Video.buildWatchUrl(this.videoEdit)) }, error: err => { this.loadingBar.useRef().complete() this.isUpdatingVideo = false this.notifier.error(err.message) - console.error(err) + logger.error(err) } }) } hydratePluginFieldsFromVideo () { - if (!this.video.pluginData) return + if (!this.videoEdit.pluginData) return this.form.patchValue({ - pluginData: this.video.pluginData + pluginData: this.videoEdit.pluginData }) }