X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;f=app%2FDoctrineMigrations%2FVersion20161024212538.php;h=35853d033f6756efe590ab3a726c80972cd84708;hb=f808b01692a835673f328d7221ba8c212caa9b61;hp=75ff86f1fa40602870e851d1ab72985fc21240f1;hpb=24becc9717423748e6ef06c6cf1c499435af66b9;p=github%2Fwallabag%2Fwallabag.git

diff --git a/app/DoctrineMigrations/Version20161024212538.php b/app/DoctrineMigrations/Version20161024212538.php
index 75ff86f1..35853d03 100644
--- a/app/DoctrineMigrations/Version20161024212538.php
+++ b/app/DoctrineMigrations/Version20161024212538.php
@@ -7,6 +7,9 @@ use Doctrine\DBAL\Schema\Schema;
 use Symfony\Component\DependencyInjection\ContainerAwareInterface;
 use Symfony\Component\DependencyInjection\ContainerInterface;
 
+/**
+ * Added user_id column on oauth2_clients to prevent users to delete API clients from other users.
+ */
 class Version20161024212538 extends AbstractMigration implements ContainerAwareInterface
 {
     /**
@@ -14,16 +17,13 @@ class Version20161024212538 extends AbstractMigration implements ContainerAwareI
      */
     private $container;
 
+    private $constraintName = 'IDX_user_oauth_client';
+
     public function setContainer(ContainerInterface $container = null)
     {
         $this->container = $container;
     }
 
-    private function getTable($tableName)
-    {
-        return $this->container->getParameter('database_table_prefix').$tableName;
-    }
-
     /**
      * @param Schema $schema
      */
@@ -33,13 +33,14 @@ class Version20161024212538 extends AbstractMigration implements ContainerAwareI
 
         $this->skipIf($clientsTable->hasColumn('user_id'), 'It seems that you already played this migration.');
 
-        $clientsTable->addColumn('user_id', 'integer');
+        $clientsTable->addColumn('user_id', 'integer', ['notnull' => false]);
 
         $clientsTable->addForeignKeyConstraint(
             $this->getTable('user'),
             ['user_id'],
             ['id'],
-            ['onDelete' => 'CASCADE']
+            ['onDelete' => 'CASCADE'],
+            $this->constraintName
         );
     }
 
@@ -48,5 +49,19 @@ class Version20161024212538 extends AbstractMigration implements ContainerAwareI
      */
     public function down(Schema $schema)
     {
+        $clientsTable = $schema->getTable($this->getTable('oauth2_clients'));
+
+        $this->skipIf(!$clientsTable->hasColumn('user_id'), 'It seems that you already played this migration.');
+
+        $clientsTable->dropColumn('user_id', 'integer');
+
+        if ($this->connection->getDatabasePlatform()->getName() !== 'sqlite') {
+            $clientsTable->removeForeignKey($this->constraintName);
+        }
+    }
+
+    private function getTable($tableName)
+    {
+        return $this->container->getParameter('database_table_prefix') . $tableName;
     }
 }