X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;f=.github%2FCONTRIBUTING.md;h=b12e973617e963cd4e0c0069721e46b25707c974;hb=af75e2d8df92d5d602e11353536ec6804a25f16f;hp=d895304a410bd26d1ec6cb620520271c55c9a8c6;hpb=e730aef76abe02485f417ecef99da2c3b760edc4;p=github%2FChocobozzz%2FPeerTube.git diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index d895304a4..b12e97361 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -1,14 +1,15 @@ # Welcome to the contributing guide for PeerTube -Interesting in contributing? Awesome! +Interested in contributing? Awesome! -**Quick Links:** +**This guide will present you the following contribution topics:** * [Translate](#translate) * [Give your feedback](#give-your-feedback) * [Write documentation](#write-documentation) + * [Improve the website](#improve-the-website) * [Develop](#develop) - + * [Write a plugin or a theme](#plugins--themes) ## Translate @@ -28,13 +29,22 @@ interested in, user interface, design, decentralized architecture... You can help to write the documentation of the REST API, code, architecture, demonstrations. -For the REST API you can see the documentation in [/support/doc/api](/support/doc/api) directory. +For the REST API you can see the documentation in [/support/doc/api](https://github.com/Chocobozzz/PeerTube/tree/develop/support/doc/api) directory. Then, you can just open the `openapi.yaml` file in a special editor like [http://editor.swagger.io/](http://editor.swagger.io/) to easily see and edit the documentation. Some hints: - * Routes are defined in [/server/controllers/](/server/controllers/) directory - * Parameters validators are defined in [/server/middlewares/validators](/server/middlewares/validators) directory - * Models sent/received by the controllers are defined in [/shared/models](/shared/models) directory + * Routes are defined in [/server/controllers/](https://github.com/Chocobozzz/PeerTube/tree/develop/server/controllers) directory + * Parameters validators are defined in [/server/middlewares/validators](https://github.com/Chocobozzz/PeerTube/tree/develop/server/middlewares/validators) directory + * Models sent/received by the controllers are defined in [/shared/models](https://github.com/Chocobozzz/PeerTube/tree/develop/shared/models) directory + + +## Improve the website + +PeerTube's website is [joinpeertube.org](https://joinpeertube.org), where people can learn about the project and how it works – note that it is not a PeerTube instance, but rather the project's homepage. + +You can help us improve it too! + +It is not hosted on GitHub but on [Framasoft](https://framasoft.org/)'s own [GitLab](https://about.gitlab.com/) instance, [FramaGit](https://framagit.org): https://framagit.org/framasoft/peertube/joinpeertube ## Develop @@ -46,14 +56,16 @@ before you start working on them :). First, you should use a server or PC with at least 4GB of RAM. Less RAM may lead to crashes. -Make sure that you have followed -[the steps](/support/doc/dependencies.md) +Make sure that you have followed +[the steps](/support/doc/dependencies.md) to install the dependencies. -Then clone the sources and install node modules: +Fork the github repository, +and then clone the sources and install node modules: ``` $ git clone https://github.com/Chocobozzz/PeerTube +$ git remote add me git@github.com:YOUR_GITHUB_USERNAME/PeerTube.git $ cd PeerTube $ yarn install --pure-lockfile ``` @@ -62,6 +74,12 @@ Note that development is done on the `develop` branch. If you want to hack on Peertube, you should switch to that branch. Also note that you have to repeat the `yarn install --pure-lockfile` command. +When you create a new branch you should also tell to use your repo for upload +not default one. To do just do: +``` +$ git push --set-upstream me +``` + Then, create a postgres database and user with the values set in the `config/default.yaml` file. For instance, if you do not change the values there, the following commands would create a new database called `peertube_dev` @@ -82,9 +100,15 @@ $ sudo -u postgres psql -c "CREATE EXTENSION unaccent;" peertube_dev In dev mode, administrator username is **root** and password is **test**. +### Online development + +You can get a complete PeerTube development setup with Gitpod, a free one-click online IDE for GitHub: + +[![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/#https://github.com/Chocobozzz/PeerTube) + ### Server side -You can find a documentation of the server code/architecture [here](/support/doc/development/server/code.md). +You can find a documentation of the server code/architecture [here](https://docs.joinpeertube.org/#/contribute-architecture?id=server-code). To develop on the server-side: @@ -98,8 +122,8 @@ restart. ### Client side -You can find a documentation of the server code/architecture -[here](/support/doc/development/client/code.md). +You can find a documentation of the client code/architecture +[here](https://docs.joinpeertube.org/#/contribute-architecture?id=client-code). To develop on the client side: @@ -122,37 +146,7 @@ and the web server is automatically restarted. $ npm run dev ``` -Depending on your OS, you may face the following error : -``` -$ [nodemon] Internal watch failed: ENOSPC: no space left on device, watch '/PeerTube/dist' -``` - -This is due to your system's limit on the number of files you can monitor for live-checking changes. For example, Ubuntu uses inotify and this limit is set to 8192. Then you need to change this limit : -``` -echo fs.inotify.max_user_watches=524288 | sudo tee -a /etc/sysctl.conf && sudo sysctl -p -``` - -See more information here : https://github.com/guard/listen/wiki/Increasing-the-amount-of-inotify-watchers - -### Configurations for VPS - -If you want to develop using a Virtual Private Server, you will need to configure the url for the API and the hostname. First, you need to edit the [client/src/environments/environment.hmr.ts](client/src/environments/environment.hmr.ts) file by replacing the `localhost` in the `apiUrl` field with the address of your VPS. Thus, the [Hot Module Replacement](https://webpack.js.org/concepts/hot-module-replacement/) from Webpack will be set up for developping with live-reload. - -Next, you will need to edit the [config/default.yaml](config/default.yaml) file. Just replace the `localhost` with your VPS address in the following `hostname` fields : -``` -listen: - hostname: 'my-vps-address.net' - port: 9000 - -webserver: - https: false - hostname: 'my-vps-address.net' - port: 9000 -``` - -Then, you just need to listen to `https://my-vps-address.net:3000/` in your web browser. - -### Federation +### Testing the federation of PeerTube servers Create a PostgreSQL user **with the same name as your username** in order to avoid using the *postgres* user. Then, we can create the databases (if they don't already exist): @@ -165,7 +159,7 @@ $ createdb -O peertube peertube_test{1,2,3} Build the application and flush the old tests data: ``` -$ npm run build +$ npm run build -- --light $ npm run clean:server:test ``` @@ -188,21 +182,25 @@ Then, we can create the databases (if they don't already exist): ``` $ sudo -u postgres createuser you_username --createdb --superuser -$ createdb -O peertube peertube_test{1,2,3,4,5,6} +$ npm run clean:server:test ``` Build the application and run the unit/integration tests: ``` -$ npm run build +$ npm run build -- --light $ npm test ``` If you just want to run 1 test: ``` -$ npm run mocha -- --exit --require ts-node/register/type-check --bail server/tests/api/index.ts +$ npm run mocha -- --exit -r ts-node/register -r tsconfig-paths/register --bail server/tests/api/index.ts ``` Instance configurations are in `config/test-{1,2,3,4,5,6}.yaml`. Note that only instance 2 has transcoding enabled. + +## Plugins & Themes + +See the dedicated documentation: https://docs.joinpeertube.org/#/contribute-plugins