X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;ds=sidebyside;f=server%2Ftests%2Fclient.ts;h=a8a697f99bebbf91521d65e6731f8701f314ed84;hb=238b9677bb00c54a3a38a1812243910a2a8cb343;hp=d61724e5116f0b5d9081316b66375f10f96bf926;hpb=7cd1b12c19d0589d1d692ed0571ca0800f028aea;p=github%2FChocobozzz%2FPeerTube.git
diff --git a/server/tests/client.ts b/server/tests/client.ts
index d61724e51..a8a697f99 100644
--- a/server/tests/client.ts
+++ b/server/tests/client.ts
@@ -2,149 +2,547 @@
import 'mocha'
import * as chai from 'chai'
-import * as request from 'supertest'
+import { omit } from 'lodash'
+import {
+ Account,
+ HTMLServerConfig,
+ HttpStatusCode,
+ ServerConfig,
+ VideoPlaylistCreateResult,
+ VideoPlaylistPrivacy,
+ VideoPrivacy
+} from '@shared/models'
import {
cleanupTests,
- flushAndRunServer,
- getCustomConfig,
- getVideosList,
+ createMultipleServers,
+ doubleFollow,
+ makeGetRequest,
makeHTMLRequest,
- ServerInfo,
- serverLogin,
- updateCustomConfig,
- updateCustomSubConfig,
- uploadVideo
-} from '../../shared/extra-utils'
+ PeerTubeServer,
+ setAccessTokensToServers,
+ setDefaultVideoChannel,
+ waitJobs
+} from '../../shared/server-commands'
const expect = chai.expect
-function checkIndexTags (html: string, title: string, description: string, css: string) {
+function checkIndexTags (html: string, title: string, description: string, css: string, config: ServerConfig) {
expect(html).to.contain('
' + title + '')
expect(html).to.contain('')
expect(html).to.contain('')
+
+ const htmlConfig: HTMLServerConfig = omit(config, 'signup')
+ const configObjectString = JSON.stringify(htmlConfig)
+ const configEscapedString = JSON.stringify(configObjectString)
+
+ expect(html).to.contain(``)
}
describe('Test a client controllers', function () {
- let server: ServerInfo
+ let servers: PeerTubeServer[] = []
+ let account: Account
+
+ const videoName = 'my super name for server 1'
+ const videoDescription = 'my
super __description__ for *server* 1'
+ const videoDescriptionPlainText = 'my super description for server 1'
+
+ const playlistName = 'super playlist name'
+ const playlistDescription = 'super playlist description'
+ let playlist: VideoPlaylistCreateResult
+
+ const channelDescription = 'my super channel description'
+
+ const watchVideoBasePaths = [ '/videos/watch/', '/w/' ]
+ const watchPlaylistBasePaths = [ '/videos/watch/playlist/', '/w/p/' ]
+
+ let videoIds: (string | number)[] = []
+ let privateVideoId: string
+ let internalVideoId: string
+ let unlistedVideoId: string
+
+ let playlistIds: (string | number)[] = []
before(async function () {
this.timeout(120000)
- server = await flushAndRunServer(1)
- server.accessToken = await serverLogin(server)
+ servers = await createMultipleServers(2)
+
+ await setAccessTokensToServers(servers)
- const videoAttributes = {
- name: 'my super name for server 1',
- description: 'my super description for server 1'
+ await doubleFollow(servers[0], servers[1])
+
+ await setDefaultVideoChannel(servers)
+
+ await servers[0].channels.update({
+ channelName: servers[0].store.channel.name,
+ attributes: { description: channelDescription }
+ })
+
+ // Public video
+
+ {
+ const attributes = { name: videoName, description: videoDescription }
+ await servers[0].videos.upload({ attributes })
+
+ const { data } = await servers[0].videos.list()
+ expect(data.length).to.equal(1)
+
+ const video = data[0]
+ servers[0].store.video = video
+ videoIds = [ video.id, video.uuid, video.shortUUID ]
}
- await uploadVideo(server.url, server.accessToken, videoAttributes)
- const res = await getVideosList(server.url)
- const videos = res.body.data
+ {
+ ({ uuid: privateVideoId } = await servers[0].videos.quickUpload({ name: 'private', privacy: VideoPrivacy.PRIVATE }));
+ ({ uuid: unlistedVideoId } = await servers[0].videos.quickUpload({ name: 'unlisted', privacy: VideoPrivacy.UNLISTED }));
+ ({ uuid: internalVideoId } = await servers[0].videos.quickUpload({ name: 'internal', privacy: VideoPrivacy.INTERNAL }))
+ }
- expect(videos.length).to.equal(1)
+ // Playlist
- server.video = videos[0]
- })
+ {
+ const attributes = {
+ displayName: playlistName,
+ description: playlistDescription,
+ privacy: VideoPlaylistPrivacy.PUBLIC,
+ videoChannelId: servers[0].store.channel.id
+ }
- it('Should have valid Open Graph tags on the watch page with video id', async function () {
- const res = await request(server.url)
- .get('/videos/watch/' + server.video.id)
- .set('Accept', 'text/html')
- .expect(200)
+ playlist = await servers[0].playlists.create({ attributes })
+ playlistIds = [ playlist.id, playlist.shortUUID, playlist.uuid ]
- expect(res.text).to.contain('')
- expect(res.text).to.contain('')
- })
+ await servers[0].playlists.addElement({ playlistId: playlist.shortUUID, attributes: { videoId: servers[0].store.video.id } })
+ }
- it('Should have valid Open Graph tags on the watch page with video uuid', async function () {
- const res = await request(server.url)
- .get('/videos/watch/' + server.video.uuid)
- .set('Accept', 'text/html')
- .expect(200)
+ // Account
- expect(res.text).to.contain('')
- expect(res.text).to.contain('')
+ {
+ await servers[0].users.updateMe({ description: 'my account description' })
+
+ account = await servers[0].accounts.get({ accountName: `${servers[0].store.user.username}@${servers[0].host}` })
+ }
+
+ await waitJobs(servers)
})
- it('Should have valid oEmbed discovery tags', async function () {
- const path = '/videos/watch/' + server.video.uuid
- const res = await request(server.url)
- .get(path)
- .set('Accept', 'text/html')
- .expect(200)
+ describe('oEmbed', function () {
- const expectedLink = '`
+ it('Should have valid oEmbed discovery tags for videos', async function () {
+ for (const basePath of watchVideoBasePaths) {
+ for (const id of videoIds) {
+ const res = await makeGetRequest({
+ url: servers[0].url,
+ path: basePath + id,
+ accept: 'text/html',
+ expectedStatus: HttpStatusCode.OK_200
+ })
- expect(res.text).to.contain(expectedLink)
- })
+ const port = servers[0].port
+
+ const expectedLink = '`
+
+ expect(res.text).to.contain(expectedLink)
+ }
+ }
+ })
+
+ it('Should have valid oEmbed discovery tags for a playlist', async function () {
+ for (const basePath of watchPlaylistBasePaths) {
+ for (const id of playlistIds) {
+ const res = await makeGetRequest({
+ url: servers[0].url,
+ path: basePath + id,
+ accept: 'text/html',
+ expectedStatus: HttpStatusCode.OK_200
+ })
+
+ const port = servers[0].port
- it('Should have valid twitter card', async function () {
- const res = await request(server.url)
- .get('/videos/watch/' + server.video.uuid)
- .set('Accept', 'text/html')
- .expect(200)
+ const expectedLink = '`
- expect(res.text).to.contain('')
- expect(res.text).to.contain('')
+ expect(res.text).to.contain(expectedLink)
+ }
+ }
+ })
})
- it('Should have valid twitter card if Twitter is whitelisted', async function () {
- const res1 = await getCustomConfig(server.url, server.accessToken)
- const config = res1.body
- config.services.twitter = {
- username: '@Kuja',
- whitelisted: true
+ describe('Open Graph', function () {
+
+ async function accountPageTest (path: string) {
+ const res = await makeGetRequest({ url: servers[0].url, path, accept: 'text/html', expectedStatus: HttpStatusCode.OK_200 })
+ const text = res.text
+
+ expect(text).to.contain(``)
+ expect(text).to.contain(``)
+ expect(text).to.contain('')
+ expect(text).to.contain(``)
+ }
+
+ async function channelPageTest (path: string) {
+ const res = await makeGetRequest({ url: servers[0].url, path, accept: 'text/html', expectedStatus: HttpStatusCode.OK_200 })
+ const text = res.text
+
+ expect(text).to.contain(``)
+ expect(text).to.contain(``)
+ expect(text).to.contain('')
+ expect(text).to.contain(``)
+ }
+
+ async function watchVideoPageTest (path: string) {
+ const res = await makeGetRequest({ url: servers[0].url, path, accept: 'text/html', expectedStatus: HttpStatusCode.OK_200 })
+ const text = res.text
+
+ expect(text).to.contain(``)
+ expect(text).to.contain(``)
+ expect(text).to.contain('')
+ expect(text).to.contain(``)
+ }
+
+ async function watchPlaylistPageTest (path: string) {
+ const res = await makeGetRequest({ url: servers[0].url, path, accept: 'text/html', expectedStatus: HttpStatusCode.OK_200 })
+ const text = res.text
+
+ expect(text).to.contain(``)
+ expect(text).to.contain(``)
+ expect(text).to.contain('')
+ expect(text).to.contain(``)
}
- await updateCustomConfig(server.url, server.accessToken, config)
- const res = await request(server.url)
- .get('/videos/watch/' + server.video.uuid)
- .set('Accept', 'text/html')
- .expect(200)
+ it('Should have valid Open Graph tags on the account page', async function () {
+ await accountPageTest('/accounts/' + servers[0].store.user.username)
+ await accountPageTest('/a/' + servers[0].store.user.username)
+ await accountPageTest('/@' + servers[0].store.user.username)
+ })
- expect(res.text).to.contain('')
- expect(res.text).to.contain('')
+ it('Should have valid Open Graph tags on the channel page', async function () {
+ await channelPageTest('/video-channels/' + servers[0].store.channel.name)
+ await channelPageTest('/c/' + servers[0].store.channel.name)
+ await channelPageTest('/@' + servers[0].store.channel.name)
+ })
+
+ it('Should have valid Open Graph tags on the watch page', async function () {
+ for (const path of watchVideoBasePaths) {
+ for (const id of videoIds) {
+ await watchVideoPageTest(path + id)
+ }
+ }
+ })
+
+ it('Should have valid Open Graph tags on the watch playlist page', async function () {
+ for (const path of watchPlaylistBasePaths) {
+ for (const id of playlistIds) {
+ await watchPlaylistPageTest(path + id)
+ }
+ }
+ })
})
- it('Should have valid index html tags (title, description...)', async function () {
- const res = await makeHTMLRequest(server.url, '/videos/trending')
+ describe('Twitter card', async function () {
+
+ describe('Not whitelisted', function () {
+
+ async function accountPageTest (path: string) {
+ const res = await makeGetRequest({ url: servers[0].url, path, accept: 'text/html', expectedStatus: HttpStatusCode.OK_200 })
+ const text = res.text
+
+ expect(text).to.contain('')
+ expect(text).to.contain('')
+ expect(text).to.contain(``)
+ expect(text).to.contain(``)
+ }
+
+ async function channelPageTest (path: string) {
+ const res = await makeGetRequest({ url: servers[0].url, path, accept: 'text/html', expectedStatus: HttpStatusCode.OK_200 })
+ const text = res.text
+
+ expect(text).to.contain('')
+ expect(text).to.contain('')
+ expect(text).to.contain(``)
+ expect(text).to.contain(``)
+ }
+
+ async function watchVideoPageTest (path: string) {
+ const res = await makeGetRequest({ url: servers[0].url, path, accept: 'text/html', expectedStatus: HttpStatusCode.OK_200 })
+ const text = res.text
+
+ expect(text).to.contain('')
+ expect(text).to.contain('')
+ expect(text).to.contain(``)
+ expect(text).to.contain(``)
+ }
+
+ async function watchPlaylistPageTest (path: string) {
+ const res = await makeGetRequest({ url: servers[0].url, path, accept: 'text/html', expectedStatus: HttpStatusCode.OK_200 })
+ const text = res.text
+
+ expect(text).to.contain('')
+ expect(text).to.contain('')
+ expect(text).to.contain(``)
+ expect(text).to.contain(``)
+ }
+
+ it('Should have valid twitter card on the watch video page', async function () {
+ for (const path of watchVideoBasePaths) {
+ for (const id of videoIds) {
+ await watchVideoPageTest(path + id)
+ }
+ }
+ })
+
+ it('Should have valid twitter card on the watch playlist page', async function () {
+ for (const path of watchPlaylistBasePaths) {
+ for (const id of playlistIds) {
+ await watchPlaylistPageTest(path + id)
+ }
+ }
+ })
+
+ it('Should have valid twitter card on the account page', async function () {
+ await accountPageTest('/accounts/' + account.name)
+ await accountPageTest('/a/' + account.name)
+ await accountPageTest('/@' + account.name)
+ })
+
+ it('Should have valid twitter card on the channel page', async function () {
+ await channelPageTest('/video-channels/' + servers[0].store.channel.name)
+ await channelPageTest('/c/' + servers[0].store.channel.name)
+ await channelPageTest('/@' + servers[0].store.channel.name)
+ })
+ })
+
+ describe('Whitelisted', function () {
- const description = 'PeerTube, a federated (ActivityPub) video streaming platform using P2P (BitTorrent) directly in the web browser ' +
- 'with WebTorrent and Angular.'
- checkIndexTags(res.text, 'PeerTube', description, '')
+ before(async function () {
+ const config = await servers[0].config.getCustomConfig()
+ config.services.twitter = {
+ username: '@Kuja',
+ whitelisted: true
+ }
+
+ await servers[0].config.updateCustomConfig({ newCustomConfig: config })
+ })
+
+ async function accountPageTest (path: string) {
+ const res = await makeGetRequest({ url: servers[0].url, path, accept: 'text/html', expectedStatus: HttpStatusCode.OK_200 })
+ const text = res.text
+
+ expect(text).to.contain('')
+ expect(text).to.contain('')
+ }
+
+ async function channelPageTest (path: string) {
+ const res = await makeGetRequest({ url: servers[0].url, path, accept: 'text/html', expectedStatus: HttpStatusCode.OK_200 })
+ const text = res.text
+
+ expect(text).to.contain('')
+ expect(text).to.contain('')
+ }
+
+ async function watchVideoPageTest (path: string) {
+ const res = await makeGetRequest({ url: servers[0].url, path, accept: 'text/html', expectedStatus: HttpStatusCode.OK_200 })
+ const text = res.text
+
+ expect(text).to.contain('')
+ expect(text).to.contain('')
+ }
+
+ async function watchPlaylistPageTest (path: string) {
+ const res = await makeGetRequest({ url: servers[0].url, path, accept: 'text/html', expectedStatus: HttpStatusCode.OK_200 })
+ const text = res.text
+
+ expect(text).to.contain('')
+ expect(text).to.contain('')
+ }
+
+ it('Should have valid twitter card on the watch video page', async function () {
+ for (const path of watchVideoBasePaths) {
+ for (const id of videoIds) {
+ await watchVideoPageTest(path + id)
+ }
+ }
+ })
+
+ it('Should have valid twitter card on the watch playlist page', async function () {
+ for (const path of watchPlaylistBasePaths) {
+ for (const id of playlistIds) {
+ await watchPlaylistPageTest(path + id)
+ }
+ }
+ })
+
+ it('Should have valid twitter card on the account page', async function () {
+ await accountPageTest('/accounts/' + account.name)
+ await accountPageTest('/a/' + account.name)
+ await accountPageTest('/@' + account.name)
+ })
+
+ it('Should have valid twitter card on the channel page', async function () {
+ await channelPageTest('/video-channels/' + servers[0].store.channel.name)
+ await channelPageTest('/c/' + servers[0].store.channel.name)
+ await channelPageTest('/@' + servers[0].store.channel.name)
+ })
+ })
})
- it('Should update the customized configuration and have the correct index html tags', async function () {
- await updateCustomSubConfig(server.url, server.accessToken, {
- instance: {
- name: 'PeerTube updated',
- shortDescription: 'my short description',
- description: 'my super description',
- terms: 'my super terms',
- defaultClientRoute: '/videos/recently-added',
- defaultNSFWPolicy: 'blur',
- customizations: {
- javascript: 'alert("coucou")',
- css: 'body { background-color: red; }'
+ describe('Index HTML', function () {
+
+ it('Should have valid index html tags (title, description...)', async function () {
+ const config = await servers[0].config.getConfig()
+ const res = await makeHTMLRequest(servers[0].url, '/videos/trending')
+
+ const description = 'PeerTube, an ActivityPub-federated video streaming platform using P2P directly in your web browser.'
+ checkIndexTags(res.text, 'PeerTube', description, '', config)
+ })
+
+ it('Should update the customized configuration and have the correct index html tags', async function () {
+ await servers[0].config.updateCustomSubConfig({
+ newConfig: {
+ instance: {
+ name: 'PeerTube updated',
+ shortDescription: 'my short description',
+ description: 'my super description',
+ terms: 'my super terms',
+ defaultNSFWPolicy: 'blur',
+ defaultClientRoute: '/videos/recently-added',
+ customizations: {
+ javascript: 'alert("coucou")',
+ css: 'body { background-color: red; }'
+ }
+ }
+ }
+ })
+
+ const config = await servers[0].config.getConfig()
+ const res = await makeHTMLRequest(servers[0].url, '/videos/trending')
+
+ checkIndexTags(res.text, 'PeerTube updated', 'my short description', 'body { background-color: red; }', config)
+ })
+
+ it('Should have valid index html updated tags (title, description...)', async function () {
+ const config = await servers[0].config.getConfig()
+ const res = await makeHTMLRequest(servers[0].url, '/videos/trending')
+
+ checkIndexTags(res.text, 'PeerTube updated', 'my short description', 'body { background-color: red; }', config)
+ })
+
+ it('Should use the original video URL for the canonical tag', async function () {
+ for (const basePath of watchVideoBasePaths) {
+ for (const id of videoIds) {
+ const res = await makeHTMLRequest(servers[1].url, basePath + id)
+ expect(res.text).to.contain(``)
+ }
+ }
+ })
+
+ it('Should use the original account URL for the canonical tag', async function () {
+ const accountURLtest = res => {
+ expect(res.text).to.contain(``)
+ }
+
+ accountURLtest(await makeHTMLRequest(servers[1].url, '/accounts/root@' + servers[0].host))
+ accountURLtest(await makeHTMLRequest(servers[1].url, '/a/root@' + servers[0].host))
+ accountURLtest(await makeHTMLRequest(servers[1].url, '/@root@' + servers[0].host))
+ })
+
+ it('Should use the original channel URL for the canonical tag', async function () {
+ const channelURLtests = res => {
+ expect(res.text).to.contain(``)
+ }
+
+ channelURLtests(await makeHTMLRequest(servers[1].url, '/video-channels/root_channel@' + servers[0].host))
+ channelURLtests(await makeHTMLRequest(servers[1].url, '/c/root_channel@' + servers[0].host))
+ channelURLtests(await makeHTMLRequest(servers[1].url, '/@root_channel@' + servers[0].host))
+ })
+
+ it('Should use the original playlist URL for the canonical tag', async function () {
+ for (const basePath of watchPlaylistBasePaths) {
+ for (const id of playlistIds) {
+ const res = await makeHTMLRequest(servers[1].url, basePath + id)
+ expect(res.text).to.contain(``)
+ }
+ }
+ })
+
+ it('Should add noindex meta tag for remote accounts', async function () {
+ const handle = 'root@' + servers[0].host
+ const paths = [ '/accounts/', '/a/', '/@' ]
+
+ for (const path of paths) {
+ {
+ const { text } = await makeHTMLRequest(servers[1].url, path + handle)
+ expect(text).to.contain('')
+ }
+
+ {
+ const { text } = await makeHTMLRequest(servers[0].url, path + handle)
+ expect(text).to.not.contain('')
+ }
+ }
+ })
+
+ it('Should add noindex meta tag for remote channels', async function () {
+ const handle = 'root_channel@' + servers[0].host
+ const paths = [ '/video-channels/', '/c/', '/@' ]
+
+ for (const path of paths) {
+ {
+ const { text } = await makeHTMLRequest(servers[1].url, path + handle)
+ expect(text).to.contain('')
+ }
+
+ {
+ const { text } = await makeHTMLRequest(servers[0].url, path + handle)
+ expect(text).to.not.contain('')
}
}
})
- const res = await makeHTMLRequest(server.url, '/videos/trending')
+ it('Should not display internal/private video', async function () {
+ for (const basePath of watchVideoBasePaths) {
+ for (const id of [ privateVideoId, internalVideoId ]) {
+ const res = await makeGetRequest({
+ url: servers[0].url,
+ path: basePath + id,
+ accept: 'text/html',
+ expectedStatus: HttpStatusCode.NOT_FOUND_404
+ })
- checkIndexTags(res.text, 'PeerTube updated', 'my short description', 'body { background-color: red; }')
+ expect(res.text).to.not.contain('internal')
+ expect(res.text).to.not.contain('private')
+ }
+ }
+ })
+
+ it('Should add noindex meta tag for unlisted video', async function () {
+ for (const basePath of watchVideoBasePaths) {
+ const res = await makeGetRequest({
+ url: servers[0].url,
+ path: basePath + unlistedVideoId,
+ accept: 'text/html',
+ expectedStatus: HttpStatusCode.OK_200
+ })
+
+ expect(res.text).to.contain('unlisted')
+ expect(res.text).to.contain('')
+ }
+ })
})
- it('Should have valid index html updated tags (title, description...)', async function () {
- const res = await makeHTMLRequest(server.url, '/videos/trending')
+ describe('Embed HTML', function () {
- checkIndexTags(res.text, 'PeerTube updated', 'my short description', 'body { background-color: red; }')
+ it('Should have the correct embed html tags', async function () {
+ const config = await servers[0].config.getConfig()
+ const res = await makeHTMLRequest(servers[0].url, servers[0].store.video.embedPath)
+
+ checkIndexTags(res.text, 'PeerTube updated', 'my short description', 'body { background-color: red; }', config)
+ })
})
after(async function () {
- await cleanupTests([ server ])
+ await cleanupTests(servers)
})
})