X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;ds=sidebyside;f=server%2Ftests%2Fapi%2Fcheck-params%2Fvideo-channels.ts;h=337ea1dd46a66f89e320467fe8a3a7ab04d14af0;hb=2a491182e483b97afb1b65c908b23cb48d591807;hp=08d1af52e57ac581b291ad92ad4a3878dcf37fc1;hpb=a265f7f30fe5f25e742c99c6d43e79dfd46bf2a9;p=github%2FChocobozzz%2FPeerTube.git diff --git a/server/tests/api/check-params/video-channels.ts b/server/tests/api/check-params/video-channels.ts index 08d1af52e..337ea1dd4 100644 --- a/server/tests/api/check-params/video-channels.ts +++ b/server/tests/api/check-params/video-channels.ts @@ -1,315 +1,491 @@ -/* tslint:disable:no-unused-expression */ +/* eslint-disable @typescript-eslint/no-unused-expressions,@typescript-eslint/require-await */ -import * as request from 'supertest' import 'mocha' import * as chai from 'chai' -const expect = chai.expect - +import { omit } from 'lodash' +import { checkBadCountPagination, checkBadSortPagination, checkBadStartPagination, FIXTURE_URLS } from '@server/tests/shared' +import { areHttpImportTestsDisabled, buildAbsoluteFixturePath } from '@shared/core-utils' +import { HttpStatusCode, VideoChannelUpdate } from '@shared/models' import { - ServerInfo, - flushTests, - runServer, - makePutBodyRequest, - setAccessTokensToServers, - killallServers, - getMyUserInformation, + ChannelsCommand, + cleanupTests, + createSingleServer, + makeGetRequest, makePostBodyRequest, - getVideoChannelsList, - createUser, - getUserAccessToken -} from '../../utils' + makePutBodyRequest, + makeUploadRequest, + PeerTubeServer, + setAccessTokensToServers +} from '@shared/server-commands' -describe('Test videos API validator', function () { - const path = '/api/v1/videos/channels' - let server: ServerInfo - let channelId: number - let accessTokenUser: string +const expect = chai.expect + +describe('Test video channels API validator', function () { + const videoChannelPath = '/api/v1/video-channels' + let server: PeerTubeServer + const userInfo = { + accessToken: '', + channelName: 'fake_channel', + id: -1, + videoQuota: -1, + videoQuotaDaily: -1 + } + let command: ChannelsCommand // --------------------------------------------------------------- before(async function () { - this.timeout(20000) - - await flushTests() + this.timeout(30000) - server = await runServer(1) + server = await createSingleServer(1) await setAccessTokensToServers([ server ]) - const res = await getMyUserInformation(server.url, server.accessToken) - channelId = res.body.videoChannels[0].id - - const user = { + const userCreds = { username: 'fake', password: 'fake_password' } - await createUser(server.url, server.accessToken, user.username, user.password) - accessTokenUser = await getUserAccessToken(server, user) + { + const user = await server.users.create({ username: userCreds.username, password: userCreds.password }) + userInfo.id = user.id + userInfo.accessToken = await server.login.getAccessToken(userCreds) + } + + command = server.channels }) describe('When listing a video channels', function () { it('Should fail with a bad start pagination', async function () { - await request(server.url) - .get(path) - .query({ start: 'hello' }) - .set('Accept', 'application/json') - .expect(400) + await checkBadStartPagination(server.url, videoChannelPath, server.accessToken) }) it('Should fail with a bad count pagination', async function () { - await request(server.url) - .get(path) - .query({ count: 'hello' }) - .set('Accept', 'application/json') - .expect(400) + await checkBadCountPagination(server.url, videoChannelPath, server.accessToken) }) it('Should fail with an incorrect sort', async function () { - await request(server.url) - .get(path) - .query({ sort: 'hello' }) - .set('Accept', 'application/json') - .expect(400) + await checkBadSortPagination(server.url, videoChannelPath, server.accessToken) }) }) - describe('When listing author video channels', function () { - it('Should fail with bad author', async function () { - const path = '/api/v1/videos/authors/hello/channels' + describe('When listing account video channels', function () { + const accountChannelPath = '/api/v1/accounts/fake/video-channels' - await request(server.url) - .get(path) - .set('Accept', 'application/json') - .expect(400) + it('Should fail with a bad start pagination', async function () { + await checkBadStartPagination(server.url, accountChannelPath, server.accessToken) + }) + + it('Should fail with a bad count pagination', async function () { + await checkBadCountPagination(server.url, accountChannelPath, server.accessToken) }) - it('Should fail with a unknown author', async function () { - const path = '/api/v1/videos/authors/156/channels' + it('Should fail with an incorrect sort', async function () { + await checkBadSortPagination(server.url, accountChannelPath, server.accessToken) + }) + + it('Should fail with a unknown account', async function () { + await server.channels.listByAccount({ accountName: 'unknown', expectedStatus: HttpStatusCode.NOT_FOUND_404 }) + }) - await request(server.url) - .get(path) - .set('Accept', 'application/json') - .expect(404) + it('Should succeed with the correct parameters', async function () { + await makeGetRequest({ + url: server.url, + path: accountChannelPath, + expectedStatus: HttpStatusCode.OK_200 + }) }) }) describe('When adding a video channel', function () { + const baseCorrectParams = { + name: 'super_channel', + displayName: 'hello', + description: 'super description', + support: 'super support text' + } it('Should fail with a non authenticated user', async function () { - const fields = { - name: 'hello', - description: 'super description' - } - await makePostBodyRequest({ url: server.url, path, token: 'none', fields, statusCodeExpected: 401 }) + await makePostBodyRequest({ + url: server.url, + path: videoChannelPath, + token: 'none', + fields: baseCorrectParams, + expectedStatus: HttpStatusCode.UNAUTHORIZED_401 + }) }) it('Should fail with nothing', async function () { const fields = {} - await makePostBodyRequest({ url: server.url, path, token: server.accessToken, fields }) + await makePostBodyRequest({ url: server.url, path: videoChannelPath, token: server.accessToken, fields }) }) - it('Should fail without name', async function () { - const fields = { - description: 'super description' - } - await makePostBodyRequest({ url: server.url, path, token: server.accessToken, fields }) + it('Should fail without a name', async function () { + const fields = omit(baseCorrectParams, 'name') + await makePostBodyRequest({ url: server.url, path: videoChannelPath, token: server.accessToken, fields }) + }) + + it('Should fail with a bad name', async function () { + const fields = { ...baseCorrectParams, name: 'super name' } + await makePostBodyRequest({ url: server.url, path: videoChannelPath, token: server.accessToken, fields }) + }) + + it('Should fail without a name', async function () { + const fields = omit(baseCorrectParams, 'displayName') + await makePostBodyRequest({ url: server.url, path: videoChannelPath, token: server.accessToken, fields }) }) it('Should fail with a long name', async function () { - const fields = { - name: 'hello tooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo' + - 'oooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo' + - 'oooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo' + - 'oooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo' + - 'oooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo long', - description: 'super description' - } - await makePostBodyRequest({ url: server.url, path, token: server.accessToken, fields }) + const fields = { ...baseCorrectParams, displayName: 'super'.repeat(25) } + await makePostBodyRequest({ url: server.url, path: videoChannelPath, token: server.accessToken, fields }) }) it('Should fail with a long description', async function () { - const fields = { - name: 'hello', - description: 'super toooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo' + - 'oooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo0' + - 'ooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo' + - 'oooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo long description' - } - await makePostBodyRequest({ url: server.url, path, token: server.accessToken, fields }) + const fields = { ...baseCorrectParams, description: 'super'.repeat(201) } + await makePostBodyRequest({ url: server.url, path: videoChannelPath, token: server.accessToken, fields }) + }) + + it('Should fail with a long support text', async function () { + const fields = { ...baseCorrectParams, support: 'super'.repeat(201) } + await makePostBodyRequest({ url: server.url, path: videoChannelPath, token: server.accessToken, fields }) }) it('Should succeed with the correct parameters', async function () { - const fields = { - name: 'hello', - description: 'super description' - } - await makePostBodyRequest({ url: server.url, path, token: server.accessToken, fields, statusCodeExpected: 204 }) + await makePostBodyRequest({ + url: server.url, + path: videoChannelPath, + token: server.accessToken, + fields: baseCorrectParams, + expectedStatus: HttpStatusCode.OK_200 + }) + }) + + it('Should fail when adding a channel with the same username', async function () { + await makePostBodyRequest({ + url: server.url, + path: videoChannelPath, + token: server.accessToken, + fields: baseCorrectParams, + expectedStatus: HttpStatusCode.CONFLICT_409 + }) }) }) describe('When updating a video channel', function () { - let videoChannelId + const baseCorrectParams: VideoChannelUpdate = { + displayName: 'hello', + description: 'super description', + support: 'toto', + bulkVideosSupportUpdate: false + } + let path: string before(async function () { - const res = await getVideoChannelsList(server.url, 0, 1) - videoChannelId = res.body.data[0].id + path = videoChannelPath + '/super_channel' }) it('Should fail with a non authenticated user', async function () { - const fields = { - name: 'hello', - description: 'super description' - } - await makePutBodyRequest({ url: server.url, path: path + '/' + videoChannelId, token: 'hi', fields, statusCodeExpected: 401 }) + await makePutBodyRequest({ + url: server.url, + path, + token: 'hi', + fields: baseCorrectParams, + expectedStatus: HttpStatusCode.UNAUTHORIZED_401 + }) }) it('Should fail with another authenticated user', async function () { - const fields = { - name: 'hello', - description: 'super description' - } await makePutBodyRequest({ url: server.url, - path: path + '/' + videoChannelId, - token: accessTokenUser, - fields, - statusCodeExpected: 403 + path, + token: userInfo.accessToken, + fields: baseCorrectParams, + expectedStatus: HttpStatusCode.FORBIDDEN_403 }) }) it('Should fail with a long name', async function () { - const fields = { - name: 'hello tooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo' + - 'oooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo' + - 'oooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo' + - 'oooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo' + - 'oooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo long', - description: 'super description' - } - await makePutBodyRequest({ url: server.url, path: path + '/' + videoChannelId, token: server.accessToken, fields }) + const fields = { ...baseCorrectParams, displayName: 'super'.repeat(25) } + await makePutBodyRequest({ url: server.url, path, token: server.accessToken, fields }) }) it('Should fail with a long description', async function () { - const fields = { - name: 'hello', - description: 'super toooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo' + - 'oooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo0' + - 'ooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo' + - 'oooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo long description' - } - await makePutBodyRequest({ url: server.url, path: path + '/' + videoChannelId, token: server.accessToken, fields }) + const fields = { ...baseCorrectParams, description: 'super'.repeat(201) } + await makePutBodyRequest({ url: server.url, path, token: server.accessToken, fields }) + }) + + it('Should fail with a long support text', async function () { + const fields = { ...baseCorrectParams, support: 'super'.repeat(201) } + await makePutBodyRequest({ url: server.url, path, token: server.accessToken, fields }) + }) + + it('Should fail with a bad bulkVideosSupportUpdate field', async function () { + const fields = { ...baseCorrectParams, bulkVideosSupportUpdate: 'super' } + await makePutBodyRequest({ url: server.url, path, token: server.accessToken, fields }) }) it('Should succeed with the correct parameters', async function () { - const fields = { - name: 'hello 2', - description: 'super description 2' - } await makePutBodyRequest({ url: server.url, - path: path + '/' + videoChannelId, + path, token: server.accessToken, - fields, - statusCodeExpected: 204 + fields: baseCorrectParams, + expectedStatus: HttpStatusCode.NO_CONTENT_204 }) }) }) - describe('When getting a video channel', function () { - let videoChannelId: number + describe('When updating video channel avatars/banners', function () { + const types = [ 'avatar', 'banner' ] + let path: string before(async function () { - const res = await getVideoChannelsList(server.url, 0, 1) - videoChannelId = res.body.data[0].id + path = videoChannelPath + '/super_channel' }) - it('Should return the list of the video channels with nothing', async function () { - const res = await request(server.url) - .get(path) - .set('Accept', 'application/json') - .expect(200) - .expect('Content-Type', /json/) + it('Should fail with an incorrect input file', async function () { + for (const type of types) { + const fields = {} + const attaches = { + [type + 'file']: buildAbsoluteFixturePath('video_short.mp4') + } - expect(res.body.data).to.be.an('array') + await makeUploadRequest({ url: server.url, path: `${path}/${type}/pick`, token: server.accessToken, fields, attaches }) + } + }) + + it('Should fail with a big file', async function () { + for (const type of types) { + const fields = {} + const attaches = { + [type + 'file']: buildAbsoluteFixturePath('avatar-big.png') + } + await makeUploadRequest({ url: server.url, path: `${path}/${type}/pick`, token: server.accessToken, fields, attaches }) + } }) - it('Should fail without a correct uuid', async function () { - await request(server.url) - .get(path + '/coucou') - .set('Accept', 'application/json') - .expect(400) + it('Should fail with an unauthenticated user', async function () { + for (const type of types) { + const fields = {} + const attaches = { + [type + 'file']: buildAbsoluteFixturePath('avatar.png') + } + await makeUploadRequest({ + url: server.url, + path: `${path}/${type}/pick`, + fields, + attaches, + expectedStatus: HttpStatusCode.UNAUTHORIZED_401 + }) + } + }) + + it('Should succeed with the correct params', async function () { + for (const type of types) { + const fields = {} + const attaches = { + [type + 'file']: buildAbsoluteFixturePath('avatar.png') + } + await makeUploadRequest({ + url: server.url, + path: `${path}/${type}/pick`, + token: server.accessToken, + fields, + attaches, + expectedStatus: HttpStatusCode.OK_200 + }) + } + }) + }) + + describe('When getting a video channel', function () { + it('Should return the list of the video channels with nothing', async function () { + const res = await makeGetRequest({ + url: server.url, + path: videoChannelPath, + expectedStatus: HttpStatusCode.OK_200 + }) + + expect(res.body.data).to.be.an('array') }) it('Should return 404 with an incorrect video channel', async function () { - await request(server.url) - .get(path + '/4da6fde3-88f7-4d16-b119-108df5630b06') - .set('Accept', 'application/json') - .expect(404) + await makeGetRequest({ + url: server.url, + path: videoChannelPath + '/super_channel2', + expectedStatus: HttpStatusCode.NOT_FOUND_404 + }) }) it('Should succeed with the correct parameters', async function () { - await request(server.url) - .get(path + '/' + videoChannelId) - .set('Accept', 'application/json') - .expect(200) + await makeGetRequest({ + url: server.url, + path: videoChannelPath + '/super_channel', + expectedStatus: HttpStatusCode.OK_200 + }) }) }) - describe('When deleting a video channel', function () { - let videoChannelId: number + describe('When getting channel followers', function () { + const path = '/api/v1/video-channels/super_channel/followers' - before(async function () { - const res = await getVideoChannelsList(server.url, 0, 1) - videoChannelId = res.body.data[0].id + it('Should fail with a bad start pagination', async function () { + await checkBadStartPagination(server.url, path, server.accessToken) + }) + + it('Should fail with a bad count pagination', async function () { + await checkBadCountPagination(server.url, path, server.accessToken) + }) + + it('Should fail with an incorrect sort', async function () { + await checkBadSortPagination(server.url, path, server.accessToken) + }) + + it('Should fail with a unauthenticated user', async function () { + await makeGetRequest({ url: server.url, path, expectedStatus: HttpStatusCode.UNAUTHORIZED_401 }) + }) + + it('Should fail with a another user', async function () { + await makeGetRequest({ url: server.url, path, token: userInfo.accessToken, expectedStatus: HttpStatusCode.FORBIDDEN_403 }) + }) + + it('Should succeed with the correct params', async function () { + await makeGetRequest({ url: server.url, path, token: server.accessToken, expectedStatus: HttpStatusCode.OK_200 }) + }) + }) + + describe('When triggering full synchronization', function () { + + it('Should fail when HTTP upload is disabled', async function () { + await server.config.disableImports() + + await command.importVideos({ + channelName: 'super_channel', + externalChannelUrl: FIXTURE_URLS.youtubeChannel, + token: server.accessToken, + expectedStatus: HttpStatusCode.FORBIDDEN_403 + }) + + await server.config.enableImports() + }) + + it('Should fail when externalChannelUrl is not provided', async function () { + await command.importVideos({ + channelName: 'super_channel', + externalChannelUrl: null, + token: server.accessToken, + expectedStatus: HttpStatusCode.BAD_REQUEST_400 + }) + }) + + it('Should fail when externalChannelUrl is malformed', async function () { + await command.importVideos({ + channelName: 'super_channel', + externalChannelUrl: 'not-a-url', + token: server.accessToken, + expectedStatus: HttpStatusCode.BAD_REQUEST_400 + }) + }) + + it('Should fail with no authentication', async function () { + await command.importVideos({ + channelName: 'super_channel', + externalChannelUrl: FIXTURE_URLS.youtubeChannel, + token: null, + expectedStatus: HttpStatusCode.UNAUTHORIZED_401 + }) + }) + + it('Should fail when sync is not owned by the user', async function () { + await command.importVideos({ + channelName: 'super_channel', + externalChannelUrl: FIXTURE_URLS.youtubeChannel, + token: userInfo.accessToken, + expectedStatus: HttpStatusCode.FORBIDDEN_403 + }) + }) + + it('Should fail when the user has no quota', async function () { + await server.users.update({ + userId: userInfo.id, + videoQuota: 0 + }) + + await command.importVideos({ + channelName: 'fake_channel', + externalChannelUrl: FIXTURE_URLS.youtubeChannel, + token: userInfo.accessToken, + expectedStatus: HttpStatusCode.PAYLOAD_TOO_LARGE_413 + }) + + await server.users.update({ + userId: userInfo.id, + videoQuota: userInfo.videoQuota + }) + }) + + it('Should fail when the user has no daily quota', async function () { + await server.users.update({ + userId: userInfo.id, + videoQuotaDaily: 0 + }) + + await command.importVideos({ + channelName: 'fake_channel', + externalChannelUrl: FIXTURE_URLS.youtubeChannel, + token: userInfo.accessToken, + expectedStatus: HttpStatusCode.PAYLOAD_TOO_LARGE_413 + }) + + await server.users.update({ + userId: userInfo.id, + videoQuotaDaily: userInfo.videoQuotaDaily + }) + }) + + it('Should succeed when sync is run by its owner', async function () { + if (!areHttpImportTestsDisabled()) return + + await command.importVideos({ + channelName: 'fake_channel', + externalChannelUrl: FIXTURE_URLS.youtubeChannel, + token: userInfo.accessToken + }) }) + it('Should succeed when sync is run with root and for another user\'s channel', async function () { + if (!areHttpImportTestsDisabled()) return + + await command.importVideos({ + channelName: 'fake_channel', + externalChannelUrl: FIXTURE_URLS.youtubeChannel + }) + }) + }) + + describe('When deleting a video channel', function () { it('Should fail with a non authenticated user', async function () { - await request(server.url) - .delete(path + '/' + videoChannelId) - .set('Authorization', 'Bearer coucou') - .expect(401) + await command.delete({ token: 'coucou', channelName: 'super_channel', expectedStatus: HttpStatusCode.UNAUTHORIZED_401 }) }) it('Should fail with another authenticated user', async function () { - await request(server.url) - .delete(path + '/' + videoChannelId) - .set('Authorization', 'Bearer ' + accessTokenUser) - .expect(403) + await command.delete({ token: userInfo.accessToken, channelName: 'super_channel', expectedStatus: HttpStatusCode.FORBIDDEN_403 }) }) - it('Should fail with an unknown id', async function () { - await request(server.url) - .delete(path + '/454554') - .set('Authorization', 'Bearer ' + server.accessToken) - .expect(404) + it('Should fail with an unknown video channel id', async function () { + await command.delete({ channelName: 'super_channel2', expectedStatus: HttpStatusCode.NOT_FOUND_404 }) }) it('Should succeed with the correct parameters', async function () { - await request(server.url) - .delete(path + '/' + videoChannelId) - .set('Authorization', 'Bearer ' + server.accessToken) - .expect(204) + await command.delete({ channelName: 'super_channel' }) }) it('Should fail to delete the last user video channel', async function () { - const res = await getVideoChannelsList(server.url, 0, 1) - videoChannelId = res.body.data[0].id - - await request(server.url) - .delete(path + '/' + videoChannelId) - .set('Authorization', 'Bearer ' + server.accessToken) - .expect(409 - ) + await command.delete({ channelName: 'root_channel', expectedStatus: HttpStatusCode.CONFLICT_409 }) }) }) after(async function () { - killallServers([ server ]) - - // Keep the logs if the test failed - if (this['ok']) { - await flushTests() - } + await cleanupTests([ server ]) }) })