X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;ds=sidebyside;f=server%2Fmiddlewares%2Fvalidators%2Fvideos.ts;h=ee2ac50c8931840d923447a37181966ab810af8b;hb=f3aaa9a95cc2b61f1f255472d7014d08faa66561;hp=47825975c002798c65722ef65035ca9f3a2fff86;hpb=e02643f32e4c97ca307f8fc5b69be79c40d70a3b;p=github%2FChocobozzz%2FPeerTube.git diff --git a/server/middlewares/validators/videos.ts b/server/middlewares/validators/videos.ts index 47825975c..ee2ac50c8 100644 --- a/server/middlewares/validators/videos.ts +++ b/server/middlewares/validators/videos.ts @@ -1,136 +1,236 @@ +import * as express from 'express' +import { body, param, query } from 'express-validator/check' +import { UserRight, VideoPrivacy } from '../../../shared' +import { isIdOrUUIDValid, isIdValid } from '../../helpers/custom-validators/misc' +import { + isVideoAbuseReasonValid, + isVideoCategoryValid, + isVideoDescriptionValid, + isVideoExist, + isVideoFile, + isVideoLanguageValid, + isVideoLicenceValid, + isVideoNameValid, + isVideoNSFWValid, + isVideoPrivacyValid, + isVideoRatingTypeValid, + isVideoTagsValid +} from '../../helpers/custom-validators/videos' +import { getDurationFromVideoFile } from '../../helpers/ffmpeg-utils' +import { logger } from '../../helpers/logger' +import { CONSTRAINTS_FIELDS } from '../../initializers' import { database as db } from '../../initializers/database' -import { checkErrors } from './utils' -import { CONSTRAINTS_FIELDS, SEARCHABLE_COLUMNS } from '../../initializers' -import { logger, isVideoDurationValid } from '../../helpers' - -function videosAddValidator (req, res, next) { - req.checkBody('videofile', 'Should have a valid file').isVideoFile(req.files) - req.checkBody('name', 'Should have a valid name').isVideoNameValid() - req.checkBody('category', 'Should have a valid category').isVideoCategoryValid() - req.checkBody('licence', 'Should have a valid licence').isVideoLicenceValid() - req.checkBody('language', 'Should have a valid language').optional().isVideoLanguageValid() - req.checkBody('nsfw', 'Should have a valid NSFW attribute').isVideoNSFWValid() - req.checkBody('description', 'Should have a valid description').isVideoDescriptionValid() - req.checkBody('tags', 'Should have correct tags').optional().isVideoTagsValid() - - logger.debug('Checking videosAdd parameters', { parameters: req.body, files: req.files }) - - checkErrors(req, res, function () { - const videoFile = req.files.videofile[0] - - db.Video.getDurationFromFile(videoFile.path, function (err, duration) { - if (err) { - return res.status(400).send('Cannot retrieve metadata of the file.') - } +import { UserInstance } from '../../models/account/user-interface' +import { VideoInstance } from '../../models/video/video-interface' +import { authenticate } from '../oauth' +import { areValidationErrors } from './utils' + +const videosAddValidator = [ + body('videofile').custom((value, { req }) => isVideoFile(req.files)).withMessage( + 'This file is not supported. Please, make sure it is of the following type : ' + + CONSTRAINTS_FIELDS.VIDEOS.EXTNAME.join(', ') + ), + body('name').custom(isVideoNameValid).withMessage('Should have a valid name'), + body('category').custom(isVideoCategoryValid).withMessage('Should have a valid category'), + body('licence').custom(isVideoLicenceValid).withMessage('Should have a valid licence'), + body('language').optional().custom(isVideoLanguageValid).withMessage('Should have a valid language'), + body('nsfw').custom(isVideoNSFWValid).withMessage('Should have a valid NSFW attribute'), + body('description').custom(isVideoDescriptionValid).withMessage('Should have a valid description'), + body('channelId').custom(isIdValid).withMessage('Should have correct video channel id'), + body('privacy').custom(isVideoPrivacyValid).withMessage('Should have correct video privacy'), + body('tags').optional().custom(isVideoTagsValid).withMessage('Should have correct tags'), + + async (req: express.Request, res: express.Response, next: express.NextFunction) => { + logger.debug('Checking videosAdd parameters', { parameters: req.body, files: req.files }) + + if (areValidationErrors(req, res)) return + + const videoFile: Express.Multer.File = req.files['videofile'][0] + const user = res.locals.oauth.token.User + + const videoChannel = await db.VideoChannel.loadByIdAndAccount(req.body.channelId, user.Account.id) + if (!videoChannel) { + res.status(400) + .json({ error: 'Unknown video video channel for this account.' }) + .end() + + return + } - if (!isVideoDurationValid(duration)) { - return res.status(400).send('Duration of the video file is too big (max: ' + CONSTRAINTS_FIELDS.VIDEOS.DURATION.max + 's).') - } + res.locals.videoChannel = videoChannel - videoFile.duration = duration - next() - }) - }) -} + const isAble = await user.isAbleToUploadVideo(videoFile) + if (isAble === false) { + res.status(403) + .json({ error: 'The user video quota is exceeded with this video.' }) + .end() -function videosUpdateValidator (req, res, next) { - req.checkParams('id', 'Should have a valid id').notEmpty().isUUID(4) - req.checkBody('name', 'Should have a valid name').optional().isVideoNameValid() - req.checkBody('category', 'Should have a valid category').optional().isVideoCategoryValid() - req.checkBody('licence', 'Should have a valid licence').optional().isVideoLicenceValid() - req.checkBody('language', 'Should have a valid language').optional().isVideoLanguageValid() - req.checkBody('nsfw', 'Should have a valid NSFW attribute').optional().isVideoNSFWValid() - req.checkBody('description', 'Should have a valid description').optional().isVideoDescriptionValid() - req.checkBody('tags', 'Should have correct tags').optional().isVideoTagsValid() - - logger.debug('Checking videosUpdate parameters', { parameters: req.body }) - - checkErrors(req, res, function () { - checkVideoExists(req.params.id, res, function () { - // We need to make additional checks - if (res.locals.video.isOwned() === false) { - return res.status(403).send('Cannot update video of another pod') - } + return + } + + let duration: number + + try { + duration = await getDurationFromVideoFile(videoFile.path) + } catch (err) { + logger.error('Invalid input file in videosAddValidator.', err) + res.status(400) + .json({ error: 'Invalid input file.' }) + .end() + + return + } + + videoFile['duration'] = duration + + return next() + } +] + +const videosUpdateValidator = [ + param('id').custom(isIdOrUUIDValid).not().isEmpty().withMessage('Should have a valid id'), + body('name').optional().custom(isVideoNameValid).withMessage('Should have a valid name'), + body('category').optional().custom(isVideoCategoryValid).withMessage('Should have a valid category'), + body('licence').optional().custom(isVideoLicenceValid).withMessage('Should have a valid licence'), + body('language').optional().custom(isVideoLanguageValid).withMessage('Should have a valid language'), + body('nsfw').optional().custom(isVideoNSFWValid).withMessage('Should have a valid NSFW attribute'), + body('privacy').optional().custom(isVideoPrivacyValid).withMessage('Should have correct video privacy'), + body('description').optional().custom(isVideoDescriptionValid).withMessage('Should have a valid description'), + body('tags').optional().custom(isVideoTagsValid).withMessage('Should have correct tags'), + + async (req: express.Request, res: express.Response, next: express.NextFunction) => { + logger.debug('Checking videosUpdate parameters', { parameters: req.body }) + + if (areValidationErrors(req, res)) return + if (!await isVideoExist(req.params.id, res)) return + + const video = res.locals.video + + // We need to make additional checks + if (video.isOwned() === false) { + return res.status(403) + .json({ error: 'Cannot update video of another server' }) + .end() + } - if (res.locals.video.Author.userId !== res.locals.oauth.token.User.id) { - return res.status(403).send('Cannot update video of another user') + if (video.VideoChannel.Account.userId !== res.locals.oauth.token.User.id) { + return res.status(403) + .json({ error: 'Cannot update video of another user' }) + .end() + } + + if (video.privacy !== VideoPrivacy.PRIVATE && req.body.privacy === VideoPrivacy.PRIVATE) { + return res.status(409) + .json({ error: 'Cannot set "private" a video that was not private anymore.' }) + .end() + } + + return next() + } +] + +const videosGetValidator = [ + param('id').custom(isIdOrUUIDValid).not().isEmpty().withMessage('Should have a valid id'), + + async (req: express.Request, res: express.Response, next: express.NextFunction) => { + logger.debug('Checking videosGet parameters', { parameters: req.params }) + + if (areValidationErrors(req, res)) return + if (!await isVideoExist(req.params.id, res)) return + + const video = res.locals.video + + // Video is not private, anyone can access it + if (video.privacy !== VideoPrivacy.PRIVATE) return next() + + authenticate(req, res, () => { + if (video.VideoChannel.Account.userId !== res.locals.oauth.token.User.id) { + return res.status(403) + .json({ error: 'Cannot get this private video of another user' }) + .end() } - next() + return next() }) - }) -} + } +] -function videosGetValidator (req, res, next) { - req.checkParams('id', 'Should have a valid id').notEmpty().isUUID(4) +const videosRemoveValidator = [ + param('id').custom(isIdOrUUIDValid).not().isEmpty().withMessage('Should have a valid id'), - logger.debug('Checking videosGet parameters', { parameters: req.params }) + async (req: express.Request, res: express.Response, next: express.NextFunction) => { + logger.debug('Checking videosRemove parameters', { parameters: req.params }) - checkErrors(req, res, function () { - checkVideoExists(req.params.id, res, next) - }) -} + if (areValidationErrors(req, res)) return + if (!await isVideoExist(req.params.id, res)) return + + // Check if the user who did the request is able to delete the video + if (!checkUserCanDeleteVideo(res.locals.oauth.token.User, res.locals.video, res)) return -function videosRemoveValidator (req, res, next) { - req.checkParams('id', 'Should have a valid id').notEmpty().isUUID(4) + return next() + } +] - logger.debug('Checking videosRemove parameters', { parameters: req.params }) +const videosSearchValidator = [ + query('search').not().isEmpty().withMessage('Should have a valid search'), - checkErrors(req, res, function () { - checkVideoExists(req.params.id, res, function () { - // We need to make additional checks + (req: express.Request, res: express.Response, next: express.NextFunction) => { + logger.debug('Checking videosSearch parameters', { parameters: req.params }) - // Check if the user who did the request is able to delete the video - checkUserCanDeleteVideo(res.locals.oauth.token.User.id, res, function () { - next() - }) - }) - }) -} + if (areValidationErrors(req, res)) return -function videosSearchValidator (req, res, next) { - const searchableColumns = SEARCHABLE_COLUMNS.VIDEOS - req.checkParams('value', 'Should have a valid search').notEmpty() - req.checkQuery('field', 'Should have correct searchable column').optional().isIn(searchableColumns) + return next() + } +] - logger.debug('Checking videosSearch parameters', { parameters: req.params }) +const videoAbuseReportValidator = [ + param('id').custom(isIdOrUUIDValid).not().isEmpty().withMessage('Should have a valid id'), + body('reason').custom(isVideoAbuseReasonValid).withMessage('Should have a valid reason'), - checkErrors(req, res, next) -} + async (req: express.Request, res: express.Response, next: express.NextFunction) => { + logger.debug('Checking videoAbuseReport parameters', { parameters: req.body }) -function videoAbuseReportValidator (req, res, next) { - req.checkParams('id', 'Should have a valid id').notEmpty().isUUID(4) - req.checkBody('reason', 'Should have a valid reason').isVideoAbuseReasonValid() + if (areValidationErrors(req, res)) return + if (!await isVideoExist(req.params.id, res)) return - logger.debug('Checking videoAbuseReport parameters', { parameters: req.body }) + return next() + } +] - checkErrors(req, res, function () { - checkVideoExists(req.params.id, res, next) - }) -} +const videoRateValidator = [ + param('id').custom(isIdOrUUIDValid).not().isEmpty().withMessage('Should have a valid id'), + body('rating').custom(isVideoRatingTypeValid).withMessage('Should have a valid rate type'), -function videoRateValidator (req, res, next) { - req.checkParams('id', 'Should have a valid id').notEmpty().isUUID(4) - req.checkBody('rating', 'Should have a valid rate type').isVideoRatingTypeValid() + async (req: express.Request, res: express.Response, next: express.NextFunction) => { + logger.debug('Checking videoRate parameters', { parameters: req.body }) - logger.debug('Checking videoRate parameters', { parameters: req.body }) + if (areValidationErrors(req, res)) return + if (!await isVideoExist(req.params.id, res)) return - checkErrors(req, res, function () { - checkVideoExists(req.params.id, res, next) - }) -} + return next() + } +] -function videosBlacklistValidator (req, res, next) { - req.checkParams('id', 'Should have a valid id').notEmpty().isUUID(4) +const videosShareValidator = [ + param('id').custom(isIdOrUUIDValid).not().isEmpty().withMessage('Should have a valid id'), + param('accountId').custom(isIdValid).not().isEmpty().withMessage('Should have a valid account id'), - logger.debug('Checking videosBlacklist parameters', { parameters: req.params }) + async (req: express.Request, res: express.Response, next: express.NextFunction) => { + logger.debug('Checking videoShare parameters', { parameters: req.params }) - checkErrors(req, res, function () { - checkVideoExists(req.params.id, res, function () { - checkVideoIsBlacklistable(req, res, next) - }) - }) -} + if (areValidationErrors(req, res)) return + if (!await isVideoExist(req.params.id, res)) return + + const share = await db.VideoShare.load(req.params.accountId, res.locals.video.id, undefined) + if (!share) { + return res.status(404) + .end() + } + + res.locals.videoShare = share + return next() + } +] // --------------------------------------------------------------------------- @@ -140,60 +240,34 @@ export { videosGetValidator, videosRemoveValidator, videosSearchValidator, + videosShareValidator, videoAbuseReportValidator, - videoRateValidator, - - videosBlacklistValidator + videoRateValidator } // --------------------------------------------------------------------------- -function checkVideoExists (id, res, callback) { - db.Video.loadAndPopulateAuthorAndPodAndTags(id, function (err, video) { - if (err) { - logger.error('Error in video request validator.', { error: err }) - return res.sendStatus(500) - } - - if (!video) return res.status(404).send('Video not found') - - res.locals.video = video - callback() - }) -} - -function checkUserCanDeleteVideo (userId, res, callback) { +function checkUserCanDeleteVideo (user: UserInstance, video: VideoInstance, res: express.Response) { // Retrieve the user who did the request - db.User.loadById(userId, function (err, user) { - if (err) { - logger.error('Error in video request validator.', { error: err }) - return res.sendStatus(500) - } - - // Check if the user can delete the video - // The user can delete it if s/he is an admin - // Or if s/he is the video's author - if (user.isAdmin() === false) { - if (res.locals.video.isOwned() === false) { - return res.status(403).send('Cannot remove video of another pod') - } - - if (res.locals.video.Author.userId !== res.locals.oauth.token.User.id) { - return res.status(403).send('Cannot remove video of another user') - } - } - - // If we reach this comment, we can delete the video - callback() - }) -} + if (video.isOwned() === false) { + res.status(403) + .json({ error: 'Cannot remove video of another server, blacklist it' }) + .end() + return false + } -function checkVideoIsBlacklistable (req, res, callback) { - if (res.locals.video.isOwned() === true) { - return res.status(403).send('Cannot blacklist a local video') + // Check if the user can delete the video + // The user can delete it if s/he is an admin + // Or if s/he is the video's account + const account = video.VideoChannel.Account + if (user.hasRight(UserRight.REMOVE_ANY_VIDEO) === false && account.userId !== user.id) { + res.status(403) + .json({ error: 'Cannot remove video of another user' }) + .end() + return false } - callback() + return true }