X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;ds=sidebyside;f=server%2Fmiddlewares%2Fasync.ts;h=7e131257d5af34451ab7d87271aef42ff0b9e4d3;hb=7a9e420a02434e4f16c99e7d58da9075dff25d15;hp=0faa4fb8c0ff2ad32fa3ad45b3c4843d73c2effb;hpb=f6d6e7f861189a4446f406efb775a29688764b48;p=github%2FChocobozzz%2FPeerTube.git diff --git a/server/middlewares/async.ts b/server/middlewares/async.ts index 0faa4fb8c..7e131257d 100644 --- a/server/middlewares/async.ts +++ b/server/middlewares/async.ts @@ -1,22 +1,26 @@ -import { eachSeries } from 'async' +import Bluebird from 'bluebird' import { NextFunction, Request, RequestHandler, Response } from 'express' import { ValidationChain } from 'express-validator' -import { ExpressPromiseHandler } from '@server/types/express' +import { ExpressPromiseHandler } from '@server/types/express-handler' import { retryTransactionWrapper } from '../helpers/database-utils' -import { HttpMethod, HttpStatusCode } from '@shared/core-utils' -// Syntactic sugar to avoid try/catch in express controllers -// Thanks: https://medium.com/@Abazhenov/using-async-await-in-express-with-node-8-b8af872c0016 +// Syntactic sugar to avoid try/catch in express controllers/middlewares export type RequestPromiseHandler = ValidationChain | ExpressPromiseHandler function asyncMiddleware (fun: RequestPromiseHandler | RequestPromiseHandler[]) { return (req: Request, res: Response, next: NextFunction) => { if (Array.isArray(fun) === true) { - return eachSeries(fun as RequestHandler[], (f, cb) => { - Promise.resolve(f(req, res, err => cb(err))) - .catch(err => next(err)) - }, next) + return Bluebird.each(fun as RequestPromiseHandler[], f => { + return new Promise((resolve, reject) => { + return asyncMiddleware(f)(req, res, err => { + if (err) return reject(err) + + return resolve() + }) + }) + }).then(() => next()) + .catch(err => next(err)) } return Promise.resolve((fun as RequestHandler)(req, res, next))