X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;ds=inline;f=src%2FWallabag%2FCoreBundle%2FHelper%2FContentProxy.php;h=5dd684f2dcc410b9d9a5d3fc2902607c2f43e526;hb=4094ea47712efbe58624ff74daeb1f77c9b0edcf;hp=3d585e6180786222603cb3f0be2e76b3ac18c8af;hpb=1c9cd2a7f03a66a1ae5132ff270e94a7fe6eb9ed;p=github%2Fwallabag%2Fwallabag.git diff --git a/src/Wallabag/CoreBundle/Helper/ContentProxy.php b/src/Wallabag/CoreBundle/Helper/ContentProxy.php index 3d585e61..5dd684f2 100644 --- a/src/Wallabag/CoreBundle/Helper/ContentProxy.php +++ b/src/Wallabag/CoreBundle/Helper/ContentProxy.php @@ -5,7 +5,9 @@ namespace Wallabag\CoreBundle\Helper; use Graby\Graby; use Psr\Log\LoggerInterface as Logger; use Wallabag\CoreBundle\Entity\Entry; +use Wallabag\CoreBundle\Entity\Tag; use Wallabag\CoreBundle\Tools\Utils; +use Wallabag\CoreBundle\Repository\TagRepository; /** * This kind of proxy class take care of getting the content from an url @@ -16,26 +18,35 @@ class ContentProxy protected $graby; protected $tagger; protected $logger; + protected $tagRepository; - public function __construct(Graby $graby, RuleBasedTagger $tagger, Logger $logger) + public function __construct(Graby $graby, RuleBasedTagger $tagger, TagRepository $tagRepository, Logger $logger) { - $this->graby = $graby; + $this->graby = $graby; $this->tagger = $tagger; $this->logger = $logger; + $this->tagRepository = $tagRepository; } /** * Fetch content using graby and hydrate given entry with results information. * In case we couldn't find content, we'll try to use Open Graph data. * - * @param Entry $entry Entry to update - * @param string $url Url to grab content for + * We can also force the content, in case of an import from the v1 for example, so the function won't + * fetch the content from the website but rather use information given with the $content parameter. + * + * @param Entry $entry Entry to update + * @param string $url Url to grab content for + * @param array $content An array with AT LEAST keys title, html, url, language & content_type to skip the fetchContent from the url * * @return Entry */ - public function updateEntry(Entry $entry, $url) + public function updateEntry(Entry $entry, $url, array $content = []) { - $content = $this->graby->fetchContent($url); + // do we have to fetch the content or the provided one is ok? + if (empty($content) || false === $this->validateContent($content)) { + $content = $this->graby->fetchContent($url); + } $title = $content['title']; if (!$title && isset($content['open_graph']['og_title'])) { @@ -58,7 +69,11 @@ class ContentProxy $entry->setLanguage($content['language']); $entry->setMimetype($content['content_type']); $entry->setReadingTime(Utils::getReadingTime($html)); - $entry->setDomainName(parse_url($entry->getUrl(), PHP_URL_HOST)); + + $domainName = parse_url($entry->getUrl(), PHP_URL_HOST); + if (false !== $domainName) { + $entry->setDomainName($domainName); + } if (isset($content['open_graph']['og_image'])) { $entry->setPreviewPicture($content['open_graph']['og_image']); @@ -67,12 +82,59 @@ class ContentProxy try { $this->tagger->tag($entry); } catch (\Exception $e) { - $this->logger->error('Error while trying to automatically tag an entry.', array( + $this->logger->error('Error while trying to automatically tag an entry.', [ 'entry_url' => $url, 'error_msg' => $e->getMessage(), - )); + ]); } return $entry; } + + /** + * Assign some tags to an entry. + * + * @param Entry $entry + * @param array|string $tags An array of tag or a string coma separated of tag + */ + public function assignTagsToEntry(Entry $entry, $tags) + { + if (!is_array($tags)) { + $tags = explode(',', $tags); + } + + foreach ($tags as $label) { + $label = trim($label); + + // avoid empty tag + if (0 === strlen($label)) { + continue; + } + + $tagEntity = $this->tagRepository->findOneByLabel($label); + + if (is_null($tagEntity)) { + $tagEntity = new Tag(); + $tagEntity->setLabel($label); + } + + // only add the tag on the entry if the relation doesn't exist + if (false === $entry->getTags()->contains($tagEntity)) { + $entry->addTag($tagEntity); + } + } + } + + /** + * Validate that the given content as enough value to be used + * instead of fetch the content from the url. + * + * @param array $content + * + * @return bool true if valid otherwise false + */ + private function validateContent(array $content) + { + return isset($content['title']) && isset($content['html']) && isset($content['url']) && isset($content['language']) && isset($content['content_type']); + } }