X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;ds=inline;f=application%2FUtils.php;h=120333c560c93c29cf33a6e6175f829ae26ca6a4;hb=refs%2Fpull%2F376%2Fhead;hp=658b97bc2f03fff6d2f5580fa912165d1a422cdb;hpb=5b0ebbc5de06b8a0e9679b78b45d0dc755db7986;p=github%2Fshaarli%2FShaarli.git diff --git a/application/Utils.php b/application/Utils.php index 658b97bc..120333c5 100644 --- a/application/Utils.php +++ b/application/Utils.php @@ -48,7 +48,7 @@ function endsWith($haystack, $needle, $case=true) */ function nl2br_escaped($html) { - return str_replace('>','>',str_replace('<','<',nl2br($html))); + return str_replace('>', '>', str_replace('<', '<', nl2br($html))); } /** @@ -97,12 +97,12 @@ function checkDateFormat($format, $string) */ function generateLocation($referer, $host, $loopTerms = array()) { - $final_referer = '?'; + $finalReferer = '?'; // No referer if it contains any value in $loopCriteria. foreach ($loopTerms as $value) { if (strpos($referer, $value) !== false) { - return $final_referer; + return $finalReferer; } } @@ -111,9 +111,60 @@ function generateLocation($referer, $host, $loopTerms = array()) $host = substr($host, 0, $pos); } - if (!empty($referer) && strpos(parse_url($referer, PHP_URL_HOST), $host) !== false) { - $final_referer = $referer; + $refererHost = parse_url($referer, PHP_URL_HOST); + if (!empty($referer) && (strpos($refererHost, $host) !== false || startsWith('?', $refererHost))) { + $finalReferer = $referer; } - return $final_referer; + return $finalReferer; +} + +/** + * Checks the PHP version to ensure Shaarli can run + * + * @param string $minVersion minimum PHP required version + * @param string $curVersion current PHP version (use PHP_VERSION) + * + * @throws Exception the PHP version is not supported + */ +function checkPHPVersion($minVersion, $curVersion) +{ + if (version_compare($curVersion, $minVersion) < 0) { + throw new Exception( + 'Your PHP version is obsolete!' + .' Shaarli requires at least PHP '.$minVersion.', and thus cannot run.' + .' Your PHP version has known security vulnerabilities and should be' + .' updated as soon as possible.' + ); + } +} + +/** + * Validate session ID to prevent Full Path Disclosure. + * + * See #298. + * The session ID's format depends on the hash algorithm set in PHP settings + * + * @param string $sessionId Session ID + * + * @return true if valid, false otherwise. + * + * @see http://php.net/manual/en/function.hash-algos.php + * @see http://php.net/manual/en/session.configuration.php + */ +function is_session_id_valid($sessionId) +{ + if (empty($sessionId)) { + return false; + } + + if (!$sessionId) { + return false; + } + + if (!preg_match('/^[a-zA-Z0-9,-]{2,128}$/', $sessionId)) { + return false; + } + + return true; }