namespace Shaarli\Api\Controllers;
+use malkusch\lock\mutex\NoMutex;
+use Shaarli\Bookmark\BookmarkFileService;
use Shaarli\Config\ConfigManager;
+use Shaarli\History;
+use Shaarli\Plugin\PluginManager;
use Slim\Container;
use Slim\Http\Environment;
use Slim\Http\Request;
use Slim\Http\Response;
-class DeleteLinkTest extends \PHPUnit_Framework_TestCase
+class DeleteLinkTest extends \Shaarli\TestCase
{
/**
* @var string datastore to test write operations
protected $refDB = null;
/**
- * @var \LinkDB instance.
+ * @var BookmarkFileService instance.
*/
- protected $linkDB;
+ protected $bookmarkService;
/**
- * @var \History instance.
+ * @var HistoryController instance.
*/
protected $history;
*/
protected $controller;
+ /** @var NoMutex */
+ protected $mutex;
+
+ /** @var PluginManager */
+ protected $pluginManager;
+
/**
- * Before each test, instantiate a new Api with its config, plugins and links.
+ * Before each test, instantiate a new Api with its config, plugins and bookmarks.
*/
- public function setUp()
+ protected function setUp(): void
{
+ $this->mutex = new NoMutex();
$this->conf = new ConfigManager('tests/utils/config/configJson');
+ $this->conf->set('resource.datastore', self::$testDatastore);
$this->refDB = new \ReferenceLinkDB();
$this->refDB->write(self::$testDatastore);
- $this->linkDB = new \LinkDB(self::$testDatastore, true, false);
$refHistory = new \ReferenceHistory();
$refHistory->write(self::$testHistory);
- $this->history = new \History(self::$testHistory);
+ $this->history = new History(self::$testHistory);
+ $this->pluginManager = new PluginManager($this->conf);
+ $this->bookmarkService = new BookmarkFileService(
+ $this->conf,
+ $this->pluginManager,
+ $this->history,
+ $this->mutex,
+ true
+ );
+
$this->container = new Container();
$this->container['conf'] = $this->conf;
- $this->container['db'] = $this->linkDB;
+ $this->container['db'] = $this->bookmarkService;
$this->container['history'] = $this->history;
$this->controller = new Links($this->container);
/**
* After each test, remove the test datastore.
*/
- public function tearDown()
+ protected function tearDown(): void
{
@unlink(self::$testDatastore);
@unlink(self::$testHistory);
public function testDeleteLinkValid()
{
$id = '41';
- $this->assertTrue(isset($this->linkDB[$id]));
+ $this->assertTrue($this->bookmarkService->exists($id));
$env = Environment::mock([
'REQUEST_METHOD' => 'DELETE',
]);
$this->assertEquals(204, $response->getStatusCode());
$this->assertEmpty((string) $response->getBody());
- $this->linkDB = new \LinkDB(self::$testDatastore, true, false);
- $this->assertFalse(isset($this->linkDB[$id]));
+ $this->bookmarkService = new BookmarkFileService(
+ $this->conf,
+ $this->pluginManager,
+ $this->history,
+ $this->mutex,
+ true
+ );
+ $this->assertFalse($this->bookmarkService->exists($id));
$historyEntry = $this->history->getHistory()[0];
- $this->assertEquals(\History::DELETED, $historyEntry['event']);
+ $this->assertEquals(History::DELETED, $historyEntry['event']);
$this->assertTrue(
(new \DateTime())->add(\DateInterval::createFromDateString('-5 seconds')) < $historyEntry['datetime']
);
/**
* Test DELETE link endpoint: reach not existing ID.
- *
- * @expectedException Shaarli\Api\Exceptions\ApiLinkNotFoundException
*/
public function testDeleteLink404()
{
+ $this->expectException(\Shaarli\Api\Exceptions\ApiLinkNotFoundException::class);
+
$id = -1;
- $this->assertFalse(isset($this->linkDB[$id]));
+ $this->assertFalse($this->bookmarkService->exists($id));
$env = Environment::mock([
'REQUEST_METHOD' => 'DELETE',
]);