namespace Tests\Wallabag\ApiBundle\Controller;
use Tests\Wallabag\CoreBundle\WallabagCoreTestCase;
+use Wallabag\ApiBundle\Entity\Client;
class DeveloperControllerTest extends WallabagCoreTestCase
{
$nbClients = $em->getRepository('WallabagApiBundle:Client')->findAll();
$crawler = $client->request('GET', '/developer/client/create');
- $this->assertEquals(200, $client->getResponse()->getStatusCode());
+ $this->assertSame(200, $client->getResponse()->getStatusCode());
- $form = $crawler->filter('button[type=submit]')->form();
+ $form = $crawler->filter('button[id=client_save]')->form();
$data = [
'client[name]' => 'My app',
$crawler = $client->submit($form, $data);
- $this->assertEquals(200, $client->getResponse()->getStatusCode());
+ $this->assertSame(200, $client->getResponse()->getStatusCode());
$newNbClients = $em->getRepository('WallabagApiBundle:Client')->findAll();
- $this->assertGreaterThan(count($nbClients), count($newNbClients));
+ $this->assertGreaterThan(\count($nbClients), \count($newNbClients));
$this->assertGreaterThan(1, $alert = $crawler->filter('.settings ul li strong')->extract(['_text']));
$this->assertContains('My app', $alert[0]);
}
- /**
- * @depends testCreateClient
- */
public function testCreateToken()
{
$client = $this->getClient();
- $em = $client->getContainer()->get('doctrine.orm.entity_manager');
- $apiClient = $em->getRepository('WallabagApiBundle:Client')->findOneByName('My app');
+ $apiClient = $this->createApiClientForUser('admin');
$client->request('POST', '/oauth/v2/token', [
'grant_type' => 'password',
'password' => 'mypassword',
]);
- $this->assertEquals(200, $client->getResponse()->getStatusCode());
+ $this->assertSame(200, $client->getResponse()->getStatusCode());
$data = json_decode($client->getResponse()->getContent(), true);
$this->assertArrayHasKey('access_token', $data);
$this->assertArrayHasKey('refresh_token', $data);
}
+ public function testCreateTokenWithBadClientId()
+ {
+ $client = $this->getClient();
+ $client->request('POST', '/oauth/v2/token', [
+ 'grant_type' => 'password',
+ 'client_id' => '$WALLABAG_CLIENT_ID',
+ 'client_secret' => 'secret',
+ 'username' => 'admin',
+ 'password' => 'mypassword',
+ ]);
+
+ $this->assertSame(400, $client->getResponse()->getStatusCode());
+ }
+
public function testListingClient()
{
$this->logInAs('admin');
$nbClients = $em->getRepository('WallabagApiBundle:Client')->findAll();
$crawler = $client->request('GET', '/developer');
- $this->assertEquals(200, $client->getResponse()->getStatusCode());
- $this->assertEquals(count($nbClients), $crawler->filter('ul[class=collapsible] li')->count());
+ $this->assertSame(200, $client->getResponse()->getStatusCode());
+ $this->assertSame(\count($nbClients), $crawler->filter('ul[class=collapsible] li')->count());
}
public function testDeveloperHowto()
$client = $this->getClient();
$crawler = $client->request('GET', '/developer/howto/first-app');
- $this->assertEquals(200, $client->getResponse()->getStatusCode());
+ $this->assertSame(200, $client->getResponse()->getStatusCode());
}
public function testRemoveClient()
{
- $this->logInAs('admin');
$client = $this->getClient();
+ $adminApiClient = $this->createApiClientForUser('admin');
$em = $client->getContainer()->get('doctrine.orm.entity_manager');
- $nbClients = $em->getRepository('WallabagApiBundle:Client')->findAll();
+ // Try to remove an admin's client with a wrong user
+ $this->logInAs('bob');
+ $client->request('GET', '/developer');
+ $this->assertContains('no_client', $client->getResponse()->getContent());
+
+ $this->logInAs('bob');
+ $client->request('GET', '/developer/client/delete/' . $adminApiClient->getId());
+ $this->assertSame(403, $client->getResponse()->getStatusCode());
+
+ // Try to remove the admin's client with the good user
+ $this->logInAs('admin');
$crawler = $client->request('GET', '/developer');
$link = $crawler
;
$client->click($link);
- $this->assertEquals(302, $client->getResponse()->getStatusCode());
+ $this->assertSame(302, $client->getResponse()->getStatusCode());
- $newNbClients = $em->getRepository('WallabagApiBundle:Client')->findAll();
- $this->assertGreaterThan(count($newNbClients), count($nbClients));
+ $this->assertNull(
+ $em->getRepository('WallabagApiBundle:Client')->find($adminApiClient->getId()),
+ 'The client should have been removed'
+ );
+ }
+
+ /**
+ * @param string $username
+ * @param array $grantTypes
+ *
+ * @return Client
+ */
+ private function createApiClientForUser($username, $grantTypes = ['password'])
+ {
+ $client = $this->getClient();
+ $em = $client->getContainer()->get('doctrine.orm.entity_manager');
+ $userManager = $client->getContainer()->get('fos_user.user_manager.test');
+ $user = $userManager->findUserBy(['username' => $username]);
+ $apiClient = new Client($user);
+ $apiClient->setName('My app');
+ $apiClient->setAllowedGrantTypes($grantTypes);
+ $em->persist($apiClient);
+ $em->flush();
+
+ return $apiClient;
}
}