<?php
+require_once 'application/config/ConfigManager.php';
require_once 'tests/Updater/DummyUpdater.php';
/**
*/
protected static $testDatastore = 'sandbox/datastore.php';
+ /**
+ * @var string Config file path (without extension).
+ */
+ protected static $configFile = 'tests/utils/config/configUpdater';
+
+ /**
+ * @var ConfigManager
+ */
+ protected $conf;
+
/**
* Executed before each test.
*/
'disablesessionprotection' => false,
'privateLinkByDefault' => false,
'config' => array(
- 'CONFIG_FILE' => 'tests/Updater/config.php',
'DATADIR' => 'tests/Updater',
'PAGECACHE' => 'sandbox/pagecache',
'config1' => 'config1data',
'config2' => 'config2data',
)
);
+
+ ConfigManager::$CONFIG_FILE = self::$configFile;
+ $this->conf = ConfigManager::reset();
+ $this->conf->reload();
+ foreach (self::$configFields as $key => $value) {
+ $this->conf->set($key, $value);
+ }
+ $this->conf->write(true);
}
/**
*/
public function tearDown()
{
- if (is_file(self::$configFields['config']['CONFIG_FILE'])) {
- unlink(self::$configFields['config']['CONFIG_FILE']);
+ if (is_file('tests/Updater/config.json')) {
+ unlink('tests/Updater/config.json');
}
if (is_file(self::$configFields['config']['DATADIR'] . '/options.php')) {
unlink(self::$configFields['config']['DATADIR'] . '/options.php');
}
- if (is_file(self::$configFields['config']['DATADIR'] . '/updates.json')) {
- unlink(self::$configFields['config']['DATADIR'] . '/updates.json');
+ if (is_file(self::$configFields['config']['DATADIR'] . '/updates.txt')) {
+ unlink(self::$configFields['config']['DATADIR'] . '/updates.txt');
}
}
public function testReadEmptyUpdatesFile()
{
$this->assertEquals(array(), read_updates_file(''));
- $updatesFile = self::$configFields['config']['DATADIR'] . '/updates.json';
+ $updatesFile = self::$configFields['config']['DATADIR'] . '/updates.txt';
touch($updatesFile);
$this->assertEquals(array(), read_updates_file($updatesFile));
}
*/
public function testReadWriteUpdatesFile()
{
- $updatesFile = self::$configFields['config']['DATADIR'] . '/updates.json';
+ $updatesFile = self::$configFields['config']['DATADIR'] . '/updates.txt';
$updatesMethods = array('m1', 'm2', 'm3');
write_updates_file($updatesFile, $updatesMethods);
*/
public function testWriteUpdatesFileNotWritable()
{
- $updatesFile = self::$configFields['config']['DATADIR'] . '/updates.json';
+ $updatesFile = self::$configFields['config']['DATADIR'] . '/updates.txt';
touch($updatesFile);
chmod($updatesFile, 0444);
@write_updates_file($updatesFile, array('test'));
'updateMethodDummy3',
'updateMethodException',
);
- $updater = new DummyUpdater($updates, array(), array(), true);
+ $updater = new DummyUpdater($updates, array(), true);
$this->assertEquals(array(), $updater->update());
- $updater = new DummyUpdater(array(), array(), array(), false);
+ $updater = new DummyUpdater(array(), array(), false);
$this->assertEquals(array(), $updater->update());
}
'updateMethodDummy2',
'updateMethodDummy3',
);
- $updater = new DummyUpdater($updates, array(), array(), true);
+ $updater = new DummyUpdater($updates, array(), true);
$this->assertEquals($expectedUpdates, $updater->update());
}
);
$expectedUpdate = array('updateMethodDummy2');
- $updater = new DummyUpdater($updates, array(), array(), true);
+ $updater = new DummyUpdater($updates, array(), true);
$this->assertEquals($expectedUpdate, $updater->update());
}
'updateMethodDummy3',
);
- $updater = new DummyUpdater($updates, array(), array(), true);
+ $updater = new DummyUpdater($updates, array(), true);
$updater->update();
}
*/
public function testUpdateMergeDeprecatedConfig()
{
- // init
- writeConfig(self::$configFields, true);
- $configCopy = self::$configFields;
- $invert = !$configCopy['privateLinkByDefault'];
- $configCopy['privateLinkByDefault'] = $invert;
-
// Use writeConfig to create a options.php
- $configCopy['config']['CONFIG_FILE'] = 'tests/Updater/options.php';
- writeConfig($configCopy, true);
+ ConfigManager::$CONFIG_FILE = 'tests/Updater/options';
+ $this->conf->setConfigIO(new ConfigPhp());
+
+ $invert = !$this->conf->get('privateLinkByDefault');
+ $this->conf->set('privateLinkByDefault', $invert);
+ $this->conf->write(true);
- $this->assertTrue(is_file($configCopy['config']['CONFIG_FILE']));
+ $optionsFile = 'tests/Updater/options.php';
+ $this->assertTrue(is_file($optionsFile));
+
+ ConfigManager::$CONFIG_FILE = 'tests/Updater/config';
// merge configs
- $updater = new Updater(array(), self::$configFields, array(), true);
+ $updater = new Updater(array(), array(), true);
+ // This writes a new config file in tests/Updater/config.php
$updater->updateMethodMergeDeprecatedConfigFile();
// make sure updated field is changed
- include self::$configFields['config']['CONFIG_FILE'];
- $this->assertEquals($invert, $GLOBALS['privateLinkByDefault']);
- $this->assertFalse(is_file($configCopy['config']['CONFIG_FILE']));
+ $this->conf->reload();
+ $this->assertEquals($invert, $this->conf->get('privateLinkByDefault'));
+ $this->assertFalse(is_file($optionsFile));
+ // Delete the generated file.
+ unlink($this->conf->getConfigFile());
}
/**
*/
public function testMergeDeprecatedConfigNoFile()
{
- writeConfig(self::$configFields, true);
-
- $updater = new Updater(array(), self::$configFields, array(), true);
+ $updater = new Updater(array(), array(), true);
$updater->updateMethodMergeDeprecatedConfigFile();
- include self::$configFields['config']['CONFIG_FILE'];
- $this->assertEquals(self::$configFields['login'], $GLOBALS['login']);
+ $this->assertEquals(self::$configFields['login'], $this->conf->get('login'));
}
+ /**
+ * Test renameDashTags update method.
+ */
public function testRenameDashTags()
{
$refDB = new ReferenceLinkDB();
$refDB->write(self::$testDatastore);
$linkDB = new LinkDB(self::$testDatastore, true, false);
- $this->assertEmpty($linkDB->filter(LinkFilter::$FILTER_TAG, 'exclude'));
- $updater = new Updater(array(), self::$configFields, $linkDB, true);
+ $this->assertEmpty($linkDB->filterSearch(array('searchtags' => 'exclude')));
+ $updater = new Updater(array(), $linkDB, true);
$updater->updateMethodRenameDashTags();
- $this->assertNotEmpty($linkDB->filter(LinkFilter::$FILTER_TAG, 'exclude'));
+ $this->assertNotEmpty($linkDB->filterSearch(array('searchtags' => 'exclude')));
+ }
+
+ /**
+ * Convert old PHP config file to JSON config.
+ */
+ public function testConfigToJson()
+ {
+ $configFile = 'tests/utils/config/configPhp';
+ ConfigManager::$CONFIG_FILE = $configFile;
+ $conf = ConfigManager::reset();
+
+ // The ConfigIO is initialized with ConfigPhp.
+ $this->assertTrue($conf->getConfigIO() instanceof ConfigPhp);
+
+ $updater = new Updater(array(), array(), false);
+ $done = $updater->updateMethodConfigToJson();
+ $this->assertTrue($done);
+
+ // The ConfigIO has been updated to ConfigJson.
+ $this->assertTrue($conf->getConfigIO() instanceof ConfigJson);
+ $this->assertTrue(file_exists($conf->getConfigFile()));
+
+ // Check JSON config data.
+ $conf->reload();
+ $this->assertEquals('root', $conf->get('login'));
+ $this->assertEquals('lala', $conf->get('redirector'));
+ $this->assertEquals('data/datastore.php', $conf->get('config.DATASTORE'));
+ $this->assertEquals('1', $conf->get('plugins.WALLABAG_VERSION'));
+
+ rename($configFile . '.save.php', $configFile . '.php');
+ unlink($conf->getConfigFile());
+ }
+
+ /**
+ * Launch config conversion update with an existing JSON file => nothing to do.
+ */
+ public function testConfigToJsonNothingToDo()
+ {
+ $configFile = 'tests/utils/config/configUpdateDone';
+ ConfigManager::$CONFIG_FILE = $configFile;
+ $conf = ConfigManager::reset();
+ $conf->reload();
+ $filetime = filemtime($conf->getConfigFile());
+ $updater = new Updater(array(), array(), false);
+ $done = $updater->updateMethodConfigToJson();
+ $this->assertTrue($done);
+ $expected = filemtime($conf->getConfigFile());
+ $this->assertEquals($expected, $filetime);
}
}