<?php
-/**
- * ApplicationUtils' tests
- */
-
-require_once 'application/config/ConfigManager.php';
-require_once 'application/ApplicationUtils.php';
-
-/**
- * Fake ApplicationUtils class to avoid HTTP requests
- */
-class FakeApplicationUtils extends ApplicationUtils
-{
- public static $VERSION_CODE = '';
+namespace Shaarli;
- /**
- * Toggle HTTP requests, allow overriding the version code
- */
- public static function getLatestGitVersionCode($url, $timeout=0)
- {
- return self::$VERSION_CODE;
- }
-}
+use Shaarli\Config\ConfigManager;
+require_once 'tests/utils/FakeApplicationUtils.php';
/**
* Unitary tests for Shaarli utilities
*/
-class ApplicationUtilsTest extends PHPUnit_Framework_TestCase
+class ApplicationUtilsTest extends \PHPUnit\Framework\TestCase
{
protected static $testUpdateFile = 'sandbox/update.txt';
protected static $testVersion = '0.5.0';
}
}
+ /**
+ * Remove test version file if it exists
+ */
+ public function tearDown()
+ {
+ if (is_file('sandbox/version.php')) {
+ unlink('sandbox/version.php');
+ }
+ }
+
/**
* Retrieve the latest version code available on Git
*
* Expected format: Semantic Versioning - major.minor.patch
*/
- public function testGetLatestGitVersionCode()
+ public function testGetVersionCode()
{
$testTimeout = 10;
$this->assertEquals(
'0.5.4',
- ApplicationUtils::getLatestGitVersionCode(
+ ApplicationUtils::getVersion(
'https://raw.githubusercontent.com/shaarli/Shaarli/'
- .'v0.5.4/shaarli_version.php',
+ .'v0.5.4/shaarli_version.php',
$testTimeout
)
);
$this->assertRegExp(
self::$versionPattern,
- ApplicationUtils::getLatestGitVersionCode(
+ ApplicationUtils::getVersion(
'https://raw.githubusercontent.com/shaarli/Shaarli/'
- .'master/shaarli_version.php',
+ .'latest/shaarli_version.php',
$testTimeout
)
);
}
/**
- * Attempt to retrieve the latest version from an invalid URL
+ * Attempt to retrieve the latest version from an invalid File
+ */
+ public function testGetVersionCodeFromFile()
+ {
+ file_put_contents('sandbox/version.php', '<?php /* 1.2.3 */ ?>'. PHP_EOL);
+ $this->assertEquals(
+ '1.2.3',
+ ApplicationUtils::getVersion('sandbox/version.php', 1)
+ );
+ }
+
+ /**
+ * Attempt to retrieve the latest version from an invalid File
*/
- public function testGetLatestGitVersionCodeInvalidUrl()
+ public function testGetVersionCodeInvalidFile()
{
+ $oldlog = ini_get('error_log');
+ ini_set('error_log', '/dev/null');
$this->assertFalse(
- ApplicationUtils::getLatestGitVersionCode('htttp://null.io', 1)
+ ApplicationUtils::getVersion('idontexist', 1)
);
+ ini_set('error_log', $oldlog);
}
/**
public function testCheckSupportedPHPVersion()
{
$minVersion = '5.3';
- ApplicationUtils::checkPHPVersion($minVersion, '5.4.32');
- ApplicationUtils::checkPHPVersion($minVersion, '5.5');
- ApplicationUtils::checkPHPVersion($minVersion, '5.6.10');
+ $this->assertTrue(ApplicationUtils::checkPHPVersion($minVersion, '5.4.32'));
+ $this->assertTrue(ApplicationUtils::checkPHPVersion($minVersion, '5.5'));
+ $this->assertTrue(ApplicationUtils::checkPHPVersion($minVersion, '5.6.10'));
}
/**
*/
public function testCheckSupportedPHPVersion51()
{
- ApplicationUtils::checkPHPVersion('5.3', '5.1.0');
+ $this->assertTrue(ApplicationUtils::checkPHPVersion('5.3', '5.1.0'));
}
/**
*/
public function testCheckSupportedPHPVersion52()
{
- ApplicationUtils::checkPHPVersion('5.3', '5.2');
+ $this->assertTrue(ApplicationUtils::checkPHPVersion('5.3', '5.2'));
}
/**
$conf->set('resource.page_cache', 'pagecache');
$conf->set('resource.raintpl_tmp', 'tmp');
$conf->set('resource.raintpl_tpl', 'tpl');
+ $conf->set('resource.theme', 'default');
$conf->set('resource.update_check', 'data/lastupdatecheck.txt');
$this->assertEquals(
$conf->set('resource.page_cache', 'null/pagecache');
$conf->set('resource.raintpl_tmp', 'null/tmp');
$conf->set('resource.raintpl_tpl', 'null/tpl');
+ $conf->set('resource.raintpl_theme', 'null/tpl/default');
$conf->set('resource.update_check', 'null/data/lastupdatecheck.txt');
$this->assertEquals(
array(
'"null/tpl" directory is not readable',
+ '"null/tpl/default" directory is not readable',
'"null/cache" directory is not readable',
'"null/cache" directory is not writable',
'"null/data" directory is not readable',
ApplicationUtils::checkResourcePermissions($conf)
);
}
+
+ /**
+ * Check update with 'dev' as curent version (master branch).
+ * It should always return false.
+ */
+ public function testCheckUpdateDev()
+ {
+ $this->assertFalse(
+ ApplicationUtils::checkUpdate('dev', self::$testUpdateFile, 100, true, true)
+ );
+ }
}