Symfony Upgrade Fixer FTW

[github/wallabag/wallabag.git] / src / Wallabag / CoreBundle / Helper / EntriesExport.php

diff --git a/src/Wallabag/CoreBundle/Helper/EntriesExport.php b/src/Wallabag/CoreBundle/Helper/EntriesExport.php
index 33ff6311b571dbccd55abcc7cc1073ca6a4c553b..31a80d6e3283b12365f7fe2e228a20ffcde372b4 100644 (file)
--- a/src/Wallabag/CoreBundle/Helper/EntriesExport.php
+++ b/src/Wallabag/CoreBundle/Helper/EntriesExport.php
@@ -2,14 +2,16 @@
 
 namespace Wallabag\CoreBundle\Helper;
 
+use JMS\Serializer;
+use JMS\Serializer\SerializationContext;
+use JMS\Serializer\SerializerBuilder;
 use PHPePub\Core\EPub;
 use PHPePub\Core\Structure\OPF\DublinCore;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\Serializer\Serializer;
-use Symfony\Component\Serializer\Encoder\XmlEncoder;
-use Symfony\Component\Serializer\Encoder\JsonEncoder;
-use Symfony\Component\Serializer\Normalizer\ObjectNormalizer;
 
+/**
+ * This class doesn't have unit test BUT it's fully covered by a functional test with ExportControllerTest.
+ */
 class EntriesExport
 {
     private $wallabagUrl;
@@ -304,7 +306,8 @@ class EntriesExport
                 array(
                     $entry->getTitle(),
                     $entry->getURL(),
-                    $entry->getContent(),
+                    // remove new line to avoid crazy results
+                    str_replace(array("\r\n", "\r", "\n"), '', $entry->getContent()),
                     implode(', ', $entry->getTags()->toArray()),
                     $entry->getMimetype(),
                     $entry->getLanguage(),
@@ -331,11 +334,8 @@ class EntriesExport
 
     private function produceJSON()
     {
-        $serializer = $this->prepareSerializingContent();
-        $jsonContent = $serializer->serialize($this->entries, 'json');
-
         return Response::create(
-            $jsonContent,
+            $this->prepareSerializingContent('json'),
             200,
             array(
                 'Content-type' => 'application/json',
@@ -347,11 +347,8 @@ class EntriesExport
 
     private function produceXML()
     {
-        $serializer = $this->prepareSerializingContent();
-        $xmlContent = $serializer->serialize($this->entries, 'xml');
-
         return Response::create(
-            $xmlContent,
+            $this->prepareSerializingContent('xml'),
             200,
             array(
                 'Content-type' => 'application/xml',
@@ -360,18 +357,21 @@ class EntriesExport
             )
         )->send();
     }
+
     /**
      * Return a Serializer object for producing processes that need it (JSON & XML).
      *
      * @return Serializer
      */
-    private function prepareSerializingContent()
+    private function prepareSerializingContent($format)
     {
-        $encoders = array(new XmlEncoder(), new JsonEncoder());
-        $normalizers = array(new ObjectNormalizer());
-        $normalizers[0]->setIgnoredAttributes(array('user', 'createdAt', 'updatedAt'));
+        $serializer = SerializerBuilder::create()->build();
 
-        return new Serializer($normalizers, $encoders);
+        return $serializer->serialize(
+            $this->entries,
+            $format,
+            SerializationContext::create()->setGroups(array('entries_for_user'))
+        );
     }
 
     /**