-/* tslint:disable:no-unused-expression */
+/* eslint-disable @typescript-eslint/no-unused-expressions,@typescript-eslint/require-await */
-import * as chai from 'chai'
import 'mocha'
+import * as chai from 'chai'
+import * as xmlParser from 'fast-xml-parser'
+import { HttpStatusCode } from '@shared/core-utils'
import {
- createUser,
+ cleanupTests,
doubleFollow,
flushAndRunMultipleServers,
- flushTests,
- getJSONfeed, getMyUserInformation,
- getXMLfeed,
- killallServers,
+ flushAndRunServer,
ServerInfo,
setAccessTokensToServers,
- uploadVideo, userLogin
-} from '../../../shared/utils'
-import * as libxmljs from 'libxmljs'
-import { addVideoCommentThread } from '../../../shared/utils/videos/video-comments'
-import { waitJobs } from '../../../shared/utils/server/jobs'
-import { User } from '../../../shared/models/users'
+ waitJobs
+} from '@shared/extra-utils'
+import { VideoPrivacy } from '@shared/models'
chai.use(require('chai-xml'))
chai.use(require('chai-json-schema'))
describe('Test syndication feeds', () => {
let servers: ServerInfo[] = []
+ let serverHLSOnly: ServerInfo
let userAccessToken: string
- let rootAccountUUID: string
- let rootChannelUUID: string
- let userAccountUUID: string
- let userChannelUUID: string
+ let rootAccountId: number
+ let rootChannelId: number
+ let userAccountId: number
+ let userChannelId: number
+ let userFeedToken: string
before(async function () {
this.timeout(120000)
// Run servers
servers = await flushAndRunMultipleServers(2)
+ serverHLSOnly = await flushAndRunServer(3, {
+ transcoding: {
+ enabled: true,
+ webtorrent: { enabled: false },
+ hls: { enabled: true }
+ }
+ })
- await setAccessTokensToServers(servers)
+ await setAccessTokensToServers([ ...servers, serverHLSOnly ])
await doubleFollow(servers[0], servers[1])
{
- const res = await getMyUserInformation(servers[0].url, servers[0].accessToken)
- const user: User = res.body
- rootAccountUUID = user.account.uuid
- rootChannelUUID = user.videoChannels[0].uuid
+ const user = await servers[0].usersCommand.getMyInfo()
+ rootAccountId = user.account.id
+ rootChannelId = user.videoChannels[0].id
}
{
const attr = { username: 'john', password: 'password' }
- await createUser(servers[0].url, servers[0].accessToken, attr.username, attr.password)
- userAccessToken = await userLogin(servers[0], attr)
+ await servers[0].usersCommand.create({ username: attr.username, password: attr.password })
+ userAccessToken = await servers[0].loginCommand.getAccessToken(attr)
+
+ const user = await servers[0].usersCommand.getMyInfo({ token: userAccessToken })
+ userAccountId = user.account.id
+ userChannelId = user.videoChannels[0].id
- const res = await getMyUserInformation(servers[0].url, userAccessToken)
- const user: User = res.body
- userAccountUUID = user.account.uuid
- userChannelUUID = user.videoChannels[0].uuid
+ const token = await servers[0].usersCommand.getMyScopedTokens({ token: userAccessToken })
+ userFeedToken = token.feedToken
}
{
- await uploadVideo(servers[ 0 ].url, userAccessToken, { name: 'user video' })
+ await servers[0].videosCommand.upload({ token: userAccessToken, attributes: { name: 'user video' } })
}
{
- const videoAttributes = {
+ const attributes = {
name: 'my super name for server 1',
description: 'my super description for server 1',
fixture: 'video_short.webm'
}
- const res = await uploadVideo(servers[ 0 ].url, servers[ 0 ].accessToken, videoAttributes)
- const videoId = res.body.video.id
+ const { id } = await servers[0].videosCommand.upload({ attributes })
+
+ await servers[0].commentsCommand.createThread({ videoId: id, text: 'super comment 1' })
+ await servers[0].commentsCommand.createThread({ videoId: id, text: 'super comment 2' })
+ }
+
+ {
+ const attributes = { name: 'unlisted video', privacy: VideoPrivacy.UNLISTED }
+ const { id } = await servers[0].videosCommand.upload({ attributes })
- await addVideoCommentThread(servers[ 0 ].url, servers[ 0 ].accessToken, videoId, 'super comment 1')
- await addVideoCommentThread(servers[ 0 ].url, servers[ 0 ].accessToken, videoId, 'super comment 2')
+ await servers[0].commentsCommand.createThread({ videoId: id, text: 'comment on unlisted video' })
}
await waitJobs(servers)
it('Should be well formed XML (covers RSS 2.0 and ATOM 1.0 endpoints)', async function () {
for (const feed of [ 'video-comments' as 'video-comments', 'videos' as 'videos' ]) {
- const rss = await getXMLfeed(servers[ 0 ].url, feed)
- expect(rss.text).xml.to.be.valid()
+ const rss = await servers[0].feedCommand.getXML({ feed })
+ expect(rss).xml.to.be.valid()
- const atom = await getXMLfeed(servers[ 0 ].url, feed, 'atom')
- expect(atom.text).xml.to.be.valid()
+ const atom = await servers[0].feedCommand.getXML({ feed, format: 'atom' })
+ expect(atom).xml.to.be.valid()
}
})
it('Should be well formed JSON (covers JSON feed 1.0 endpoint)', async function () {
for (const feed of [ 'video-comments' as 'video-comments', 'videos' as 'videos' ]) {
- const json = await getJSONfeed(servers[ 0 ].url, feed)
- expect(JSON.parse(json.text)).to.be.jsonSchema({ 'type': 'object' })
+ const jsonText = await servers[0].feedCommand.getJSON({ feed })
+ expect(JSON.parse(jsonText)).to.be.jsonSchema({ type: 'object' })
}
})
})
describe('Videos feed', function () {
+
it('Should contain a valid enclosure (covers RSS 2.0 endpoint)', async function () {
for (const server of servers) {
- const rss = await getXMLfeed(server.url, 'videos')
- const xmlDoc = libxmljs.parseXmlString(rss.text)
- const xmlEnclosure = xmlDoc.get('/rss/channel/item/enclosure')
- expect(xmlEnclosure).to.exist
- expect(xmlEnclosure.attr('type').value()).to.be.equal('application/x-bittorrent')
- expect(xmlEnclosure.attr('length').value()).to.be.equal('218910')
- expect(xmlEnclosure.attr('url').value()).to.contain('720.torrent')
+ const rss = await server.feedCommand.getXML({ feed: 'videos' })
+ expect(xmlParser.validate(rss)).to.be.true
+
+ const xmlDoc = xmlParser.parse(rss, { parseAttributeValue: true, ignoreAttributes: false })
+
+ const enclosure = xmlDoc.rss.channel.item[0].enclosure
+ expect(enclosure).to.exist
+ expect(enclosure['@_type']).to.equal('application/x-bittorrent')
+ expect(enclosure['@_length']).to.equal(218910)
+ expect(enclosure['@_url']).to.contain('720.torrent')
}
})
it('Should contain a valid \'attachments\' object (covers JSON feed 1.0 endpoint)', async function () {
for (const server of servers) {
- const json = await getJSONfeed(server.url, 'videos')
- const jsonObj = JSON.parse(json.text)
+ const json = await server.feedCommand.getJSON({ feed: 'videos' })
+ const jsonObj = JSON.parse(json)
expect(jsonObj.items.length).to.be.equal(2)
- expect(jsonObj.items[ 0 ].attachments).to.exist
- expect(jsonObj.items[ 0 ].attachments.length).to.be.eq(1)
- expect(jsonObj.items[ 0 ].attachments[ 0 ].mime_type).to.be.eq('application/x-bittorrent')
- expect(jsonObj.items[ 0 ].attachments[ 0 ].size_in_bytes).to.be.eq(218910)
- expect(jsonObj.items[ 0 ].attachments[ 0 ].url).to.contain('720.torrent')
+ expect(jsonObj.items[0].attachments).to.exist
+ expect(jsonObj.items[0].attachments.length).to.be.eq(1)
+ expect(jsonObj.items[0].attachments[0].mime_type).to.be.eq('application/x-bittorrent')
+ expect(jsonObj.items[0].attachments[0].size_in_bytes).to.be.eq(218910)
+ expect(jsonObj.items[0].attachments[0].url).to.contain('720.torrent')
}
})
it('Should filter by account', async function () {
+ {
+ const json = await servers[0].feedCommand.getJSON({ feed: 'videos', query: { accountId: rootAccountId } })
+ const jsonObj = JSON.parse(json)
+ expect(jsonObj.items.length).to.be.equal(1)
+ expect(jsonObj.items[0].title).to.equal('my super name for server 1')
+ expect(jsonObj.items[0].author.name).to.equal('root')
+ }
+
+ {
+ const json = await servers[0].feedCommand.getJSON({ feed: 'videos', query: { accountId: userAccountId } })
+ const jsonObj = JSON.parse(json)
+ expect(jsonObj.items.length).to.be.equal(1)
+ expect(jsonObj.items[0].title).to.equal('user video')
+ expect(jsonObj.items[0].author.name).to.equal('john')
+ }
+
for (const server of servers) {
{
- const json = await getJSONfeed(server.url, 'videos', { accountId: rootAccountUUID })
- const jsonObj = JSON.parse(json.text)
+ const json = await server.feedCommand.getJSON({ feed: 'videos', query: { accountName: 'root@localhost:' + servers[0].port } })
+ const jsonObj = JSON.parse(json)
expect(jsonObj.items.length).to.be.equal(1)
- expect(jsonObj.items[ 0 ].title).to.equal('my super name for server 1')
- expect(jsonObj.items[ 0 ].author.name).to.equal('root')
+ expect(jsonObj.items[0].title).to.equal('my super name for server 1')
}
{
- const json = await getJSONfeed(server.url, 'videos', { accountId: userAccountUUID })
- const jsonObj = JSON.parse(json.text)
+ const json = await server.feedCommand.getJSON({ feed: 'videos', query: { accountName: 'john@localhost:' + servers[0].port } })
+ const jsonObj = JSON.parse(json)
expect(jsonObj.items.length).to.be.equal(1)
- expect(jsonObj.items[ 0 ].title).to.equal('user video')
- expect(jsonObj.items[ 0 ].author.name).to.equal('john')
+ expect(jsonObj.items[0].title).to.equal('user video')
}
}
+ })
+ it('Should filter by video channel', async function () {
{
- const json = await getJSONfeed(servers[0].url, 'videos', { accountName: 'root' })
- const jsonObj = JSON.parse(json.text)
+ const json = await servers[0].feedCommand.getJSON({ feed: 'videos', query: { videoChannelId: rootChannelId } })
+ const jsonObj = JSON.parse(json)
expect(jsonObj.items.length).to.be.equal(1)
- expect(jsonObj.items[ 0 ].title).to.equal('my super name for server 1')
+ expect(jsonObj.items[0].title).to.equal('my super name for server 1')
+ expect(jsonObj.items[0].author.name).to.equal('root')
}
{
- const json = await getJSONfeed(servers[0].url, 'videos', { accountName: 'john' })
- const jsonObj = JSON.parse(json.text)
+ const json = await servers[0].feedCommand.getJSON({ feed: 'videos', query: { videoChannelId: userChannelId } })
+ const jsonObj = JSON.parse(json)
expect(jsonObj.items.length).to.be.equal(1)
- expect(jsonObj.items[ 0 ].title).to.equal('user video')
+ expect(jsonObj.items[0].title).to.equal('user video')
+ expect(jsonObj.items[0].author.name).to.equal('john')
}
- })
- it('Should filter by video channel', async function () {
for (const server of servers) {
{
- const json = await getJSONfeed(server.url, 'videos', { videoChannelId: rootChannelUUID })
- const jsonObj = JSON.parse(json.text)
+ const query = { videoChannelName: 'root_channel@localhost:' + servers[0].port }
+ const json = await server.feedCommand.getJSON({ feed: 'videos', query })
+ const jsonObj = JSON.parse(json)
expect(jsonObj.items.length).to.be.equal(1)
- expect(jsonObj.items[ 0 ].title).to.equal('my super name for server 1')
- expect(jsonObj.items[ 0 ].author.name).to.equal('root')
+ expect(jsonObj.items[0].title).to.equal('my super name for server 1')
}
{
- const json = await getJSONfeed(server.url, 'videos', { videoChannelId: userChannelUUID })
- const jsonObj = JSON.parse(json.text)
+ const query = { videoChannelName: 'john_channel@localhost:' + servers[0].port }
+ const json = await server.feedCommand.getJSON({ feed: 'videos', query })
+ const jsonObj = JSON.parse(json)
expect(jsonObj.items.length).to.be.equal(1)
- expect(jsonObj.items[ 0 ].title).to.equal('user video')
- expect(jsonObj.items[ 0 ].author.name).to.equal('john')
+ expect(jsonObj.items[0].title).to.equal('user video')
}
}
+ })
- {
- const json = await getJSONfeed(servers[0].url, 'videos', { videoChannelName: 'root_channel' })
- const jsonObj = JSON.parse(json.text)
- expect(jsonObj.items.length).to.be.equal(1)
- expect(jsonObj.items[ 0 ].title).to.equal('my super name for server 1')
- }
+ it('Should correctly have videos feed with HLS only', async function () {
+ this.timeout(120000)
- {
- const json = await getJSONfeed(servers[0].url, 'videos', { videoChannelName: 'john_channel' })
- const jsonObj = JSON.parse(json.text)
- expect(jsonObj.items.length).to.be.equal(1)
- expect(jsonObj.items[ 0 ].title).to.equal('user video')
+ await serverHLSOnly.videosCommand.upload({ attributes: { name: 'hls only video' } })
+
+ await waitJobs([ serverHLSOnly ])
+
+ const json = await serverHLSOnly.feedCommand.getJSON({ feed: 'videos' })
+ const jsonObj = JSON.parse(json)
+ expect(jsonObj.items.length).to.be.equal(1)
+ expect(jsonObj.items[0].attachments).to.exist
+ expect(jsonObj.items[0].attachments.length).to.be.eq(4)
+
+ for (let i = 0; i < 4; i++) {
+ expect(jsonObj.items[0].attachments[i].mime_type).to.be.eq('application/x-bittorrent')
+ expect(jsonObj.items[0].attachments[i].size_in_bytes).to.be.greaterThan(0)
+ expect(jsonObj.items[0].attachments[i].url).to.exist
}
})
})
describe('Video comments feed', function () {
- it('Should contain valid comments (covers JSON feed 1.0 endpoint)', async function () {
+
+ it('Should contain valid comments (covers JSON feed 1.0 endpoint) and not from unlisted videos', async function () {
for (const server of servers) {
- const json = await getJSONfeed(server.url, 'video-comments')
+ const json = await server.feedCommand.getJSON({ feed: 'video-comments' })
- const jsonObj = JSON.parse(json.text)
+ const jsonObj = JSON.parse(json)
+ expect(jsonObj.items.length).to.be.equal(2)
+ expect(jsonObj.items[0].html_content).to.equal('super comment 2')
+ expect(jsonObj.items[1].html_content).to.equal('super comment 1')
+ }
+ })
+
+ it('Should not list comments from muted accounts or instances', async function () {
+ this.timeout(30000)
+
+ const remoteHandle = 'root@localhost:' + servers[0].port
+
+ await servers[1].blocklistCommand.addToServerBlocklist({ account: remoteHandle })
+
+ {
+ const json = await servers[1].feedCommand.getJSON({ feed: 'video-comments', query: { version: 2 } })
+ const jsonObj = JSON.parse(json)
+ expect(jsonObj.items.length).to.be.equal(0)
+ }
+
+ await servers[1].blocklistCommand.removeFromServerBlocklist({ account: remoteHandle })
+
+ {
+ const videoUUID = (await servers[1].videosCommand.quickUpload({ name: 'server 2' })).uuid
+ await waitJobs(servers)
+ await servers[0].commentsCommand.createThread({ videoId: videoUUID, text: 'super comment' })
+ await waitJobs(servers)
+
+ const json = await servers[1].feedCommand.getJSON({ feed: 'video-comments', query: { version: 3 } })
+ const jsonObj = JSON.parse(json)
+ expect(jsonObj.items.length).to.be.equal(3)
+ }
+
+ await servers[1].blocklistCommand.addToMyBlocklist({ account: remoteHandle })
+
+ {
+ const json = await servers[1].feedCommand.getJSON({ feed: 'video-comments', query: { version: 4 } })
+ const jsonObj = JSON.parse(json)
expect(jsonObj.items.length).to.be.equal(2)
- expect(jsonObj.items[ 0 ].html_content).to.equal('super comment 2')
- expect(jsonObj.items[ 1 ].html_content).to.equal('super comment 1')
}
})
})
- after(async function () {
- killallServers(servers)
+ describe('Video feed from my subscriptions', function () {
+ let feeduserAccountId: number
+ let feeduserFeedToken: string
- // Keep the logs if the test failed
- if (this['ok']) {
- await flushTests()
- }
+ it('Should list no videos for a user with no videos and no subscriptions', async function () {
+ const attr = { username: 'feeduser', password: 'password' }
+ await servers[0].usersCommand.create({ username: attr.username, password: attr.password })
+ const feeduserAccessToken = await servers[0].loginCommand.getAccessToken(attr)
+
+ {
+ const user = await servers[0].usersCommand.getMyInfo({ token: feeduserAccessToken })
+ feeduserAccountId = user.account.id
+ }
+
+ {
+ const token = await servers[0].usersCommand.getMyScopedTokens({ token: feeduserAccessToken })
+ feeduserFeedToken = token.feedToken
+ }
+
+ {
+ const body = await servers[0].subscriptionsCommand.listVideos({ token: feeduserAccessToken })
+ expect(body.total).to.equal(0)
+
+ const query = { accountId: feeduserAccountId, token: feeduserFeedToken }
+ const json = await servers[0].feedCommand.getJSON({ feed: 'subscriptions', query })
+ const jsonObj = JSON.parse(json)
+ expect(jsonObj.items.length).to.be.equal(0) // no subscription, it should not list the instance's videos but list 0 videos
+ }
+ })
+
+ it('Should fail with an invalid token', async function () {
+ const query = { accountId: feeduserAccountId, token: 'toto' }
+ await servers[0].feedCommand.getJSON({ feed: 'subscriptions', query, expectedStatus: HttpStatusCode.FORBIDDEN_403 })
+ })
+
+ it('Should fail with a token of another user', async function () {
+ const query = { accountId: feeduserAccountId, token: userFeedToken }
+ await servers[0].feedCommand.getJSON({ feed: 'subscriptions', query, expectedStatus: HttpStatusCode.FORBIDDEN_403 })
+ })
+
+ it('Should list no videos for a user with videos but no subscriptions', async function () {
+ const body = await servers[0].subscriptionsCommand.listVideos({ token: userAccessToken })
+ expect(body.total).to.equal(0)
+
+ const query = { accountId: userAccountId, token: userFeedToken }
+ const json = await servers[0].feedCommand.getJSON({ feed: 'subscriptions', query })
+ const jsonObj = JSON.parse(json)
+ expect(jsonObj.items.length).to.be.equal(0) // no subscription, it should not list the instance's videos but list 0 videos
+ })
+
+ it('Should list self videos for a user with a subscription to themselves', async function () {
+ this.timeout(30000)
+
+ await servers[0].subscriptionsCommand.add({ token: userAccessToken, targetUri: 'john_channel@localhost:' + servers[0].port })
+ await waitJobs(servers)
+
+ {
+ const body = await servers[0].subscriptionsCommand.listVideos({ token: userAccessToken })
+ expect(body.total).to.equal(1)
+ expect(body.data[0].name).to.equal('user video')
+
+ const query = { accountId: userAccountId, token: userFeedToken, version: 1 }
+ const json = await servers[0].feedCommand.getJSON({ feed: 'subscriptions', query })
+ const jsonObj = JSON.parse(json)
+ expect(jsonObj.items.length).to.be.equal(1) // subscribed to self, it should not list the instance's videos but list john's
+ }
+ })
+
+ it('Should list videos of a user\'s subscription', async function () {
+ this.timeout(30000)
+
+ await servers[0].subscriptionsCommand.add({ token: userAccessToken, targetUri: 'root_channel@localhost:' + servers[0].port })
+ await waitJobs(servers)
+
+ {
+ const body = await servers[0].subscriptionsCommand.listVideos({ token: userAccessToken })
+ expect(body.total).to.equal(2, "there should be 2 videos part of the subscription")
+
+ const query = { accountId: userAccountId, token: userFeedToken, version: 2 }
+ const json = await servers[0].feedCommand.getJSON({ feed: 'subscriptions', query })
+ const jsonObj = JSON.parse(json)
+ expect(jsonObj.items.length).to.be.equal(2) // subscribed to root, it should not list the instance's videos but list root/john's
+ }
+ })
+
+ it('Should renew the token, and so have an invalid old token', async function () {
+ await servers[0].usersCommand.renewMyScopedTokens({ token: userAccessToken })
+
+ const query = { accountId: userAccountId, token: userFeedToken, version: 3 }
+ await servers[0].feedCommand.getJSON({ feed: 'subscriptions', query, expectedStatus: HttpStatusCode.FORBIDDEN_403 })
+ })
+
+ it('Should succeed with the new token', async function () {
+ const token = await servers[0].usersCommand.getMyScopedTokens({ token: userAccessToken })
+ userFeedToken = token.feedToken
+
+ const query = { accountId: userAccountId, token: userFeedToken, version: 4 }
+ await servers[0].feedCommand.getJSON({ feed: 'subscriptions', query })
+ })
+
+ })
+
+ after(async function () {
+ await cleanupTests([ ...servers, serverHLSOnly ])
})
})
projects / github / Chocobozzz / PeerTube.git / blobdiff