-/* tslint:disable:no-unused-expression */
+/* eslint-disable @typescript-eslint/no-unused-expressions,@typescript-eslint/require-await */
-import * as request from 'supertest'
-import { join } from 'path'
import 'mocha'
import * as chai from 'chai'
-const expect = chai.expect
-
+import { omit } from 'lodash'
+import { join } from 'path'
+import { randomInt } from '@shared/core-utils'
+import { PeerTubeProblemDocument, VideoCreateResult } from '@shared/models'
+import { HttpStatusCode } from '../../../../shared/core-utils/miscs/http-error-codes'
import {
- ServerInfo,
- flushTests,
- runServer,
+ checkUploadVideoParam,
+ cleanupTests,
+ createUser,
+ flushAndRunServer,
+ getMyUserInformation,
+ getVideo,
getVideosList,
+ immutableAssign,
+ makeDeleteRequest,
+ makeGetRequest,
makePutBodyRequest,
+ makeUploadRequest,
+ removeVideo,
+ root,
+ ServerInfo,
setAccessTokensToServers,
- killallServers,
- makePostUploadRequest,
- getMyUserInformation,
- createUser,
- getUserAccessToken
-} from '../../utils'
+ userLogin
+} from '../../../../shared/extra-utils'
+import {
+ checkBadCountPagination,
+ checkBadSortPagination,
+ checkBadStartPagination
+} from '../../../../shared/extra-utils/requests/check-api-params'
+import { VideoPrivacy } from '../../../../shared/models/videos/video-privacy.enum'
+
+const expect = chai.expect
describe('Test videos API validator', function () {
const path = '/api/v1/videos/'
let server: ServerInfo
+ let userAccessToken = ''
+ let accountName: string
let channelId: number
+ let channelName: string
+ let video: VideoCreateResult
// ---------------------------------------------------------------
before(async function () {
- this.timeout(20000)
-
- await flushTests()
+ this.timeout(30000)
- server = await runServer(1)
+ server = await flushAndRunServer(1)
await setAccessTokensToServers([ server ])
- const res = await getMyUserInformation(server.url, server.accessToken)
- channelId = res.body.videoChannels[0].id
+ const username = 'user1'
+ const password = 'my super password'
+ await createUser({ url: server.url, accessToken: server.accessToken, username: username, password: password })
+ userAccessToken = await userLogin(server, { username, password })
+
+ {
+ const res = await getMyUserInformation(server.url, server.accessToken)
+ channelId = res.body.videoChannels[0].id
+ channelName = res.body.videoChannels[0].name
+ accountName = res.body.account.name + '@' + res.body.account.host
+ }
})
- describe('When listing a video', function () {
+ describe('When listing videos', function () {
it('Should fail with a bad start pagination', async function () {
- await request(server.url)
- .get(path)
- .query({ start: 'hello' })
- .set('Accept', 'application/json')
- .expect(400)
+ await checkBadStartPagination(server.url, path)
})
it('Should fail with a bad count pagination', async function () {
- await request(server.url)
- .get(path)
- .query({ count: 'hello' })
- .set('Accept', 'application/json')
- .expect(400)
+ await checkBadCountPagination(server.url, path)
})
it('Should fail with an incorrect sort', async function () {
- await request(server.url)
- .get(path)
- .query({ sort: 'hello' })
- .set('Accept', 'application/json')
- .expect(400)
+ await checkBadSortPagination(server.url, path)
+ })
+
+ it('Should fail with a bad skipVideos query', async function () {
+ await makeGetRequest({ url: server.url, path, statusCodeExpected: HttpStatusCode.OK_200, query: { skipCount: 'toto' } })
+ })
+
+ it('Should success with the correct parameters', async function () {
+ await makeGetRequest({ url: server.url, path, statusCodeExpected: HttpStatusCode.OK_200, query: { skipCount: false } })
})
})
describe('When searching a video', function () {
+
it('Should fail with nothing', async function () {
- await request(server.url)
- .get(join(path, 'search'))
- .set('Accept', 'application/json')
- .expect(400)
+ await makeGetRequest({
+ url: server.url,
+ path: join(path, 'search'),
+ statusCodeExpected: HttpStatusCode.BAD_REQUEST_400
+ })
})
it('Should fail with a bad start pagination', async function () {
- await request(server.url)
- .get(join(path, 'search', 'test'))
- .query({ start: 'hello' })
- .set('Accept', 'application/json')
- .expect(400)
+ await checkBadStartPagination(server.url, join(path, 'search', 'test'))
})
it('Should fail with a bad count pagination', async function () {
- await request(server.url)
- .get(join(path, 'search', 'test'))
- .query({ count: 'hello' })
- .set('Accept', 'application/json')
- .expect(400)
+ await checkBadCountPagination(server.url, join(path, 'search', 'test'))
})
it('Should fail with an incorrect sort', async function () {
- await request(server.url)
- .get(join(path, 'search', 'test'))
- .query({ sort: 'hello' })
- .set('Accept', 'application/json')
- .expect(400)
+ await checkBadSortPagination(server.url, join(path, 'search', 'test'))
})
- })
- describe('When adding a video', function () {
- it('Should fail with nothing', async function () {
- const fields = {}
- const attaches = {}
- await makePostUploadRequest({ url: server.url, path: path + '/upload', token: server.accessToken, fields, attaches })
+ it('Should success with the correct parameters', async function () {
+ await makeGetRequest({ url: server.url, path, statusCodeExpected: HttpStatusCode.OK_200 })
})
+ })
- it('Should fail without name', async function () {
- const fields = {
- category: 5,
- licence: 1,
- language: 6,
- nsfw: false,
- description: 'my super description',
- tags: [ 'tag1', 'tag2' ],
- channelId
- }
- const attaches = {
- 'videofile': join(__dirname, '..', 'fixtures', 'video_short.webm')
- }
- await makePostUploadRequest({ url: server.url, path: path + '/upload', token: server.accessToken, fields, attaches })
+ describe('When listing my videos', function () {
+ const path = '/api/v1/users/me/videos'
+
+ it('Should fail with a bad start pagination', async function () {
+ await checkBadStartPagination(server.url, path, server.accessToken)
})
- it('Should fail with a long name', async function () {
- const fields = {
- name: 'My very very very very very very very very very very very very very very very very very ' +
- 'very very very very very very very very very very very very very very very very long long' +
- 'very very very very very very very very very very very very very very very very long name',
- category: 5,
- licence: 1,
- language: 6,
- nsfw: false,
- description: 'my super description',
- tags: [ 'tag1', 'tag2' ],
- channelId
- }
- const attaches = {
- 'videofile': join(__dirname, '..', 'fixtures', 'video_short.webm')
- }
- await makePostUploadRequest({ url: server.url, path: path + '/upload', token: server.accessToken, fields, attaches })
+ it('Should fail with a bad count pagination', async function () {
+ await checkBadCountPagination(server.url, path, server.accessToken)
})
- it('Should fail without a category', async function () {
- const fields = {
- name: 'my super name',
- licence: 1,
- language: 6,
- nsfw: false,
- description: 'my super description',
- tags: [ 'tag1', 'tag2' ],
- channelId
- }
- const attaches = {
- 'videofile': join(__dirname, '..', 'fixtures', 'video_short.webm')
- }
- await makePostUploadRequest({ url: server.url, path: path + '/upload', token: server.accessToken, fields, attaches })
+ it('Should fail with an incorrect sort', async function () {
+ await checkBadSortPagination(server.url, path, server.accessToken)
})
- it('Should fail with a bad category', async function () {
- const fields = {
- name: 'my super name',
- category: 125,
- licence: 1,
- language: 6,
- nsfw: false,
- description: 'my super description',
- tags: [ 'tag1', 'tag2' ],
- channelId
- }
- const attaches = {
- 'videofile': join(__dirname, '..', 'fixtures', 'video_short.webm')
- }
- await makePostUploadRequest({ url: server.url, path: path + '/upload', token: server.accessToken, fields, attaches })
+ it('Should success with the correct parameters', async function () {
+ await makeGetRequest({ url: server.url, token: server.accessToken, path, statusCodeExpected: HttpStatusCode.OK_200 })
})
+ })
- it('Should fail without a licence', async function () {
- const fields = {
- name: 'my super name',
- category: 5,
- language: 6,
- nsfw: false,
- description: 'my super description',
- tags: [ 'tag1', 'tag2' ],
- channelId
- }
- const attaches = {
- 'videofile': join(__dirname, '..', 'fixtures', 'video_short.webm')
- }
- await makePostUploadRequest({ url: server.url, path: path + '/upload', token: server.accessToken, fields, attaches })
+ describe('When listing account videos', function () {
+ let path: string
+
+ before(async function () {
+ path = '/api/v1/accounts/' + accountName + '/videos'
})
- it('Should fail with a bad licence', async function () {
- const fields = {
- name: 'my super name',
- category: 5,
- licence: 125,
- language: 6,
- nsfw: false,
- description: 'my super description',
- tags: [ 'tag1', 'tag2' ],
- channelId
- }
- const attaches = {
- 'videofile': join(__dirname, '..', 'fixtures', 'video_short.webm')
- }
- await makePostUploadRequest({ url: server.url, path: path + '/upload', token: server.accessToken, fields, attaches })
+ it('Should fail with a bad start pagination', async function () {
+ await checkBadStartPagination(server.url, path, server.accessToken)
})
- it('Should fail with a bad language', async function () {
- const fields = {
- name: 'my super name',
- category: 5,
- licence: 4,
- language: 563,
- nsfw: false,
- description: 'my super description',
- tags: [ 'tag1', 'tag2' ],
- channelId
- }
- const attaches = {
- 'videofile': join(__dirname, '..', 'fixtures', 'video_short.webm')
- }
- await makePostUploadRequest({ url: server.url, path: path + '/upload', token: server.accessToken, fields, attaches })
+ it('Should fail with a bad count pagination', async function () {
+ await checkBadCountPagination(server.url, path, server.accessToken)
})
- it('Should fail without nsfw attribute', async function () {
- const fields = {
- name: 'my super name',
- category: 5,
- licence: 4,
- language: 6,
- description: 'my super description',
- tags: [ 'tag1', 'tag2' ],
- channelId
- }
- const attaches = {
- 'videofile': join(__dirname, '..', 'fixtures', 'video_short.webm')
- }
- await makePostUploadRequest({ url: server.url, path: path + '/upload', token: server.accessToken, fields, attaches })
+ it('Should fail with an incorrect sort', async function () {
+ await checkBadSortPagination(server.url, path, server.accessToken)
})
- it('Should fail with a bad nsfw attribute', async function () {
- const fields = {
- name: 'my super name',
- category: 5,
- licence: 4,
- language: 6,
- nsfw: 2,
- description: 'my super description',
- tags: [ 'tag1', 'tag2' ],
- channelId
- }
- const attaches = {
- 'videofile': join(__dirname, '..', 'fixtures', 'video_short.webm')
- }
- await makePostUploadRequest({ url: server.url, path: path + '/upload', token: server.accessToken, fields, attaches })
+ it('Should success with the correct parameters', async function () {
+ await makeGetRequest({ url: server.url, path, statusCodeExpected: HttpStatusCode.OK_200 })
})
+ })
- it('Should fail without description', async function () {
- const fields = {
- name: 'my super name',
- category: 5,
- licence: 1,
- language: 6,
- nsfw: false,
- tags: [ 'tag1', 'tag2' ],
- channelId
- }
- const attaches = {
- 'videofile': join(__dirname, '..', 'fixtures', 'video_short.webm')
- }
- await makePostUploadRequest({ url: server.url, path: path + '/upload', token: server.accessToken, fields, attaches })
+ describe('When listing video channel videos', function () {
+ let path: string
+
+ before(async function () {
+ path = '/api/v1/video-channels/' + channelName + '/videos'
})
- it('Should fail with a long description', async function () {
- const fields = {
- name: 'my super name',
- category: 5,
- licence: 1,
- language: 6,
- nsfw: false,
- description: 'my super description which is very very very very very very very very very very very very very very' +
- 'very very very very very very very very very very very very very very very very very very very very very' +
- 'very very very very very very very very very very very very very very very long',
- tags: [ 'tag1', 'tag2' ],
- channelId
- }
- const attaches = {
- 'videofile': join(__dirname, '..', 'fixtures', 'video_short.webm')
- }
- await makePostUploadRequest({ url: server.url, path: path + '/upload', token: server.accessToken, fields, attaches })
+ it('Should fail with a bad start pagination', async function () {
+ await checkBadStartPagination(server.url, path, server.accessToken)
})
- it('Should fail without a channel', async function () {
- const fields = {
- name: 'my super name',
- category: 5,
- licence: 1,
- language: 6,
- nsfw: false,
- description: 'my super description',
- tags: [ 'tag1', 'tag2' ]
- }
- const attaches = {
- 'videofile': join(__dirname, '..', 'fixtures', 'video_short.webm')
- }
- await makePostUploadRequest({ url: server.url, path: path + '/upload', token: server.accessToken, fields, attaches })
+ it('Should fail with a bad count pagination', async function () {
+ await checkBadCountPagination(server.url, path, server.accessToken)
})
- it('Should fail with a bad channel', async function () {
- const fields = {
- name: 'my super name',
- category: 5,
- licence: 1,
- language: 6,
- nsfw: false,
- description: 'my super description',
- tags: [ 'tag1', 'tag2' ],
- channelId: 545454
- }
- const attaches = {
- 'videofile': join(__dirname, '..', 'fixtures', 'video_short.webm')
- }
- await makePostUploadRequest({ url: server.url, path: path + '/upload', token: server.accessToken, fields, attaches })
+ it('Should fail with an incorrect sort', async function () {
+ await checkBadSortPagination(server.url, path, server.accessToken)
})
- it('Should fail with another user channel', async function () {
- const user = {
- username: 'fake',
- password: 'fake_password'
- }
- await createUser(server.url, server.accessToken, user.username, user.password)
+ it('Should success with the correct parameters', async function () {
+ await makeGetRequest({ url: server.url, path, statusCodeExpected: HttpStatusCode.OK_200 })
+ })
+ })
- const accessTokenUser = await getUserAccessToken(server, user)
- const res = await getMyUserInformation(server.url, accessTokenUser)
- const channelId = res.body.videoChannels[0].id
+ describe('When adding a video', function () {
+ let baseCorrectParams
+ const baseCorrectAttaches = {
+ fixture: join(root(), 'server', 'tests', 'fixtures', 'video_short.webm')
+ }
- const fields = {
+ before(function () {
+ // Put in before to have channelId
+ baseCorrectParams = {
name: 'my super name',
category: 5,
licence: 1,
- language: 6,
+ language: 'pt',
nsfw: false,
+ commentsEnabled: true,
+ downloadEnabled: true,
+ waitTranscoding: true,
description: 'my super description',
+ support: 'my super support text',
tags: [ 'tag1', 'tag2' ],
- channelId
+ privacy: VideoPrivacy.PUBLIC,
+ channelId: channelId,
+ originallyPublishedAt: new Date().toISOString()
}
- const attaches = {
- 'videofile': join(__dirname, '..', 'fixtures', 'video_short.webm')
- }
- await makePostUploadRequest({ url: server.url, path: path + '/upload', token: server.accessToken, fields, attaches })
})
- it('Should fail with too many tags', async function () {
- const fields = {
- name: 'my super name',
- category: 5,
- licence: 1,
- language: 6,
- nsfw: false,
- description: 'my super description',
- tags: [ 'tag1', 'tag2', 'tag3', 'tag4', 'tag5', 'tag6' ],
- channelId
- }
- const attaches = {
- 'videofile': join(__dirname, '..', 'fixtures', 'video_short.webm')
- }
- await makePostUploadRequest({ url: server.url, path: path + '/upload', token: server.accessToken, fields, attaches })
- })
+ function runSuite (mode: 'legacy' | 'resumable') {
- it('Should fail with a tag length too low', async function () {
- const fields = {
- name: 'my super name',
- category: 5,
- licence: 1,
- language: 6,
- nsfw: false,
- description: 'my super description',
- tags: [ 'tag1', 't' ],
- channelId
- }
- const attaches = {
- 'videofile': join(__dirname, '..', 'fixtures', 'video_short.webm')
- }
- await makePostUploadRequest({ url: server.url, path: path + '/upload', token: server.accessToken, fields, attaches })
- })
+ it('Should fail with nothing', async function () {
+ const fields = {}
+ const attaches = {}
+ await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.BAD_REQUEST_400, mode)
+ })
- it('Should fail with a tag length too big', async function () {
- const fields = {
- name: 'my super name',
- category: 5,
- licence: 1,
- language: 6,
- nsfw: false,
- description: 'my super description',
- tags: [ 'my_super_tag_too_long_long_long_long_long_long', 'tag1' ],
- channelId
- }
- const attaches = {
- 'videofile': join(__dirname, '..', 'fixtures', 'video_short.webm')
- }
- await makePostUploadRequest({ url: server.url, path: path + '/upload', token: server.accessToken, fields, attaches })
- })
+ it('Should fail without name', async function () {
+ const fields = omit(baseCorrectParams, 'name')
+ const attaches = baseCorrectAttaches
- it('Should fail without an input file', async function () {
- const fields = {
- name: 'my super name',
- category: 5,
- licence: 1,
- language: 6,
- nsfw: false,
- description: 'my super description',
- tags: [ 'tag1', 'tag2' ],
- channelId
- }
- const attaches = {}
- await makePostUploadRequest({ url: server.url, path: path + '/upload', token: server.accessToken, fields, attaches })
- })
+ await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.BAD_REQUEST_400, mode)
+ })
- it('Should fail without an incorrect input file', async function () {
- const fields = {
- name: 'my super name',
- category: 5,
- licence: 1,
- language: 6,
- nsfw: false,
- description: 'my super description',
- tags: [ 'tag1', 'tag2' ],
- channelId
- }
- const attaches = {
- 'videofile': join(__dirname, '..', 'fixtures', 'video_short_fake.webm')
- }
- await makePostUploadRequest({ url: server.url, path: path + '/upload', token: server.accessToken, fields, attaches })
- })
+ it('Should fail with a long name', async function () {
+ const fields = immutableAssign(baseCorrectParams, { name: 'super'.repeat(65) })
+ const attaches = baseCorrectAttaches
- it('Should fail with a too big duration', async function () {
- const fields = {
- name: 'my super name',
- category: 5,
- licence: 1,
- language: 6,
- nsfw: false,
- description: 'my super description',
- tags: [ 'tag1', 'tag2' ],
- channelId
- }
- const attaches = {
- 'videofile': join(__dirname, '..', 'fixtures', 'video_too_long.webm')
- }
- await makePostUploadRequest({ url: server.url, path: path + '/upload', token: server.accessToken, fields, attaches })
- })
+ await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.BAD_REQUEST_400, mode)
+ })
- it('Should succeed with the correct parameters', async function () {
- this.timeout(10000)
+ it('Should fail with a bad category', async function () {
+ const fields = immutableAssign(baseCorrectParams, { category: 125 })
+ const attaches = baseCorrectAttaches
- const fields = {
- name: 'my super name',
- category: 5,
- licence: 1,
- language: 6,
- nsfw: false,
- description: 'my super description',
- tags: [ 'tag1', 'tag2' ],
- channelId
- }
- const attaches = {
- 'videofile': join(__dirname, '..', 'fixtures', 'video_short.webm')
- }
+ await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.BAD_REQUEST_400, mode)
+ })
- await makePostUploadRequest({
- url: server.url,
- path: path + '/upload',
- token: server.accessToken,
- fields,
- attaches,
- statusCodeExpected: 204
+ it('Should fail with a bad licence', async function () {
+ const fields = immutableAssign(baseCorrectParams, { licence: 125 })
+ const attaches = baseCorrectAttaches
+
+ await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.BAD_REQUEST_400, mode)
})
- attaches.videofile = join(__dirname, '..', 'fixtures', 'video_short.mp4')
- await makePostUploadRequest({
- url: server.url,
- path: path + '/upload',
- token: server.accessToken,
- fields,
- attaches,
- statusCodeExpected: 204
+ it('Should fail with a bad language', async function () {
+ const fields = immutableAssign(baseCorrectParams, { language: 'a'.repeat(15) })
+ const attaches = baseCorrectAttaches
+
+ await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.BAD_REQUEST_400, mode)
})
- attaches.videofile = join(__dirname, '..', 'fixtures', 'video_short.ogv')
- await makePostUploadRequest({
- url: server.url,
- path: path + '/upload',
- token: server.accessToken,
- fields,
- attaches,
- statusCodeExpected: 204
+ it('Should fail with a long description', async function () {
+ const fields = immutableAssign(baseCorrectParams, { description: 'super'.repeat(2500) })
+ const attaches = baseCorrectAttaches
+
+ await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.BAD_REQUEST_400, mode)
+ })
+
+ it('Should fail with a long support text', async function () {
+ const fields = immutableAssign(baseCorrectParams, { support: 'super'.repeat(201) })
+ const attaches = baseCorrectAttaches
+
+ await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.BAD_REQUEST_400, mode)
+ })
+
+ it('Should fail without a channel', async function () {
+ const fields = omit(baseCorrectParams, 'channelId')
+ const attaches = baseCorrectAttaches
+
+ await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.BAD_REQUEST_400, mode)
+ })
+
+ it('Should fail with a bad channel', async function () {
+ const fields = immutableAssign(baseCorrectParams, { channelId: 545454 })
+ const attaches = baseCorrectAttaches
+
+ await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.BAD_REQUEST_400, mode)
+ })
+
+ it('Should fail with another user channel', async function () {
+ const user = {
+ username: 'fake' + randomInt(0, 1500),
+ password: 'fake_password'
+ }
+ await createUser({ url: server.url, accessToken: server.accessToken, username: user.username, password: user.password })
+
+ const accessTokenUser = await userLogin(server, user)
+ const res = await getMyUserInformation(server.url, accessTokenUser)
+ const customChannelId = res.body.videoChannels[0].id
+
+ const fields = immutableAssign(baseCorrectParams, { channelId: customChannelId })
+ const attaches = baseCorrectAttaches
+
+ await checkUploadVideoParam(server.url, userAccessToken, { ...fields, ...attaches }, HttpStatusCode.BAD_REQUEST_400, mode)
+ })
+
+ it('Should fail with too many tags', async function () {
+ const fields = immutableAssign(baseCorrectParams, { tags: [ 'tag1', 'tag2', 'tag3', 'tag4', 'tag5', 'tag6' ] })
+ const attaches = baseCorrectAttaches
+
+ await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.BAD_REQUEST_400, mode)
+ })
+
+ it('Should fail with a tag length too low', async function () {
+ const fields = immutableAssign(baseCorrectParams, { tags: [ 'tag1', 't' ] })
+ const attaches = baseCorrectAttaches
+
+ await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.BAD_REQUEST_400, mode)
+ })
+
+ it('Should fail with a tag length too big', async function () {
+ const fields = immutableAssign(baseCorrectParams, { tags: [ 'tag1', 'my_super_tag_too_long_long_long_long_long_long' ] })
+ const attaches = baseCorrectAttaches
+
+ await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.BAD_REQUEST_400, mode)
+ })
+
+ it('Should fail with a bad schedule update (miss updateAt)', async function () {
+ const fields = immutableAssign(baseCorrectParams, { scheduleUpdate: { privacy: VideoPrivacy.PUBLIC } })
+ const attaches = baseCorrectAttaches
+
+ await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.BAD_REQUEST_400, mode)
+ })
+
+ it('Should fail with a bad schedule update (wrong updateAt)', async function () {
+ const fields = immutableAssign(baseCorrectParams, {
+ scheduleUpdate: {
+ privacy: VideoPrivacy.PUBLIC,
+ updateAt: 'toto'
+ }
+ })
+ const attaches = baseCorrectAttaches
+
+ await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.BAD_REQUEST_400, mode)
+ })
+
+ it('Should fail with a bad originally published at attribute', async function () {
+ const fields = immutableAssign(baseCorrectParams, { originallyPublishedAt: 'toto' })
+ const attaches = baseCorrectAttaches
+
+ await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.BAD_REQUEST_400, mode)
+ })
+
+ it('Should fail without an input file', async function () {
+ const fields = baseCorrectParams
+ const attaches = {}
+ await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.BAD_REQUEST_400, mode)
+ })
+
+ it('Should fail with an incorrect input file', async function () {
+ const fields = baseCorrectParams
+ let attaches = { fixture: join(root(), 'server', 'tests', 'fixtures', 'video_short_fake.webm') }
+
+ await checkUploadVideoParam(
+ server.url,
+ server.accessToken,
+ { ...fields, ...attaches },
+ HttpStatusCode.UNPROCESSABLE_ENTITY_422,
+ mode
+ )
+
+ attaches = { fixture: join(root(), 'server', 'tests', 'fixtures', 'video_short.mkv') }
+ await checkUploadVideoParam(
+ server.url,
+ server.accessToken,
+ { ...fields, ...attaches },
+ HttpStatusCode.UNSUPPORTED_MEDIA_TYPE_415,
+ mode
+ )
+ })
+
+ it('Should fail with an incorrect thumbnail file', async function () {
+ const fields = baseCorrectParams
+ const attaches = {
+ thumbnailfile: join(root(), 'server', 'tests', 'fixtures', 'video_short.mp4'),
+ fixture: join(root(), 'server', 'tests', 'fixtures', 'video_short.mp4')
+ }
+
+ await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.BAD_REQUEST_400, mode)
+ })
+
+ it('Should fail with a big thumbnail file', async function () {
+ const fields = baseCorrectParams
+ const attaches = {
+ thumbnailfile: join(root(), 'server', 'tests', 'fixtures', 'preview-big.png'),
+ fixture: join(root(), 'server', 'tests', 'fixtures', 'video_short.mp4')
+ }
+
+ await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.BAD_REQUEST_400, mode)
+ })
+
+ it('Should fail with an incorrect preview file', async function () {
+ const fields = baseCorrectParams
+ const attaches = {
+ previewfile: join(root(), 'server', 'tests', 'fixtures', 'video_short.mp4'),
+ fixture: join(root(), 'server', 'tests', 'fixtures', 'video_short.mp4')
+ }
+
+ await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.BAD_REQUEST_400, mode)
+ })
+
+ it('Should fail with a big preview file', async function () {
+ const fields = baseCorrectParams
+ const attaches = {
+ previewfile: join(root(), 'server', 'tests', 'fixtures', 'preview-big.png'),
+ fixture: join(root(), 'server', 'tests', 'fixtures', 'video_short.mp4')
+ }
+
+ await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.BAD_REQUEST_400, mode)
})
+
+ it('Should report the appropriate error', async function () {
+ const fields = immutableAssign(baseCorrectParams, { language: 'a'.repeat(15) })
+ const attaches = baseCorrectAttaches
+
+ const attributes = { ...fields, ...attaches }
+ const res = await checkUploadVideoParam(server.url, server.accessToken, attributes, HttpStatusCode.BAD_REQUEST_400, mode)
+
+ const error = res.body as PeerTubeProblemDocument
+
+ if (mode === 'legacy') {
+ expect(error.docs).to.equal('https://docs.joinpeertube.org/api-rest-reference.html#operation/uploadLegacy')
+ } else {
+ expect(error.docs).to.equal('https://docs.joinpeertube.org/api-rest-reference.html#operation/uploadResumableInit')
+ }
+
+ expect(error.type).to.equal('about:blank')
+ expect(error.title).to.equal('Bad Request')
+
+ expect(error.detail).to.equal('Incorrect request parameters: language')
+ expect(error.error).to.equal('Incorrect request parameters: language')
+
+ expect(error.status).to.equal(HttpStatusCode.BAD_REQUEST_400)
+ expect(error['invalid-params'].language).to.exist
+ })
+
+ it('Should succeed with the correct parameters', async function () {
+ this.timeout(10000)
+
+ const fields = baseCorrectParams
+
+ {
+ const attaches = baseCorrectAttaches
+ await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.OK_200, mode)
+ }
+
+ {
+ const attaches = immutableAssign(baseCorrectAttaches, {
+ videofile: join(root(), 'server', 'tests', 'fixtures', 'video_short.mp4')
+ })
+
+ await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.OK_200, mode)
+ }
+
+ {
+ const attaches = immutableAssign(baseCorrectAttaches, {
+ videofile: join(root(), 'server', 'tests', 'fixtures', 'video_short.ogv')
+ })
+
+ await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.OK_200, mode)
+ }
+ })
+ }
+
+ describe('Resumable upload', function () {
+ runSuite('resumable')
+ })
+
+ describe('Legacy upload', function () {
+ runSuite('legacy')
})
})
describe('When updating a video', function () {
- let videoId
+ const baseCorrectParams = {
+ name: 'my super name',
+ category: 5,
+ licence: 2,
+ language: 'pt',
+ nsfw: false,
+ commentsEnabled: false,
+ downloadEnabled: false,
+ description: 'my super description',
+ privacy: VideoPrivacy.PUBLIC,
+ tags: [ 'tag1', 'tag2' ]
+ }
before(async function () {
const res = await getVideosList(server.url)
- videoId = res.body.data[0].id
+ video = res.body.data[0]
})
it('Should fail with nothing', async function () {
})
it('Should fail without a valid uuid', async function () {
- const fields = {
- category: 5,
- licence: 2,
- language: 6,
- nsfw: false,
- description: 'my super description',
- tags: [ 'tag1', 'tag2' ]
- }
+ const fields = baseCorrectParams
await makePutBodyRequest({ url: server.url, path: path + 'blabla', token: server.accessToken, fields })
})
it('Should fail with an unknown id', async function () {
- const fields = {
- category: 5,
- licence: 2,
- language: 6,
- nsfw: false,
- description: 'my super description',
- tags: [ 'tag1', 'tag2' ]
- }
+ const fields = baseCorrectParams
+
await makePutBodyRequest({
url: server.url,
path: path + '4da6fde3-88f7-4d16-b119-108df5630b06',
token: server.accessToken,
fields,
- statusCodeExpected: 404
+ statusCodeExpected: HttpStatusCode.NOT_FOUND_404
})
})
it('Should fail with a long name', async function () {
- const fields = {
- name: 'My very very very very very very very very very very very very very very very very very ' +
- 'very very very very very very very very very very very very very very very very long long' +
- 'very very very very very very very very very very very very very very very very long name',
- category: 5,
- licence: 2,
- language: 6,
- nsfw: false,
- description: 'my super description',
- tags: [ 'tag1', 'tag2' ]
- }
- await makePutBodyRequest({ url: server.url, path: path + videoId, token: server.accessToken, fields })
+ const fields = immutableAssign(baseCorrectParams, { name: 'super'.repeat(65) })
+
+ await makePutBodyRequest({ url: server.url, path: path + video.shortUUID, token: server.accessToken, fields })
})
it('Should fail with a bad category', async function () {
- const fields = {
- name: 'my super name',
- category: 128,
- licence: 2,
- language: 6,
- nsfw: false,
- description: 'my super description',
- tags: [ 'tag1', 'tag2' ]
- }
- await makePutBodyRequest({ url: server.url, path: path + videoId, token: server.accessToken, fields })
+ const fields = immutableAssign(baseCorrectParams, { category: 125 })
+
+ await makePutBodyRequest({ url: server.url, path: path + video.shortUUID, token: server.accessToken, fields })
})
it('Should fail with a bad licence', async function () {
- const fields = {
- name: 'my super name',
- category: 5,
- licence: 128,
- language: 6,
- nsfw: false,
- description: 'my super description',
- tags: [ 'tag1', 'tag2' ]
- }
- await makePutBodyRequest({ url: server.url, path: path + videoId, token: server.accessToken, fields })
+ const fields = immutableAssign(baseCorrectParams, { licence: 125 })
+
+ await makePutBodyRequest({ url: server.url, path: path + video.shortUUID, token: server.accessToken, fields })
})
it('Should fail with a bad language', async function () {
- const fields = {
- name: 'my super name',
- category: 5,
- licence: 3,
- language: 896,
- nsfw: false,
- description: 'my super description',
- tags: [ 'tag1', 'tag2' ]
- }
- await makePutBodyRequest({ url: server.url, path: path + videoId, token: server.accessToken, fields })
- })
+ const fields = immutableAssign(baseCorrectParams, { language: 'a'.repeat(15) })
- it('Should fail with a bad nsfw attribute', async function () {
- const fields = {
- name: 'my super name',
- category: 5,
- licence: 5,
- language: 6,
- nsfw: -4,
- description: 'my super description',
- tags: [ 'tag1', 'tag2' ]
- }
- await makePutBodyRequest({ url: server.url, path: path + videoId, token: server.accessToken, fields })
+ await makePutBodyRequest({ url: server.url, path: path + video.shortUUID, token: server.accessToken, fields })
})
it('Should fail with a long description', async function () {
- const fields = {
- name: 'my super name',
- category: 5,
- licence: 2,
- language: 6,
- nsfw: false,
- description: 'my super description which is very very very very very very very very very very very very very very' +
- 'very very very very very very very very very very very very very very very very very very very very very' +
- 'very very very very very very very very very very very very very very very long',
- tags: [ 'tag1', 'tag2' ]
- }
- await makePutBodyRequest({ url: server.url, path: path + videoId, token: server.accessToken, fields })
+ const fields = immutableAssign(baseCorrectParams, { description: 'super'.repeat(2500) })
+
+ await makePutBodyRequest({ url: server.url, path: path + video.shortUUID, token: server.accessToken, fields })
+ })
+
+ it('Should fail with a long support text', async function () {
+ const fields = immutableAssign(baseCorrectParams, { support: 'super'.repeat(201) })
+
+ await makePutBodyRequest({ url: server.url, path: path + video.shortUUID, token: server.accessToken, fields })
+ })
+
+ it('Should fail with a bad channel', async function () {
+ const fields = immutableAssign(baseCorrectParams, { channelId: 545454 })
+
+ await makePutBodyRequest({ url: server.url, path: path + video.shortUUID, token: server.accessToken, fields })
})
it('Should fail with too many tags', async function () {
- const fields = {
- name: 'my super name',
- category: 5,
- licence: 2,
- language: 6,
- nsfw: false,
- description: 'my super description',
- tags: [ 'tag1', 'tag2', 'tag3', 'tag4', 'tag5', 'tag6' ]
- }
- await makePutBodyRequest({ url: server.url, path: path + videoId, token: server.accessToken, fields })
+ const fields = immutableAssign(baseCorrectParams, { tags: [ 'tag1', 'tag2', 'tag3', 'tag4', 'tag5', 'tag6' ] })
+
+ await makePutBodyRequest({ url: server.url, path: path + video.shortUUID, token: server.accessToken, fields })
})
it('Should fail with a tag length too low', async function () {
- const fields = {
- name: 'my super name',
- category: 5,
- licence: 2,
- language: 6,
- nsfw: false,
- description: 'my super description',
- tags: [ 'tag1', 't' ]
- }
- await makePutBodyRequest({ url: server.url, path: path + videoId, token: server.accessToken, fields })
+ const fields = immutableAssign(baseCorrectParams, { tags: [ 'tag1', 't' ] })
+
+ await makePutBodyRequest({ url: server.url, path: path + video.shortUUID, token: server.accessToken, fields })
})
it('Should fail with a tag length too big', async function () {
- const fields = {
- name: 'my super name',
- category: 5,
- licence: 2,
- language: 6,
- nsfw: false,
- description: 'my super description',
- tags: [ 'my_super_tag_too_long_long_long_long', 'tag1' ]
+ const fields = immutableAssign(baseCorrectParams, { tags: [ 'tag1', 'my_super_tag_too_long_long_long_long_long_long' ] })
+
+ await makePutBodyRequest({ url: server.url, path: path + video.shortUUID, token: server.accessToken, fields })
+ })
+
+ it('Should fail with a bad schedule update (miss updateAt)', async function () {
+ const fields = immutableAssign(baseCorrectParams, { scheduleUpdate: { privacy: VideoPrivacy.PUBLIC } })
+
+ await makePutBodyRequest({ url: server.url, path: path + video.shortUUID, token: server.accessToken, fields })
+ })
+
+ it('Should fail with a bad schedule update (wrong updateAt)', async function () {
+ const fields = immutableAssign(baseCorrectParams, { scheduleUpdate: { updateAt: 'toto', privacy: VideoPrivacy.PUBLIC } })
+
+ await makePutBodyRequest({ url: server.url, path: path + video.shortUUID, token: server.accessToken, fields })
+ })
+
+ it('Should fail with a bad originally published at param', async function () {
+ const fields = immutableAssign(baseCorrectParams, { originallyPublishedAt: 'toto' })
+
+ await makePutBodyRequest({ url: server.url, path: path + video.shortUUID, token: server.accessToken, fields })
+ })
+
+ it('Should fail with an incorrect thumbnail file', async function () {
+ const fields = baseCorrectParams
+ const attaches = {
+ thumbnailfile: join(root(), 'server', 'tests', 'fixtures', 'video_short.mp4')
}
- await makePutBodyRequest({ url: server.url, path: path + videoId, token: server.accessToken, fields })
+
+ await makeUploadRequest({
+ url: server.url,
+ method: 'PUT',
+ path: path + video.shortUUID,
+ token: server.accessToken,
+ fields,
+ attaches
+ })
})
- it('Should fail with a video of another user')
+ it('Should fail with a big thumbnail file', async function () {
+ const fields = baseCorrectParams
+ const attaches = {
+ thumbnailfile: join(root(), 'server', 'tests', 'fixtures', 'preview-big.png')
+ }
- it('Should fail with a video of another pod')
+ await makeUploadRequest({
+ url: server.url,
+ method: 'PUT',
+ path: path + video.shortUUID,
+ token: server.accessToken,
+ fields,
+ attaches
+ })
+ })
+
+ it('Should fail with an incorrect preview file', async function () {
+ const fields = baseCorrectParams
+ const attaches = {
+ previewfile: join(root(), 'server', 'tests', 'fixtures', 'video_short.mp4')
+ }
+
+ await makeUploadRequest({
+ url: server.url,
+ method: 'PUT',
+ path: path + video.shortUUID,
+ token: server.accessToken,
+ fields,
+ attaches
+ })
+ })
+
+ it('Should fail with a big preview file', async function () {
+ const fields = baseCorrectParams
+ const attaches = {
+ previewfile: join(root(), 'server', 'tests', 'fixtures', 'preview-big.png')
+ }
+
+ await makeUploadRequest({
+ url: server.url,
+ method: 'PUT',
+ path: path + video.shortUUID,
+ token: server.accessToken,
+ fields,
+ attaches
+ })
+ })
+
+ it('Should fail with a video of another user without the appropriate right', async function () {
+ const fields = baseCorrectParams
+
+ await makePutBodyRequest({
+ url: server.url,
+ path: path + video.shortUUID,
+ token: userAccessToken,
+ fields,
+ statusCodeExpected: HttpStatusCode.FORBIDDEN_403
+ })
+ })
+
+ it('Should fail with a video of another server')
+
+ it('Shoud report the appropriate error', async function () {
+ const fields = immutableAssign(baseCorrectParams, { licence: 125 })
+
+ const res = await makePutBodyRequest({ url: server.url, path: path + video.shortUUID, token: server.accessToken, fields })
+ const error = res.body as PeerTubeProblemDocument
+
+ expect(error.docs).to.equal('https://docs.joinpeertube.org/api-rest-reference.html#operation/putVideo')
+
+ expect(error.type).to.equal('about:blank')
+ expect(error.title).to.equal('Bad Request')
+
+ expect(error.detail).to.equal('Incorrect request parameters: licence')
+ expect(error.error).to.equal('Incorrect request parameters: licence')
+
+ expect(error.status).to.equal(HttpStatusCode.BAD_REQUEST_400)
+ expect(error['invalid-params'].licence).to.exist
+ })
+
+ it('Should succeed with the correct parameters', async function () {
+ const fields = baseCorrectParams
+
+ await makePutBodyRequest({
+ url: server.url,
+ path: path + video.shortUUID,
+ token: server.accessToken,
+ fields,
+ statusCodeExpected: HttpStatusCode.NO_CONTENT_204
+ })
+ })
})
describe('When getting a video', function () {
it('Should return the list of the videos with nothing', async function () {
- const res = await request(server.url)
- .get(path)
- .set('Accept', 'application/json')
- .expect(200)
- .expect('Content-Type', /json/)
+ const res = await makeGetRequest({
+ url: server.url,
+ path,
+ statusCodeExpected: HttpStatusCode.OK_200
+ })
expect(res.body.data).to.be.an('array')
- expect(res.body.data.length).to.equal(3)
+ expect(res.body.data.length).to.equal(6)
})
it('Should fail without a correct uuid', async function () {
- await request(server.url)
- .get(path + 'coucou')
- .set('Accept', 'application/json')
- .expect(400)
+ await getVideo(server.url, 'coucou', HttpStatusCode.BAD_REQUEST_400)
})
it('Should return 404 with an incorrect video', async function () {
- await request(server.url)
- .get(path + '4da6fde3-88f7-4d16-b119-108df5630b06')
- .set('Accept', 'application/json')
- .expect(404)
+ await getVideo(server.url, '4da6fde3-88f7-4d16-b119-108df5630b06', HttpStatusCode.NOT_FOUND_404)
+ })
+
+ it('Shoud report the appropriate error', async function () {
+ const res = await getVideo(server.url, 'hi', HttpStatusCode.BAD_REQUEST_400)
+ const error = res.body as PeerTubeProblemDocument
+
+ expect(error.docs).to.equal('https://docs.joinpeertube.org/api-rest-reference.html#operation/getVideo')
+
+ expect(error.type).to.equal('about:blank')
+ expect(error.title).to.equal('Bad Request')
+
+ expect(error.detail).to.equal('Incorrect request parameters: id')
+ expect(error.error).to.equal('Incorrect request parameters: id')
+
+ expect(error.status).to.equal(HttpStatusCode.BAD_REQUEST_400)
+ expect(error['invalid-params'].id).to.exist
})
- it('Should succeed with the correct parameters')
+ it('Should succeed with the correct parameters', async function () {
+ await getVideo(server.url, video.shortUUID)
+ })
})
describe('When rating a video', function () {
path: path + '4da6fde3-88f7-4d16-b119-108df5630b06/rate',
token: server.accessToken,
fields,
- statusCodeExpected: 404
+ statusCodeExpected: HttpStatusCode.NOT_FOUND_404
})
})
path: path + videoId + '/rate',
token: server.accessToken,
fields,
- statusCodeExpected: 204
+ statusCodeExpected: HttpStatusCode.NO_CONTENT_204
})
})
})
describe('When removing a video', function () {
it('Should have 404 with nothing', async function () {
- await request(server.url)
- .delete(path)
- .set('Authorization', 'Bearer ' + server.accessToken)
- .expect(400)
+ await makeDeleteRequest({
+ url: server.url,
+ path,
+ statusCodeExpected: HttpStatusCode.BAD_REQUEST_400
+ })
})
it('Should fail without a correct uuid', async function () {
- await request(server.url)
- .delete(path + 'hello')
- .set('Authorization', 'Bearer ' + server.accessToken)
- .expect(400)
+ await removeVideo(server.url, server.accessToken, 'hello', HttpStatusCode.BAD_REQUEST_400)
})
it('Should fail with a video which does not exist', async function () {
- await request(server.url)
- .delete(path + '4da6fde3-88f7-4d16-b119-108df5630b06')
- .set('Authorization', 'Bearer ' + server.accessToken)
- .expect(404)
+ await removeVideo(server.url, server.accessToken, '4da6fde3-88f7-4d16-b119-108df5630b06', HttpStatusCode.NOT_FOUND_404)
})
- it('Should fail with a video of another user')
+ it('Should fail with a video of another user without the appropriate right', async function () {
+ await removeVideo(server.url, userAccessToken, video.uuid, HttpStatusCode.FORBIDDEN_403)
+ })
+
+ it('Should fail with a video of another server')
+
+ it('Shoud report the appropriate error', async function () {
+ const res = await removeVideo(server.url, server.accessToken, 'hello', HttpStatusCode.BAD_REQUEST_400)
+ const error = res.body as PeerTubeProblemDocument
+
+ expect(error.docs).to.equal('https://docs.joinpeertube.org/api-rest-reference.html#operation/delVideo')
- it('Should fail with a video of another pod')
+ expect(error.type).to.equal('about:blank')
+ expect(error.title).to.equal('Bad Request')
- it('Should succeed with the correct parameters')
+ expect(error.detail).to.equal('Incorrect request parameters: id')
+ expect(error.error).to.equal('Incorrect request parameters: id')
+
+ expect(error.status).to.equal(HttpStatusCode.BAD_REQUEST_400)
+ expect(error['invalid-params'].id).to.exist
+ })
+
+ it('Should succeed with the correct parameters', async function () {
+ await removeVideo(server.url, server.accessToken, video.uuid)
+ })
})
after(async function () {
- killallServers([ server ])
-
- // Keep the logs if the test failed
- if (this['ok']) {
- await flushTests()
- }
+ await cleanupTests([ server ])
})
})
projects / github / Chocobozzz / PeerTube.git / blobdiff