import * as chai from 'chai'
import { omit } from 'lodash'
import { join } from 'path'
+import { randomInt } from '@shared/core-utils'
+import { PeerTubeProblemDocument, VideoCreateResult } from '@shared/models'
import { HttpStatusCode } from '../../../../shared/core-utils/miscs/http-error-codes'
import {
checkUploadVideoParam,
checkBadStartPagination
} from '../../../../shared/extra-utils/requests/check-api-params'
import { VideoPrivacy } from '../../../../shared/models/videos/video-privacy.enum'
-import { randomInt } from '@shared/core-utils'
const expect = chai.expect
let accountName: string
let channelId: number
let channelName: string
- let videoId
+ let video: VideoCreateResult
// ---------------------------------------------------------------
await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.BAD_REQUEST_400, mode)
})
+ it('Should report the appropriate error', async function () {
+ const fields = immutableAssign(baseCorrectParams, { language: 'a'.repeat(15) })
+ const attaches = baseCorrectAttaches
+
+ const attributes = { ...fields, ...attaches }
+ const res = await checkUploadVideoParam(server.url, server.accessToken, attributes, HttpStatusCode.BAD_REQUEST_400, mode)
+
+ const error = res.body as PeerTubeProblemDocument
+
+ if (mode === 'legacy') {
+ expect(error.docs).to.equal('https://docs.joinpeertube.org/api-rest-reference.html#operation/uploadLegacy')
+ } else {
+ expect(error.docs).to.equal('https://docs.joinpeertube.org/api-rest-reference.html#operation/uploadResumableInit')
+ }
+
+ expect(error.type).to.equal('about:blank')
+ expect(error.title).to.equal('Bad Request')
+
+ expect(error.detail).to.equal('Incorrect request parameters: language')
+ expect(error.error).to.equal('Incorrect request parameters: language')
+
+ expect(error.status).to.equal(HttpStatusCode.BAD_REQUEST_400)
+ expect(error['invalid-params'].language).to.exist
+ })
+
it('Should succeed with the correct parameters', async function () {
this.timeout(10000)
before(async function () {
const res = await getVideosList(server.url)
- videoId = res.body.data[0].uuid
+ video = res.body.data[0]
})
it('Should fail with nothing', async function () {
it('Should fail with a long name', async function () {
const fields = immutableAssign(baseCorrectParams, { name: 'super'.repeat(65) })
- await makePutBodyRequest({ url: server.url, path: path + videoId, token: server.accessToken, fields })
+ await makePutBodyRequest({ url: server.url, path: path + video.shortUUID, token: server.accessToken, fields })
})
it('Should fail with a bad category', async function () {
const fields = immutableAssign(baseCorrectParams, { category: 125 })
- await makePutBodyRequest({ url: server.url, path: path + videoId, token: server.accessToken, fields })
+ await makePutBodyRequest({ url: server.url, path: path + video.shortUUID, token: server.accessToken, fields })
})
it('Should fail with a bad licence', async function () {
const fields = immutableAssign(baseCorrectParams, { licence: 125 })
- await makePutBodyRequest({ url: server.url, path: path + videoId, token: server.accessToken, fields })
+ await makePutBodyRequest({ url: server.url, path: path + video.shortUUID, token: server.accessToken, fields })
})
it('Should fail with a bad language', async function () {
const fields = immutableAssign(baseCorrectParams, { language: 'a'.repeat(15) })
- await makePutBodyRequest({ url: server.url, path: path + videoId, token: server.accessToken, fields })
+ await makePutBodyRequest({ url: server.url, path: path + video.shortUUID, token: server.accessToken, fields })
})
it('Should fail with a long description', async function () {
const fields = immutableAssign(baseCorrectParams, { description: 'super'.repeat(2500) })
- await makePutBodyRequest({ url: server.url, path: path + videoId, token: server.accessToken, fields })
+ await makePutBodyRequest({ url: server.url, path: path + video.shortUUID, token: server.accessToken, fields })
})
it('Should fail with a long support text', async function () {
const fields = immutableAssign(baseCorrectParams, { support: 'super'.repeat(201) })
- await makePutBodyRequest({ url: server.url, path: path + videoId, token: server.accessToken, fields })
+ await makePutBodyRequest({ url: server.url, path: path + video.shortUUID, token: server.accessToken, fields })
})
it('Should fail with a bad channel', async function () {
const fields = immutableAssign(baseCorrectParams, { channelId: 545454 })
- await makePutBodyRequest({ url: server.url, path: path + videoId, token: server.accessToken, fields })
+ await makePutBodyRequest({ url: server.url, path: path + video.shortUUID, token: server.accessToken, fields })
})
it('Should fail with too many tags', async function () {
const fields = immutableAssign(baseCorrectParams, { tags: [ 'tag1', 'tag2', 'tag3', 'tag4', 'tag5', 'tag6' ] })
- await makePutBodyRequest({ url: server.url, path: path + videoId, token: server.accessToken, fields })
+ await makePutBodyRequest({ url: server.url, path: path + video.shortUUID, token: server.accessToken, fields })
})
it('Should fail with a tag length too low', async function () {
const fields = immutableAssign(baseCorrectParams, { tags: [ 'tag1', 't' ] })
- await makePutBodyRequest({ url: server.url, path: path + videoId, token: server.accessToken, fields })
+ await makePutBodyRequest({ url: server.url, path: path + video.shortUUID, token: server.accessToken, fields })
})
it('Should fail with a tag length too big', async function () {
const fields = immutableAssign(baseCorrectParams, { tags: [ 'tag1', 'my_super_tag_too_long_long_long_long_long_long' ] })
- await makePutBodyRequest({ url: server.url, path: path + videoId, token: server.accessToken, fields })
+ await makePutBodyRequest({ url: server.url, path: path + video.shortUUID, token: server.accessToken, fields })
})
it('Should fail with a bad schedule update (miss updateAt)', async function () {
const fields = immutableAssign(baseCorrectParams, { scheduleUpdate: { privacy: VideoPrivacy.PUBLIC } })
- await makePutBodyRequest({ url: server.url, path: path + videoId, token: server.accessToken, fields })
+ await makePutBodyRequest({ url: server.url, path: path + video.shortUUID, token: server.accessToken, fields })
})
it('Should fail with a bad schedule update (wrong updateAt)', async function () {
const fields = immutableAssign(baseCorrectParams, { scheduleUpdate: { updateAt: 'toto', privacy: VideoPrivacy.PUBLIC } })
- await makePutBodyRequest({ url: server.url, path: path + videoId, token: server.accessToken, fields })
+ await makePutBodyRequest({ url: server.url, path: path + video.shortUUID, token: server.accessToken, fields })
})
it('Should fail with a bad originally published at param', async function () {
const fields = immutableAssign(baseCorrectParams, { originallyPublishedAt: 'toto' })
- await makePutBodyRequest({ url: server.url, path: path + videoId, token: server.accessToken, fields })
+ await makePutBodyRequest({ url: server.url, path: path + video.shortUUID, token: server.accessToken, fields })
})
it('Should fail with an incorrect thumbnail file', async function () {
await makeUploadRequest({
url: server.url,
method: 'PUT',
- path: path + videoId,
+ path: path + video.shortUUID,
token: server.accessToken,
fields,
attaches
await makeUploadRequest({
url: server.url,
method: 'PUT',
- path: path + videoId,
+ path: path + video.shortUUID,
token: server.accessToken,
fields,
attaches
await makeUploadRequest({
url: server.url,
method: 'PUT',
- path: path + videoId,
+ path: path + video.shortUUID,
token: server.accessToken,
fields,
attaches
await makeUploadRequest({
url: server.url,
method: 'PUT',
- path: path + videoId,
+ path: path + video.shortUUID,
token: server.accessToken,
fields,
attaches
await makePutBodyRequest({
url: server.url,
- path: path + videoId,
+ path: path + video.shortUUID,
token: userAccessToken,
fields,
statusCodeExpected: HttpStatusCode.FORBIDDEN_403
it('Should fail with a video of another server')
+ it('Shoud report the appropriate error', async function () {
+ const fields = immutableAssign(baseCorrectParams, { licence: 125 })
+
+ const res = await makePutBodyRequest({ url: server.url, path: path + video.shortUUID, token: server.accessToken, fields })
+ const error = res.body as PeerTubeProblemDocument
+
+ expect(error.docs).to.equal('https://docs.joinpeertube.org/api-rest-reference.html#operation/putVideo')
+
+ expect(error.type).to.equal('about:blank')
+ expect(error.title).to.equal('Bad Request')
+
+ expect(error.detail).to.equal('Incorrect request parameters: licence')
+ expect(error.error).to.equal('Incorrect request parameters: licence')
+
+ expect(error.status).to.equal(HttpStatusCode.BAD_REQUEST_400)
+ expect(error['invalid-params'].licence).to.exist
+ })
+
it('Should succeed with the correct parameters', async function () {
const fields = baseCorrectParams
await makePutBodyRequest({
url: server.url,
- path: path + videoId,
+ path: path + video.shortUUID,
token: server.accessToken,
fields,
statusCodeExpected: HttpStatusCode.NO_CONTENT_204
await getVideo(server.url, '4da6fde3-88f7-4d16-b119-108df5630b06', HttpStatusCode.NOT_FOUND_404)
})
+ it('Shoud report the appropriate error', async function () {
+ const res = await getVideo(server.url, 'hi', HttpStatusCode.BAD_REQUEST_400)
+ const error = res.body as PeerTubeProblemDocument
+
+ expect(error.docs).to.equal('https://docs.joinpeertube.org/api-rest-reference.html#operation/getVideo')
+
+ expect(error.type).to.equal('about:blank')
+ expect(error.title).to.equal('Bad Request')
+
+ expect(error.detail).to.equal('Incorrect request parameters: id')
+ expect(error.error).to.equal('Incorrect request parameters: id')
+
+ expect(error.status).to.equal(HttpStatusCode.BAD_REQUEST_400)
+ expect(error['invalid-params'].id).to.exist
+ })
+
it('Should succeed with the correct parameters', async function () {
- await getVideo(server.url, videoId)
+ await getVideo(server.url, video.shortUUID)
})
})
})
it('Should fail with a video of another user without the appropriate right', async function () {
- await removeVideo(server.url, userAccessToken, videoId, HttpStatusCode.FORBIDDEN_403)
+ await removeVideo(server.url, userAccessToken, video.uuid, HttpStatusCode.FORBIDDEN_403)
})
it('Should fail with a video of another server')
+ it('Shoud report the appropriate error', async function () {
+ const res = await removeVideo(server.url, server.accessToken, 'hello', HttpStatusCode.BAD_REQUEST_400)
+ const error = res.body as PeerTubeProblemDocument
+
+ expect(error.docs).to.equal('https://docs.joinpeertube.org/api-rest-reference.html#operation/delVideo')
+
+ expect(error.type).to.equal('about:blank')
+ expect(error.title).to.equal('Bad Request')
+
+ expect(error.detail).to.equal('Incorrect request parameters: id')
+ expect(error.error).to.equal('Incorrect request parameters: id')
+
+ expect(error.status).to.equal(HttpStatusCode.BAD_REQUEST_400)
+ expect(error['invalid-params'].id).to.exist
+ })
+
it('Should succeed with the correct parameters', async function () {
- await removeVideo(server.url, server.accessToken, videoId)
+ await removeVideo(server.url, server.accessToken, video.uuid)
})
})