-/* tslint:disable:no-unused-expression */
+/* eslint-disable @typescript-eslint/no-unused-expressions,@typescript-eslint/require-await */
import 'mocha'
import {
addVideoInPlaylist,
+ cleanupTests,
createVideoPlaylist,
deleteVideoPlaylist,
- flushTests,
+ flushAndRunServer,
generateUserAccessToken,
getAccountPlaylistsListWithToken,
getVideoPlaylist,
immutableAssign,
- killallServers,
makeGetRequest,
removeVideoFromPlaylist,
reorderVideosPlaylist,
- runServer,
ServerInfo,
setAccessTokensToServers,
+ setDefaultVideoChannel,
updateVideoPlaylist,
updateVideoPlaylistElement,
uploadVideoAndGetId
-} from '../../../../shared/utils'
+} from '../../../../shared/extra-utils'
import {
checkBadCountPagination,
checkBadSortPagination,
checkBadStartPagination
-} from '../../../../shared/utils/requests/check-api-params'
+} from '../../../../shared/extra-utils/requests/check-api-params'
import { VideoPlaylistPrivacy } from '../../../../shared/models/videos/playlist/video-playlist-privacy.model'
import { VideoPlaylistType } from '../../../../shared/models/videos/playlist/video-playlist-type.model'
+import { HttpStatusCode } from '../../../../shared/core-utils/miscs/http-error-codes'
describe('Test video playlists API validator', function () {
let server: ServerInfo
let userAccessToken: string
let playlistUUID: string
+ let privatePlaylistUUID: string
let watchLaterPlaylistId: number
let videoId: number
- let videoId2: number
+ let playlistElementId: number
// ---------------------------------------------------------------
before(async function () {
this.timeout(30000)
- await flushTests()
-
- server = await runServer(1)
+ server = await flushAndRunServer(1)
await setAccessTokensToServers([ server ])
+ await setDefaultVideoChannel([ server ])
userAccessToken = await generateUserAccessToken(server, 'user1')
videoId = (await uploadVideoAndGetId({ server, videoName: 'video 1' })).id
- videoId2 = (await uploadVideoAndGetId({ server, videoName: 'video 2' })).id
{
- const res = await getAccountPlaylistsListWithToken(server.url, server.accessToken, 'root',0, 5, VideoPlaylistType.WATCH_LATER)
+ const res = await getAccountPlaylistsListWithToken(server.url, server.accessToken, 'root', 0, 5, VideoPlaylistType.WATCH_LATER)
watchLaterPlaylistId = res.body.data[0].id
}
token: server.accessToken,
playlistAttrs: {
displayName: 'super playlist',
- privacy: VideoPlaylistPrivacy.PUBLIC
+ privacy: VideoPlaylistPrivacy.PUBLIC,
+ videoChannelId: server.videoChannel.id
}
})
playlistUUID = res.body.videoPlaylist.uuid
}
+
+ {
+ const res = await createVideoPlaylist({
+ url: server.url,
+ token: server.accessToken,
+ playlistAttrs: {
+ displayName: 'private',
+ privacy: VideoPlaylistPrivacy.PRIVATE
+ }
+ })
+ privatePlaylistUUID = res.body.videoPlaylist.uuid
+ }
})
describe('When listing playlists', function () {
it('Should fail with a bad account parameter', async function () {
const accountPath = '/api/v1/accounts/root2/video-playlists'
- await makeGetRequest({ url: server.url, path: accountPath, statusCodeExpected: 404, token: server.accessToken })
+ await makeGetRequest({
+ url: server.url,
+ path: accountPath,
+ statusCodeExpected: HttpStatusCode.NOT_FOUND_404,
+ token: server.accessToken
+ })
})
it('Should fail with a bad video channel parameter', async function () {
const accountPath = '/api/v1/video-channels/bad_channel/video-playlists'
- await makeGetRequest({ url: server.url, path: accountPath, statusCodeExpected: 404, token: server.accessToken })
+ await makeGetRequest({
+ url: server.url,
+ path: accountPath,
+ statusCodeExpected: HttpStatusCode.NOT_FOUND_404,
+ token: server.accessToken
+ })
})
it('Should success with the correct parameters', async function () {
- await makeGetRequest({ url: server.url, path: globalPath, statusCodeExpected: 200, token: server.accessToken })
- await makeGetRequest({ url: server.url, path: accountPath, statusCodeExpected: 200, token: server.accessToken })
- await makeGetRequest({ url: server.url, path: videoChannelPath, statusCodeExpected: 200, token: server.accessToken })
+ await makeGetRequest({ url: server.url, path: globalPath, statusCodeExpected: HttpStatusCode.OK_200, token: server.accessToken })
+ await makeGetRequest({ url: server.url, path: accountPath, statusCodeExpected: HttpStatusCode.OK_200, token: server.accessToken })
+ await makeGetRequest({
+ url: server.url,
+ path: videoChannelPath,
+ statusCodeExpected: HttpStatusCode.OK_200,
+ token: server.accessToken
+ })
})
})
describe('When listing videos of a playlist', function () {
- const path = '/api/v1/video-playlists'
+ const path = '/api/v1/video-playlists/'
it('Should fail with a bad start pagination', async function () {
- await checkBadStartPagination(server.url, path, server.accessToken)
+ await checkBadStartPagination(server.url, path + playlistUUID + '/videos', server.accessToken)
})
it('Should fail with a bad count pagination', async function () {
- await checkBadCountPagination(server.url, path, server.accessToken)
+ await checkBadCountPagination(server.url, path + playlistUUID + '/videos', server.accessToken)
})
- it('Should fail with a bad filter', async function () {
- await checkBadSortPagination(server.url, path, server.accessToken)
+ it('Should success with the correct parameters', async function () {
+ await makeGetRequest({ url: server.url, path: path + playlistUUID + '/videos', statusCodeExpected: HttpStatusCode.OK_200 })
})
})
describe('When getting a video playlist', function () {
it('Should fail with a bad id or uuid', async function () {
- await getVideoPlaylist(server.url, 'toto', 400)
+ await getVideoPlaylist(server.url, 'toto', HttpStatusCode.BAD_REQUEST_400)
})
it('Should fail with an unknown playlist', async function () {
- await getVideoPlaylist(server.url, 42, 404)
+ await getVideoPlaylist(server.url, 42, HttpStatusCode.NOT_FOUND_404)
})
it('Should fail to get an unlisted playlist with the number id', async function () {
})
const playlist = res.body.videoPlaylist
- await getVideoPlaylist(server.url, playlist.id, 404)
- await getVideoPlaylist(server.url, playlist.uuid, 200)
+ await getVideoPlaylist(server.url, playlist.id, HttpStatusCode.NOT_FOUND_404)
+ await getVideoPlaylist(server.url, playlist.uuid, HttpStatusCode.OK_200)
})
it('Should succeed with the correct params', async function () {
- await getVideoPlaylist(server.url, playlistUUID, 200)
+ await getVideoPlaylist(server.url, playlistUUID, HttpStatusCode.OK_200)
})
})
describe('When creating/updating a video playlist', function () {
const getBase = (playlistAttrs: any = {}, wrapper: any = {}) => {
return Object.assign({
- expectedStatus: 400,
+ expectedStatus: HttpStatusCode.BAD_REQUEST_400,
url: server.url,
token: server.accessToken,
playlistAttrs: Object.assign({
displayName: 'display name',
privacy: VideoPlaylistPrivacy.UNLISTED,
- thumbnailfile: 'thumbnail.jpg'
+ thumbnailfile: 'thumbnail.jpg',
+ videoChannelId: server.videoChannel.id
}, playlistAttrs)
}, wrapper)
}
}
it('Should fail with an unauthenticated user', async function () {
- const params = getBase({}, { token: null, expectedStatus: 401 })
+ const params = getBase({}, { token: null, expectedStatus: HttpStatusCode.UNAUTHORIZED_401 })
await createVideoPlaylist(params)
await updateVideoPlaylist(getUpdate(params, playlistUUID))
const params = getBase({ displayName: undefined })
await createVideoPlaylist(params)
- await updateVideoPlaylist(getUpdate(params, playlistUUID))
})
it('Should fail with an incorrect display name', async function () {
})
it('Should fail with an unknown video channel id', async function () {
- const params = getBase({ videoChannelId: 42 }, { expectedStatus: 404 })
+ const params = getBase({ videoChannelId: 42 }, { expectedStatus: HttpStatusCode.NOT_FOUND_404 })
await createVideoPlaylist(params)
await updateVideoPlaylist(getUpdate(params, playlistUUID))
})
it('Should fail with an incorrect thumbnail file', async function () {
- const params = getBase({ thumbnailfile: 'avatar.png' })
+ const params = getBase({ thumbnailfile: 'video_short.mp4' })
+
+ await createVideoPlaylist(params)
+ await updateVideoPlaylist(getUpdate(params, playlistUUID))
+ })
+
+ it('Should fail with a thumbnail file too big', async function () {
+ const params = getBase({ thumbnailfile: 'preview-big.png' })
await createVideoPlaylist(params)
await updateVideoPlaylist(getUpdate(params, playlistUUID))
})
+ it('Should fail to set "public" a playlist not assigned to a channel', async function () {
+ const params = getBase({ privacy: VideoPlaylistPrivacy.PUBLIC, videoChannelId: undefined })
+ const params2 = getBase({ privacy: VideoPlaylistPrivacy.PUBLIC, videoChannelId: 'null' })
+ const params3 = getBase({ privacy: undefined, videoChannelId: 'null' })
+
+ await createVideoPlaylist(params)
+ await createVideoPlaylist(params2)
+ await updateVideoPlaylist(getUpdate(params, privatePlaylistUUID))
+ await updateVideoPlaylist(getUpdate(params2, playlistUUID))
+ await updateVideoPlaylist(getUpdate(params3, playlistUUID))
+ })
+
it('Should fail with an unknown playlist to update', async function () {
await updateVideoPlaylist(getUpdate(
- getBase({}, { expectedStatus: 404 }),
+ getBase({}, { expectedStatus: HttpStatusCode.NOT_FOUND_404 }),
42
))
})
it('Should fail to update a playlist of another user', async function () {
await updateVideoPlaylist(getUpdate(
- getBase({}, { token: userAccessToken, expectedStatus: 403 }),
+ getBase({}, { token: userAccessToken, expectedStatus: HttpStatusCode.FORBIDDEN_403 }),
playlistUUID
))
})
- it('Should fail to update to private a public/unlisted playlist', async function () {
- const params = getBase({ privacy: VideoPlaylistPrivacy.PUBLIC }, { expectedStatus: 200 })
-
- const res = await createVideoPlaylist(params)
- const playlist = res.body.videoPlaylist
-
- const paramsUpdate = getBase({ privacy: VideoPlaylistPrivacy.PRIVATE }, { expectedStatus: 409 })
-
- await updateVideoPlaylist(getUpdate(paramsUpdate, playlist.id))
- })
-
it('Should fail to update the watch later playlist', async function () {
await updateVideoPlaylist(getUpdate(
- getBase({}, { expectedStatus: 409 }),
+ getBase({}, { expectedStatus: HttpStatusCode.BAD_REQUEST_400 }),
watchLaterPlaylistId
))
})
it('Should succeed with the correct params', async function () {
{
- const params = getBase({}, { expectedStatus: 200 })
+ const params = getBase({}, { expectedStatus: HttpStatusCode.OK_200 })
await createVideoPlaylist(params)
}
{
- const params = getBase({}, { expectedStatus: 204 })
+ const params = getBase({}, { expectedStatus: HttpStatusCode.NO_CONTENT_204 })
await updateVideoPlaylist(getUpdate(params, playlistUUID))
}
})
describe('When adding an element in a playlist', function () {
const getBase = (elementAttrs: any = {}, wrapper: any = {}) => {
return Object.assign({
- expectedStatus: 400,
+ expectedStatus: HttpStatusCode.BAD_REQUEST_400,
url: server.url,
token: server.accessToken,
playlistId: playlistUUID,
elementAttrs: Object.assign({
- videoId: videoId,
+ videoId,
startTimestamp: 2,
stopTimestamp: 3
}, elementAttrs)
}
it('Should fail with an unauthenticated user', async function () {
- const params = getBase({}, { token: null, expectedStatus: 401 })
+ const params = getBase({}, { token: null, expectedStatus: HttpStatusCode.UNAUTHORIZED_401 })
await addVideoInPlaylist(params)
})
it('Should fail with the playlist of another user', async function () {
- const params = getBase({}, { token: userAccessToken, expectedStatus: 403 })
+ const params = getBase({}, { token: userAccessToken, expectedStatus: HttpStatusCode.FORBIDDEN_403 })
await addVideoInPlaylist(params)
})
}
{
- const params = getBase({}, { playlistId: 42, expectedStatus: 404 })
+ const params = getBase({}, { playlistId: 42, expectedStatus: HttpStatusCode.NOT_FOUND_404 })
await addVideoInPlaylist(params)
}
})
it('Should fail with an unknown or incorrect video id', async function () {
- const params = getBase({ videoId: 42 }, { expectedStatus: 404 })
+ const params = getBase({ videoId: 42 }, { expectedStatus: HttpStatusCode.NOT_FOUND_404 })
await addVideoInPlaylist(params)
})
})
it('Succeed with the correct params', async function () {
- const params = getBase({}, { expectedStatus: 200 })
- await addVideoInPlaylist(params)
- })
-
- it('Should fail if the video was already added in the playlist', async function () {
- const params = getBase({}, { expectedStatus: 409 })
- await addVideoInPlaylist(params)
+ const params = getBase({}, { expectedStatus: HttpStatusCode.OK_200 })
+ const res = await addVideoInPlaylist(params)
+ playlistElementId = res.body.videoPlaylistElement.id
})
})
startTimestamp: 1,
stopTimestamp: 2
}, elementAttrs),
- videoId: videoId,
+ playlistElementId,
playlistId: playlistUUID,
- expectedStatus: 400
+ expectedStatus: HttpStatusCode.BAD_REQUEST_400
}, wrapper)
}
it('Should fail with an unauthenticated user', async function () {
- const params = getBase({}, { token: null, expectedStatus: 401 })
+ const params = getBase({}, { token: null, expectedStatus: HttpStatusCode.UNAUTHORIZED_401 })
await updateVideoPlaylistElement(params)
})
it('Should fail with the playlist of another user', async function () {
- const params = getBase({}, { token: userAccessToken, expectedStatus: 403 })
+ const params = getBase({}, { token: userAccessToken, expectedStatus: HttpStatusCode.FORBIDDEN_403 })
await updateVideoPlaylistElement(params)
})
}
{
- const params = getBase({}, { playlistId: 42, expectedStatus: 404 })
+ const params = getBase({}, { playlistId: 42, expectedStatus: HttpStatusCode.NOT_FOUND_404 })
await updateVideoPlaylistElement(params)
}
})
- it('Should fail with an unknown or incorrect video id', async function () {
+ it('Should fail with an unknown or incorrect playlistElement id', async function () {
{
- const params = getBase({}, { videoId: 'toto' })
+ const params = getBase({}, { playlistElementId: 'toto' })
await updateVideoPlaylistElement(params)
}
{
- const params = getBase({}, { videoId: 42, expectedStatus: 404 })
+ const params = getBase({}, { playlistElementId: 42, expectedStatus: HttpStatusCode.NOT_FOUND_404 })
await updateVideoPlaylistElement(params)
}
})
})
it('Should fail with an unknown element', async function () {
- const params = getBase({}, { videoId: videoId2, expectedStatus: 404 })
+ const params = getBase({}, { playlistElementId: 888, expectedStatus: HttpStatusCode.NOT_FOUND_404 })
await updateVideoPlaylistElement(params)
})
it('Succeed with the correct params', async function () {
- const params = getBase({}, { expectedStatus: 204 })
+ const params = getBase({}, { expectedStatus: HttpStatusCode.NO_CONTENT_204 })
await updateVideoPlaylistElement(params)
})
})
insertAfterPosition: 2,
reorderLength: 3
}, elementAttrs),
- expectedStatus: 400
+ expectedStatus: HttpStatusCode.BAD_REQUEST_400
}, wrapper)
}
videoId3 = (await uploadVideoAndGetId({ server, videoName: 'video 3' })).id
videoId4 = (await uploadVideoAndGetId({ server, videoName: 'video 4' })).id
- for (let id of [ videoId3, videoId4 ]) {
+ for (const id of [ videoId3, videoId4 ]) {
await addVideoInPlaylist({
url: server.url,
token: server.accessToken,
})
it('Should fail with an unauthenticated user', async function () {
- const params = getBase({}, { token: null, expectedStatus: 401 })
+ const params = getBase({}, { token: null, expectedStatus: HttpStatusCode.UNAUTHORIZED_401 })
await reorderVideosPlaylist(params)
})
it('Should fail with the playlist of another user', async function () {
- const params = getBase({}, { token: userAccessToken, expectedStatus: 403 })
+ const params = getBase({}, { token: userAccessToken, expectedStatus: HttpStatusCode.FORBIDDEN_403 })
await reorderVideosPlaylist(params)
})
}
{
- const params = getBase({}, { playlistId: 42, expectedStatus: 404 })
+ const params = getBase({}, { playlistId: 42, expectedStatus: HttpStatusCode.NOT_FOUND_404 })
await reorderVideosPlaylist(params)
}
})
})
it('Succeed with the correct params', async function () {
- const params = getBase({}, { expectedStatus: 204 })
+ const params = getBase({}, { expectedStatus: HttpStatusCode.NO_CONTENT_204 })
await reorderVideosPlaylist(params)
})
})
+ describe('When checking exists in playlist endpoint', function () {
+ const path = '/api/v1/users/me/video-playlists/videos-exist'
+
+ it('Should fail with an unauthenticated user', async function () {
+ await makeGetRequest({
+ url: server.url,
+ path,
+ query: { videoIds: [ 1, 2 ] },
+ statusCodeExpected: HttpStatusCode.UNAUTHORIZED_401
+ })
+ })
+
+ it('Should fail with invalid video ids', async function () {
+ await makeGetRequest({
+ url: server.url,
+ token: server.accessToken,
+ path,
+ query: { videoIds: 'toto' }
+ })
+
+ await makeGetRequest({
+ url: server.url,
+ token: server.accessToken,
+ path,
+ query: { videoIds: [ 'toto' ] }
+ })
+
+ await makeGetRequest({
+ url: server.url,
+ token: server.accessToken,
+ path,
+ query: { videoIds: [ 1, 'toto' ] }
+ })
+ })
+
+ it('Should succeed with the correct params', async function () {
+ await makeGetRequest({
+ url: server.url,
+ token: server.accessToken,
+ path,
+ query: { videoIds: [ 1, 2 ] },
+ statusCodeExpected: HttpStatusCode.OK_200
+ })
+ })
+ })
+
describe('When deleting an element in a playlist', function () {
const getBase = (wrapper: any = {}) => {
return Object.assign({
url: server.url,
token: server.accessToken,
- videoId: videoId,
+ playlistElementId,
playlistId: playlistUUID,
- expectedStatus: 400
+ expectedStatus: HttpStatusCode.BAD_REQUEST_400
}, wrapper)
}
it('Should fail with an unauthenticated user', async function () {
- const params = getBase({ token: null, expectedStatus: 401 })
+ const params = getBase({ token: null, expectedStatus: HttpStatusCode.UNAUTHORIZED_401 })
await removeVideoFromPlaylist(params)
})
it('Should fail with the playlist of another user', async function () {
- const params = getBase({ token: userAccessToken, expectedStatus: 403 })
+ const params = getBase({ token: userAccessToken, expectedStatus: HttpStatusCode.FORBIDDEN_403 })
await removeVideoFromPlaylist(params)
})
}
{
- const params = getBase({ playlistId: 42, expectedStatus: 404 })
+ const params = getBase({ playlistId: 42, expectedStatus: HttpStatusCode.NOT_FOUND_404 })
await removeVideoFromPlaylist(params)
}
})
it('Should fail with an unknown or incorrect video id', async function () {
{
- const params = getBase({ videoId: 'toto' })
+ const params = getBase({ playlistElementId: 'toto' })
await removeVideoFromPlaylist(params)
}
{
- const params = getBase({ videoId: 42, expectedStatus: 404 })
+ const params = getBase({ playlistElementId: 42, expectedStatus: HttpStatusCode.NOT_FOUND_404 })
await removeVideoFromPlaylist(params)
}
})
it('Should fail with an unknown element', async function () {
- const params = getBase({ videoId: videoId2, expectedStatus: 404 })
+ const params = getBase({ playlistElementId: 888, expectedStatus: HttpStatusCode.NOT_FOUND_404 })
await removeVideoFromPlaylist(params)
})
it('Succeed with the correct params', async function () {
- const params = getBase({ expectedStatus: 204 })
+ const params = getBase({ expectedStatus: HttpStatusCode.NO_CONTENT_204 })
await removeVideoFromPlaylist(params)
})
})
describe('When deleting a playlist', function () {
it('Should fail with an unknown playlist', async function () {
- await deleteVideoPlaylist(server.url, server.accessToken, 42, 404)
+ await deleteVideoPlaylist(server.url, server.accessToken, 42, HttpStatusCode.NOT_FOUND_404)
})
it('Should fail with a playlist of another user', async function () {
- await deleteVideoPlaylist(server.url, userAccessToken, playlistUUID, 403)
+ await deleteVideoPlaylist(server.url, userAccessToken, playlistUUID, HttpStatusCode.FORBIDDEN_403)
})
it('Should fail with the watch later playlist', async function () {
- await deleteVideoPlaylist(server.url, server.accessToken, watchLaterPlaylistId, 409)
+ await deleteVideoPlaylist(server.url, server.accessToken, watchLaterPlaylistId, HttpStatusCode.BAD_REQUEST_400)
})
it('Should succeed with the correct params', async function () {
})
after(async function () {
- killallServers([ server ])
-
- // Keep the logs if the test failed
- if (this['ok']) {
- await flushTests()
- }
+ await cleanupTests([ server ])
})
})
projects / github / Chocobozzz / PeerTube.git / blobdiff