-/* tslint:disable:no-unused-expression */
+/* eslint-disable @typescript-eslint/no-unused-expressions,@typescript-eslint/require-await */
import 'mocha'
-import {
- cleanupTests,
- closeAllSequelize,
- flushAndRunMultipleServers,
- killallServers,
- ServerInfo,
- setActorField
-} from '../../../../shared/extra-utils'
+import { cleanupTests, closeAllSequelize, flushAndRunMultipleServers, ServerInfo, setActorField } from '../../../../shared/extra-utils'
import { HTTP_SIGNATURE } from '../../../initializers/constants'
-import { buildDigest, buildGlobalHeaders } from '../../../lib/job-queue/handlers/utils/activitypub-http-utils'
+import { buildGlobalHeaders } from '../../../lib/job-queue/handlers/utils/activitypub-http-utils'
import * as chai from 'chai'
import { activityPubContextify, buildSignedActivity } from '../../../helpers/activitypub'
import { makeFollowRequest, makePOSTAPRequest } from '../../../../shared/extra-utils/requests/activitypub'
+import { buildDigest } from '@server/helpers/peertube-crypto'
const expect = chai.expect
if (Array.isArray(json[key])) {
result[key] = json[key].map(v => v.replace(':9002', `:${server2.port}`))
} else {
- result[ key ] = json[ key ].replace(':9002', `:${server2.port}`)
+ result[key] = json[key].replace(':9002', `:${server2.port}`)
}
}
expect(response.statusCode).to.equal(403)
})
- it('Should succeed with a valid HTTP signature', async function () {
+ it('Should reject requests without appropriate signed headers', async function () {
await setKeysOfServer(servers[0], servers[1], keys.publicKey, keys.privateKey)
await setKeysOfServer(servers[1], servers[1], keys.publicKey, keys.privateKey)
const body = activityPubContextify(getAnnounceWithoutContext(servers[1]))
const headers = buildGlobalHeaders(body)
+ const signatureOptions = baseHttpSignature()
+ const badHeadersMatrix = [
+ [ '(request-target)', 'date', 'digest' ],
+ [ 'host', 'date', 'digest' ],
+ [ '(request-target)', 'host', 'digest' ]
+ ]
+
+ for (const badHeaders of badHeadersMatrix) {
+ signatureOptions.headers = badHeaders
+
+ const { response } = await makePOSTAPRequest(url, body, signatureOptions, headers)
+ expect(response.statusCode).to.equal(403)
+ }
+ })
+
+ it('Should succeed with a valid HTTP signature', async function () {
+ const body = activityPubContextify(getAnnounceWithoutContext(servers[1]))
+ const headers = buildGlobalHeaders(body)
+
const { response } = await makePOSTAPRequest(url, body, baseHttpSignature(), headers)
expect(response.statusCode).to.equal(204)