/* eslint-disable @typescript-eslint/no-unused-expressions,@typescript-eslint/require-await */
-import 'mocha'
+import { expect } from 'chai'
+import { buildDigest } from '@server/helpers/peertube-crypto'
+import { HTTP_SIGNATURE } from '@server/initializers/constants'
+import { activityPubContextify } from '@server/lib/activitypub/context'
+import { buildGlobalHeaders, signAndContextify } from '@server/lib/activitypub/send'
+import { makeFollowRequest, makePOSTAPRequest } from '@server/tests/shared'
+import { buildAbsoluteFixturePath, wait } from '@shared/core-utils'
+import { HttpStatusCode } from '@shared/models'
+import { cleanupTests, createMultipleServers, killallServers, PeerTubeServer } from '@shared/server-commands'
+
+function setKeysOfServer (onServer: PeerTubeServer, ofServer: PeerTubeServer, publicKey: string, privateKey: string) {
+ const url = ofServer.url + '/accounts/peertube'
-import { cleanupTests, closeAllSequelize, flushAndRunMultipleServers, ServerInfo, setActorField } from '../../../../shared/extra-utils'
-import { HTTP_SIGNATURE } from '../../../initializers/constants'
-import { buildDigest, buildGlobalHeaders } from '../../../lib/job-queue/handlers/utils/activitypub-http-utils'
-import * as chai from 'chai'
-import { activityPubContextify, buildSignedActivity } from '../../../helpers/activitypub'
-import { makeFollowRequest, makePOSTAPRequest } from '../../../../shared/extra-utils/requests/activitypub'
+ return Promise.all([
+ onServer.sql.setActorField(url, 'publicKey', publicKey),
+ onServer.sql.setActorField(url, 'privateKey', privateKey)
+ ])
+}
-const expect = chai.expect
+function setUpdatedAtOfServer (onServer: PeerTubeServer, ofServer: PeerTubeServer, updatedAt: string) {
+ const url = ofServer.url + '/accounts/peertube'
-function setKeysOfServer (onServer: ServerInfo, ofServer: ServerInfo, publicKey: string, privateKey: string) {
return Promise.all([
- setActorField(onServer.internalServerNumber, 'http://localhost:' + ofServer.port + '/accounts/peertube', 'publicKey', publicKey),
- setActorField(onServer.internalServerNumber, 'http://localhost:' + ofServer.port + '/accounts/peertube', 'privateKey', privateKey)
+ onServer.sql.setActorField(url, 'createdAt', updatedAt),
+ onServer.sql.setActorField(url, 'updatedAt', updatedAt)
])
}
-function getAnnounceWithoutContext (server2: ServerInfo) {
- const json = require('./json/peertube/announce-without-context.json')
+function getAnnounceWithoutContext (server: PeerTubeServer) {
+ const json = require(buildAbsoluteFixturePath('./ap-json/peertube/announce-without-context.json'))
const result: typeof json = {}
for (const key of Object.keys(json)) {
if (Array.isArray(json[key])) {
- result[key] = json[key].map(v => v.replace(':9002', `:${server2.port}`))
+ result[key] = json[key].map(v => v.replace(':9002', `:${server.port}`))
} else {
- result[key] = json[key].replace(':9002', `:${server2.port}`)
+ result[key] = json[key].replace(':9002', `:${server.port}`)
}
}
}
describe('Test ActivityPub security', function () {
- let servers: ServerInfo[]
+ let servers: PeerTubeServer[]
let url: string
- const keys = require('./json/peertube/keys.json')
- const invalidKeys = require('./json/peertube/invalid-keys.json')
+ const keys = require(buildAbsoluteFixturePath('./ap-json/peertube/keys.json'))
+ const invalidKeys = require(buildAbsoluteFixturePath('./ap-json/peertube/invalid-keys.json'))
const baseHttpSignature = () => ({
algorithm: HTTP_SIGNATURE.ALGORITHM,
authorizationHeaderName: HTTP_SIGNATURE.HEADER_NAME,
- keyId: 'acct:peertube@localhost:' + servers[1].port,
+ keyId: 'acct:peertube@' + servers[1].host,
key: keys.privateKey,
headers: HTTP_SIGNATURE.HEADERS_TO_SIGN
})
before(async function () {
this.timeout(60000)
- servers = await flushAndRunMultipleServers(3)
+ servers = await createMultipleServers(3)
url = servers[0].url + '/inbox'
- await setKeysOfServer(servers[0], servers[1], keys.publicKey, keys.privateKey)
+ await setKeysOfServer(servers[0], servers[1], keys.publicKey, null)
+ await setKeysOfServer(servers[1], servers[1], keys.publicKey, keys.privateKey)
- const to = { url: 'http://localhost:' + servers[0].port + '/accounts/peertube' }
- const by = { url: 'http://localhost:' + servers[1].port + '/accounts/peertube', privateKey: keys.privateKey }
+ const to = { url: servers[0].url + '/accounts/peertube' }
+ const by = { url: servers[1].url + '/accounts/peertube', privateKey: keys.privateKey }
await makeFollowRequest(to, by)
})
describe('When checking HTTP signature', function () {
it('Should fail with an invalid digest', async function () {
- const body = activityPubContextify(getAnnounceWithoutContext(servers[1]))
+ const body = activityPubContextify(getAnnounceWithoutContext(servers[1]), 'Announce')
const headers = {
Digest: buildDigest({ hello: 'coucou' })
}
- const { response } = await makePOSTAPRequest(url, body, baseHttpSignature(), headers)
-
- expect(response.statusCode).to.equal(403)
+ try {
+ await makePOSTAPRequest(url, body, baseHttpSignature(), headers)
+ expect(true, 'Did not throw').to.be.false
+ } catch (err) {
+ expect(err.statusCode).to.equal(HttpStatusCode.FORBIDDEN_403)
+ }
})
it('Should fail with an invalid date', async function () {
- const body = activityPubContextify(getAnnounceWithoutContext(servers[1]))
+ const body = activityPubContextify(getAnnounceWithoutContext(servers[1]), 'Announce')
const headers = buildGlobalHeaders(body)
headers['date'] = 'Wed, 21 Oct 2015 07:28:00 GMT'
- const { response } = await makePOSTAPRequest(url, body, baseHttpSignature(), headers)
-
- expect(response.statusCode).to.equal(403)
+ try {
+ await makePOSTAPRequest(url, body, baseHttpSignature(), headers)
+ expect(true, 'Did not throw').to.be.false
+ } catch (err) {
+ expect(err.statusCode).to.equal(HttpStatusCode.FORBIDDEN_403)
+ }
})
it('Should fail with bad keys', async function () {
await setKeysOfServer(servers[0], servers[1], invalidKeys.publicKey, invalidKeys.privateKey)
await setKeysOfServer(servers[1], servers[1], invalidKeys.publicKey, invalidKeys.privateKey)
- const body = activityPubContextify(getAnnounceWithoutContext(servers[1]))
+ const body = activityPubContextify(getAnnounceWithoutContext(servers[1]), 'Announce')
const headers = buildGlobalHeaders(body)
- const { response } = await makePOSTAPRequest(url, body, baseHttpSignature(), headers)
-
- expect(response.statusCode).to.equal(403)
+ try {
+ await makePOSTAPRequest(url, body, baseHttpSignature(), headers)
+ expect(true, 'Did not throw').to.be.false
+ } catch (err) {
+ expect(err.statusCode).to.equal(HttpStatusCode.FORBIDDEN_403)
+ }
})
- it('Should succeed with a valid HTTP signature', async function () {
+ it('Should reject requests without appropriate signed headers', async function () {
await setKeysOfServer(servers[0], servers[1], keys.publicKey, keys.privateKey)
await setKeysOfServer(servers[1], servers[1], keys.publicKey, keys.privateKey)
- const body = activityPubContextify(getAnnounceWithoutContext(servers[1]))
+ const body = activityPubContextify(getAnnounceWithoutContext(servers[1]), 'Announce')
const headers = buildGlobalHeaders(body)
- const { response } = await makePOSTAPRequest(url, body, baseHttpSignature(), headers)
+ const signatureOptions = baseHttpSignature()
+ const badHeadersMatrix = [
+ [ '(request-target)', 'date', 'digest' ],
+ [ 'host', 'date', 'digest' ],
+ [ '(request-target)', 'host', 'digest' ]
+ ]
+
+ for (const badHeaders of badHeadersMatrix) {
+ signatureOptions.headers = badHeaders
+
+ try {
+ await makePOSTAPRequest(url, body, signatureOptions, headers)
+ expect(true, 'Did not throw').to.be.false
+ } catch (err) {
+ expect(err.statusCode).to.equal(HttpStatusCode.FORBIDDEN_403)
+ }
+ }
+ })
- expect(response.statusCode).to.equal(204)
+ it('Should succeed with a valid HTTP signature draft 11 (without date but with (created))', async function () {
+ const body = activityPubContextify(getAnnounceWithoutContext(servers[1]), 'Announce')
+ const headers = buildGlobalHeaders(body)
+
+ const signatureOptions = baseHttpSignature()
+ signatureOptions.headers = [ '(request-target)', '(created)', 'host', 'digest' ]
+
+ const { statusCode } = await makePOSTAPRequest(url, body, signatureOptions, headers)
+ expect(statusCode).to.equal(HttpStatusCode.NO_CONTENT_204)
+ })
+
+ it('Should succeed with a valid HTTP signature', async function () {
+ const body = activityPubContextify(getAnnounceWithoutContext(servers[1]), 'Announce')
+ const headers = buildGlobalHeaders(body)
+
+ const { statusCode } = await makePOSTAPRequest(url, body, baseHttpSignature(), headers)
+ expect(statusCode).to.equal(HttpStatusCode.NO_CONTENT_204)
+ })
+
+ it('Should refresh the actor keys', async function () {
+ this.timeout(20000)
+
+ // Update keys of server 2 to invalid keys
+ // Server 1 should refresh the actor and fail
+ await setKeysOfServer(servers[1], servers[1], invalidKeys.publicKey, invalidKeys.privateKey)
+ await setUpdatedAtOfServer(servers[0], servers[1], '2015-07-17 22:00:00+00')
+
+ // Invalid peertube actor cache
+ await killallServers([ servers[1] ])
+ await servers[1].run()
+
+ const body = activityPubContextify(getAnnounceWithoutContext(servers[1]), 'Announce')
+ const headers = buildGlobalHeaders(body)
+
+ try {
+ await makePOSTAPRequest(url, body, baseHttpSignature(), headers)
+ expect(true, 'Did not throw').to.be.false
+ } catch (err) {
+ console.error(err)
+ expect(err.statusCode).to.equal(HttpStatusCode.FORBIDDEN_403)
+ }
})
})
describe('When checking Linked Data Signature', function () {
- before(async () => {
+ before(async function () {
+ this.timeout(10000)
+
+ await setKeysOfServer(servers[0], servers[1], keys.publicKey, keys.privateKey)
+ await setKeysOfServer(servers[1], servers[1], keys.publicKey, keys.privateKey)
await setKeysOfServer(servers[2], servers[2], keys.publicKey, keys.privateKey)
- const to = { url: 'http://localhost:' + servers[0].port + '/accounts/peertube' }
- const by = { url: 'http://localhost:' + servers[2].port + '/accounts/peertube', privateKey: keys.privateKey }
+ const to = { url: servers[0].url + '/accounts/peertube' }
+ const by = { url: servers[2].url + '/accounts/peertube', privateKey: keys.privateKey }
await makeFollowRequest(to, by)
})
await setKeysOfServer(servers[2], servers[2], invalidKeys.publicKey, invalidKeys.privateKey)
const body = getAnnounceWithoutContext(servers[1])
- body.actor = 'http://localhost:' + servers[2].port + '/accounts/peertube'
+ body.actor = servers[2].url + '/accounts/peertube'
- const signer: any = { privateKey: invalidKeys.privateKey, url: 'http://localhost:' + servers[2].port + '/accounts/peertube' }
- const signedBody = await buildSignedActivity(signer, body)
+ const signer: any = { privateKey: invalidKeys.privateKey, url: servers[2].url + '/accounts/peertube' }
+ const signedBody = await signAndContextify(signer, body, 'Announce')
const headers = buildGlobalHeaders(signedBody)
- const { response } = await makePOSTAPRequest(url, signedBody, baseHttpSignature(), headers)
-
- expect(response.statusCode).to.equal(403)
+ try {
+ await makePOSTAPRequest(url, signedBody, baseHttpSignature(), headers)
+ expect(true, 'Did not throw').to.be.false
+ } catch (err) {
+ expect(err.statusCode).to.equal(HttpStatusCode.FORBIDDEN_403)
+ }
})
it('Should fail with an altered body', async function () {
await setKeysOfServer(servers[0], servers[2], keys.publicKey, keys.privateKey)
const body = getAnnounceWithoutContext(servers[1])
- body.actor = 'http://localhost:' + servers[2].port + '/accounts/peertube'
+ body.actor = servers[2].url + '/accounts/peertube'
- const signer: any = { privateKey: keys.privateKey, url: 'http://localhost:' + servers[2].port + '/accounts/peertube' }
- const signedBody = await buildSignedActivity(signer, body)
+ const signer: any = { privateKey: keys.privateKey, url: servers[2].url + '/accounts/peertube' }
+ const signedBody = await signAndContextify(signer, body, 'Announce')
- signedBody.actor = 'http://localhost:' + servers[2].port + '/account/peertube'
+ signedBody.actor = servers[2].url + '/account/peertube'
const headers = buildGlobalHeaders(signedBody)
- const { response } = await makePOSTAPRequest(url, signedBody, baseHttpSignature(), headers)
-
- expect(response.statusCode).to.equal(403)
+ try {
+ await makePOSTAPRequest(url, signedBody, baseHttpSignature(), headers)
+ expect(true, 'Did not throw').to.be.false
+ } catch (err) {
+ expect(err.statusCode).to.equal(HttpStatusCode.FORBIDDEN_403)
+ }
})
it('Should succeed with a valid signature', async function () {
this.timeout(10000)
const body = getAnnounceWithoutContext(servers[1])
- body.actor = 'http://localhost:' + servers[2].port + '/accounts/peertube'
+ body.actor = servers[2].url + '/accounts/peertube'
- const signer: any = { privateKey: keys.privateKey, url: 'http://localhost:' + servers[2].port + '/accounts/peertube' }
- const signedBody = await buildSignedActivity(signer, body)
+ const signer: any = { privateKey: keys.privateKey, url: servers[2].url + '/accounts/peertube' }
+ const signedBody = await signAndContextify(signer, body, 'Announce')
const headers = buildGlobalHeaders(signedBody)
- const { response } = await makePOSTAPRequest(url, signedBody, baseHttpSignature(), headers)
+ const { statusCode } = await makePOSTAPRequest(url, signedBody, baseHttpSignature(), headers)
+ expect(statusCode).to.equal(HttpStatusCode.NO_CONTENT_204)
+ })
+
+ it('Should refresh the actor keys', async function () {
+ this.timeout(20000)
+
+ // Wait refresh invalidation
+ await wait(10000)
+
+ // Update keys of server 3 to invalid keys
+ // Server 1 should refresh the actor and fail
+ await setKeysOfServer(servers[2], servers[2], invalidKeys.publicKey, invalidKeys.privateKey)
+
+ const body = getAnnounceWithoutContext(servers[1])
+ body.actor = servers[2].url + '/accounts/peertube'
+
+ const signer: any = { privateKey: keys.privateKey, url: servers[2].url + '/accounts/peertube' }
+ const signedBody = await signAndContextify(signer, body, 'Announce')
+
+ const headers = buildGlobalHeaders(signedBody)
- expect(response.statusCode).to.equal(204)
+ try {
+ await makePOSTAPRequest(url, signedBody, baseHttpSignature(), headers)
+ expect(true, 'Did not throw').to.be.false
+ } catch (err) {
+ expect(err.statusCode).to.equal(HttpStatusCode.FORBIDDEN_403)
+ }
})
})
this.timeout(10000)
await cleanupTests(servers)
-
- await closeAllSequelize(servers)
})
})
projects / github / Chocobozzz / PeerTube.git / blobdiff