import * as express from 'express'
import 'express-validator'
-import { body, param, query, ValidationChain } from 'express-validator/check'
+import { body, param, ValidationChain } from 'express-validator/check'
import { UserRight, VideoPrivacy } from '../../../shared'
import {
isBooleanValid,
import {
checkUserCanManageVideo,
isScheduleVideoUpdatePrivacyValid,
- isVideoAbuseReasonValid,
isVideoCategoryValid,
isVideoChannelOfAccountExist,
isVideoDescriptionValid,
import { VideoShareModel } from '../../models/video/video-share'
import { authenticate } from '../oauth'
import { areValidationErrors } from './utils'
+import { cleanUpReqFiles } from '../../helpers/utils'
+import { VideoModel } from '../../models/video/video'
+import { UserModel } from '../../models/account/user'
const videosAddValidator = getCommonVideoAttributes().concat([
body('videofile')
async (req: express.Request, res: express.Response, next: express.NextFunction) => {
logger.debug('Checking videosAdd parameters', { parameters: req.body, files: req.files })
- if (areValidationErrors(req, res)) return
- if (areErrorsInVideoImageFiles(req, res)) return
- if (areErrorsInScheduleUpdate(req, res)) return
+ if (areValidationErrors(req, res)) return cleanUpReqFiles(req)
+ if (areErrorsInScheduleUpdate(req, res)) return cleanUpReqFiles(req)
const videoFile: Express.Multer.File = req.files['videofile'][0]
const user = res.locals.oauth.token.User
- if (!await isVideoChannelOfAccountExist(req.body.channelId, user, res)) return
+ if (!await isVideoChannelOfAccountExist(req.body.channelId, user, res)) return cleanUpReqFiles(req)
const isAble = await user.isAbleToUploadVideo(videoFile)
if (isAble === false) {
.json({ error: 'The user video quota is exceeded with this video.' })
.end()
- return
+ return cleanUpReqFiles(req)
}
let duration: number
.json({ error: 'Invalid input file.' })
.end()
- return
+ return cleanUpReqFiles(req)
}
videoFile['duration'] = duration
async (req: express.Request, res: express.Response, next: express.NextFunction) => {
logger.debug('Checking videosUpdate parameters', { parameters: req.body })
- if (areValidationErrors(req, res)) return
- if (areErrorsInVideoImageFiles(req, res)) return
- if (areErrorsInScheduleUpdate(req, res)) return
- if (!await isVideoExist(req.params.id, res)) return
+ if (areValidationErrors(req, res)) return cleanUpReqFiles(req)
+ if (areErrorsInScheduleUpdate(req, res)) return cleanUpReqFiles(req)
+ if (!await isVideoExist(req.params.id, res)) return cleanUpReqFiles(req)
const video = res.locals.video
// Check if the user who did the request is able to update the video
const user = res.locals.oauth.token.User
- if (!checkUserCanManageVideo(user, res.locals.video, UserRight.UPDATE_ANY_VIDEO, res)) return
+ if (!checkUserCanManageVideo(user, res.locals.video, UserRight.UPDATE_ANY_VIDEO, res)) return cleanUpReqFiles(req)
if (video.privacy !== VideoPrivacy.PRIVATE && req.body.privacy === VideoPrivacy.PRIVATE) {
+ cleanUpReqFiles(req)
return res.status(409)
.json({ error: 'Cannot set "private" a video that was not private.' })
.end()
}
- if (req.body.channelId && !await isVideoChannelOfAccountExist(req.body.channelId, user, res)) return
+ if (req.body.channelId && !await isVideoChannelOfAccountExist(req.body.channelId, user, res)) return cleanUpReqFiles(req)
return next()
}
if (areValidationErrors(req, res)) return
if (!await isVideoExist(req.params.id, res)) return
- const video = res.locals.video
+ const video: VideoModel = res.locals.video
+
+ // Video private or blacklisted
+ if (video.privacy === VideoPrivacy.PRIVATE || video.VideoBlacklist) {
+ authenticate(req, res, () => {
+ const user: UserModel = res.locals.oauth.token.User
+
+ // Only the owner or a user that have blacklist rights can see the video
+ if (video.VideoChannel.Account.userId !== user.id && !user.hasRight(UserRight.MANAGE_VIDEO_BLACKLIST)) {
+ return res.status(403)
+ .json({ error: 'Cannot get this private or blacklisted video.' })
+ .end()
+ }
+
+ return next()
+ })
+
+ return
+ }
// Video is public, anyone can access it
if (video.privacy === VideoPrivacy.PUBLIC) return next()
// Don't leak this unlisted video
return res.status(404).end()
}
-
- // Video is private, check the user
- authenticate(req, res, () => {
- if (video.VideoChannel.Account.userId !== res.locals.oauth.token.User.id) {
- return res.status(403)
- .json({ error: 'Cannot get this private video of another user' })
- .end()
- }
-
- return next()
- })
}
]
}
]
-const videosSearchValidator = [
- query('search').not().isEmpty().withMessage('Should have a valid search'),
-
- (req: express.Request, res: express.Response, next: express.NextFunction) => {
- logger.debug('Checking videosSearch parameters', { parameters: req.params })
-
- if (areValidationErrors(req, res)) return
-
- return next()
- }
-]
-
-const videoAbuseReportValidator = [
- param('id').custom(isIdOrUUIDValid).not().isEmpty().withMessage('Should have a valid id'),
- body('reason').custom(isVideoAbuseReasonValid).withMessage('Should have a valid reason'),
-
- async (req: express.Request, res: express.Response, next: express.NextFunction) => {
- logger.debug('Checking videoAbuseReport parameters', { parameters: req.body })
-
- if (areValidationErrors(req, res)) return
- if (!await isVideoExist(req.params.id, res)) return
-
- return next()
- }
-]
-
const videoRateValidator = [
param('id').custom(isIdOrUUIDValid).not().isEmpty().withMessage('Should have a valid id'),
body('rating').custom(isVideoRatingTypeValid).withMessage('Should have a valid rate type'),
}
]
-// ---------------------------------------------------------------------------
-
-export {
- videosAddValidator,
- videosUpdateValidator,
- videosGetValidator,
- videosRemoveValidator,
- videosSearchValidator,
- videosShareValidator,
-
- videoAbuseReportValidator,
-
- videoRateValidator
-}
-
-// ---------------------------------------------------------------------------
-
-function areErrorsInVideoImageFiles (req: express.Request, res: express.Response) {
- // Files are optional
- if (!req.files) return false
-
- for (const imageField of [ 'thumbnail', 'preview' ]) {
- if (!req.files[ imageField ]) continue
-
- const imageFile = req.files[ imageField ][ 0 ] as Express.Multer.File
- if (imageFile.size > CONSTRAINTS_FIELDS.VIDEOS.IMAGE.FILE_SIZE.max) {
- res.status(400)
- .json({ error: `The size of the ${imageField} is too big (>${CONSTRAINTS_FIELDS.VIDEOS.IMAGE.FILE_SIZE.max}).` })
- .end()
- return true
- }
- }
-
- return false
-}
-
-function areErrorsInScheduleUpdate (req: express.Request, res: express.Response) {
- if (req.body.scheduleUpdate) {
- if (!req.body.scheduleUpdate.updateAt) {
- res.status(400)
- .json({ error: 'Schedule update at is mandatory.' })
- .end()
-
- return true
- }
- }
-
- return false
-}
-
function getCommonVideoAttributes () {
return [
body('thumbnailfile')
.custom(isScheduleVideoUpdatePrivacyValid).withMessage('Should have correct schedule update privacy')
] as (ValidationChain | express.Handler)[]
}
+
+// ---------------------------------------------------------------------------
+
+export {
+ videosAddValidator,
+ videosUpdateValidator,
+ videosGetValidator,
+ videosRemoveValidator,
+ videosShareValidator,
+
+ videoRateValidator,
+
+ getCommonVideoAttributes
+}
+
+// ---------------------------------------------------------------------------
+
+function areErrorsInScheduleUpdate (req: express.Request, res: express.Response) {
+ if (req.body.scheduleUpdate) {
+ if (!req.body.scheduleUpdate.updateAt) {
+ res.status(400)
+ .json({ error: 'Schedule update at is mandatory.' })
+ .end()
+
+ return true
+ }
+ }
+
+ return false
+}
projects / github / Chocobozzz / PeerTube.git / blobdiff