import { isAbleToUploadVideo } from '@server/lib/user'
import { getServerActor } from '@server/models/application/application'
import { ExpressPromiseHandler } from '@server/types/express'
-import { MUserAccountId, MVideoWithRights } from '@server/types/models'
-import { ServerErrorCode, UserRight, VideoChangeOwnershipStatus, VideoPrivacy } from '../../../../shared'
-import { HttpStatusCode } from '../../../../shared/core-utils/miscs/http-error-codes'
-import { VideoChangeOwnershipAccept } from '../../../../shared/models/videos/change-ownership/video-change-ownership-accept.model'
+import { MUserAccountId, MVideoFullLight } from '@server/types/models'
+import { ServerErrorCode, UserRight, VideoPrivacy } from '../../../../shared'
+import { HttpStatusCode } from '../../../../shared/models/http/http-error-codes'
import {
exists,
isBooleanValid,
isDateValid,
isFileFieldValid,
- isIdOrUUIDValid,
isIdValid,
isUUIDValid,
toArray,
toValueOrNull
} from '../../../helpers/custom-validators/misc'
import { isBooleanBothQueryValid, isNumberArray, isStringArray } from '../../../helpers/custom-validators/search'
-import { checkUserCanTerminateOwnershipChange, doesChangeVideoOwnershipExist } from '../../../helpers/custom-validators/video-ownership'
import {
isScheduleVideoUpdatePrivacyValid,
isVideoCategoryValid,
import { cleanUpReqFiles } from '../../../helpers/express-utils'
import { getDurationFromVideoFile } from '../../../helpers/ffprobe-utils'
import { logger } from '../../../helpers/logger'
-import {
- checkUserCanManageVideo,
- doesVideoChannelOfAccountExist,
- doesVideoExist,
- doesVideoFileOfVideoExist
-} from '../../../helpers/middlewares'
import { deleteFileAndCatch } from '../../../helpers/utils'
import { getVideoWithAttributes } from '../../../helpers/video'
import { CONFIG } from '../../../initializers/config'
import { CONSTRAINTS_FIELDS, OVERVIEWS } from '../../../initializers/constants'
import { isLocalVideoAccepted } from '../../../lib/moderation'
import { Hooks } from '../../../lib/plugins/hooks'
-import { AccountModel } from '../../../models/account/account'
import { VideoModel } from '../../../models/video/video'
import { authenticatePromiseIfNeeded } from '../../auth'
-import { areValidationErrors } from '../utils'
+import {
+ areValidationErrors,
+ checkUserCanManageVideo,
+ doesVideoChannelOfAccountExist,
+ doesVideoExist,
+ doesVideoFileOfVideoExist,
+ isValidVideoIdParam
+} from '../shared'
const videosAddLegacyValidator = getCommonVideoEditAttributes().concat([
body('videofile')
.withMessage('Should have a file'),
body('name')
.trim()
- .custom(isVideoNameValid)
- .withMessage('Should have a valid name'),
+ .custom(isVideoNameValid).withMessage(
+ `Should have a video name between ${CONSTRAINTS_FIELDS.VIDEOS.NAME.min} and ${CONSTRAINTS_FIELDS.VIDEOS.NAME.max} characters long`
+ ),
body('channelId')
.customSanitizer(toIntOrNull)
.custom(isIdValid).withMessage('Should have correct video channel id'),
if (!videoFile.duration) await addDurationToVideo(videoFile)
} catch (err) {
logger.error('Invalid input file in videosAddLegacyValidator.', { err })
- res.status(HttpStatusCode.UNPROCESSABLE_ENTITY_422)
- .json({ error: 'Video file unreadable.' })
+ res.fail({
+ status: HttpStatusCode.UNPROCESSABLE_ENTITY_422,
+ message: 'Video file unreadable.'
+ })
return cleanUpReqFiles(req)
}
if (!file.duration) await addDurationToVideo(file)
} catch (err) {
logger.error('Invalid input file in videosAddResumableValidator.', { err })
- res.status(HttpStatusCode.UNPROCESSABLE_ENTITY_422)
- .json({ error: 'Video file unreadable.' })
+ res.fail({
+ status: HttpStatusCode.UNPROCESSABLE_ENTITY_422,
+ message: 'Video file unreadable.'
+ })
return cleanup()
}
.withMessage('Should have a valid filename'),
body('name')
.trim()
- .custom(isVideoNameValid)
- .withMessage('Should have a valid name'),
+ .custom(isVideoNameValid).withMessage(
+ `Should have a video name between ${CONSTRAINTS_FIELDS.VIDEOS.NAME.min} and ${CONSTRAINTS_FIELDS.VIDEOS.NAME.max} characters long`
+ ),
body('channelId')
.customSanitizer(toIntOrNull)
.custom(isIdValid).withMessage('Should have correct video channel id'),
])
const videosUpdateValidator = getCommonVideoEditAttributes().concat([
- param('id').custom(isIdOrUUIDValid).not().isEmpty().withMessage('Should have a valid id'),
+ isValidVideoIdParam('id'),
+
body('name')
.optional()
.trim()
- .custom(isVideoNameValid).withMessage('Should have a valid name'),
+ .custom(isVideoNameValid).withMessage(
+ `Should have a video name between ${CONSTRAINTS_FIELDS.VIDEOS.NAME.min} and ${CONSTRAINTS_FIELDS.VIDEOS.NAME.max} characters long`
+ ),
body('channelId')
.optional()
.customSanitizer(toIntOrNull)
const serverActor = await getServerActor()
if (await VideoModel.checkVideoHasInstanceFollow(video.id, serverActor.id) === true) return next()
- return res.status(HttpStatusCode.FORBIDDEN_403)
- .json({
- errorCode: ServerErrorCode.DOES_NOT_RESPECT_FOLLOW_CONSTRAINTS,
- error: 'Cannot get this video regarding follow constraints.',
- originUrl: video.url
- })
+ return res.fail({
+ status: HttpStatusCode.FORBIDDEN_403,
+ message: 'Cannot get this video regarding follow constraints',
+ type: ServerErrorCode.DOES_NOT_RESPECT_FOLLOW_CONSTRAINTS,
+ data: {
+ originUrl: video.url
+ }
+ })
}
const videosCustomGetValidator = (
- fetchType: 'all' | 'only-video' | 'only-video-with-rights' | 'only-immutable-attributes',
+ fetchType: 'for-api' | 'all' | 'only-video' | 'only-immutable-attributes',
authenticateInQuery = false
) => {
return [
- param('id').custom(isIdOrUUIDValid).not().isEmpty().withMessage('Should have a valid id'),
+ isValidVideoIdParam('id'),
async (req: express.Request, res: express.Response, next: express.NextFunction) => {
logger.debug('Checking videosGet parameters', { parameters: req.params })
// Controllers does not need to check video rights
if (fetchType === 'only-immutable-attributes') return next()
- const video = getVideoWithAttributes(res) as MVideoWithRights
+ const video = getVideoWithAttributes(res) as MVideoFullLight
// Video private or blacklisted
if (video.requiresAuth()) {
const user = res.locals.oauth ? res.locals.oauth.token.User : null
- // Only the owner or a user that have blacklist rights can see the video
+ // Only the owner or a user that have blocklist rights can see the video
if (!user || !user.canGetVideo(video)) {
- return res.status(HttpStatusCode.FORBIDDEN_403)
- .json({ error: 'Cannot get this private/internal or blacklisted video.' })
+ return res.fail({
+ status: HttpStatusCode.FORBIDDEN_403,
+ message: 'Cannot get this private/internal or blocklisted video'
+ })
}
return next()
if (isUUIDValid(req.params.id)) return next()
// Don't leak this unlisted video
- return res.status(HttpStatusCode.NOT_FOUND_404).end()
+ return res.fail({
+ status: HttpStatusCode.NOT_FOUND_404,
+ message: 'Video not found'
+ })
}
}
]
const videosDownloadValidator = videosCustomGetValidator('all', true)
const videoFileMetadataGetValidator = getCommonVideoEditAttributes().concat([
- param('id').custom(isIdOrUUIDValid).not().isEmpty().withMessage('Should have a valid id'),
- param('videoFileId').custom(isIdValid).not().isEmpty().withMessage('Should have a valid videoFileId'),
+ isValidVideoIdParam('id'),
+
+ param('videoFileId')
+ .custom(isIdValid).not().isEmpty().withMessage('Should have a valid videoFileId'),
async (req: express.Request, res: express.Response, next: express.NextFunction) => {
logger.debug('Checking videoFileMetadataGet parameters', { parameters: req.params })
])
const videosRemoveValidator = [
- param('id').custom(isIdOrUUIDValid).not().isEmpty().withMessage('Should have a valid id'),
+ isValidVideoIdParam('id'),
async (req: express.Request, res: express.Response, next: express.NextFunction) => {
logger.debug('Checking videosRemove parameters', { parameters: req.params })
}
]
-const videosChangeOwnershipValidator = [
- param('videoId').custom(isIdOrUUIDValid).not().isEmpty().withMessage('Should have a valid id'),
-
- async (req: express.Request, res: express.Response, next: express.NextFunction) => {
- logger.debug('Checking changeOwnership parameters', { parameters: req.params })
-
- if (areValidationErrors(req, res)) return
- if (!await doesVideoExist(req.params.videoId, res)) return
-
- // Check if the user who did the request is able to change the ownership of the video
- if (!checkUserCanManageVideo(res.locals.oauth.token.User, res.locals.videoAll, UserRight.CHANGE_VIDEO_OWNERSHIP, res)) return
-
- const nextOwner = await AccountModel.loadLocalByName(req.body.username)
- if (!nextOwner) {
- res.status(HttpStatusCode.BAD_REQUEST_400)
- .json({ error: 'Changing video ownership to a remote account is not supported yet' })
-
- return
- }
- res.locals.nextOwner = nextOwner
-
- return next()
- }
-]
-
-const videosTerminateChangeOwnershipValidator = [
- param('id').custom(isIdOrUUIDValid).not().isEmpty().withMessage('Should have a valid id'),
-
- async (req: express.Request, res: express.Response, next: express.NextFunction) => {
- logger.debug('Checking changeOwnership parameters', { parameters: req.params })
-
- if (areValidationErrors(req, res)) return
- if (!await doesChangeVideoOwnershipExist(req.params.id, res)) return
-
- // Check if the user who did the request is able to change the ownership of the video
- if (!checkUserCanTerminateOwnershipChange(res.locals.oauth.token.User, res.locals.videoChangeOwnership, res)) return
-
- const videoChangeOwnership = res.locals.videoChangeOwnership
-
- if (videoChangeOwnership.status !== VideoChangeOwnershipStatus.WAITING) {
- res.status(HttpStatusCode.FORBIDDEN_403)
- .json({ error: 'Ownership already accepted or refused' })
- return
- }
-
- return next()
- }
-]
-
-const videosAcceptChangeOwnershipValidator = [
- async (req: express.Request, res: express.Response, next: express.NextFunction) => {
- const body = req.body as VideoChangeOwnershipAccept
- if (!await doesVideoChannelOfAccountExist(body.channelId, res.locals.oauth.token.User, res)) return
-
- const user = res.locals.oauth.token.User
- const videoChangeOwnership = res.locals.videoChangeOwnership
- const isAble = await isAbleToUploadVideo(user.id, videoChangeOwnership.Video.getMaxQualityFile().size)
- if (isAble === false) {
- res.status(HttpStatusCode.PAYLOAD_TOO_LARGE_413)
- .json({ error: 'The user video quota is exceeded with this video.' })
-
- return
- }
-
- return next()
- }
-]
-
const videosOverviewValidator = [
query('page')
.optional()
body('tags')
.optional()
.customSanitizer(toValueOrNull)
- .custom(isVideoTagsValid).withMessage('Should have correct tags'),
+ .custom(isVideoTagsValid)
+ .withMessage(
+ `Should have an array of up to ${CONSTRAINTS_FIELDS.VIDEOS.TAGS.max} tags between ` +
+ `${CONSTRAINTS_FIELDS.VIDEOS.TAG.min} and ${CONSTRAINTS_FIELDS.VIDEOS.TAG.max} characters each`
+ ),
body('commentsEnabled')
.optional()
.customSanitizer(toBooleanOrNull)
(req.query.filter === 'all-local' || req.query.filter === 'all') &&
(!user || user.hasRight(UserRight.SEE_ALL_VIDEOS) === false)
) {
- res.status(HttpStatusCode.UNAUTHORIZED_401)
- .json({ error: 'You are not allowed to see all local videos.' })
-
+ res.fail({
+ status: HttpStatusCode.UNAUTHORIZED_401,
+ message: 'You are not allowed to see all local videos.'
+ })
return
}
videosCustomGetValidator,
videosRemoveValidator,
- videosChangeOwnershipValidator,
- videosTerminateChangeOwnershipValidator,
- videosAcceptChangeOwnershipValidator,
-
getCommonVideoEditAttributes,
commonVideosFiltersValidator,
if (!req.body.scheduleUpdate.updateAt) {
logger.warn('Invalid parameters: scheduleUpdate.updateAt is mandatory.')
- res.status(HttpStatusCode.BAD_REQUEST_400)
- .json({ error: 'Schedule update at is mandatory.' })
-
+ res.fail({ message: 'Schedule update at is mandatory.' })
return true
}
}
if (!await doesVideoChannelOfAccountExist(req.body.channelId, user, res)) return false
if (!isVideoFileMimeTypeValid(files)) {
- res.status(HttpStatusCode.UNSUPPORTED_MEDIA_TYPE_415)
- .json({
- error: 'This file is not supported. Please, make sure it is of the following type: ' +
- CONSTRAINTS_FIELDS.VIDEOS.EXTNAME.join(', ')
- })
-
+ res.fail({
+ status: HttpStatusCode.UNSUPPORTED_MEDIA_TYPE_415,
+ message: 'This file is not supported. Please, make sure it is of the following type: ' +
+ CONSTRAINTS_FIELDS.VIDEOS.EXTNAME.join(', ')
+ })
return false
}
if (!isVideoFileSizeValid(videoFileSize.toString())) {
- res.status(HttpStatusCode.PAYLOAD_TOO_LARGE_413)
- .json({ error: 'This file is too large. It exceeds the maximum file size authorized.' })
-
+ res.fail({
+ status: HttpStatusCode.PAYLOAD_TOO_LARGE_413,
+ message: 'This file is too large. It exceeds the maximum file size authorized.',
+ type: ServerErrorCode.MAX_FILE_SIZE_REACHED
+ })
return false
}
if (await isAbleToUploadVideo(user.id, videoFileSize) === false) {
- res.status(HttpStatusCode.PAYLOAD_TOO_LARGE_413)
- .json({ error: 'The user video quota is exceeded with this video.' })
-
+ res.fail({
+ status: HttpStatusCode.PAYLOAD_TOO_LARGE_413,
+ message: 'The user video quota is exceeded with this video.',
+ type: ServerErrorCode.QUOTA_REACHED
+ })
return false
}
if (!acceptedResult || acceptedResult.accepted !== true) {
logger.info('Refused local video.', { acceptedResult, acceptParameters })
- res.status(HttpStatusCode.FORBIDDEN_403)
- .json({ error: acceptedResult.errorMessage || 'Refused local video' })
-
+ res.fail({
+ status: HttpStatusCode.FORBIDDEN_403,
+ message: acceptedResult.errorMessage || 'Refused local video'
+ })
return false
}
projects / github / Chocobozzz / PeerTube.git / blobdiff