import * as express from 'express'
-import { body, param, ValidationChain } from 'express-validator/check'
-import { UserRight, VideoPrivacy } from '../../../../shared'
+import { body, param, query, ValidationChain } from 'express-validator/check'
+import { UserRight, VideoPlaylistCreate, VideoPlaylistUpdate } from '../../../../shared'
import { logger } from '../../../helpers/logger'
import { UserModel } from '../../../models/account/user'
import { areValidationErrors } from '../utils'
-import { isVideoExist, isVideoImage } from '../../../helpers/custom-validators/videos'
+import { doesVideoExist, isVideoImage } from '../../../helpers/custom-validators/videos'
import { CONSTRAINTS_FIELDS } from '../../../initializers'
-import { isIdOrUUIDValid, toValueOrNull } from '../../../helpers/custom-validators/misc'
+import { isArrayOf, isIdOrUUIDValid, isIdValid, isUUIDValid, toIntArray, toValueOrNull } from '../../../helpers/custom-validators/misc'
import {
+ doesVideoPlaylistExist,
isVideoPlaylistDescriptionValid,
- isVideoPlaylistExist,
isVideoPlaylistNameValid,
- isVideoPlaylistPrivacyValid
+ isVideoPlaylistPrivacyValid,
+ isVideoPlaylistTimestampValid,
+ isVideoPlaylistTypeValid
} from '../../../helpers/custom-validators/video-playlists'
import { VideoPlaylistModel } from '../../../models/video/video-playlist'
import { cleanUpReqFiles } from '../../../helpers/express-utils'
-import { isVideoChannelIdExist } from '../../../helpers/custom-validators/video-channels'
+import { doesVideoChannelIdExist } from '../../../helpers/custom-validators/video-channels'
import { VideoPlaylistElementModel } from '../../../models/video/video-playlist-element'
-import { VideoModel } from '../../../models/video/video'
import { authenticatePromiseIfNeeded } from '../../oauth'
import { VideoPlaylistPrivacy } from '../../../../shared/models/videos/playlist/video-playlist-privacy.model'
+import { VideoPlaylistType } from '../../../../shared/models/videos/playlist/video-playlist-type.model'
const videoPlaylistsAddValidator = getCommonPlaylistEditAttributes().concat([
async (req: express.Request, res: express.Response, next: express.NextFunction) => {
if (areValidationErrors(req, res)) return cleanUpReqFiles(req)
- if (req.body.videoChannelId && !await isVideoChannelIdExist(req.body.videoChannelId, res)) return cleanUpReqFiles(req)
+ const body: VideoPlaylistCreate = req.body
+ if (body.videoChannelId && !await doesVideoChannelIdExist(body.videoChannelId, res)) return cleanUpReqFiles(req)
+
+ if (body.privacy === VideoPlaylistPrivacy.PUBLIC && !body.videoChannelId) {
+ cleanUpReqFiles(req)
+ return res.status(400)
+ .json({ error: 'Cannot set "public" a playlist that is not assigned to a channel.' })
+ }
return next()
}
if (areValidationErrors(req, res)) return cleanUpReqFiles(req)
- if (!await isVideoPlaylistExist(req.params.playlistId, res)) return cleanUpReqFiles(req)
+ if (!await doesVideoPlaylistExist(req.params.playlistId, res, 'all')) return cleanUpReqFiles(req)
+
+ const videoPlaylist = res.locals.videoPlaylist
+
if (!checkUserCanManageVideoPlaylist(res.locals.oauth.token.User, res.locals.videoPlaylist, UserRight.REMOVE_ANY_VIDEO_PLAYLIST, res)) {
return cleanUpReqFiles(req)
}
- if (req.body.videoChannelId && !await isVideoChannelIdExist(req.body.videoChannelId, res)) return cleanUpReqFiles(req)
+ const body: VideoPlaylistUpdate = req.body
+
+ if (videoPlaylist.privacy !== VideoPlaylistPrivacy.PRIVATE && body.privacy === VideoPlaylistPrivacy.PRIVATE) {
+ cleanUpReqFiles(req)
+ return res.status(400)
+ .json({ error: 'Cannot set "private" a video playlist that was not private.' })
+ }
+
+ const newPrivacy = body.privacy || videoPlaylist.privacy
+ if (newPrivacy === VideoPlaylistPrivacy.PUBLIC &&
+ (
+ (!videoPlaylist.videoChannelId && !body.videoChannelId) ||
+ body.videoChannelId === null
+ )
+ ) {
+ cleanUpReqFiles(req)
+ return res.status(400)
+ .json({ error: 'Cannot set "public" a playlist that is not assigned to a channel.' })
+ }
+
+ if (videoPlaylist.type === VideoPlaylistType.WATCH_LATER) {
+ cleanUpReqFiles(req)
+ return res.status(400)
+ .json({ error: 'Cannot update a watch later playlist.' })
+ }
+
+ if (body.videoChannelId && !await doesVideoChannelIdExist(body.videoChannelId, res)) return cleanUpReqFiles(req)
return next()
}
if (areValidationErrors(req, res)) return
- if (!await isVideoPlaylistExist(req.params.playlistId, res)) return
+ if (!await doesVideoPlaylistExist(req.params.playlistId, res)) return
+
+ const videoPlaylist = res.locals.videoPlaylist
+ if (videoPlaylist.type === VideoPlaylistType.WATCH_LATER) {
+ return res.status(400)
+ .json({ error: 'Cannot delete a watch later playlist.' })
+ }
+
if (!checkUserCanManageVideoPlaylist(res.locals.oauth.token.User, res.locals.videoPlaylist, UserRight.REMOVE_ANY_VIDEO_PLAYLIST, res)) {
return
}
if (areValidationErrors(req, res)) return
- if (!await isVideoPlaylistExist(req.params.playlistId, res)) return
+ if (!await doesVideoPlaylistExist(req.params.playlistId, res)) return
+
+ const videoPlaylist = res.locals.videoPlaylist
+
+ // Video is unlisted, check we used the uuid to fetch it
+ if (videoPlaylist.privacy === VideoPlaylistPrivacy.UNLISTED) {
+ if (isUUIDValid(req.params.playlistId)) return next()
+
+ return res.status(404).end()
+ }
- const videoPlaylist: VideoPlaylistModel = res.locals.videoPlaylist
if (videoPlaylist.privacy === VideoPlaylistPrivacy.PRIVATE) {
await authenticatePromiseIfNeeded(req, res)
- const user: UserModel = res.locals.oauth ? res.locals.oauth.token.User : null
-
+ const user = res.locals.oauth ? res.locals.oauth.token.User : null
if (
!user ||
(videoPlaylist.OwnerAccount.userId !== user.id && !user.hasRight(UserRight.UPDATE_ANY_VIDEO_PLAYLIST))
.custom(isIdOrUUIDValid).withMessage('Should have a valid video id/uuid'),
body('startTimestamp')
.optional()
- .isInt({ min: 0 }).withMessage('Should have a valid start timestamp'),
+ .custom(isVideoPlaylistTimestampValid).withMessage('Should have a valid start timestamp'),
body('stopTimestamp')
.optional()
- .isInt({ min: 0 }).withMessage('Should have a valid stop timestamp'),
+ .custom(isVideoPlaylistTimestampValid).withMessage('Should have a valid stop timestamp'),
async (req: express.Request, res: express.Response, next: express.NextFunction) => {
logger.debug('Checking videoPlaylistsAddVideoValidator parameters', { parameters: req.params })
if (areValidationErrors(req, res)) return
- if (!await isVideoPlaylistExist(req.params.playlistId, res)) return
- if (!await isVideoExist(req.body.videoId, res, 'id')) return
+ if (!await doesVideoPlaylistExist(req.params.playlistId, res, 'all')) return
+ if (!await doesVideoExist(req.body.videoId, res, 'only-video')) return
- const videoPlaylist: VideoPlaylistModel = res.locals.videoPlaylist
- const video: VideoModel = res.locals.video
+ const videoPlaylist = res.locals.videoPlaylist
+ const video = res.locals.video
const videoPlaylistElement = await VideoPlaylistElementModel.loadByPlaylistAndVideo(videoPlaylist.id, video.id)
if (videoPlaylistElement) {
.custom(isIdOrUUIDValid).withMessage('Should have an video id/uuid'),
body('startTimestamp')
.optional()
- .isInt({ min: 0 }).withMessage('Should have a valid start timestamp'),
+ .custom(isVideoPlaylistTimestampValid).withMessage('Should have a valid start timestamp'),
body('stopTimestamp')
.optional()
- .isInt({ min: 0 }).withMessage('Should have a valid stop timestamp'),
+ .custom(isVideoPlaylistTimestampValid).withMessage('Should have a valid stop timestamp'),
async (req: express.Request, res: express.Response, next: express.NextFunction) => {
logger.debug('Checking videoPlaylistsRemoveVideoValidator parameters', { parameters: req.params })
if (areValidationErrors(req, res)) return
- if (!await isVideoPlaylistExist(req.params.playlistId, res)) return
- if (!await isVideoExist(req.params.playlistId, res, 'id')) return
+ if (!await doesVideoPlaylistExist(req.params.playlistId, res, 'all')) return
+ if (!await doesVideoExist(req.params.videoId, res, 'id')) return
- const videoPlaylist: VideoPlaylistModel = res.locals.videoPlaylist
- const video: VideoModel = res.locals.video
+ const videoPlaylist = res.locals.videoPlaylist
+ const video = res.locals.video
const videoPlaylistElement = await VideoPlaylistElementModel.loadByPlaylistAndVideo(videoPlaylist.id, video.id)
if (!videoPlaylistElement) {
if (areValidationErrors(req, res)) return
- if (!await isVideoPlaylistExist(req.params.playlistId, res)) return
+ if (!await doesVideoPlaylistExist(req.params.playlistId, res, 'all')) return
- const videoPlaylist: VideoPlaylistModel = res.locals.videoPlaylist
+ const videoPlaylist = res.locals.videoPlaylist
if (!checkUserCanManageVideoPlaylist(res.locals.oauth.token.User, videoPlaylist, UserRight.UPDATE_ANY_VIDEO_PLAYLIST, res)) return
+ const nextPosition = await VideoPlaylistElementModel.getNextPositionOf(videoPlaylist.id)
+ const startPosition: number = req.body.startPosition
+ const insertAfterPosition: number = req.body.insertAfterPosition
+ const reorderLength: number = req.body.reorderLength
+
+ if (startPosition >= nextPosition || insertAfterPosition >= nextPosition) {
+ res.status(400)
+ .json({ error: `Start position or insert after position exceed the playlist limits (max: ${nextPosition - 1})` })
+ .end()
+
+ return
+ }
+
+ if (reorderLength && reorderLength + startPosition > nextPosition) {
+ res.status(400)
+ .json({ error: `Reorder length with this start position exceeds the playlist limits (max: ${nextPosition - startPosition})` })
+ .end()
+
+ return
+ }
+
+ return next()
+ }
+]
+
+const commonVideoPlaylistFiltersValidator = [
+ query('playlistType')
+ .optional()
+ .custom(isVideoPlaylistTypeValid).withMessage('Should have a valid playlist type'),
+
+ (req: express.Request, res: express.Response, next: express.NextFunction) => {
+ logger.debug('Checking commonVideoPlaylistFiltersValidator parameters', { parameters: req.params })
+
+ if (areValidationErrors(req, res)) return
+
+ return next()
+ }
+]
+
+const doVideosInPlaylistExistValidator = [
+ query('videoIds')
+ .customSanitizer(toIntArray)
+ .custom(v => isArrayOf(v, isIdValid)).withMessage('Should have a valid video ids array'),
+
+ (req: express.Request, res: express.Response, next: express.NextFunction) => {
+ logger.debug('Checking areVideosInPlaylistExistValidator parameters', { parameters: req.query })
+
+ if (areValidationErrors(req, res)) return
+
return next()
}
]
videoPlaylistsUpdateOrRemoveVideoValidator,
videoPlaylistsReorderVideosValidator,
- videoPlaylistElementAPGetValidator
+ videoPlaylistElementAPGetValidator,
+
+ commonVideoPlaylistFiltersValidator,
+
+ doVideosInPlaylistExistValidator
}
// ---------------------------------------------------------------------------
.custom(isVideoPlaylistPrivacyValid).withMessage('Should have correct playlist privacy'),
body('videoChannelId')
.optional()
+ .customSanitizer(toValueOrNull)
.toInt()
] as (ValidationChain | express.Handler)[]
}