import * as express from 'express'
-import { body, param } from 'express-validator/check'
+import { body, param, query } from 'express-validator'
+import { VIDEO_CHANNELS } from '@server/initializers/constants'
+import { MChannelAccountDefault, MUser } from '@server/types/models'
import { UserRight } from '../../../../shared'
-import { isAccountNameWithHostExist } from '../../../helpers/custom-validators/accounts'
+import { HttpStatusCode } from '../../../../shared/core-utils/miscs/http-error-codes'
+import { isActorPreferredUsernameValid } from '../../../helpers/custom-validators/activitypub/actor'
+import { isBooleanValid, toBooleanOrNull } from '../../../helpers/custom-validators/misc'
import {
- isLocalVideoChannelNameExist,
isVideoChannelDescriptionValid,
isVideoChannelNameValid,
- isVideoChannelNameWithHostExist,
isVideoChannelSupportValid
} from '../../../helpers/custom-validators/video-channels'
import { logger } from '../../../helpers/logger'
-import { UserModel } from '../../../models/account/user'
+import { doesLocalVideoChannelNameExist, doesVideoChannelNameWithHostExist } from '../../../helpers/middlewares'
+import { ActorModel } from '../../../models/actor/actor'
import { VideoChannelModel } from '../../../models/video/video-channel'
import { areValidationErrors } from '../utils'
-import { isActorPreferredUsernameValid } from '../../../helpers/custom-validators/activitypub/actor'
-import { ActorModel } from '../../../models/activitypub/actor'
-
-const listVideoAccountChannelsValidator = [
- param('accountName').exists().withMessage('Should have a valid account name'),
-
- async (req: express.Request, res: express.Response, next: express.NextFunction) => {
- logger.debug('Checking listVideoAccountChannelsValidator parameters', { parameters: req.body })
-
- if (areValidationErrors(req, res)) return
- if (!await isAccountNameWithHostExist(req.params.accountName, res)) return
-
- return next()
- }
-]
const videoChannelsAddValidator = [
body('name').custom(isActorPreferredUsernameValid).withMessage('Should have a valid channel name'),
const actor = await ActorModel.loadLocalByName(req.body.name)
if (actor) {
- res.status(409)
+ res.status(HttpStatusCode.CONFLICT_409)
.send({ error: 'Another actor (account/channel) with this name on this instance already exists or has already existed.' })
.end()
return false
}
+ const count = await VideoChannelModel.countByAccount(res.locals.oauth.token.User.Account.id)
+ if (count >= VIDEO_CHANNELS.MAX_PER_USER) {
+ res.status(HttpStatusCode.BAD_REQUEST_400)
+ .send({ error: `You cannot create more than ${VIDEO_CHANNELS.MAX_PER_USER} channels` })
+ .end()
+ return false
+ }
+
return next()
}
]
const videoChannelsUpdateValidator = [
param('nameWithHost').exists().withMessage('Should have an video channel name with host'),
- body('displayName').optional().custom(isVideoChannelNameValid).withMessage('Should have a valid display name'),
- body('description').optional().custom(isVideoChannelDescriptionValid).withMessage('Should have a valid description'),
- body('support').optional().custom(isVideoChannelSupportValid).withMessage('Should have a valid support text'),
+ body('displayName')
+ .optional()
+ .custom(isVideoChannelNameValid).withMessage('Should have a valid display name'),
+ body('description')
+ .optional()
+ .custom(isVideoChannelDescriptionValid).withMessage('Should have a valid description'),
+ body('support')
+ .optional()
+ .custom(isVideoChannelSupportValid).withMessage('Should have a valid support text'),
+ body('bulkVideosSupportUpdate')
+ .optional()
+ .custom(isBooleanValid).withMessage('Should have a valid bulkVideosSupportUpdate boolean field'),
async (req: express.Request, res: express.Response, next: express.NextFunction) => {
logger.debug('Checking videoChannelsUpdate parameters', { parameters: req.body })
if (areValidationErrors(req, res)) return
- if (!await isVideoChannelNameWithHostExist(req.params.nameWithHost, res)) return
+ if (!await doesVideoChannelNameWithHostExist(req.params.nameWithHost, res)) return
// We need to make additional checks
if (res.locals.videoChannel.Actor.isOwned() === false) {
- return res.status(403)
+ return res.status(HttpStatusCode.FORBIDDEN_403)
.json({ error: 'Cannot update video channel of another server' })
- .end()
}
if (res.locals.videoChannel.Account.userId !== res.locals.oauth.token.User.id) {
- return res.status(403)
+ return res.status(HttpStatusCode.FORBIDDEN_403)
.json({ error: 'Cannot update video channel of another user' })
- .end()
}
return next()
logger.debug('Checking videoChannelsRemove parameters', { parameters: req.params })
if (areValidationErrors(req, res)) return
- if (!await isVideoChannelNameWithHostExist(req.params.nameWithHost, res)) return
+ if (!await doesVideoChannelNameWithHostExist(req.params.nameWithHost, res)) return
if (!checkUserCanDeleteVideoChannel(res.locals.oauth.token.User, res.locals.videoChannel, res)) return
if (!await checkVideoChannelIsNotTheLastOne(res)) return
if (areValidationErrors(req, res)) return
- if (!await isVideoChannelNameWithHostExist(req.params.nameWithHost, res)) return
+ if (!await doesVideoChannelNameWithHostExist(req.params.nameWithHost, res)) return
return next()
}
logger.debug('Checking localVideoChannelValidator parameters', { parameters: req.params })
if (areValidationErrors(req, res)) return
- if (!await isLocalVideoChannelNameExist(req.params.name, res)) return
+ if (!await doesLocalVideoChannelNameExist(req.params.name, res)) return
return next()
}
]
+const videoChannelStatsValidator = [
+ query('withStats')
+ .optional()
+ .customSanitizer(toBooleanOrNull)
+ .custom(isBooleanValid).withMessage('Should have a valid stats flag'),
+
+ (req: express.Request, res: express.Response, next: express.NextFunction) => {
+ if (areValidationErrors(req, res)) return
+ return next()
+ }
+]
+
// ---------------------------------------------------------------------------
export {
- listVideoAccountChannelsValidator,
videoChannelsAddValidator,
videoChannelsUpdateValidator,
videoChannelsRemoveValidator,
videoChannelsNameWithHostValidator,
- localVideoChannelValidator
+ localVideoChannelValidator,
+ videoChannelStatsValidator
}
// ---------------------------------------------------------------------------
-function checkUserCanDeleteVideoChannel (user: UserModel, videoChannel: VideoChannelModel, res: express.Response) {
+function checkUserCanDeleteVideoChannel (user: MUser, videoChannel: MChannelAccountDefault, res: express.Response) {
if (videoChannel.Actor.isOwned() === false) {
- res.status(403)
+ res.status(HttpStatusCode.FORBIDDEN_403)
.json({ error: 'Cannot remove video channel of another server.' })
.end()
// The user can delete it if s/he is an admin
// Or if s/he is the video channel's account
if (user.hasRight(UserRight.REMOVE_ANY_VIDEO_CHANNEL) === false && videoChannel.Account.userId !== user.id) {
- res.status(403)
+ res.status(HttpStatusCode.FORBIDDEN_403)
.json({ error: 'Cannot remove video channel of another user' })
.end()
const count = await VideoChannelModel.countByAccount(res.locals.oauth.token.User.Account.id)
if (count <= 1) {
- res.status(409)
- .json({ error: 'Cannot remove the last channel of this user' })
- .end()
+ res.status(HttpStatusCode.CONFLICT_409)
+ .json({ error: 'Cannot remove the last channel of this user' })
+ .end()
return false
}
projects / github / Chocobozzz / PeerTube.git / blobdiff