Merge branch 'release/4.2.0' into develop

[github/Chocobozzz/PeerTube.git] / server / middlewares / validators / sort.ts

diff --git a/server/middlewares/validators/sort.ts b/server/middlewares/validators/sort.ts
index ebc7333c7c07a88104474b55dac130c42981fd20..c9978e3b4542b71e1a027240068216c1cc5f333a 100644 (file)
--- a/server/middlewares/validators/sort.ts
+++ b/server/middlewares/validators/sort.ts
@@ -1,44 +1,88 @@
-import { checkErrors } from './utils'
-import { logger } from '../../helpers'
-import { SORTABLE_COLUMNS } from '../../initializers'
+import express from 'express'
+import { query } from 'express-validator'
+import { logger } from '@server/helpers/logger'
+import { SORTABLE_COLUMNS } from '../../initializers/constants'
+import { areValidationErrors } from './shared'
 
-// Initialize constants here for better performances
-const SORTABLE_USERS_COLUMNS = createSortableColumns(SORTABLE_COLUMNS.USERS)
-const SORTABLE_VIDEO_ABUSES_COLUMNS = createSortableColumns(SORTABLE_COLUMNS.VIDEO_ABUSES)
-const SORTABLE_VIDEOS_COLUMNS = createSortableColumns(SORTABLE_COLUMNS.VIDEOS)
-
-function usersSortValidator (req, res, next) {
-  checkSort(req, res, next, SORTABLE_USERS_COLUMNS)
+function checkSortFactory (columns: string[], tags: string[] = []) {
+  return checkSort(createSortableColumns(columns), tags)
 }
 
-function videoAbusesSortValidator (req, res, next) {
-  checkSort(req, res, next, SORTABLE_VIDEO_ABUSES_COLUMNS)
-}
+function checkSort (sortableColumns: string[], tags: string[] = []) {
+  return [
+    query('sort').optional().isIn(sortableColumns).withMessage('Should have correct sortable column'),
 
-function videosSortValidator (req, res, next) {
-  checkSort(req, res, next, SORTABLE_VIDEOS_COLUMNS)
-}
+    (req: express.Request, res: express.Response, next: express.NextFunction) => {
+      logger.debug('Checking sort parameters', { parameters: req.query, tags })
 
-// ---------------------------------------------------------------------------
+      if (areValidationErrors(req, res)) return
 
-export {
-  usersSortValidator,
-  videoAbusesSortValidator,
-  videosSortValidator
+      return next()
+    }
+  ]
 }
 
-// ---------------------------------------------------------------------------
+function createSortableColumns (sortableColumns: string[]) {
+  const sortableColumnDesc = sortableColumns.map(sortableColumn => '-' + sortableColumn)
 
-function checkSort (req, res, next, sortableColumns) {
-  req.checkQuery('sort', 'Should have correct sortable column').optional().isIn(sortableColumns)
+  return sortableColumns.concat(sortableColumnDesc)
+}
 
-  logger.debug('Checking sort parameters', { parameters: req.query })
+const adminUsersSortValidator = checkSortFactory(SORTABLE_COLUMNS.ADMIN_USERS)
+const accountsSortValidator = checkSortFactory(SORTABLE_COLUMNS.ACCOUNTS)
+const jobsSortValidator = checkSortFactory(SORTABLE_COLUMNS.JOBS, [ 'jobs' ])
+const abusesSortValidator = checkSortFactory(SORTABLE_COLUMNS.ABUSES)
+const videosSortValidator = checkSortFactory(SORTABLE_COLUMNS.VIDEOS)
+const videoImportsSortValidator = checkSortFactory(SORTABLE_COLUMNS.VIDEO_IMPORTS)
+const videosSearchSortValidator = checkSortFactory(SORTABLE_COLUMNS.VIDEOS_SEARCH)
+const videoChannelsSearchSortValidator = checkSortFactory(SORTABLE_COLUMNS.VIDEO_CHANNELS_SEARCH)
+const videoPlaylistsSearchSortValidator = checkSortFactory(SORTABLE_COLUMNS.VIDEO_PLAYLISTS_SEARCH)
+const videoCommentsValidator = checkSortFactory(SORTABLE_COLUMNS.VIDEO_COMMENTS)
+const videoCommentThreadsSortValidator = checkSortFactory(SORTABLE_COLUMNS.VIDEO_COMMENT_THREADS)
+const videoRatesSortValidator = checkSortFactory(SORTABLE_COLUMNS.VIDEO_RATES)
+const blacklistSortValidator = checkSortFactory(SORTABLE_COLUMNS.BLACKLISTS)
+const videoChannelsSortValidator = checkSortFactory(SORTABLE_COLUMNS.VIDEO_CHANNELS)
+const instanceFollowersSortValidator = checkSortFactory(SORTABLE_COLUMNS.INSTANCE_FOLLOWERS)
+const instanceFollowingSortValidator = checkSortFactory(SORTABLE_COLUMNS.INSTANCE_FOLLOWING)
+const userSubscriptionsSortValidator = checkSortFactory(SORTABLE_COLUMNS.USER_SUBSCRIPTIONS)
+const accountsBlocklistSortValidator = checkSortFactory(SORTABLE_COLUMNS.ACCOUNTS_BLOCKLIST)
+const serversBlocklistSortValidator = checkSortFactory(SORTABLE_COLUMNS.SERVERS_BLOCKLIST)
+const userNotificationsSortValidator = checkSortFactory(SORTABLE_COLUMNS.USER_NOTIFICATIONS)
+const videoPlaylistsSortValidator = checkSortFactory(SORTABLE_COLUMNS.VIDEO_PLAYLISTS)
+const pluginsSortValidator = checkSortFactory(SORTABLE_COLUMNS.PLUGINS)
+const availablePluginsSortValidator = checkSortFactory(SORTABLE_COLUMNS.AVAILABLE_PLUGINS)
+const videoRedundanciesSortValidator = checkSortFactory(SORTABLE_COLUMNS.VIDEO_REDUNDANCIES)
 
-  checkErrors(req, res, next)
-}
+const accountsFollowersSortValidator = checkSortFactory(SORTABLE_COLUMNS.ACCOUNT_FOLLOWERS)
+const videoChannelsFollowersSortValidator = checkSortFactory(SORTABLE_COLUMNS.CHANNEL_FOLLOWERS)
 
-function createSortableColumns (sortableColumns) {
-  const sortableColumnDesc = sortableColumns.map(sortableColumn => '-' + sortableColumn)
+// ---------------------------------------------------------------------------
 
-  return sortableColumns.concat(sortableColumnDesc)
+export {
+  adminUsersSortValidator,
+  abusesSortValidator,
+  videoChannelsSortValidator,
+  videoImportsSortValidator,
+  videoCommentsValidator,
+  videosSearchSortValidator,
+  videosSortValidator,
+  blacklistSortValidator,
+  accountsSortValidator,
+  instanceFollowersSortValidator,
+  instanceFollowingSortValidator,
+  jobsSortValidator,
+  videoCommentThreadsSortValidator,
+  videoRatesSortValidator,
+  userSubscriptionsSortValidator,
+  availablePluginsSortValidator,
+  videoChannelsSearchSortValidator,
+  accountsBlocklistSortValidator,
+  serversBlocklistSortValidator,
+  userNotificationsSortValidator,
+  videoPlaylistsSortValidator,
+  videoRedundanciesSortValidator,
+  videoPlaylistsSearchSortValidator,
+  accountsFollowersSortValidator,
+  videoChannelsFollowersSortValidator,
+  pluginsSortValidator
 }