-import * as express from 'express'
+import express from 'express'
import { body, param, query } from 'express-validator'
-import { exists, isBooleanValid, isIdOrUUIDValid, isIdValid, toBooleanOrNull, toIntOrNull } from '../../helpers/custom-validators/misc'
+import { isVideoRedundancyTarget } from '@server/helpers/custom-validators/video-redundancies'
+import { HttpStatusCode } from '../../../shared/models/http/http-error-codes'
+import {
+ exists,
+ isBooleanValid,
+ isIdOrUUIDValid,
+ isIdValid,
+ toBooleanOrNull,
+ toCompleteUUID,
+ toIntOrNull
+} from '../../helpers/custom-validators/misc'
+import { isHostValid } from '../../helpers/custom-validators/servers'
import { logger } from '../../helpers/logger'
-import { areValidationErrors } from './utils'
import { VideoRedundancyModel } from '../../models/redundancy/video-redundancy'
-import { isHostValid } from '../../helpers/custom-validators/servers'
import { ServerModel } from '../../models/server/server'
-import { doesVideoExist } from '../../helpers/middlewares'
-import { isVideoRedundancyTarget } from '@server/helpers/custom-validators/video-redundancies'
+import { areValidationErrors, doesVideoExist, isValidVideoIdParam } from './shared'
const videoFileRedundancyGetValidator = [
- param('videoId').custom(isIdOrUUIDValid).not().isEmpty().withMessage('Should have a valid video id'),
+ isValidVideoIdParam('videoId'),
+
param('resolution')
.customSanitizer(toIntOrNull)
.custom(exists).withMessage('Should have a valid resolution'),
return f.resolution === paramResolution && (!req.params.fps || paramFPS)
})
- if (!videoFile) return res.status(404).json({ error: 'Video file not found.' })
+ if (!videoFile) {
+ return res.fail({
+ status: HttpStatusCode.NOT_FOUND_404,
+ message: 'Video file not found.'
+ })
+ }
res.locals.videoFile = videoFile
const videoRedundancy = await VideoRedundancyModel.loadLocalByFileId(videoFile.id)
- if (!videoRedundancy) return res.status(404).json({ error: 'Video redundancy not found.' })
+ if (!videoRedundancy) {
+ return res.fail({
+ status: HttpStatusCode.NOT_FOUND_404,
+ message: 'Video redundancy not found.'
+ })
+ }
res.locals.videoRedundancy = videoRedundancy
return next()
]
const videoPlaylistRedundancyGetValidator = [
- param('videoId')
- .custom(isIdOrUUIDValid)
- .not().isEmpty().withMessage('Should have a valid video id'),
+ isValidVideoIdParam('videoId'),
+
param('streamingPlaylistType')
.customSanitizer(toIntOrNull)
.custom(exists).withMessage('Should have a valid streaming playlist type'),
const paramPlaylistType = req.params.streamingPlaylistType as unknown as number // We casted to int above
const videoStreamingPlaylist = video.VideoStreamingPlaylists.find(p => p.type === paramPlaylistType)
- if (!videoStreamingPlaylist) return res.status(404).json({ error: 'Video playlist not found.' })
+ if (!videoStreamingPlaylist) {
+ return res.fail({
+ status: HttpStatusCode.NOT_FOUND_404,
+ message: 'Video playlist not found.'
+ })
+ }
res.locals.videoStreamingPlaylist = videoStreamingPlaylist
const videoRedundancy = await VideoRedundancyModel.loadLocalByStreamingPlaylistId(videoStreamingPlaylist.id)
- if (!videoRedundancy) return res.status(404).json({ error: 'Video redundancy not found.' })
+ if (!videoRedundancy) {
+ return res.fail({
+ status: HttpStatusCode.NOT_FOUND_404,
+ message: 'Video redundancy not found.'
+ })
+ }
res.locals.videoRedundancy = videoRedundancy
return next()
const server = await ServerModel.loadByHost(req.params.host)
if (!server) {
- return res
- .status(404)
- .json({
- error: `Server ${req.params.host} not found.`
- })
- .end()
+ return res.fail({
+ status: HttpStatusCode.NOT_FOUND_404,
+ message: `Server ${req.params.host} not found.`
+ })
}
res.locals.server = server
query('target')
.custom(isVideoRedundancyTarget).withMessage('Should have a valid video redundancies target'),
- async (req: express.Request, res: express.Response, next: express.NextFunction) => {
+ (req: express.Request, res: express.Response, next: express.NextFunction) => {
logger.debug('Checking listVideoRedundanciesValidator parameters', { parameters: req.query })
if (areValidationErrors(req, res)) return
const addVideoRedundancyValidator = [
body('videoId')
- .custom(isIdValid)
+ .customSanitizer(toCompleteUUID)
+ .custom(isIdOrUUIDValid)
.withMessage('Should have a valid video id'),
async (req: express.Request, res: express.Response, next: express.NextFunction) => {
if (!await doesVideoExist(req.body.videoId, res, 'only-video')) return
if (res.locals.onlyVideo.remote === false) {
- return res.status(400)
- .json({ error: 'Cannot create a redundancy on a local video' })
- .end()
+ return res.fail({ message: 'Cannot create a redundancy on a local video' })
+ }
+
+ if (res.locals.onlyVideo.isLive) {
+ return res.fail({ message: 'Cannot create a redundancy of a live video' })
}
const alreadyExists = await VideoRedundancyModel.isLocalByVideoUUIDExists(res.locals.onlyVideo.uuid)
if (alreadyExists) {
- return res.status(409)
- .json({ error: 'This video is already duplicated by your instance.' })
+ return res.fail({
+ status: HttpStatusCode.CONFLICT_409,
+ message: 'This video is already duplicated by your instance.'
+ })
}
return next()
const redundancy = await VideoRedundancyModel.loadByIdWithVideo(parseInt(req.params.redundancyId, 10))
if (!redundancy) {
- return res.status(404)
- .json({ error: 'Video redundancy not found' })
- .end()
+ return res.fail({
+ status: HttpStatusCode.NOT_FOUND_404,
+ message: 'Video redundancy not found'
+ })
}
res.locals.videoRedundancy = redundancy