refactor API errors to standard error format

[github/Chocobozzz/PeerTube.git] / server / middlewares / validators / oembed.ts

diff --git a/server/middlewares/validators/oembed.ts b/server/middlewares/validators/oembed.ts
index cd9b27b164490e7a5d5e12724e2e4e810c0e4281..b1d763fbeee46cbf931d5fdfa3a2a711862b9f54 100644 (file)
--- a/server/middlewares/validators/oembed.ts
+++ b/server/middlewares/validators/oembed.ts
@@ -1,15 +1,34 @@
 import * as express from 'express'
-import { query } from 'express-validator/check'
+import { query } from 'express-validator'
 import { join } from 'path'
+import { fetchVideo } from '@server/helpers/video'
+import { VideoPlaylistModel } from '@server/models/video/video-playlist'
+import { VideoPlaylistPrivacy, VideoPrivacy } from '@shared/models'
+import { HttpStatusCode } from '../../../shared/core-utils/miscs/http-error-codes'
 import { isTestInstance } from '../../helpers/core-utils'
 import { isIdOrUUIDValid } from '../../helpers/custom-validators/misc'
-import { isVideoExist } from '../../helpers/custom-validators/videos'
 import { logger } from '../../helpers/logger'
-import { CONFIG } from '../../initializers'
+import { WEBSERVER } from '../../initializers/constants'
 import { areValidationErrors } from './utils'
 
-const urlShouldStartWith = CONFIG.WEBSERVER.SCHEME + '://' + join(CONFIG.WEBSERVER.HOST, 'videos', 'watch') + '/'
-const videoWatchRegex = new RegExp('([^/]+)$')
+const playlistPaths = [
+  join('videos', 'watch', 'playlist'),
+  join('w', 'p')
+]
+
+const videoPaths = [
+  join('videos', 'watch'),
+  'w'
+]
+
+function buildUrls (paths: string[]) {
+  return paths.map(p => WEBSERVER.SCHEME + '://' + join(WEBSERVER.HOST, p) + '/')
+}
+
+const startPlaylistURLs = buildUrls(playlistPaths)
+const startVideoURLs = buildUrls(videoPaths)
+
+const watchRegex = /([^/]+)$/
 const isURLOptions = {
   require_host: true,
   require_tld: true
@@ -32,30 +51,81 @@ const oembedValidator = [
     if (areValidationErrors(req, res)) return
 
     if (req.query.format !== undefined && req.query.format !== 'json') {
-      return res.status(501)
-                .json({ error: 'Requested format is not implemented on server.' })
-                .end()
+      return res.fail({
+        status: HttpStatusCode.NOT_IMPLEMENTED_501,
+        message: 'Requested format is not implemented on server.',
+        data: {
+          format: req.query.format
+        }
+      })
     }
 
-    const startIsOk = req.query.url.startsWith(urlShouldStartWith)
-    const matches = videoWatchRegex.exec(req.query.url)
+    const url = req.query.url as string
+
+    const isPlaylist = startPlaylistURLs.some(u => url.startsWith(u))
+    const isVideo = isPlaylist ? false : startVideoURLs.some(u => url.startsWith(u))
+
+    const startIsOk = isVideo || isPlaylist
+
+    const matches = watchRegex.exec(url)
+
     if (startIsOk === false || matches === null) {
-      return res.status(400)
-                .json({ error: 'Invalid url.' })
-                .end()
+      return res.fail({
+        status: HttpStatusCode.BAD_REQUEST_400,
+        message: 'Invalid url.',
+        data: {
+          url
+        }
+      })
     }
 
-    const videoId = matches[1]
-    if (isIdOrUUIDValid(videoId) === false) {
-      return res.status(400)
-                .json({ error: 'Invalid video id.' })
-                .end()
+    const elementId = matches[1]
+    if (isIdOrUUIDValid(elementId) === false) {
+      return res.fail({ message: 'Invalid video or playlist id.' })
     }
 
-    if (!await isVideoExist(videoId, res)) return
+    if (isVideo) {
+      const video = await fetchVideo(elementId, 'all')
 
+      if (!video) {
+        return res.fail({
+          status: HttpStatusCode.NOT_FOUND_404,
+          message: 'Video not found'
+        })
+      }
+
+      if (video.privacy !== VideoPrivacy.PUBLIC) {
+        return res.fail({
+          status: HttpStatusCode.FORBIDDEN_403,
+          message: 'Video is not public'
+        })
+      }
+
+      res.locals.videoAll = video
+      return next()
+    }
+
+    // Is playlist
+
+    const videoPlaylist = await VideoPlaylistModel.loadWithAccountAndChannelSummary(elementId, undefined)
+    if (!videoPlaylist) {
+      return res.fail({
+        status: HttpStatusCode.NOT_FOUND_404,
+        message: 'Video playlist not found'
+      })
+    }
+
+    if (videoPlaylist.privacy !== VideoPlaylistPrivacy.PUBLIC) {
+      return res.fail({
+        status: HttpStatusCode.FORBIDDEN_403,
+        message: 'Playlist is not public'
+      })
+    }
+
+    res.locals.videoPlaylistSummary = videoPlaylist
     return next()
   }
+
 ]
 
 // ---------------------------------------------------------------------------