Don't crash on youtube-dl update write error

[github/Chocobozzz/PeerTube.git] / server / middlewares / user-right.ts

diff --git a/server/middlewares/user-right.ts b/server/middlewares/user-right.ts
index 5d63ebaf4f361dfaf373c2a8db5b5200b877b0ed..45dda4781211f9a5a85221bd47df989647fcda90 100644 (file)
--- a/server/middlewares/user-right.ts
+++ b/server/middlewares/user-right.ts
@@ -1,15 +1,17 @@
 import * as express from 'express'
-import 'express-validator'
 import { UserRight } from '../../shared'
-import { logger } from '../helpers'
-import { UserModel } from '../models/account/user'
+import { logger } from '../helpers/logger'
+import { HttpStatusCode } from '../../shared/core-utils/miscs/http-error-codes'
 
 function ensureUserHasRight (userRight: UserRight) {
   return function (req: express.Request, res: express.Response, next: express.NextFunction) {
-    const user = res.locals.oauth.token.user as UserModel
+    const user = res.locals.oauth.token.user
     if (user.hasRight(userRight) === false) {
-      logger.info('User %s does not have right %s to access to %s.', user.username, UserRight[userRight], req.path)
-      return res.sendStatus(403)
+      const message = `User ${user.username} does not have right ${userRight} to access to ${req.path}.`
+      logger.info(message)
+
+      return res.status(HttpStatusCode.FORBIDDEN_403)
+                .json({ error: message })
     }
 
     return next()