-import { eachSeries } from 'async'
-import { NextFunction, Request, RequestHandler, Response } from 'express'
+import { NextFunction, Request, Response } from 'express'
import { ActivityPubSignature } from '../../shared'
import { logger } from '../helpers/logger'
import { isHTTPSignatureVerified, isJsonLDSignatureVerified, parseHTTPSignature } from '../helpers/peertube-crypto'
-import { ACCEPT_HEADERS, ACTIVITY_PUB, HTTP_SIGNATURE } from '../initializers'
+import { ACCEPT_HEADERS, ACTIVITY_PUB, HTTP_SIGNATURE } from '../initializers/constants'
import { getOrCreateActorAndServerAndModel } from '../lib/activitypub'
-import { ActorModel } from '../models/activitypub/actor'
import { loadActorUrlOrGetFromWebfinger } from '../helpers/webfinger'
async function checkSignature (req: Request, res: Response, next: NextFunction) {
const httpSignatureChecked = await checkHttpSignature(req, res)
if (httpSignatureChecked !== true) return
- const actor: ActorModel = res.locals.signature.actor
+ const actor = res.locals.signature.actor
// Forwarded activity
const bodyActor = req.body.actor
}
}
-function executeIfActivityPub (fun: RequestHandler | RequestHandler[]) {
- return (req: Request, res: Response, next: NextFunction) => {
- const accepted = req.accepts(ACCEPT_HEADERS)
- if (accepted === false || ACTIVITY_PUB.POTENTIAL_ACCEPT_HEADERS.indexOf(accepted) === -1) {
- return next()
- }
-
- logger.debug('ActivityPub request for %s.', req.url)
+function executeIfActivityPub (req: Request, res: Response, next: NextFunction) {
+ const accepted = req.accepts(ACCEPT_HEADERS)
+ if (accepted === false || ACTIVITY_PUB.POTENTIAL_ACCEPT_HEADERS.indexOf(accepted) === -1) {
+ // Bypass this route
+ return next('route')
+ }
- if (Array.isArray(fun) === true) {
- return eachSeries(fun as RequestHandler[], (f, cb) => {
- f(req, res, cb)
- }, next)
- }
+ logger.debug('ActivityPub request for %s.', req.url)
- return (fun as RequestHandler)(req, res, next)
- }
+ return next()
}
// ---------------------------------------------------------------------------
const sig = req.headers[HTTP_SIGNATURE.HEADER_NAME] as string
if (sig && sig.startsWith('Signature ') === false) req.headers[HTTP_SIGNATURE.HEADER_NAME] = 'Signature ' + sig
- const parsed = parseHTTPSignature(req)
+ const parsed = parseHTTPSignature(req, HTTP_SIGNATURE.CLOCK_SKEW_SECONDS)
const keyId = parsed.keyId
if (!keyId) {
const verified = isHTTPSignatureVerified(parsed, actor)
if (verified !== true) {
+ logger.warn('Signature from %s is invalid', actorUrl, { parsed })
+
res.sendStatus(403)
return false
}
const verified = await isJsonLDSignatureVerified(actor, req.body)
if (verified !== true) {
+ logger.warn('Signature not verified.', req.body)
+
res.sendStatus(403)
return false
}