-import { eachSeries } from 'async'
-import { NextFunction, Request, RequestHandler, Response } from 'express'
-import { ActivityPubSignature } from '../../shared'
-import { isSignatureVerified, logger } from '../helpers'
-import { ACCEPT_HEADERS, ACTIVITY_PUB } from '../initializers'
+import { NextFunction, Request, Response } from 'express'
+import { ActivityDelete, ActivityPubSignature } from '../../shared'
+import { logger } from '../helpers/logger'
+import { isHTTPSignatureVerified, isJsonLDSignatureVerified, parseHTTPSignature } from '../helpers/peertube-crypto'
+import { ACCEPT_HEADERS, ACTIVITY_PUB, HTTP_SIGNATURE } from '../initializers/constants'
import { getOrCreateActorAndServerAndModel } from '../lib/activitypub'
-import { ActorModel } from '../models/activitypub/actor'
+import { loadActorUrlOrGetFromWebfinger } from '../helpers/webfinger'
+import { isActorDeleteActivityValid } from '@server/helpers/custom-validators/activitypub/actor'
+import { getAPId } from '@server/helpers/activitypub'
async function checkSignature (req: Request, res: Response, next: NextFunction) {
- const signatureObject: ActivityPubSignature = req.body.signature
+ try {
+ const httpSignatureChecked = await checkHttpSignature(req, res)
+ if (httpSignatureChecked !== true) return
- const [ creator ] = signatureObject.creator.split('#')
+ const actor = res.locals.signature.actor
- logger.debug('Checking signature of actor %s...', creator)
+ // Forwarded activity
+ const bodyActor = req.body.actor
+ const bodyActorId = getAPId(bodyActor)
+ if (bodyActorId && bodyActorId !== actor.url) {
+ const jsonLDSignatureChecked = await checkJsonLDSignature(req, res)
+ if (jsonLDSignatureChecked !== true) return
+ }
- let actor: ActorModel
- try {
- actor = await getOrCreateActorAndServerAndModel(creator)
+ return next()
} catch (err) {
- logger.error('Cannot create remote actor and check signature.', err)
+ const activity: ActivityDelete = req.body
+ if (isActorDeleteActivityValid(activity) && activity.object === activity.actor) {
+ logger.debug('Handling signature error on actor delete activity', { err })
+ return res.sendStatus(204)
+ }
+
+ logger.warn('Error in ActivityPub signature checker.', { err })
return res.sendStatus(403)
}
+}
- const verified = await isSignatureVerified(actor, req.body)
- if (verified === false) return res.sendStatus(403)
-
- res.locals.signature = {
- actor
+function executeIfActivityPub (req: Request, res: Response, next: NextFunction) {
+ const accepted = req.accepts(ACCEPT_HEADERS)
+ if (accepted === false || ACTIVITY_PUB.POTENTIAL_ACCEPT_HEADERS.includes(accepted) === false) {
+ // Bypass this route
+ return next('route')
}
+ logger.debug('ActivityPub request for %s.', req.url)
+
return next()
}
-function executeIfActivityPub (fun: RequestHandler | RequestHandler[]) {
- return (req: Request, res: Response, next: NextFunction) => {
- const accepted = req.accepts(ACCEPT_HEADERS)
- if (accepted === false || ACTIVITY_PUB.POTENTIAL_ACCEPT_HEADERS.indexOf(accepted) === -1) {
- return next()
- }
+// ---------------------------------------------------------------------------
- logger.debug('ActivityPub request for %s.', req.url)
+export {
+ checkSignature,
+ executeIfActivityPub,
+ checkHttpSignature
+}
- if (Array.isArray(fun) === true) {
- return eachSeries(fun as RequestHandler[], (f, cb) => {
- f(req, res, cb)
- }, next)
- }
+// ---------------------------------------------------------------------------
+
+async function checkHttpSignature (req: Request, res: Response) {
+ // FIXME: compatibility with http-signature < v1.3
+ const sig = req.headers[HTTP_SIGNATURE.HEADER_NAME] as string
+ if (sig && sig.startsWith('Signature ') === true) req.headers[HTTP_SIGNATURE.HEADER_NAME] = sig.replace(/^Signature /, '')
+
+ const parsed = parseHTTPSignature(req, HTTP_SIGNATURE.CLOCK_SKEW_SECONDS)
+
+ const keyId = parsed.keyId
+ if (!keyId) {
+ res.sendStatus(403)
+ return false
+ }
- return (fun as RequestHandler)(req, res, next)
+ logger.debug('Checking HTTP signature of actor %s...', keyId)
+
+ let [ actorUrl ] = keyId.split('#')
+ if (actorUrl.startsWith('acct:')) {
+ actorUrl = await loadActorUrlOrGetFromWebfinger(actorUrl.replace(/^acct:/, ''))
+ }
+
+ const actor = await getOrCreateActorAndServerAndModel(actorUrl)
+
+ const verified = isHTTPSignatureVerified(parsed, actor)
+ if (verified !== true) {
+ logger.warn('Signature from %s is invalid', actorUrl, { parsed })
+
+ res.sendStatus(403)
+ return false
}
+
+ res.locals.signature = { actor }
+
+ return true
}
-// ---------------------------------------------------------------------------
+async function checkJsonLDSignature (req: Request, res: Response) {
+ const signatureObject: ActivityPubSignature = req.body.signature
-export {
- checkSignature,
- executeIfActivityPub
+ if (!signatureObject || !signatureObject.creator) {
+ res.sendStatus(403)
+ return false
+ }
+
+ const [ creator ] = signatureObject.creator.split('#')
+
+ logger.debug('Checking JsonLD signature of actor %s...', creator)
+
+ const actor = await getOrCreateActorAndServerAndModel(creator)
+ const verified = await isJsonLDSignatureVerified(actor, req.body)
+
+ if (verified !== true) {
+ logger.warn('Signature not verified.', req.body)
+
+ res.sendStatus(403)
+ return false
+ }
+
+ res.locals.signature = { actor }
+
+ return true
}