Constants consistency

[github/Chocobozzz/PeerTube.git] / server / lib / schedulers / update-videos-scheduler.ts

diff --git a/server/lib/schedulers/update-videos-scheduler.ts b/server/lib/schedulers/update-videos-scheduler.ts
index d123c3ceba6cb40f28390a00c9038ff6c1f7058f..c652682dd6a7f4b19a584856dc040e90e2b1ae77 100644 (file)
--- a/server/lib/schedulers/update-videos-scheduler.ts
+++ b/server/lib/schedulers/update-videos-scheduler.ts
@@ -1,59 +1,60 @@
-import { isTestInstance } from '../../helpers/core-utils'
+import { VideoModel } from '@server/models/video/video'
+import { MVideoFullLight } from '@server/types/models'
 import { logger } from '../../helpers/logger'
-import { JobQueue } from '../job-queue'
-import { AbstractScheduler } from './abstract-scheduler'
+import { SCHEDULER_INTERVALS_MS } from '../../initializers/constants'
+import { sequelizeTypescript } from '../../initializers/database'
 import { ScheduleVideoUpdateModel } from '../../models/video/schedule-video-update'
-import { retryTransactionWrapper } from '../../helpers/database-utils'
-import { federateVideoIfNeeded } from '../activitypub'
-import { SCHEDULER_INTERVALS_MS, sequelizeTypescript } from '../../initializers'
-import { VideoPrivacy } from '../../../shared/models/videos'
+import { federateVideoIfNeeded } from '../activitypub/videos'
+import { Notifier } from '../notifier'
+import { AbstractScheduler } from './abstract-scheduler'
 
 export class UpdateVideosScheduler extends AbstractScheduler {
 
   private static instance: AbstractScheduler
 
-  protected schedulerIntervalMs = SCHEDULER_INTERVALS_MS.updateVideos
-
-  private isRunning = false
+  protected schedulerIntervalMs = SCHEDULER_INTERVALS_MS.UPDATE_VIDEOS
 
   private constructor () {
     super()
   }
 
-  async execute () {
-    if (this.isRunning === true) return
-    this.isRunning = true
-
-    try {
-      await retryTransactionWrapper(this.updateVideos.bind(this))
-    } catch (err) {
-      logger.error('Cannot execute update videos scheduler.', { err })
-    } finally {
-      this.isRunning = false
-    }
+  protected async internalExecute () {
+    return this.updateVideos()
   }
 
-  private updateVideos () {
-    return sequelizeTypescript.transaction(async t => {
-      const schedules = await ScheduleVideoUpdateModel.listVideosToUpdate(t)
+  private async updateVideos () {
+    if (!await ScheduleVideoUpdateModel.areVideosToUpdate()) return undefined
+
+    const schedules = await ScheduleVideoUpdateModel.listVideosToUpdate()
+    const publishedVideos: MVideoFullLight[] = []
+
+    for (const schedule of schedules) {
+      await sequelizeTypescript.transaction(async t => {
+        const video = await VideoModel.loadAndPopulateAccountAndServerAndTags(schedule.videoId, t)
 
-      for (const schedule of schedules) {
-        const video = schedule.Video
         logger.info('Executing scheduled video update on %s.', video.uuid)
 
         if (schedule.privacy) {
-          const oldPrivacy = video.privacy
+          const wasConfidentialVideo = video.isConfidential()
+          const isNewVideo = video.isNewVideo(schedule.privacy)
 
-          video.privacy = schedule.privacy
+          video.setPrivacy(schedule.privacy)
           await video.save({ transaction: t })
-
-          const isNewVideo = oldPrivacy === VideoPrivacy.PRIVATE
           await federateVideoIfNeeded(video, isNewVideo, t)
+
+          if (wasConfidentialVideo) {
+            publishedVideos.push(video)
+          }
         }
 
         await schedule.destroy({ transaction: t })
-      }
-    })
+      })
+    }
+
+    for (const v of publishedVideos) {
+      Notifier.Instance.notifyOnNewVideoIfNeeded(v)
+      Notifier.Instance.notifyOnVideoPublishedAfterScheduledUpdate(v)
+    }
   }
 
   static get Instance () {