registerWebSocketRouter () {
this.server.on('upgrade', (request, socket, head) => {
+ // Check if it's a plugin websocket connection
+ // No need to destroy the stream when we abort the request
+ // Other handlers in PeerTube will catch this upgrade event too (socket.io, tracker etc)
+
const url = request.url
const matched = url.match(`/plugins/([^/]+)/([^/]+/)?ws(/.*)`)
const wss = routes.find(r => r.route.startsWith(subRoute))
if (!wss) return
- wss.handler(request, socket, head)
+ try {
+ wss.handler(request, socket, head)
+ } catch (err) {
+ logger.error('Exception in plugin handler ' + npmName, { err })
+ }
})
}
// ###################### Installation ######################
- async install (toInstall: string, version?: string, fromDisk = false) {
+ async install (options: {
+ toInstall: string
+ version?: string
+ fromDisk?: boolean // default false
+ register?: boolean // default true
+ }) {
+ const { toInstall, version, fromDisk = false, register = true } = options
+
let plugin: PluginModel
let npmName: string
logger.info('Successful installation of plugin %s.', toInstall)
- await this.registerPluginOrTheme(plugin)
+ if (register) {
+ await this.registerPluginOrTheme(plugin)
+ }
} catch (rootErr) {
logger.error('Cannot install plugin %s, removing it...', toInstall, { err: rootErr })
try {
- await this.uninstall(npmName)
+ await this.uninstall({ npmName })
} catch (err) {
logger.error('Cannot uninstall plugin %s after failed installation.', toInstall, { err })
// Unregister old hooks
await this.unregister(npmName)
- return this.install(toUpdate, version, fromDisk)
+ return this.install({ toInstall: toUpdate, version, fromDisk })
}
- async uninstall (npmName: string) {
+ async uninstall (options: {
+ npmName: string
+ unregister?: boolean // default true
+ }) {
+ const { npmName, unregister = true } = options
+
logger.info('Uninstalling plugin %s.', npmName)
- try {
- await this.unregister(npmName)
- } catch (err) {
- logger.warn('Cannot unregister plugin %s.', npmName, { err })
+ if (unregister) {
+ try {
+ await this.unregister(npmName)
+ } catch (err) {
+ logger.warn('Cannot unregister plugin %s.', npmName, { err })
+ }
}
const plugin = await PluginModel.loadByNpmName(npmName)