import { Redis } from '../../redis'
import { logger } from '../../../helpers/logger'
import { VideoModel } from '../../../models/video/video'
-import { VideoViewModel } from '../../../models/video/video-views'
+import { VideoViewModel } from '../../../models/video/video-view'
import { isTestInstance } from '../../../helpers/core-utils'
-import { federateVideoIfNeeded } from '../../activitypub'
+import { federateVideoIfNeeded } from '../../activitypub/videos'
async function processVideosViews () {
const lastHour = new Date()
for (const videoId of videoIds) {
try {
const views = await Redis.Instance.getVideoViews(videoId, hour)
- if (isNaN(views)) {
- logger.error('Cannot process videos views of video %d in hour %d: views number is NaN.', videoId, hour)
- } else {
- logger.debug('Adding %d views to video %d in hour %d.', views, videoId, hour)
+ await Redis.Instance.deleteVideoViews(videoId, hour)
- await VideoModel.incrementViews(videoId, views)
+ if (views) {
+ logger.debug('Adding %d views to video %d in hour %d.', views, videoId, hour)
try {
+ const video = await VideoModel.loadAndPopulateAccountAndServerAndTags(videoId)
+ if (!video) {
+ logger.debug('Video %d does not exist anymore, skipping videos view addition.', videoId)
+ continue
+ }
+
await VideoViewModel.create({
- startDate,
- endDate,
+ startDate: new Date(startDate),
+ endDate: new Date(endDate),
views,
videoId
})
- const video = await VideoModel.loadAndPopulateAccountAndServerAndTags(videoId)
- if (video.isOwned()) await federateVideoIfNeeded(video, false)
+ if (video.isOwned()) {
+ // If this is a remote video, the origin instance will send us an update
+ await VideoModel.incrementViews(videoId, views)
+
+ // Send video update
+ video.views += views
+ await federateVideoIfNeeded(video, false)
+ }
} catch (err) {
- logger.debug('Cannot create video views for video %d in hour %d. Maybe the video does not exist anymore?', videoId, hour)
+ logger.error('Cannot create video views for video %d in hour %d.', videoId, hour, { err })
}
}
-
- await Redis.Instance.deleteVideoViews(videoId, hour)
} catch (err) {
- logger.error('Cannot update video views of video %d in hour %d.', videoId, hour)
+ logger.error('Cannot update video views of video %d in hour %d.', videoId, hour, { err })
}
}
}