-import * as Bull from 'bull'
-import * as Bluebird from 'bluebird'
-import { logger } from '../../../helpers/logger'
-import { doRequest } from '../../../helpers/requests'
-import { buildGlobalHeaders, buildSignedRequestOptions, computeBody } from './utils/activitypub-http-utils'
-import { BROADCAST_CONCURRENCY, JOB_REQUEST_TIMEOUT } from '../../../initializers/constants'
-import { ActorFollowScoreCache } from '../../files-cache'
+import { Job } from 'bullmq'
+import { buildGlobalHeaders, buildSignedRequestOptions, computeBody } from '@server/lib/activitypub/send'
+import { ActorFollowHealthCache } from '@server/lib/actor-follow-health-cache'
+import { parallelHTTPBroadcastFromWorker, sequentialHTTPBroadcastFromWorker } from '@server/lib/worker/parent-process'
import { ActivitypubHttpBroadcastPayload } from '@shared/models'
+import { logger } from '../../../helpers/logger'
-async function processActivityPubHttpBroadcast (job: Bull.Job) {
- logger.info('Processing ActivityPub broadcast in job %d.', job.id)
+// Prefer using a worker thread for HTTP requests because on high load we may have to sign many requests, which can be CPU intensive
- const payload = job.data as ActivitypubHttpBroadcastPayload
+async function processActivityPubHttpSequentialBroadcast (job: Job<ActivitypubHttpBroadcastPayload>) {
+ logger.info('Processing ActivityPub broadcast in job %s.', job.id)
- const body = await computeBody(payload)
- const httpSignatureOptions = await buildSignedRequestOptions(payload)
+ const requestOptions = await buildRequestOptions(job.data)
- const options = {
- method: 'POST',
- uri: '',
- json: body,
- httpSignature: httpSignatureOptions,
- timeout: JOB_REQUEST_TIMEOUT,
- headers: buildGlobalHeaders(body)
- }
+ const { badUrls, goodUrls } = await sequentialHTTPBroadcastFromWorker({ uris: job.data.uris, requestOptions })
+
+ return ActorFollowHealthCache.Instance.updateActorFollowsHealth(goodUrls, badUrls)
+}
+
+async function processActivityPubParallelHttpBroadcast (job: Job<ActivitypubHttpBroadcastPayload>) {
+ logger.info('Processing ActivityPub parallel broadcast in job %s.', job.id)
- const badUrls: string[] = []
- const goodUrls: string[] = []
+ const requestOptions = await buildRequestOptions(job.data)
- await Bluebird.map(payload.uris, uri => {
- return doRequest(Object.assign({}, options, { uri }))
- .then(() => goodUrls.push(uri))
- .catch(() => badUrls.push(uri))
- }, { concurrency: BROADCAST_CONCURRENCY })
+ const { badUrls, goodUrls } = await parallelHTTPBroadcastFromWorker({ uris: job.data.uris, requestOptions })
- return ActorFollowScoreCache.Instance.updateActorFollowsScore(goodUrls, badUrls)
+ return ActorFollowHealthCache.Instance.updateActorFollowsHealth(goodUrls, badUrls)
}
// ---------------------------------------------------------------------------
export {
- processActivityPubHttpBroadcast
+ processActivityPubHttpSequentialBroadcast,
+ processActivityPubParallelHttpBroadcast
+}
+
+// ---------------------------------------------------------------------------
+
+async function buildRequestOptions (payload: ActivitypubHttpBroadcastPayload) {
+ const body = await computeBody(payload)
+ const httpSignatureOptions = await buildSignedRequestOptions(payload)
+
+ return {
+ method: 'POST' as 'POST',
+ json: body,
+ httpSignature: httpSignatureOptions,
+ headers: buildGlobalHeaders(body)
+ }
}