import { getOrCreateVideoAndAccountAndChannel } from './videos'
import * as Bluebird from 'bluebird'
import { checkUrlsSameHost } from '../../helpers/activitypub'
-import { MCommentOwner, MCommentOwnerVideo, MVideoAccountLightBlacklistAllFiles } from '../../typings/models/video'
+import { MCommentOwner, MCommentOwnerVideo, MVideoAccountLightBlacklistAllFiles } from '../../types/models/video'
type ResolveThreadParams = {
- url: string,
- comments?: MCommentOwner[],
- isVideo?: boolean,
+ url: string
+ comments?: MCommentOwner[]
+ isVideo?: boolean
commentCreated?: boolean
}
type ResolveThreadResult = Promise<{ video: MVideoAccountLightBlacklistAllFiles, comment: MCommentOwnerVideo, commentCreated: boolean }>
if (params.commentCreated === undefined) params.commentCreated = false
if (params.comments === undefined) params.comments = []
- // Already have this comment?
- if (isVideo !== true) {
+ // If it is not a video, or if we don't know if it's a video
+ if (isVideo === false || isVideo === undefined) {
const result = await resolveCommentFromDB(params)
if (result) return result
}
try {
- if (isVideo !== false) return await tryResolveThreadFromVideo(params)
-
- return resolveParentComment(params)
+ // If it is a video, or if we don't know if it's a video
+ if (isVideo === true || isVideo === undefined) {
+ // Keep await so we catch the exception
+ return await tryResolveThreadFromVideo(params)
+ }
} catch (err) {
logger.debug('Cannot get or create account and video and channel for reply %s, fetch comment', url, { err })
-
- return resolveParentComment(params)
}
+
+ return resolveParentComment(params)
}
export {
const syncParam = { likes: true, dislikes: true, shares: true, comments: false, thumbnail: true, refreshVideo: false }
const { video } = await getOrCreateVideoAndAccountAndChannel({ videoObject: url, syncParam })
+ if (video.isOwned() && !video.hasPrivacyForFederation()) {
+ throw new Error('Cannot resolve thread of video with privacy that is not compatible with federation')
+ }
+
let resultComment: MCommentOwnerVideo
if (comments.length !== 0) {
- const firstReply = comments[ comments.length - 1 ] as MCommentOwnerVideo
+ const firstReply = comments[comments.length - 1] as MCommentOwnerVideo
firstReply.inReplyToCommentId = null
firstReply.originCommentId = null
firstReply.videoId = video.id
comments[comments.length - 1] = await firstReply.save()
for (let i = comments.length - 2; i >= 0; i--) {
- const comment = comments[ i ] as MCommentOwnerVideo
+ const comment = comments[i] as MCommentOwnerVideo
comment.originCommentId = firstReply.id
- comment.inReplyToCommentId = comments[ i + 1 ].id
+ comment.inReplyToCommentId = comments[i + 1].id
comment.videoId = video.id
comment.changed('updatedAt', true)
comment.Video = video
throw new Error('Recursion limit reached when resolving a thread')
}
- const { body } = await doRequest({
+ const { body } = await doRequest<any>({
uri: url,
json: true,
activityPub: true