Improve AP validation for Notes

[github/Chocobozzz/PeerTube.git] / server / lib / activitypub / send / send-update.ts

diff --git a/server/lib/activitypub/send/send-update.ts b/server/lib/activitypub/send/send-update.ts
index e8f11edd0ec2a21b32bc2e0498774acb8d61ace8..e15fecff656cde6d137dee1c12a36a8af4a52cc5 100644 (file)
--- a/server/lib/activitypub/send/send-update.ts
+++ b/server/lib/activitypub/send/send-update.ts
@@ -1,9 +1,10 @@
 import { Transaction } from 'sequelize'
 import { ActivityAudience, ActivityUpdate } from '../../../../shared/models/activitypub'
 import { VideoPrivacy } from '../../../../shared/models/videos'
-import { UserModel } from '../../../models/account/user'
+import { AccountModel } from '../../../models/account/account'
 import { ActorModel } from '../../../models/activitypub/actor'
 import { VideoModel } from '../../../models/video/video'
+import { VideoChannelModel } from '../../../models/video/video-channel'
 import { VideoShareModel } from '../../../models/video/video-share'
 import { getUpdateActivityPubUrl } from '../url'
 import { audiencify, broadcastToFollowers, getAudience } from './misc'
@@ -23,15 +24,23 @@ async function sendUpdateVideo (video: VideoModel, t: Transaction) {
   return broadcastToFollowers(data, byActor, actorsInvolved, t)
 }
 
-async function sendUpdateUser (user: UserModel, t: Transaction) {
-  const byActor = user.Account.Actor
+async function sendUpdateActor (accountOrChannel: AccountModel | VideoChannelModel, t: Transaction) {
+  const byActor = accountOrChannel.Actor
 
   const url = getUpdateActivityPubUrl(byActor.url, byActor.updatedAt.toISOString())
-  const accountObject = user.Account.toActivityPubObject()
+  const accountOrChannelObject = accountOrChannel.toActivityPubObject()
   const audience = await getAudience(byActor, t)
-  const data = await updateActivityData(url, byActor, accountObject, t, audience)
+  const data = await updateActivityData(url, byActor, accountOrChannelObject, t, audience)
+
+  let actorsInvolved: ActorModel[]
+  if (accountOrChannel instanceof AccountModel) {
+    // Actors that shared my videos are involved too
+    actorsInvolved = await VideoShareModel.loadActorsByVideoOwner(byActor.id, t)
+  } else {
+    // Actors that shared videos of my channel are involved too
+    actorsInvolved = await VideoShareModel.loadActorsByVideoChannel(accountOrChannel.id, t)
+  }
 
-  const actorsInvolved = await VideoShareModel.loadActorsByVideoOwner(byActor.id, t)
   actorsInvolved.push(byActor)
 
   return broadcastToFollowers(data, byActor, actorsInvolved, t)
@@ -40,7 +49,7 @@ async function sendUpdateUser (user: UserModel, t: Transaction) {
 // ---------------------------------------------------------------------------
 
 export {
-  sendUpdateUser,
+  sendUpdateActor,
   sendUpdateVideo
 }
 
@@ -58,7 +67,7 @@ async function updateActivityData (
   }
 
   return audiencify({
-    type: 'Update',
+    type: 'Update' as 'Update',
     id: url,
     actor: byActor.url,
     object: audiencify(object, audience)