Fix announce activities

[github/Chocobozzz/PeerTube.git] / server / lib / activitypub / send / send-like.ts

diff --git a/server/lib/activitypub/send/send-like.ts b/server/lib/activitypub/send/send-like.ts
index 70a7d886feb8453f9816790223a8d817a80eee98..78ed1aaf284774a92f4ac32e8ec951928f8a7d38 100644 (file)
--- a/server/lib/activitypub/send/send-like.ts
+++ b/server/lib/activitypub/send/send-like.ts
@@ -1,54 +1,56 @@
 import { Transaction } from 'sequelize'
-import { ActivityLike } from '../../../../shared/models/activitypub/activity'
-import { getServerAccount } from '../../../helpers/utils'
-import { AccountInstance, VideoInstance } from '../../../models'
+import { ActivityAudience, ActivityLike } from '../../../../shared/models/activitypub'
+import { ActorModel } from '../../../models/activitypub/actor'
+import { VideoModel } from '../../../models/video/video'
 import { getVideoLikeActivityPubUrl } from '../url'
 import {
+  audiencify,
   broadcastToFollowers,
-  getAccountsToForwardVideoAction,
+  getActorsInvolvedInVideo,
   getAudience,
+  getObjectFollowersAudience,
   getOriginVideoAudience,
-  getVideoFollowersAudience,
   unicastTo
 } from './misc'
 
-async function sendLikeToOrigin (byAccount: AccountInstance, video: VideoInstance, t: Transaction) {
-  const url = getVideoLikeActivityPubUrl(byAccount, video)
+async function sendLikeToOrigin (byActor: ActorModel, video: VideoModel, t: Transaction) {
+  const url = getVideoLikeActivityPubUrl(byActor, video)
 
-  const audience = getOriginVideoAudience(video)
-  const data = await likeActivityData(url, byAccount, video, audience)
+  const accountsInvolvedInVideo = await getActorsInvolvedInVideo(video, t)
+  const audience = getOriginVideoAudience(video, accountsInvolvedInVideo)
+  const data = await likeActivityData(url, byActor, video, t, audience)
 
-  return unicastTo(data, byAccount, video.VideoChannel.Account.sharedInboxUrl, t)
+  return unicastTo(data, byActor, video.VideoChannel.Account.Actor.sharedInboxUrl)
 }
 
-async function sendLikeToVideoFollowers (byAccount: AccountInstance, video: VideoInstance, t: Transaction) {
-  const url = getVideoLikeActivityPubUrl(byAccount, video)
+async function sendLikeToVideoFollowers (byActor: ActorModel, video: VideoModel, t: Transaction) {
+  const url = getVideoLikeActivityPubUrl(byActor, video)
 
-  const audience = getVideoFollowersAudience(video)
-  const data = await likeActivityData(url, byAccount, video, audience)
+  const accountsInvolvedInVideo = await getActorsInvolvedInVideo(video, t)
+  const audience = getObjectFollowersAudience(accountsInvolvedInVideo)
+  const data = await likeActivityData(url, byActor, video, t, audience)
 
-  const accountsToForwardView = await getAccountsToForwardVideoAction(byAccount, video)
-  const serverAccount = await getServerAccount()
-
-  const followersException = [ byAccount ]
-  return broadcastToFollowers(data, serverAccount, accountsToForwardView, t, followersException)
+  const followersException = [ byActor ]
+  return broadcastToFollowers(data, byActor, accountsInvolvedInVideo, t, followersException)
 }
 
-async function likeActivityData (url: string, byAccount: AccountInstance, video: VideoInstance, audience?: { to: string[], cc: string[] }) {
+async function likeActivityData (
+  url: string,
+  byActor: ActorModel,
+  video: VideoModel,
+  t: Transaction,
+  audience?: ActivityAudience
+): Promise<ActivityLike> {
   if (!audience) {
-    audience = await getAudience(byAccount)
+    audience = await getAudience(byActor, t)
   }
 
-  const activity: ActivityLike = {
+  return audiencify({
     type: 'Like',
     id: url,
-    actor: byAccount.url,
-    to: audience.to,
-    cc: audience.cc,
+    actor: byActor.url,
     object: video.url
-  }
-
-  return activity
+  }, audience)
 }
 
 // ---------------------------------------------------------------------------