Fix bad to/cc when undo dislike

[github/Chocobozzz/PeerTube.git] / server / lib / activitypub / process / process.ts

diff --git a/server/lib/activitypub/process/process.ts b/server/lib/activitypub/process/process.ts
index 6135973411c7f373700f9b0d046fdea7805ba0b4..54981c289fd640ec9b4865ec9ac92cc72d25361b 100644 (file)
--- a/server/lib/activitypub/process/process.ts
+++ b/server/lib/activitypub/process/process.ts
@@ -1,4 +1,5 @@
 import { Activity, ActivityType } from '../../../../shared/models/activitypub/activity'
+import { logger } from '../../../helpers/logger'
 import { AccountInstance } from '../../../models/account/account-interface'
 import { processAcceptActivity } from './process-accept'
 import { processAddActivity } from './process-add'
@@ -6,9 +7,9 @@ import { processAnnounceActivity } from './process-announce'
 import { processCreateActivity } from './process-create'
 import { processDeleteActivity } from './process-delete'
 import { processFollowActivity } from './process-follow'
+import { processLikeActivity } from './process-like'
 import { processUndoActivity } from './process-undo'
 import { processUpdateActivity } from './process-update'
-import { logger } from '../../../helpers/logger'
 
 const processActivity: { [ P in ActivityType ]: (activity: Activity, inboxAccount?: AccountInstance) => Promise<any> } = {
   Create: processCreateActivity,
@@ -18,18 +19,29 @@ const processActivity: { [ P in ActivityType ]: (activity: Activity, inboxAccoun
   Follow: processFollowActivity,
   Accept: processAcceptActivity,
   Announce: processAnnounceActivity,
-  Undo: processUndoActivity
+  Undo: processUndoActivity,
+  Like: processLikeActivity
 }
 
-async function processActivities (activities: Activity[], inboxAccount?: AccountInstance) {
+async function processActivities (activities: Activity[], signatureAccount?: AccountInstance, inboxAccount?: AccountInstance) {
   for (const activity of activities) {
+    // When we fetch remote data, we don't have signature
+    if (signatureAccount && activity.actor !== signatureAccount.url) {
+      logger.warn('Signature mismatch between %s and %s.', activity.actor, signatureAccount.url)
+      continue
+    }
+
     const activityProcessor = processActivity[activity.type]
     if (activityProcessor === undefined) {
       logger.warn('Unknown activity type %s.', activity.type, { activityId: activity.id })
       continue
     }
 
-    await activityProcessor(activity, inboxAccount)
+    try {
+      await activityProcessor(activity, inboxAccount)
+    } catch (err) {
+      logger.warn('Cannot process activity %s.', activity.type, err)
+    }
   }
 }