MVideoImmutable,
MVideoThumbnail,
MVideoWithRights
-} from '@server/typings/models'
+} from '@server/types/models'
import { VideoFileModel } from '@server/models/video/video-file'
+import { HttpStatusCode } from '../../../shared/core-utils/miscs/http-error-codes'
async function doesVideoExist (id: number | string, res: Response, fetchType: VideoFetchType = 'all') {
const userId = res.locals.oauth ? res.locals.oauth.token.User.id : undefined
const video = await fetchVideo(id, fetchType, userId)
if (video === null) {
- res.status(404)
+ res.status(HttpStatusCode.NOT_FOUND_404)
.json({ error: 'Video not found' })
.end()
async function doesVideoFileOfVideoExist (id: number, videoIdOrUUID: number | string, res: Response) {
if (!await VideoFileModel.doesVideoExistForVideoFile(id, videoIdOrUUID)) {
- res.status(404)
+ res.status(HttpStatusCode.NOT_FOUND_404)
.json({ error: 'VideoFile matching Video not found' })
.end()
}
async function doesVideoChannelOfAccountExist (channelId: number, user: MUserAccountId, res: Response) {
- if (user.hasRight(UserRight.UPDATE_ANY_VIDEO) === true) {
- const videoChannel = await VideoChannelModel.loadAndPopulateAccount(channelId)
- if (videoChannel === null) {
- res.status(400)
- .json({ error: 'Unknown video `video channel` on this instance.' })
- .end()
+ const videoChannel = await VideoChannelModel.loadAndPopulateAccount(channelId)
+
+ if (videoChannel === null) {
+ res.status(HttpStatusCode.BAD_REQUEST_400)
+ .json({ error: 'Unknown video "video channel" for this instance.' })
- return false
- }
+ return false
+ }
+ // Don't check account id if the user can update any video
+ if (user.hasRight(UserRight.UPDATE_ANY_VIDEO) === true) {
res.locals.videoChannel = videoChannel
return true
}
- const videoChannel = await VideoChannelModel.loadByIdAndAccount(channelId, user.Account.id)
- if (videoChannel === null) {
- res.status(400)
- .json({ error: 'Unknown video `video channel` for this account.' })
- .end()
+ if (videoChannel.Account.id !== user.Account.id) {
+ res.status(HttpStatusCode.BAD_REQUEST_400)
+ .json({ error: 'Unknown video "video channel" for this account.' })
return false
}
return true
}
-function checkUserCanManageVideo (user: MUser, video: MVideoAccountLight, right: UserRight, res: Response) {
+function checkUserCanManageVideo (user: MUser, video: MVideoAccountLight, right: UserRight, res: Response, onlyOwned = true) {
// Retrieve the user who did the request
- if (video.isOwned() === false) {
- res.status(403)
+ if (onlyOwned && video.isOwned() === false) {
+ res.status(HttpStatusCode.FORBIDDEN_403)
.json({ error: 'Cannot manage a video of another server.' })
.end()
return false
// Or if s/he is the video's account
const account = video.VideoChannel.Account
if (user.hasRight(right) === false && account.userId !== user.id) {
- res.status(403)
+ res.status(HttpStatusCode.FORBIDDEN_403)
.json({ error: 'Cannot manage a video of another user.' })
.end()
return false