emit more specific status codes on video upload (#3423)

[github/Chocobozzz/PeerTube.git] / server / helpers / middlewares / abuses.ts

diff --git a/server/helpers/middlewares/abuses.ts b/server/helpers/middlewares/abuses.ts
index b102273a2794b2c5f03c2f9628da6a8c3d19594a..c53bd9efd9af211bd45709b4ab771df7c1e39bbe 100644 (file)
--- a/server/helpers/middlewares/abuses.ts
+++ b/server/helpers/middlewares/abuses.ts
@@ -1,36 +1,13 @@
 import { Response } from 'express'
 import { AbuseModel } from '../../models/abuse/abuse'
-import { fetchVideo } from '../video'
-
-// FIXME: deprecated in 2.3. Remove this function
-async function doesVideoAbuseExist (abuseIdArg: number | string, videoUUID: string, res: Response) {
-  const abuseId = parseInt(abuseIdArg + '', 10)
-  let abuse = await AbuseModel.loadByIdAndVideoId(abuseId, null, videoUUID)
-
-  if (!abuse) {
-    const userId = res.locals.oauth?.token.User.id
-    const video = await fetchVideo(videoUUID, 'all', userId)
-
-    if (video) abuse = await AbuseModel.loadByIdAndVideoId(abuseId, video.id)
-  }
-
-  if (abuse === null) {
-    res.status(404)
-       .json({ error: 'Video abuse not found' })
-
-    return false
-  }
-
-  res.locals.abuse = abuse
-  return true
-}
+import { HttpStatusCode } from '../../../shared/core-utils/miscs/http-error-codes'
 
 async function doesAbuseExist (abuseId: number | string, res: Response) {
-  const abuse = await AbuseModel.loadById(parseInt(abuseId + '', 10))
+  const abuse = await AbuseModel.loadByIdWithReporter(parseInt(abuseId + '', 10))
 
   if (!abuse) {
-    res.status(404)
-       .json({ error: 'Video abuse not found' })
+    res.status(HttpStatusCode.NOT_FOUND_404)
+       .json({ error: 'Abuse not found' })
 
     return false
   }
@@ -42,6 +19,5 @@ async function doesAbuseExist (abuseId: number | string, res: Response) {
 // ---------------------------------------------------------------------------
 
 export {
-  doesAbuseExist,
-  doesVideoAbuseExist
+  doesAbuseExist
 }