Better 413 error handling in cli script

[github/Chocobozzz/PeerTube.git] / server / helpers / express-utils.ts

diff --git a/server/helpers/express-utils.ts b/server/helpers/express-utils.ts
index d023117a8616c8ae942a5853e74b2cd838ab962b..780fd6345e850df4735f70d066c3f65616e8d926 100644 (file)
--- a/server/helpers/express-utils.ts
+++ b/server/helpers/express-utils.ts
@@ -1,17 +1,49 @@
-import * as express from 'express'
-import * as multer from 'multer'
-import { CONFIG, REMOTE_SCHEME } from '../initializers'
+import express, { RequestHandler } from 'express'
+import multer, { diskStorage } from 'multer'
+import { HttpStatusCode } from '../../shared/models/http/http-error-codes'
+import { CONFIG } from '../initializers/config'
+import { REMOTE_SCHEME } from '../initializers/constants'
+import { getLowercaseExtension } from '@shared/core-utils'
+import { isArray } from './custom-validators/misc'
 import { logger } from './logger'
-import { User } from '../../shared/models/users'
-import { generateRandomString } from './utils'
+import { deleteFileAndCatch, generateRandomString } from './utils'
+import { getExtFromMimetype } from './video'
 
-function isNSFWHidden (res: express.Response) {
-  if (res.locals.oauth) {
-    const user: User = res.locals.oauth.token.User
-    if (user) return user.nsfwPolicy === 'do_not_list'
+function buildNSFWFilter (res?: express.Response, paramNSFW?: string) {
+  if (paramNSFW === 'true') return true
+  if (paramNSFW === 'false') return false
+  if (paramNSFW === 'both') return undefined
+
+  if (res?.locals.oauth) {
+    const user = res.locals.oauth.token.User
+
+    // User does not want NSFW videos
+    if (user.nsfwPolicy === 'do_not_list') return false
+
+    // Both
+    return undefined
   }
 
-  return CONFIG.INSTANCE.DEFAULT_NSFW_POLICY === 'do_not_list'
+  if (CONFIG.INSTANCE.DEFAULT_NSFW_POLICY === 'do_not_list') return false
+
+  // Display all
+  return null
+}
+
+function cleanUpReqFiles (req: express.Request) {
+  const filesObject = req.files
+  if (!filesObject) return
+
+  if (isArray(filesObject)) {
+    filesObject.forEach(f => deleteFileAndCatch(f.path))
+    return
+  }
+
+  for (const key of Object.keys(filesObject)) {
+    const files = filesObject[key]
+
+    files.forEach(f => deleteFileAndCatch(f.path))
+  }
 }
 
 function getHostWithPort (host: string) {
@@ -27,22 +59,35 @@ function getHostWithPort (host: string) {
   return host
 }
 
-function badRequest (req: express.Request, res: express.Response, next: express.NextFunction) {
-  return res.type('json').status(400).end()
+function badRequest (_req: express.Request, res: express.Response) {
+  return res.type('json')
+            .status(HttpStatusCode.BAD_REQUEST_400)
+            .end()
 }
 
 function createReqFiles (
   fieldNames: string[],
-  mimeTypes: { [ id: string ]: string },
-  destinations: { [ fieldName: string ]: string }
-) {
-  const storage = multer.diskStorage({
+  mimeTypes: { [id: string]: string | string[] },
+  destinations: { [fieldName: string]: string }
+): RequestHandler {
+  const storage = diskStorage({
     destination: (req, file, cb) => {
-      cb(null, destinations[ file.fieldname ])
+      cb(null, destinations[file.fieldname])
     },
 
     filename: async (req, file, cb) => {
-      const extension = mimeTypes[ file.mimetype ]
+      let extension: string
+      const fileExtension = getLowercaseExtension(file.originalname)
+      const extensionFromMimetype = getExtFromMimetype(mimeTypes, file.mimetype)
+
+      // Take the file extension if we don't understand the mime type
+      if (!extensionFromMimetype) {
+        extension = fileExtension
+      } else {
+        // Take the first available extension for this mimetype
+        extension = extensionFromMimetype
+      }
+
       let randomString = ''
 
       try {
@@ -56,7 +101,7 @@ function createReqFiles (
     }
   })
 
-  const fields = []
+  const fields: { name: string, maxCount: number }[] = []
   for (const fieldName of fieldNames) {
     fields.push({
       name: fieldName,
@@ -67,11 +112,25 @@ function createReqFiles (
   return multer({ storage }).fields(fields)
 }
 
+function isUserAbleToSearchRemoteURI (res: express.Response) {
+  const user = res.locals.oauth ? res.locals.oauth.token.User : undefined
+
+  return CONFIG.SEARCH.REMOTE_URI.ANONYMOUS === true ||
+    (CONFIG.SEARCH.REMOTE_URI.USERS === true && user !== undefined)
+}
+
+function getCountVideos (req: express.Request) {
+  return req.query.skipCount !== true
+}
+
 // ---------------------------------------------------------------------------
 
 export {
-  isNSFWHidden,
+  buildNSFWFilter,
   getHostWithPort,
+  isUserAbleToSearchRemoteURI,
   badRequest,
-  createReqFiles
+  createReqFiles,
+  cleanUpReqFiles,
+  getCountVideos
 }