const validatorsVideos = validators.videos
const search = middlewares.search
const sort = middlewares.sort
+const databaseUtils = require('../../helpers/database-utils')
const utils = require('../../helpers/utils')
const router = express.Router()
const reqFiles = multer({ storage: storage }).fields([{ name: 'videofile', maxCount: 1 }])
+router.get('/categories', listVideoCategories)
+router.get('/licences', listVideoLicences)
+
router.get('/abuse',
oAuth.authenticate,
admin.ensureIsAdmin,
reportVideoAbuseRetryWrapper
)
+router.put('/:id/rate',
+ oAuth.authenticate,
+ validatorsVideos.videoRate,
+ rateVideoRetryWrapper
+)
+
router.get('/',
validatorsPagination.pagination,
validatorsSort.videosSort,
// ---------------------------------------------------------------------------
+function listVideoCategories (req, res, next) {
+ res.json(constants.VIDEO_CATEGORIES)
+}
+
+function listVideoLicences (req, res, next) {
+ res.json(constants.VIDEO_LICENCES)
+}
+
+function rateVideoRetryWrapper (req, res, next) {
+ const options = {
+ arguments: [ req, res ],
+ errorMessage: 'Cannot update the user video rate.'
+ }
+
+ databaseUtils.retryTransactionWrapper(rateVideo, options, function (err) {
+ if (err) return next(err)
+
+ return res.type('json').status(204).end()
+ })
+}
+
+function rateVideo (req, res, finalCallback) {
+ const rateType = req.body.rating
+ const videoInstance = res.locals.video
+ const userInstance = res.locals.oauth.token.User
+
+ waterfall([
+ databaseUtils.startSerializableTransaction,
+
+ function findPreviousRate (t, callback) {
+ db.UserVideoRate.load(userInstance.id, videoInstance.id, t, function (err, previousRate) {
+ return callback(err, t, previousRate)
+ })
+ },
+
+ function insertUserRateIntoDB (t, previousRate, callback) {
+ const options = { transaction: t }
+
+ let likesToIncrement = 0
+ let dislikesToIncrement = 0
+
+ if (rateType === constants.VIDEO_RATE_TYPES.LIKE) likesToIncrement++
+ else if (rateType === constants.VIDEO_RATE_TYPES.DISLIKE) dislikesToIncrement++
+
+ // There was a previous rate, update it
+ if (previousRate) {
+ // We will remove the previous rate, so we will need to remove it from the video attribute
+ if (previousRate.type === constants.VIDEO_RATE_TYPES.LIKE) likesToIncrement--
+ else if (previousRate.type === constants.VIDEO_RATE_TYPES.DISLIKE) dislikesToIncrement--
+
+ previousRate.type = rateType
+
+ previousRate.save(options).asCallback(function (err) {
+ return callback(err, t, likesToIncrement, dislikesToIncrement)
+ })
+ } else { // There was not a previous rate, insert a new one
+ const query = {
+ userId: userInstance.id,
+ videoId: videoInstance.id,
+ type: rateType
+ }
+
+ db.UserVideoRate.create(query, options).asCallback(function (err) {
+ return callback(err, t, likesToIncrement, dislikesToIncrement)
+ })
+ }
+ },
+
+ function updateVideoAttributeDB (t, likesToIncrement, dislikesToIncrement, callback) {
+ const options = { transaction: t }
+ const incrementQuery = {
+ likes: likesToIncrement,
+ dislikes: dislikesToIncrement
+ }
+
+ // Even if we do not own the video we increment the attributes
+ // It is usefull for the user to have a feedback
+ videoInstance.increment(incrementQuery, options).asCallback(function (err) {
+ return callback(err, t, likesToIncrement, dislikesToIncrement)
+ })
+ },
+
+ function sendEventsToFriendsIfNeeded (t, likesToIncrement, dislikesToIncrement, callback) {
+ // No need for an event type, we own the video
+ if (videoInstance.isOwned()) return callback(null, t, likesToIncrement, dislikesToIncrement)
+
+ const eventsParams = []
+
+ if (likesToIncrement !== 0) {
+ eventsParams.push({
+ videoId: videoInstance.id,
+ type: constants.REQUEST_VIDEO_EVENT_TYPES.LIKES,
+ count: likesToIncrement
+ })
+ }
+
+ if (dislikesToIncrement !== 0) {
+ eventsParams.push({
+ videoId: videoInstance.id,
+ type: constants.REQUEST_VIDEO_EVENT_TYPES.DISLIKES,
+ count: dislikesToIncrement
+ })
+ }
+
+ friends.addEventsToRemoteVideo(eventsParams, t, function (err) {
+ return callback(err, t, likesToIncrement, dislikesToIncrement)
+ })
+ },
+
+ function sendQaduToFriendsIfNeeded (t, likesToIncrement, dislikesToIncrement, callback) {
+ // We do not own the video, there is no need to send a quick and dirty update to friends
+ // Our rate was already sent by the addEvent function
+ if (videoInstance.isOwned() === false) return callback(null, t)
+
+ const qadusParams = []
+
+ if (likesToIncrement !== 0) {
+ qadusParams.push({
+ videoId: videoInstance.id,
+ type: constants.REQUEST_VIDEO_QADU_TYPES.LIKES
+ })
+ }
+
+ if (dislikesToIncrement !== 0) {
+ qadusParams.push({
+ videoId: videoInstance.id,
+ type: constants.REQUEST_VIDEO_QADU_TYPES.DISLIKES
+ })
+ }
+
+ friends.quickAndDirtyUpdatesVideoToFriends(qadusParams, t, function (err) {
+ return callback(err, t)
+ })
+ },
+
+ databaseUtils.commitTransaction
+
+ ], function (err, t) {
+ if (err) {
+ // This is just a debug because we will retry the insert
+ logger.debug('Cannot add the user video rate.', { error: err })
+ return databaseUtils.rollbackTransaction(err, t, finalCallback)
+ }
+
+ logger.info('User video rate for video %s of user %s updated.', videoInstance.name, userInstance.username)
+ return finalCallback(null)
+ })
+}
+
// Wrapper to video add that retry the function if there is a database error
// We need this because we run the transaction in SERIALIZABLE isolation that can fail
function addVideoRetryWrapper (req, res, next) {
errorMessage: 'Cannot insert the video with many retries.'
}
- utils.retryWrapper(addVideo, options, function (err) {
+ databaseUtils.retryTransactionWrapper(addVideo, options, function (err) {
if (err) return next(err)
// TODO : include Location of the new video -> 201
})
}
-function addVideo (req, res, videoFile, callback) {
+function addVideo (req, res, videoFile, finalCallback) {
const videoInfos = req.body
waterfall([
- function startTransaction (callbackWaterfall) {
- db.sequelize.transaction({ isolationLevel: 'SERIALIZABLE' }).asCallback(function (err, t) {
- return callbackWaterfall(err, t)
- })
- },
+ databaseUtils.startSerializableTransaction,
- function findOrCreateAuthor (t, callbackWaterfall) {
+ function findOrCreateAuthor (t, callback) {
const user = res.locals.oauth.token.User
const name = user.username
const userId = user.id
db.Author.findOrCreateAuthor(name, podId, userId, t, function (err, authorInstance) {
- return callbackWaterfall(err, t, authorInstance)
+ return callback(err, t, authorInstance)
})
},
- function findOrCreateTags (t, author, callbackWaterfall) {
+ function findOrCreateTags (t, author, callback) {
const tags = videoInfos.tags
db.Tag.findOrCreateTags(tags, t, function (err, tagInstances) {
- return callbackWaterfall(err, t, author, tagInstances)
+ return callback(err, t, author, tagInstances)
})
},
- function createVideoObject (t, author, tagInstances, callbackWaterfall) {
+ function createVideoObject (t, author, tagInstances, callback) {
const videoData = {
name: videoInfos.name,
remoteId: null,
extname: path.extname(videoFile.filename),
+ category: videoInfos.category,
+ licence: videoInfos.licence,
+ nsfw: videoInfos.nsfw,
description: videoInfos.description,
duration: videoFile.duration,
authorId: author.id
const video = db.Video.build(videoData)
- return callbackWaterfall(null, t, author, tagInstances, video)
+ return callback(null, t, author, tagInstances, video)
},
// Set the videoname the same as the id
- function renameVideoFile (t, author, tagInstances, video, callbackWaterfall) {
+ function renameVideoFile (t, author, tagInstances, video, callback) {
const videoDir = constants.CONFIG.STORAGE.VIDEOS_DIR
const source = path.join(videoDir, videoFile.filename)
const destination = path.join(videoDir, video.getVideoFilename())
fs.rename(source, destination, function (err) {
- if (err) return callbackWaterfall(err)
+ if (err) return callback(err)
// This is important in case if there is another attempt
videoFile.filename = video.getVideoFilename()
- return callbackWaterfall(null, t, author, tagInstances, video)
+ return callback(null, t, author, tagInstances, video)
})
},
- function insertVideoIntoDB (t, author, tagInstances, video, callbackWaterfall) {
+ function insertVideoIntoDB (t, author, tagInstances, video, callback) {
const options = { transaction: t }
// Add tags association
video.save(options).asCallback(function (err, videoCreated) {
- if (err) return callbackWaterfall(err)
+ if (err) return callback(err)
// Do not forget to add Author informations to the created video
videoCreated.Author = author
- return callbackWaterfall(err, t, tagInstances, videoCreated)
+ return callback(err, t, tagInstances, videoCreated)
})
},
- function associateTagsToVideo (t, tagInstances, video, callbackWaterfall) {
+ function associateTagsToVideo (t, tagInstances, video, callback) {
const options = { transaction: t }
video.setTags(tagInstances, options).asCallback(function (err) {
video.Tags = tagInstances
- return callbackWaterfall(err, t, video)
+ return callback(err, t, video)
})
},
- function sendToFriends (t, video, callbackWaterfall) {
+ function sendToFriends (t, video, callback) {
video.toAddRemoteJSON(function (err, remoteVideo) {
- if (err) return callbackWaterfall(err)
+ if (err) return callback(err)
// Now we'll add the video's meta data to our friends
friends.addVideoToFriends(remoteVideo, t, function (err) {
- return callbackWaterfall(err, t)
+ return callback(err, t)
})
})
- }
+ },
+
+ databaseUtils.commitTransaction
], function andFinally (err, t) {
if (err) {
// This is just a debug because we will retry the insert
logger.debug('Cannot insert the video.', { error: err })
-
- // Abort transaction?
- if (t) t.rollback()
-
- return callback(err)
+ return databaseUtils.rollbackTransaction(err, t, finalCallback)
}
- // Commit transaction
- t.commit().asCallback(function (err) {
- if (err) return callback(err)
-
- logger.info('Video with name %s created.', videoInfos.name)
- return callback(null)
- })
+ logger.info('Video with name %s created.', videoInfos.name)
+ return finalCallback(null)
})
}
errorMessage: 'Cannot update the video with many retries.'
}
- utils.retryWrapper(updateVideo, options, function (err) {
+ databaseUtils.retryTransactionWrapper(updateVideo, options, function (err) {
if (err) return next(err)
// TODO : include Location of the new video -> 201
waterfall([
- function startTransaction (callback) {
- db.sequelize.transaction({ isolationLevel: 'SERIALIZABLE' }).asCallback(function (err, t) {
- return callback(err, t)
- })
- },
+ databaseUtils.startSerializableTransaction,
function findOrCreateTags (t, callback) {
if (videoInfosToUpdate.tags) {
}
if (videoInfosToUpdate.name) videoInstance.set('name', videoInfosToUpdate.name)
+ if (videoInfosToUpdate.category) videoInstance.set('category', videoInfosToUpdate.category)
+ if (videoInfosToUpdate.licence) videoInstance.set('licence', videoInfosToUpdate.licence)
+ if (videoInfosToUpdate.nsfw) videoInstance.set('nsfw', videoInfosToUpdate.nsfw)
if (videoInfosToUpdate.description) videoInstance.set('description', videoInfosToUpdate.description)
videoInstance.save(options).asCallback(function (err) {
friends.updateVideoToFriends(json, t, function (err) {
return callback(err, t)
})
- }
+ },
+
+ databaseUtils.commitTransaction
], function andFinally (err, t) {
if (err) {
logger.debug('Cannot update the video.', { error: err })
- // Abort transaction?
- if (t) t.rollback()
-
// Force fields we want to update
// If the transaction is retried, sequelize will think the object has not changed
// So it will skip the SQL request, even if the last one was ROLLBACKed!
videoInstance.set(key, value)
})
- return finalCallback(err)
+ return databaseUtils.rollbackTransaction(err, t, finalCallback)
}
- // Commit transaction
- t.commit().asCallback(function (err) {
- if (err) return finalCallback(err)
-
- logger.info('Video with name %s updated.', videoInfosToUpdate.name)
- return finalCallback(null)
- })
+ logger.info('Video with name %s updated.', videoInfosToUpdate.name)
+ return finalCallback(null)
})
}
function getVideo (req, res, next) {
const videoInstance = res.locals.video
+
+ if (videoInstance.isOwned()) {
+ // The increment is done directly in the database, not using the instance value
+ videoInstance.increment('views').asCallback(function (err) {
+ if (err) {
+ logger.error('Cannot add view to video %d.', videoInstance.id)
+ return
+ }
+
+ // FIXME: make a real view system
+ // For example, only add a view when a user watch a video during 30s etc
+ const qaduParams = {
+ videoId: videoInstance.id,
+ type: constants.REQUEST_VIDEO_QADU_TYPES.VIEWS
+ }
+ friends.quickAndDirtyUpdateVideoToFriends(qaduParams)
+ })
+ } else {
+ // Just send the event to our friends
+ const eventParams = {
+ videoId: videoInstance.id,
+ type: constants.REQUEST_VIDEO_EVENT_TYPES.VIEWS
+ }
+ friends.addEventToRemoteVideo(eventParams)
+ }
+
+ // Do not wait the view system
res.json(videoInstance.toFormatedJSON())
}
}
function reportVideoAbuseRetryWrapper (req, res, next) {
- utils.transactionRetryer(
- function (callback) {
- return reportVideoAbuse(req, res, callback)
- },
- function (err) {
- if (err) {
- logger.error('Cannot report abuse to the video with many retries.', { error: err })
- return next(err)
- }
+ const options = {
+ arguments: [ req, res ],
+ errorMessage: 'Cannot report abuse to the video with many retries.'
+ }
- return res.type('json').status(204).end()
- }
- )
+ databaseUtils.retryTransactionWrapper(reportVideoAbuse, options, function (err) {
+ if (err) return next(err)
+
+ return res.type('json').status(204).end()
+ })
}
function reportVideoAbuse (req, res, finalCallback) {
waterfall([
- function startTransaction (callback) {
- db.sequelize.transaction().asCallback(function (err, t) {
- return callback(err, t)
- })
- },
+ databaseUtils.startSerializableTransaction,
function createAbuse (t, callback) {
db.VideoAbuse.create(abuse).asCallback(function (err, abuse) {
}
return callback(null, t)
- }
+ },
+
+ databaseUtils.commitTransaction
], function andFinally (err, t) {
if (err) {
logger.debug('Cannot update the video.', { error: err })
-
- // Abort transaction?
- if (t) t.rollback()
-
- return finalCallback(err)
+ return databaseUtils.rollbackTransaction(err, t, finalCallback)
}
- // Commit transaction
- t.commit().asCallback(function (err) {
- if (err) return finalCallback(err)
-
- logger.info('Abuse report for video %s created.', videoInstance.name)
- return finalCallback(null)
- })
+ logger.info('Abuse report for video %s created.', videoInstance.name)
+ return finalCallback(null)
})
}
-
projects / github / Chocobozzz / PeerTube.git / blobdiff