Fix video_share_url duplicate key in transcoding job

[github/Chocobozzz/PeerTube.git] / server / controllers / activitypub / inbox.ts

diff --git a/server/controllers/activitypub/inbox.ts b/server/controllers/activitypub/inbox.ts
index 79d989c2c26d6d0bb1e55477f2947fb151c23843..df041aebf6c72fc22b7556576b11fe8e9446d0b7 100644 (file)
--- a/server/controllers/activitypub/inbox.ts
+++ b/server/controllers/activitypub/inbox.ts
@@ -1,36 +1,26 @@
 import * as express from 'express'
-
-import {
-  processCreateActivity,
-  processUpdateActivity,
-  processFlagActivity
-} from '../../lib'
-import {
-  Activity,
-  ActivityType,
-  RootActivity,
-  ActivityPubCollection,
-  ActivityPubOrderedCollection
-} from '../../../shared'
-import {
-  signatureValidator,
-  checkSignature,
-  asyncMiddleware
-} from '../../middlewares'
-import { logger } from '../../helpers'
-
-const processActivity: { [ P in ActivityType ]: (activity: Activity) => Promise<any> } = {
-  Create: processCreateActivity,
-  Update: processUpdateActivity,
-  Flag: processFlagActivity
-}
+import { Activity, ActivityPubCollection, ActivityPubOrderedCollection, RootActivity } from '../../../shared'
+import { isActivityValid } from '../../helpers/custom-validators/activitypub/activity'
+import { logger } from '../../helpers/logger'
+import { processActivities } from '../../lib/activitypub/process/process'
+import { asyncMiddleware, checkSignature, localAccountValidator, signatureValidator } from '../../middlewares'
+import { activityPubValidator } from '../../middlewares/validators/activitypub/activity'
+import { ActorModel } from '../../models/activitypub/actor'
 
 const inboxRouter = express.Router()
 
-inboxRouter.post('/',
+inboxRouter.post('/inbox',
   signatureValidator,
   asyncMiddleware(checkSignature),
-  // inboxValidator,
+  asyncMiddleware(activityPubValidator),
+  asyncMiddleware(inboxController)
+)
+
+inboxRouter.post('/accounts/:name/inbox',
+  signatureValidator,
+  asyncMiddleware(checkSignature),
+  localAccountValidator,
+  asyncMiddleware(activityPubValidator),
   asyncMiddleware(inboxController)
 )
 
@@ -49,24 +39,26 @@ async function inboxController (req: express.Request, res: express.Response, nex
   if ([ 'Collection', 'CollectionPage' ].indexOf(rootActivity.type) !== -1) {
     activities = (rootActivity as ActivityPubCollection).items
   } else if ([ 'OrderedCollection', 'OrderedCollectionPage' ].indexOf(rootActivity.type) !== -1) {
-    activities = (rootActivity as ActivityPubOrderedCollection).orderedItems
+    activities = (rootActivity as ActivityPubOrderedCollection<Activity>).orderedItems
   } else {
     activities = [ rootActivity as Activity ]
   }
 
-  await processActivities(activities)
+  // Only keep activities we are able to process
+  logger.debug('Filtering %d activities...', activities.length)
+  activities = activities.filter(a => isActivityValid(a))
+  logger.debug('We keep %d activities.', activities.length, { activities })
 
-  res.status(204).end()
-}
+  let specificActor: ActorModel = undefined
+  if (res.locals.account) {
+    specificActor = res.locals.account
+  } else if (res.locals.videoChannel) {
+    specificActor = res.locals.videoChannel
+  }
 
-async function processActivities (activities: Activity[]) {
-  for (const activity of activities) {
-    const activityProcessor = processActivity[activity.type]
-    if (activityProcessor === undefined) {
-      logger.warn('Unknown activity type %s.', activity.type, { activityId: activity.id })
-      continue
-    }
+  logger.info('Receiving inbox requests for %d activities by %s.', activities.length, res.locals.signature.actor.url)
 
-    await activityProcessor(activity)
-  }
+  await processActivities(activities, res.locals.signature.actor, specificActor)
+
+  res.status(204).end()
 }