-import * as express from 'express'
-import { Activity, ActivityPubCollection, ActivityPubOrderedCollection, RootActivity } from '../../../shared'
+import express from 'express'
+import { InboxManager } from '@server/lib/activitypub/inbox-manager'
+import { Activity, ActivityPubCollection, ActivityPubOrderedCollection, RootActivity } from '@shared/models'
+import { HttpStatusCode } from '../../../shared/models/http/http-error-codes'
import { isActivityValid } from '../../helpers/custom-validators/activitypub/activity'
import { logger } from '../../helpers/logger'
-import { processActivities } from '../../lib/activitypub/process/process'
-import { asyncMiddleware, checkSignature, localAccountValidator, signatureValidator } from '../../middlewares'
+import {
+ asyncMiddleware,
+ checkSignature,
+ ensureIsLocalChannel,
+ localAccountValidator,
+ signatureValidator,
+ videoChannelsNameWithHostValidator
+} from '../../middlewares'
import { activityPubValidator } from '../../middlewares/validators/activitypub/activity'
-import { ActorModel } from '../../models/activitypub/actor'
const inboxRouter = express.Router()
signatureValidator,
asyncMiddleware(checkSignature),
asyncMiddleware(activityPubValidator),
- asyncMiddleware(inboxController)
+ inboxController
)
inboxRouter.post('/accounts/:name/inbox',
asyncMiddleware(checkSignature),
asyncMiddleware(localAccountValidator),
asyncMiddleware(activityPubValidator),
- asyncMiddleware(inboxController)
+ inboxController
+)
+inboxRouter.post('/video-channels/:nameWithHost/inbox',
+ signatureValidator,
+ asyncMiddleware(checkSignature),
+ asyncMiddleware(videoChannelsNameWithHostValidator),
+ ensureIsLocalChannel,
+ asyncMiddleware(activityPubValidator),
+ inboxController
)
// ---------------------------------------------------------------------------
// ---------------------------------------------------------------------------
-async function inboxController (req: express.Request, res: express.Response, next: express.NextFunction) {
+function inboxController (req: express.Request, res: express.Response) {
const rootActivity: RootActivity = req.body
- let activities: Activity[] = []
+ let activities: Activity[]
- if ([ 'Collection', 'CollectionPage' ].indexOf(rootActivity.type) !== -1) {
+ if ([ 'Collection', 'CollectionPage' ].includes(rootActivity.type)) {
activities = (rootActivity as ActivityPubCollection).items
- } else if ([ 'OrderedCollection', 'OrderedCollectionPage' ].indexOf(rootActivity.type) !== -1) {
+ } else if ([ 'OrderedCollection', 'OrderedCollectionPage' ].includes(rootActivity.type)) {
activities = (rootActivity as ActivityPubOrderedCollection<Activity>).orderedItems
} else {
activities = [ rootActivity as Activity ]
activities = activities.filter(a => isActivityValid(a))
logger.debug('We keep %d activities.', activities.length, { activities })
- let specificActor: ActorModel = undefined
- if (res.locals.account) {
- specificActor = res.locals.account
- } else if (res.locals.videoChannel) {
- specificActor = res.locals.videoChannel
- }
+ const accountOrChannel = res.locals.account || res.locals.videoChannel
logger.info('Receiving inbox requests for %d activities by %s.', activities.length, res.locals.signature.actor.url)
- await processActivities(activities, res.locals.signature.actor, specificActor)
+ InboxManager.Instance.addInboxMessage({
+ activities,
+ signatureActor: res.locals.signature.actor,
+ inboxActor: accountOrChannel
+ ? accountOrChannel.Actor
+ : undefined
+ })
- res.status(204).end()
+ return res.status(HttpStatusCode.NO_CONTENT_204).end()
}