Error handling mini refractoring

[github/Chocobozzz/PeerTube.git] / lib / friends.js

diff --git a/lib/friends.js b/lib/friends.js
index e093c85c497b4580eb000939586e3dc1d77a0130..badf09c7dd7e6d184978d2479c117315ec4c524a 100644 (file)
--- a/lib/friends.js
+++ b/lib/friends.js
@@ -8,10 +8,11 @@
 
   var constants = require('../initializers/constants')
   var logger = require('../helpers/logger')
+  var peertubeCrypto = require('../helpers/peertubeCrypto')
   var Pods = require('../models/pods')
   var PoolRequests = require('../models/poolRequests')
   var poolRequests = require('../lib/poolRequests')
-  var utils = require('../helpers/utils')
+  var requests = require('../helpers/requests')
   var Videos = require('../models/videos')
 
   var http = config.get('webserver.https') ? 'https' : 'http'
@@ -29,8 +30,7 @@
   function addVideoToFriends (video) {
     // To avoid duplicates
     var id = video.name + video.magnetUri
-    // namePath is null
-    // TODO
+    // ensure namePath is null
     video.namePath = null
     PoolRequests.addRequest(id, 'add', video)
   }
@@ -48,15 +48,17 @@
     var pods_score = {}
 
     logger.info('Make friends!')
-    fs.readFile(utils.getCertDir() + 'peertube.pub', 'utf8', function (err, cert) {
+    fs.readFile(peertubeCrypto.getCertDir() + 'peertube.pub', 'utf8', function (err, cert) {
       if (err) {
-        logger.error('Cannot read public cert.', { error: err })
+        logger.error('Cannot read public cert.')
         return callback(err)
       }
 
       var urls = config.get('network.friends')
 
-      async.each(urls, computeForeignPodsList, function () {
+      async.each(urls, computeForeignPodsList, function (err) {
+        if (err) return callback(err)
+
         logger.debug('Pods scores computed.', { pods_score: pods_score })
         var pods_list = computeWinningPods(urls, pods_score)
         logger.debug('Pods that we keep computed.', { pods_to_keep: pods_list })
@@ -71,7 +73,8 @@
       // Let's give 1 point to the pod we ask the friends list
       pods_score[url] = 1
 
-      getForeignPodsList(url, function (foreign_pods_list) {
+      getForeignPodsList(url, function (err, foreign_pods_list) {
+        if (err) return callback(err)
         if (foreign_pods_list.length === 0) return callback()
 
         async.each(foreign_pods_list, function (foreign_pod, callback_each) {
@@ -107,7 +110,10 @@
 
       // Get the list of our videos to send to our new friends
       Videos.listOwned(function (err, videos_list) {
-        if (err) throw err
+        if (err) {
+          logger.error('Cannot get the list of videos we own.')
+          return callback(err)
+        }
 
         var data = {
           url: http + '://' + host + ':' + port,
@@ -115,7 +121,7 @@
           videos: videos_list
         }
 
-        utils.makeMultipleRetryRequest(
+        requests.makeMultipleRetryRequest(
           { method: 'POST', path: '/api/' + constants.API_VERSION + '/pods/', data: data },
 
           pods_list,
@@ -144,7 +150,7 @@
             poolRequests.activate()
 
             if (err) {
-              logger.error('There was some errors when we wanted to make friends.', { error: err })
+              logger.error('There was some errors when we wanted to make friends.')
               return callback(err)
             }
 
@@ -176,7 +182,7 @@
       }
 
       // Announce we quit them
-      utils.makeMultipleRetryRequest(request, pods, function () {
+      requests.makeMultipleRetryRequest(request, pods, function () {
         Pods.removeAll(function (err) {
           poolRequests.activate()
 
@@ -211,8 +217,9 @@
     var path = '/api/' + constants.API_VERSION + '/pods'
 
     request.get(url + path, function (err, response, body) {
-      if (err) throw err
-      callback(JSON.parse(body))
+      if (err) return callback(err)
+
+      callback(null, JSON.parse(body))
     })
   }
 })()